Laravel-Backpack / CRUD

tests/Unit/CrudPanel/CrudPanelMacroTest.php

<?php

namespace Backpack\CRUD\Tests\Unit\CrudPanel;

use Backpack\CRUD\Tests\config\CrudPanel\BaseCrudPanel;

/**
 * @covers Backpack\CRUD\app\Library\CrudPanel\Traits\Macroable
 */
class CrudPanelMacroTest extends BaseCrudPanel
{
    public function testItCanRegisterMacro()
    {
        $this->crudPanel::macro('validMacro', function () {
            return true;
        });

        $this->assertTrue($this->crudPanel->validMacro());
    }

    public function testThrowsErrorIfMacroExists()
    {
        try {
            $this->crudPanel::macro('setModel', function () {
                return true;
            });
        } catch (\Throwable $e) {

Consider adding a comment why this CATCH block is empty.

        }
        $this->assertEquals(
            new \Symfony\Component\HttpKernel\Exception\HttpException(500, 'Cannot register \'setModel\' macro. \'setModel()\' already exists on Backpack\CRUD\app\Library\CrudPanel\CrudPanel', null, ['developer-error-exception']),
            $e

The variable $e does not seem to be defined for all execution paths leading up to this point.

        );
    }
}