Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Completed
Pull Request — master (#966)
by Cristian
02:49
created
src/PanelTraits/FakeColumns.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -24,19 +24,19 @@
 block discarded – undo
24 24
             if (isset($field['fake']) && $field['fake'] == true) {
25 25
                 // add it to the request in its appropriate variable - the one defined, if defined
26 26
                 if (isset($field['store_in'])) {
27
-                    if (! in_array($field['store_in'], $fakeFieldsColumnsArray, true)) {
27
+                    if (!in_array($field['store_in'], $fakeFieldsColumnsArray, true)) {
28 28
                         array_push($fakeFieldsColumnsArray, $field['store_in']);
29 29
                     }
30 30
                 } else {
31 31
                     //otherwise in the one defined in the $crud variable
32
-                    if (! in_array('extras', $fakeFieldsColumnsArray, true)) {
32
+                    if (!in_array('extras', $fakeFieldsColumnsArray, true)) {
33 33
                         array_push($fakeFieldsColumnsArray, 'extras');
34 34
                     }
35 35
                 }
36 36
             }
37 37
         }
38 38
 
39
-        if (! count($fakeFieldsColumnsArray)) {
39
+        if (!count($fakeFieldsColumnsArray)) {
40 40
             $fakeFieldsColumnsArray = ['extras'];
41 41
         }
42 42
 
Please login to merge, or discard this patch.
src/PanelTraits/FakeFields.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -29,7 +29,7 @@  discard block
 block discarded – undo
29 29
                 $fakeFieldKey = isset($field['store_in']) ? $field['store_in'] : 'extras';
30 30
                 $this->addCompactedField($requestInput, $field['name'], $fakeFieldKey);
31 31
 
32
-                if (! in_array($fakeFieldKey, $compactedFakeFields)) {
32
+                if (!in_array($fakeFieldKey, $compactedFakeFields)) {
33 33
                     $compactedFakeFields[] = $fakeFieldKey;
34 34
                 }
35 35
             }
@@ -37,7 +37,7 @@  discard block
 block discarded – undo
37 37
 
38 38
         // json_encode all fake_value columns in the database, so they can be properly stored and interpreted
39 39
         foreach ($compactedFakeFields as $value) {
40
-            if (! (property_exists($this->model, 'translatable') && in_array($value, $this->model->getTranslatableAttributes(), true))) {
40
+            if (!(property_exists($this->model, 'translatable') && in_array($value, $this->model->getTranslatableAttributes(), true))) {
41 41
                 $requestInput[$value] = json_encode($requestInput[$value]);
42 42
             }
43 43
         }
Please login to merge, or discard this patch.
src/PanelTraits/Buttons.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -94,7 +94,7 @@  discard block
 block discarded – undo
94 94
      */
95 95
     public function removeButton($name, $stack = null)
96 96
     {
97
-        $this->buttons = $this->buttons->reject(function ($button) use ($name, $stack) {
97
+        $this->buttons = $this->buttons->reject(function($button) use ($name, $stack) {
98 98
             return $stack == null ? $button->name == $name : ($button->stack == $stack) && ($button->name == $name);
99 99
         });
100 100
     }
@@ -106,14 +106,14 @@  discard block
 block discarded – undo
106 106
 
107 107
     public function removeAllButtonsFromStack($stack)
108 108
     {
109
-        $this->buttons = $this->buttons->reject(function ($button) use ($stack) {
109
+        $this->buttons = $this->buttons->reject(function($button) use ($stack) {
110 110
             return $button->stack == $stack;
111 111
         });
112 112
     }
113 113
 
114 114
     public function removeButtonFromStack($name, $stack)
115 115
     {
116
-        $this->buttons = $this->buttons->reject(function ($button) use ($name, $stack) {
116
+        $this->buttons = $this->buttons->reject(function($button) use ($name, $stack) {
117 117
             return $button->name == $name && $button->stack == $stack;
118 118
         });
119 119
     }
Please login to merge, or discard this patch.
src/PanelTraits/Access.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -33,7 +33,7 @@  discard block
 block discarded – undo
33 33
      */
34 34
     public function hasAccess($permission)
35 35
     {
36
-        if (! in_array($permission, $this->access)) {
36
+        if (!in_array($permission, $this->access)) {
37 37
             return false;
38 38
         }
39 39
 
@@ -68,7 +68,7 @@  discard block
 block discarded – undo
68 68
     public function hasAccessToAll($permission_array)
69 69
     {
70 70
         foreach ($permission_array as $key => $permission) {
71
-            if (! in_array($permission, $this->access)) {
71
+            if (!in_array($permission, $this->access)) {
72 72
                 return false;
73 73
             }
74 74
         }
@@ -86,7 +86,7 @@  discard block
 block discarded – undo
86 86
      */
87 87
     public function hasAccessOrFail($permission)
88 88
     {
89
-        if (! in_array($permission, $this->access)) {
89
+        if (!in_array($permission, $this->access)) {
90 90
             throw new AccessDeniedException(trans('backpack::crud.unauthorized_access'));
91 91
         }
92 92
 
Please login to merge, or discard this patch.
src/PanelTraits/Delete.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -15,7 +15,7 @@
 block discarded – undo
15 15
      *
16 16
      * @param  int $id The id of the item to be deleted.
17 17
      *
18
-     * @return bool True if the item was deleted.
18
+     * @return string True if the item was deleted.
19 19
      *
20 20
      * @throws \Illuminate\Database\Eloquent\ModelNotFoundException if the model was not found.
21 21
      *
Please login to merge, or discard this patch.
src/PanelTraits/Columns.php 1 patch
Spacing   +9 added lines, -10 removed lines patch added patch discarded remove patch
@@ -54,7 +54,7 @@  discard block
 block discarded – undo
54 54
     public function addColumn($column)
55 55
     {
56 56
         // if a string was passed, not an array, change it to an array
57
-        if (! is_array($column)) {
57
+        if (!is_array($column)) {
58 58
             $column = ['name' => $column];
59 59
         }
60 60
 
@@ -62,7 +62,7 @@  discard block
 block discarded – undo
62 62
         $column_with_details = $this->addDefaultLabel($column);
63 63
 
64 64
         // make sure the column has a name
65
-        if (! array_key_exists('name', $column_with_details)) {
65
+        if (!array_key_exists('name', $column_with_details)) {
66 66
             $column_with_details['name'] = 'anonymous_column_'.str_random(5);
67 67
         }
68 68
 
@@ -70,7 +70,7 @@  discard block
 block discarded – undo
70 70
 
71 71
         // if this is a relation type field and no corresponding model was specified, get it from the relation method
72 72
         // defined in the main model
73
-        if (isset($column_with_details['entity']) && ! isset($column_with_details['model'])) {
73
+        if (isset($column_with_details['entity']) && !isset($column_with_details['model'])) {
74 74
             $column_with_details['model'] = $this->getRelationModel($column_with_details['entity']);
75 75
         }
76 76
 
@@ -124,8 +124,7 @@  discard block
 block discarded – undo
124 124
         $targetColumnName = is_array($targetColumn) ? $targetColumn['name'] : $targetColumn;
125 125
 
126 126
         if (array_key_exists($targetColumnName, $this->columns)) {
127
-            $targetColumnPosition = $before ? array_search($targetColumnName, array_keys($this->columns)) :
128
-                array_search($targetColumnName, array_keys($this->columns)) + 1;
127
+            $targetColumnPosition = $before ? array_search($targetColumnName, array_keys($this->columns)) : array_search($targetColumnName, array_keys($this->columns)) + 1;
129 128
 
130 129
             $element = array_pop($this->columns);
131 130
             $beginningPart = array_slice($this->columns, 0, $targetColumnPosition, true);
@@ -159,7 +158,7 @@  discard block
 block discarded – undo
159 158
      */
160 159
     public function addDefaultLabel($array)
161 160
     {
162
-        if (! array_key_exists('label', (array) $array) && array_key_exists('name', (array) $array)) {
161
+        if (!array_key_exists('label', (array) $array) && array_key_exists('name', (array) $array)) {
163 162
             $array = array_merge(['label' => ucfirst($this->makeLabel($array['name']))], $array);
164 163
 
165 164
             return $array;
@@ -185,7 +184,7 @@  discard block
 block discarded – undo
185 184
      */
186 185
     public function removeColumns($columns)
187 186
     {
188
-        if (! empty($columns)) {
187
+        if (!empty($columns)) {
189 188
             foreach ($columns as $columnName) {
190 189
                 $this->removeColumn($columnName);
191 190
             }
@@ -206,8 +205,8 @@  discard block
 block discarded – undo
206 205
      */
207 206
     public function remove($entity, $fields)
208 207
     {
209
-        return array_values(array_filter($this->{$entity}, function ($field) use ($fields) {
210
-            return ! in_array($field['name'], (array) $fields);
208
+        return array_values(array_filter($this->{$entity}, function($field) use ($fields) {
209
+            return !in_array($field['name'], (array) $fields);
211 210
         }));
212 211
     }
213 212
 
@@ -258,7 +257,7 @@  discard block
 block discarded – undo
258 257
     {
259 258
         $columns = $this->getColumns();
260 259
 
261
-        return collect($columns)->pluck('entity')->reject(function ($value, $key) {
260
+        return collect($columns)->pluck('entity')->reject(function($value, $key) {
262 261
             return $value == null;
263 262
         })->toArray();
264 263
     }
Please login to merge, or discard this patch.
src/PanelTraits/Filters.php 1 patch
Spacing   +13 added lines, -13 removed lines patch added patch discarded remove patch
@@ -8,7 +8,7 @@  discard block
 block discarded – undo
8 8
 
9 9
     public function filtersEnabled()
10 10
     {
11
-        return ! is_array($this->filters);
11
+        return !is_array($this->filters);
12 12
     }
13 13
 
14 14
     public function filtersDisabled()
@@ -53,7 +53,7 @@  discard block
 block discarded – undo
53 53
         $this->enableFilters();
54 54
 
55 55
         // check if another filter with the same name exists
56
-        if (! isset($options['name'])) {
56
+        if (!isset($options['name'])) {
57 57
             abort(500, 'All your filters need names.');
58 58
         }
59 59
         if ($this->filters->contains('name', $options['name'])) {
@@ -66,16 +66,16 @@  discard block
 block discarded – undo
66 66
 
67 67
         // if a closure was passed as "filter_logic"
68 68
         if ($this->doingListOperation()) {
69
-	        if ( $this->request->has( $options['name'] ) ) {
70
-		        if ( is_callable( $filter_logic ) ) {
69
+	        if ($this->request->has($options['name'])) {
70
+		        if (is_callable($filter_logic)) {
71 71
 			        // apply it
72
-			        $filter_logic( $this->request->input( $options['name'] ) );
72
+			        $filter_logic($this->request->input($options['name']));
73 73
 		        } else {
74
-			        $this->addDefaultFilterLogic( $filter->name, $filter_logic );
74
+			        $this->addDefaultFilterLogic($filter->name, $filter_logic);
75 75
 		        }
76 76
 	        } else {
77 77
 		        //if the filter is not active, but fallback logic was supplied
78
-		        if ( is_callable( $fallback_logic ) ) {
78
+		        if (is_callable($fallback_logic)) {
79 79
 			        // apply the fallback logic
80 80
 			        $fallback_logic();
81 81
 		        }
@@ -138,7 +138,7 @@  discard block
 block discarded – undo
138 138
 
139 139
     public function removeFilter($name)
140 140
     {
141
-        $this->filters = $this->filters->reject(function ($filter) use ($name) {
141
+        $this->filters = $this->filters->reject(function($filter) use ($name) {
142 142
             return $filter->name == $name;
143 143
         });
144 144
     }
@@ -208,7 +208,7 @@  discard block
 block discarded – undo
208 208
         $this->type = $options['type'];
209 209
         $this->label = $options['label'];
210 210
 
211
-        if (! isset($options['placeholder'])) {
211
+        if (!isset($options['placeholder'])) {
212 212
             $this->placeholder = '';
213 213
         } else {
214 214
             $this->placeholder = $options['placeholder'];
@@ -225,16 +225,16 @@  discard block
 block discarded – undo
225 225
 
226 226
     public function checkOptionsIntegrity($options)
227 227
     {
228
-        if (! isset($options['name'])) {
228
+        if (!isset($options['name'])) {
229 229
             abort(500, 'Please make sure all your filters have names.');
230 230
         }
231
-        if (! isset($options['type'])) {
231
+        if (!isset($options['type'])) {
232 232
             abort(500, 'Please make sure all your filters have types.');
233 233
         }
234
-        if (! \View::exists('crud::filters.'.$options['type'])) {
234
+        if (!\View::exists('crud::filters.'.$options['type'])) {
235 235
             abort(500, 'No filter view named "'.$options['type'].'.blade.php" was found.');
236 236
         }
237
-        if (! isset($options['label'])) {
237
+        if (!isset($options['label'])) {
238 238
             abort(500, 'Please make sure all your filters have labels.');
239 239
         }
240 240
     }
Please login to merge, or discard this patch.