Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Passed
Pull Request — master (#3017)
by Roberto
48:35 queued 36:45
created
src/app/Console/Commands/AddCustomRouteContent.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -72,7 +72,7 @@  discard block
 block discarded – undo
72 72
 
73 73
             $process = new Process($command, null, null, null, 300, null);
74 74
 
75
-            $process->run(function ($type, $buffer) {
75
+            $process->run(function($type, $buffer) {
76 76
                 if (Process::ERR === $type) {
77 77
                     $this->line($buffer);
78 78
                 } else {
@@ -81,7 +81,7 @@  discard block
 block discarded – undo
81 81
             });
82 82
 
83 83
             // executes after the command finishes
84
-            if (! $process->isSuccessful()) {
84
+            if (!$process->isSuccessful()) {
85 85
                 throw new ProcessFailedException($process);
86 86
             }
87 87
 
@@ -100,7 +100,7 @@  discard block
 block discarded – undo
100 100
 
101 101
         // otherwise, in case the last line HAS been modified
102 102
         // return the last line that has an ending in it
103
-        $possible_end_lines = array_filter($file_lines, function ($k) {
103
+        $possible_end_lines = array_filter($file_lines, function($k) {
104 104
             return strpos($k, '});') === 0;
105 105
         });
106 106
 
@@ -121,7 +121,7 @@  discard block
 block discarded – undo
121 121
      */
122 122
     private function getLastLineNumberThatContains($needle, $haystack)
123 123
     {
124
-        $matchingLines = array_filter($haystack, function ($k) use ($needle) {
124
+        $matchingLines = array_filter($haystack, function($k) use ($needle) {
125 125
             return strpos($k, $needle) !== false;
126 126
         });
127 127
 
Please login to merge, or discard this patch.
src/app/Console/Commands/AddSidebarContent.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -71,7 +71,7 @@
 block discarded – undo
71 71
      */
72 72
     private function getLastLineNumberThatContains($needle, $haystack)
73 73
     {
74
-        $matchingLines = array_filter($haystack, function ($k) use ($needle) {
74
+        $matchingLines = array_filter($haystack, function($k) use ($needle) {
75 75
             return strpos($k, $needle) !== false;
76 76
         });
77 77
 
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Filters.php 1 patch
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -73,7 +73,7 @@  discard block
 block discarded – undo
73 73
         $this->enableFilters();
74 74
 
75 75
         // check if another filter with the same name exists
76
-        if (! isset($options['name'])) {
76
+        if (!isset($options['name'])) {
77 77
             abort(500, 'All your filters need names.');
78 78
         } else {
79 79
             // make sure we check against the converted camel name before adding.
@@ -123,7 +123,7 @@  discard block
 block discarded – undo
123 123
     {
124 124
         $unappliedFilters = $this->filters()->where('applied', false);
125 125
         if ($unappliedFilters->count()) {
126
-            $unappliedFilters->each(function ($filter) {
126
+            $unappliedFilters->each(function($filter) {
127 127
                 $filter->apply();
128 128
             });
129 129
         }
@@ -173,7 +173,7 @@  discard block
 block discarded – undo
173 173
     {
174 174
         $filter = $this->filters()->firstWhere('name', $name);
175 175
 
176
-        if (! $filter) {
176
+        if (!$filter) {
177 177
             abort(500, 'CRUD Filter "'.$name.'" not found. Please check the filter exists before you modify it.');
178 178
         }
179 179
 
@@ -188,7 +188,7 @@  discard block
 block discarded – undo
188 188
 
189 189
     public function replaceFilter($name, $newFilter)
190 190
     {
191
-        $newFilters = $this->filters()->map(function ($filter, $key) use ($name, $newFilter) {
191
+        $newFilters = $this->filters()->map(function($filter, $key) use ($name, $newFilter) {
192 192
             if ($filter->name != $name) {
193 193
                 return $filter;
194 194
             }
@@ -201,7 +201,7 @@  discard block
 block discarded – undo
201 201
 
202 202
     public function removeFilter($name)
203 203
     {
204
-        $strippedCollection = $this->filters()->reject(function ($filter) use ($name) {
204
+        $strippedCollection = $this->filters()->reject(function($filter) use ($name) {
205 205
             return $filter->name == $name;
206 206
         });
207 207
 
@@ -244,7 +244,7 @@  discard block
 block discarded – undo
244 244
      */
245 245
     public function makeFirstFilter()
246 246
     {
247
-        if (! $this->filters()) {
247
+        if (!$this->filters()) {
248 248
             return false;
249 249
         }
250 250
 
@@ -274,15 +274,15 @@  discard block
 block discarded – undo
274 274
         $destinationFilter = $this->firstFilterWhere('name', $destination);
275 275
         $destinationKey = $this->getFilterKey($destination);
276 276
         $newDestinationKey = ($where == 'before' ? $destinationKey : $destinationKey + 1);
277
-        $newFilters = $this->filters()->filter(function ($value, $key) use ($target) {
277
+        $newFilters = $this->filters()->filter(function($value, $key) use ($target) {
278 278
             return $value->name != $target;
279 279
         });
280 280
 
281
-        if (! $targetFilter) {
281
+        if (!$targetFilter) {
282 282
             return;
283 283
         }
284 284
 
285
-        if (! $destinationFilter) {
285
+        if (!$destinationFilter) {
286 286
             return;
287 287
         }
288 288
 
@@ -290,7 +290,7 @@  discard block
 block discarded – undo
290 290
         $lastSlice = $newFilters->slice($newDestinationKey, null);
291 291
 
292 292
         $newFilters = $firstSlice->push($targetFilter);
293
-        $lastSlice->each(function ($item, $key) use ($newFilters) {
293
+        $lastSlice->each(function($item, $key) use ($newFilters) {
294 294
             $newFilters->push($item);
295 295
         });
296 296
 
Please login to merge, or discard this patch.
src/app/Http/Controllers/Operations/FetchOperation.php 1 patch
Spacing   +6 added lines, -8 removed lines patch added patch discarded remove patch
@@ -45,8 +45,8 @@  discard block
 block discarded – undo
45 45
         // otherwise assume the arguments are actually the configuration array
46 46
         $config = [];
47 47
 
48
-        if (! is_array($arg)) {
49
-            if (! class_exists($arg)) {
48
+        if (!is_array($arg)) {
49
+            if (!class_exists($arg)) {
50 50
                 return response()->json(['error' => 'Class: '.$arg.' does not exists'], 500);
51 51
             }
52 52
             $config['model'] = $arg;
@@ -76,8 +76,7 @@  discard block
 block discarded – undo
76 76
 
77 77
         if ($search_string === false) {
78 78
             return ($config['paginate'] !== false) ?
79
-            $config['query']->paginate($config['paginate']) :
80
-            $config['query']->get();
79
+            $config['query']->paginate($config['paginate']) : $config['query']->get();
81 80
         }
82 81
 
83 82
         $textColumnTypes = ['string', 'json_string', 'text', 'longText', 'json_array'];
@@ -88,8 +87,8 @@  discard block
 block discarded – undo
88 87
         // .... 'query' => function($model) { return $model->where('active', 1); }
89 88
         // So it reads: SELECT ... WHERE active = 1 AND (XXX = x OR YYY = y) and not SELECT ... WHERE active = 1 AND XXX = x OR YYY = y;
90 89
 
91
-        if (! empty($config['query']->getQuery()->wheres)) {
92
-            $config['query'] = $config['query']->where(function ($query) use ($model_instance, $config, $search_string, $textColumnTypes) {
90
+        if (!empty($config['query']->getQuery()->wheres)) {
91
+            $config['query'] = $config['query']->where(function($query) use ($model_instance, $config, $search_string, $textColumnTypes) {
93 92
                 foreach ((array) $config['searchable_attributes'] as $k => $searchColumn) {
94 93
                     $operation = ($k == 0) ? 'where' : 'orWhere';
95 94
                     $columnType = $model_instance->getColumnType($searchColumn);
@@ -118,7 +117,6 @@  discard block
 block discarded – undo
118 117
 
119 118
         // return the results with or without pagination
120 119
         return ($config['paginate'] !== false) ?
121
-                    $config['query']->paginate($config['paginate']) :
122
-                    $config['query']->get();
120
+                    $config['query']->paginate($config['paginate']) : $config['query']->get();
123 121
     }
124 122
 }
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/AutoSet.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -12,11 +12,11 @@  discard block
 block discarded – undo
12 12
      */
13 13
     public function setFromDb()
14 14
     {
15
-        if (! $this->driverIsMongoDb()) {
15
+        if (!$this->driverIsMongoDb()) {
16 16
             $this->getDbColumnTypes();
17 17
         }
18 18
 
19
-        array_map(function ($field) {
19
+        array_map(function($field) {
20 20
             $new_field = [
21 21
                 'name'       => $field,
22 22
                 'label'      => $this->makeLabel($field),
@@ -28,11 +28,11 @@  discard block
 block discarded – undo
28 28
                 'autoset'    => true,
29 29
             ];
30 30
 
31
-            if (! isset($this->fields()[$field])) {
31
+            if (!isset($this->fields()[$field])) {
32 32
                 $this->addField($new_field);
33 33
             }
34 34
 
35
-            if (! in_array($field, $this->model->getHidden()) && ! in_array($field, $this->columns())) {
35
+            if (!in_array($field, $this->model->getHidden()) && !in_array($field, $this->columns())) {
36 36
                 $this->addColumn([
37 37
                     'name'    => $field,
38 38
                     'label'   => $this->makeLabel($field),
@@ -110,7 +110,7 @@  discard block
 block discarded – undo
110 110
 
111 111
         $dbColumnTypes = $this->getDbColumnTypes();
112 112
 
113
-        if (! isset($dbColumnTypes[$fieldName])) {
113
+        if (!isset($dbColumnTypes[$fieldName])) {
114 114
             return 'text';
115 115
         }
116 116
 
@@ -168,7 +168,7 @@  discard block
 block discarded – undo
168 168
         $types = ['enum' => 'string'];
169 169
         $platform = $this->getSchema()->getConnection()->getDoctrineConnection()->getDatabasePlatform();
170 170
         foreach ($types as $type_key => $type_value) {
171
-            if (! $platform->hasDoctrineTypeMappingFor($type_key)) {
171
+            if (!$platform->hasDoctrineTypeMappingFor($type_key)) {
172 172
                 $platform->registerDoctrineTypeMapping($type_key, $type_value);
173 173
             }
174 174
         }
@@ -227,7 +227,7 @@  discard block
 block discarded – undo
227 227
             // Automatically-set columns should be both in the database, and in the $fillable variable on the Eloquent Model
228 228
             $columns = $this->model->getConnection()->getSchemaBuilder()->getColumnListing($this->model->getTable());
229 229
 
230
-            if (! empty($fillable)) {
230
+            if (!empty($fillable)) {
231 231
                 $columns = array_intersect($columns, $fillable);
232 232
             }
233 233
         }
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/CrudPanel.php 1 patch
Spacing   +16 added lines, -16 removed lines patch added patch discarded remove patch
@@ -101,11 +101,11 @@  discard block
 block discarded – undo
101 101
      */
102 102
     public function setModel($model_namespace)
103 103
     {
104
-        if (! class_exists($model_namespace)) {
104
+        if (!class_exists($model_namespace)) {
105 105
             throw new \Exception('The model does not exist.', 500);
106 106
         }
107 107
 
108
-        if (! method_exists($model_namespace, 'hasCrudTrait')) {
108
+        if (!method_exists($model_namespace, 'hasCrudTrait')) {
109 109
             throw new \Exception('Please use CrudTrait on the model.', 500);
110 110
         }
111 111
 
@@ -168,7 +168,7 @@  discard block
 block discarded – undo
168 168
     {
169 169
         $complete_route = $route.'.index';
170 170
 
171
-        if (! \Route::has($complete_route)) {
171
+        if (!\Route::has($complete_route)) {
172 172
             throw new \Exception('There are no routes for this route name.', 404);
173 173
         }
174 174
 
@@ -269,7 +269,7 @@  discard block
 block discarded – undo
269 269
      */
270 270
     public function getFirstOfItsTypeInArray($type, $array)
271 271
     {
272
-        return Arr::first($array, function ($item) use ($type) {
272
+        return Arr::first($array, function($item) use ($type) {
273 273
             return $item['type'] == $type;
274 274
         });
275 275
     }
@@ -286,8 +286,8 @@  discard block
 block discarded – undo
286 286
 
287 287
     public function sync($type, $fields, $attributes)
288 288
     {
289
-        if (! empty($this->{$type})) {
290
-            $this->{$type} = array_map(function ($field) use ($fields, $attributes) {
289
+        if (!empty($this->{$type})) {
290
+            $this->{$type} = array_map(function($field) use ($fields, $attributes) {
291 291
                 if (in_array($field['name'], (array) $fields)) {
292 292
                     $field = array_merge($field, $attributes);
293 293
                 }
@@ -318,15 +318,15 @@  discard block
 block discarded – undo
318 318
     {
319 319
         $relationArray = explode('.', $relationString);
320 320
 
321
-        if (! isset($length)) {
321
+        if (!isset($length)) {
322 322
             $length = count($relationArray);
323 323
         }
324 324
 
325
-        if (! isset($model)) {
325
+        if (!isset($model)) {
326 326
             $model = $this->model;
327 327
         }
328 328
 
329
-        $result = array_reduce(array_splice($relationArray, 0, $length), function ($obj, $method) {
329
+        $result = array_reduce(array_splice($relationArray, 0, $length), function($obj, $method) {
330 330
             try {
331 331
                 $result = $obj->$method();
332 332
 
@@ -362,7 +362,7 @@  discard block
 block discarded – undo
362 362
             if (is_array($entries)) {
363 363
                 //if attribute does not exist in main array we have more than one entry OR the attribute
364 364
                 //is an acessor that is not in $appends property of model.
365
-                if (! isset($entries[$attribute])) {
365
+                if (!isset($entries[$attribute])) {
366 366
                     //we first check if we don't have the attribute because it's and acessor that is not in appends.
367 367
                     if ($model_instance->hasGetMutator($attribute) && isset($entries[$modelKey])) {
368 368
                         $entry_in_database = $model_instance->find($entries[$modelKey]);
@@ -402,21 +402,21 @@  discard block
 block discarded – undo
402 402
      */
403 403
     public function parseTranslatableAttributes($model, $attribute, $value)
404 404
     {
405
-        if (! method_exists($model, 'isTranslatableAttribute')) {
405
+        if (!method_exists($model, 'isTranslatableAttribute')) {
406 406
             return $value;
407 407
         }
408 408
 
409
-        if (! $model->isTranslatableAttribute($attribute)) {
409
+        if (!$model->isTranslatableAttribute($attribute)) {
410 410
             return $value;
411 411
         }
412 412
 
413
-        if (! is_array($value)) {
413
+        if (!is_array($value)) {
414 414
             $decodedAttribute = json_decode($value, true);
415 415
         } else {
416 416
             $decodedAttribute = $value;
417 417
         }
418 418
 
419
-        if (is_array($decodedAttribute) && ! empty($decodedAttribute)) {
419
+        if (is_array($decodedAttribute) && !empty($decodedAttribute)) {
420 420
             if (isset($decodedAttribute[app()->getLocale()])) {
421 421
                 return $decodedAttribute[app()->getLocale()];
422 422
             } else {
@@ -443,7 +443,7 @@  discard block
 block discarded – undo
443 443
         $relation = $model->{$firstRelationName};
444 444
 
445 445
         $results = [];
446
-        if (! is_null($relation)) {
446
+        if (!is_null($relation)) {
447 447
             if ($relation instanceof Collection) {
448 448
                 $currentResults = $relation->all();
449 449
             } elseif (is_array($relation)) {
@@ -456,7 +456,7 @@  discard block
 block discarded – undo
456 456
 
457 457
             array_shift($relationArray);
458 458
 
459
-            if (! empty($relationArray)) {
459
+            if (!empty($relationArray)) {
460 460
                 foreach ($currentResults as $currentResult) {
461 461
                     $results = array_merge_recursive($results, $this->getRelatedEntries($currentResult, implode('.', $relationArray)));
462 462
                 }
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Create.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -82,7 +82,7 @@  discard block
 block discarded – undo
82 82
     {
83 83
         $all_relation_fields = $this->getRelationFields();
84 84
 
85
-        return Arr::where($all_relation_fields, function ($value, $key) {
85
+        return Arr::where($all_relation_fields, function($value, $key) {
86 86
             return isset($value['pivot']) && $value['pivot'];
87 87
         });
88 88
     }
@@ -161,11 +161,11 @@  discard block
 block discarded – undo
161 161
      */
162 162
     private function createRelationsForItem($item, $formattedData)
163 163
     {
164
-        if (! isset($formattedData['relations'])) {
164
+        if (!isset($formattedData['relations'])) {
165 165
             return false;
166 166
         }
167 167
         foreach ($formattedData['relations'] as $relationMethod => $relationData) {
168
-            if (! isset($relationData['model'])) {
168
+            if (!isset($relationData['model'])) {
169 169
                 continue;
170 170
             }
171 171
             $model = $relationData['model'];
@@ -219,13 +219,13 @@  discard block
 block discarded – undo
219 219
         foreach ($relation_fields as $relation_field) {
220 220
             $attributeKey = $this->parseRelationFieldNamesFromHtml([$relation_field])[0]['name'];
221 221
 
222
-            if (! is_null(Arr::get($data, $attributeKey)) && isset($relation_field['pivot']) && $relation_field['pivot'] !== true) {
222
+            if (!is_null(Arr::get($data, $attributeKey)) && isset($relation_field['pivot']) && $relation_field['pivot'] !== true) {
223 223
                 $key = implode('.relations.', explode('.', $this->getOnlyRelationEntity($relation_field)));
224 224
                 $fieldData = Arr::get($relationData, 'relations.'.$key, []);
225
-                if (! array_key_exists('model', $fieldData)) {
225
+                if (!array_key_exists('model', $fieldData)) {
226 226
                     $fieldData['model'] = $relation_field['model'];
227 227
                 }
228
-                if (! array_key_exists('parent', $fieldData)) {
228
+                if (!array_key_exists('parent', $fieldData)) {
229 229
                     $fieldData['parent'] = $this->getRelationModel($attributeKey, -1);
230 230
                 }
231 231
                 $relatedAttribute = Arr::last(explode('.', $attributeKey));
@@ -246,7 +246,7 @@  discard block
 block discarded – undo
246 246
 
247 247
         $related_method = Arr::last($entity_array);
248 248
 
249
-        if (! method_exists($relation_model, $related_method)) {
249
+        if (!method_exists($relation_model, $related_method)) {
250 250
             if (count($entity_array) <= 1) {
251 251
                 return $relation_field['entity'];
252 252
             } else {
Please login to merge, or discard this patch.