Laravel-Backpack / CRUD

tests/Unit/CrudPanel/BaseCrudPanelTest.php

Spacing +1 added lines, -1 removed lines

@@ -24,7 +24,7 @@
     {
         parent::setUp();
 
-        $this->app->singleton('crud', function ($app) {
+        $this->app->singleton('crud', function($app) {
             return new CrudPanel($app);
         });
         $this->crudPanel = app('crud');

src/app/Library/CrudPanel/CrudFilter.php

Spacing +2 added lines, -2 removed lines

@@ -80,7 +80,7 @@ 
      */
     public function wasNotApplied()
     {
-        return ! $this->applied;
+        return !$this->applied;
     }
 
     /**
@@ -101,7 +101,7 @@ 
 
         $input = $input ?? new ParameterBag($this->crud()->getRequest()->all());
 
-        if (! $input->has($this->name)) {
+        if (!$input->has($this->name)) {
             return;
         }
 

Braces +3 added lines, -1 removed lines

@@ -389,10 +389,12 @@
         return $this->fallbackLogic($value);
     }
 
-    public function else($value)
+    public function else {
+        ($value)
     {
         return $this->fallbackLogic($value);
     }
+    }
 
     // ---------------
     // PRIVATE METHODS

src/app/Library/CrudPanel/Traits/Fields.php

Spacing +13 added lines, -13 removed lines

@@ -62,7 +62,7 @@ 
      */
     public function afterField($targetFieldName)
     {
-        $this->transformFields(function ($fields) use ($targetFieldName) {
+        $this->transformFields(function($fields) use ($targetFieldName) {
             return $this->moveField($fields, $targetFieldName, false);
         });
     }
@@ -74,7 +74,7 @@ 
      */
     public function beforeField($targetFieldName)
     {
-        $this->transformFields(function ($fields) use ($targetFieldName) {
+        $this->transformFields(function($fields) use ($targetFieldName) {
             return $this->moveField($fields, $targetFieldName, true);
         });
     }
@@ -86,7 +86,7 @@ 
      */
     public function makeFirstField()
     {
-        if (! $this->fields()) {
+        if (!$this->fields()) {
             return false;
         }
 
@@ -101,7 +101,7 @@ 
      */
     public function removeField($name)
     {
-        $this->transformFields(function ($fields) use ($name) {
+        $this->transformFields(function($fields) use ($name) {
             Arr::forget($fields, $name);
 
             return $fields;
@@ -115,7 +115,7 @@ 
      */
     public function removeFields($array_of_names)
     {
-        if (! empty($array_of_names)) {
+        if (!empty($array_of_names)) {
             foreach ($array_of_names as $name) {
                 $this->removeField($name);
             }
@@ -128,7 +128,7 @@ 
     public function removeAllFields()
     {
         $current_fields = $this->getCurrentFields();
-        if (! empty($current_fields)) {
+        if (!empty($current_fields)) {
             foreach ($current_fields as $field) {
                 $this->removeField($field['name']);
             }
@@ -220,7 +220,7 @@ 
                 $jsonCastables = ['array', 'object', 'json'];
                 $fieldCasting = $casted_attributes[$field['name']];
 
-                if (in_array($fieldCasting, $jsonCastables) && isset($data[$field['name']]) && ! empty($data[$field['name']]) && ! is_array($data[$field['name']])) {
+                if (in_array($fieldCasting, $jsonCastables) && isset($data[$field['name']]) && !empty($data[$field['name']]) && !is_array($data[$field['name']])) {
                     try {
                         $data[$field['name']] = json_decode($data[$field['name']]);
                     } catch (\Exception $e) {
@@ -249,7 +249,7 @@ 
      */
     public function orderFields($order)
     {
-        $this->transformFields(function ($fields) use ($order) {
+        $this->transformFields(function($fields) use ($order) {
             return $this->applyOrderToFields($fields, $order);
         });
     }
@@ -276,7 +276,7 @@ 
     public function hasUploadFields()
     {
         $fields = $this->getFields();
-        $upload_fields = Arr::where($fields, function ($value, $key) {
+        $upload_fields = Arr::where($fields, function($value, $key) {
             return isset($value['upload']) && $value['upload'] == true;
         });
 
@@ -339,7 +339,7 @@ 
         $alreadyLoaded = $this->getLoadedFieldTypes();
         $type = $this->getFieldTypeWithNamespace($field);
 
-        if (! in_array($type, $this->getLoadedFieldTypes(), true)) {
+        if (!in_array($type, $this->getLoadedFieldTypes(), true)) {
             $alreadyLoaded[] = $type;
             $this->setLoadedFieldTypes($alreadyLoaded);
 
@@ -380,7 +380,7 @@ 
      */
     public function fieldTypeNotLoaded($field)
     {
-        return ! in_array($this->getFieldTypeWithNamespace($field), $this->getLoadedFieldTypes());
+        return !in_array($this->getFieldTypeWithNamespace($field), $this->getLoadedFieldTypes());
     }
 
     /**
@@ -421,7 +421,7 @@ 
      */
     public function hasFieldWhere($attribute, $value)
     {
-        $match = Arr::first($this->fields(), function ($field, $fieldKey) use ($attribute, $value) {
+        $match = Arr::first($this->fields(), function($field, $fieldKey) use ($attribute, $value) {
             return isset($field[$attribute]) && $field[$attribute] == $value;
         });
 
@@ -437,7 +437,7 @@ 
      */
     public function firstFieldWhere($attribute, $value)
     {
-        return Arr::first($this->fields(), function ($field, $fieldKey) use ($attribute, $value) {
+        return Arr::first($this->fields(), function($field, $fieldKey) use ($attribute, $value) {
             return isset($field[$attribute]) && $field[$attribute] == $value;
         });
     }

src/app/Library/CrudPanel/Traits/Buttons.php

Spacing +13 added lines, -13 removed lines

@@ -25,7 +25,7 @@ 
         $otherButtons = collect([]);
 
         // we get the buttons that belong to the specified stack
-        $stackButtons = $this->buttons()->reject(function ($item) use ($stack, $otherButtons) {
+        $stackButtons = $this->buttons()->reject(function($item) use ($stack, $otherButtons) {
             if ($item->stack != $stack) {
                 // if the button does not belong to this stack we just add it for merging later
                 $otherButtons->push($item);
@@ -37,8 +37,8 @@ 
         });
 
         // we parse the ordered buttons
-        collect($order)->each(function ($btnKey) use ($newButtons, $stackButtons) {
-            if (! $button = $stackButtons->where('name', $btnKey)->first()) {
+        collect($order)->each(function($btnKey) use ($newButtons, $stackButtons) {
+            if (!$button = $stackButtons->where('name', $btnKey)->first()) {
                 abort(500, 'Button name [«'.$btnKey.'»] not found.');
             }
             $newButtons->push($button);
@@ -48,7 +48,7 @@ 
         // we add the remaining buttons to the end of the ordered ones
         if (count($newButtons) < count($stackButtons)) {
             foreach ($stackButtons as $button) {
-                if (! $newButtons->where('name', $button->name)->first()) {
+                if (!$newButtons->where('name', $button->name)->first()) {
                     $newButtons->push($button);
                 }
             }
@@ -114,7 +114,7 @@ 
          */
         $button = $this->buttons()->firstWhere('name', $name);
 
-        if (! $button) {
+        if (!$button) {
             abort(500, 'CRUD Button "'.$name.'" not found. Please check the button exists before you modify it.');
         }
 
@@ -135,7 +135,7 @@ 
      */
     public function removeButton($name, $stack = null)
     {
-        $this->setOperationSetting('buttons', $this->buttons()->reject(function ($button) use ($name, $stack) {
+        $this->setOperationSetting('buttons', $this->buttons()->reject(function($button) use ($name, $stack) {
             return $stack == null ? $button->name == $name : ($button->stack == $stack) && ($button->name == $name);
         }));
     }
@@ -146,7 +146,7 @@ 
      */
     public function removeButtons($names, $stack = null)
     {
-        if (! empty($names)) {
+        if (!empty($names)) {
             foreach ($names as $name) {
                 $this->removeButton($name, $stack);
             }
@@ -160,14 +160,14 @@ 
 
     public function removeAllButtonsFromStack($stack)
     {
-        $this->setOperationSetting('buttons', $this->buttons()->reject(function ($button) use ($stack) {
+        $this->setOperationSetting('buttons', $this->buttons()->reject(function($button) use ($stack) {
             return $button->stack == $stack;
         }));
     }
 
     public function removeButtonFromStack($name, $stack)
     {
-        $this->setOperationSetting('buttons', $this->buttons()->reject(function ($button) use ($name, $stack) {
+        $this->setOperationSetting('buttons', $this->buttons()->reject(function($button) use ($name, $stack) {
             return $button->name == $name && $button->stack == $stack;
         }));
     }
@@ -185,15 +185,15 @@ 
         $destinationButton = $this->firstButtonWhere('name', $destination);
         $destinationKey = $this->getButtonKey($destination);
         $newDestinationKey = ($where == 'before' ? $destinationKey : $destinationKey + 1);
-        $newButtons = $this->buttons()->filter(function ($value, $key) use ($target) {
+        $newButtons = $this->buttons()->filter(function($value, $key) use ($target) {
             return $value->name != $target;
         });
 
-        if (! $targetButton) {
+        if (!$targetButton) {
             return;
         }
 
-        if (! $destinationButton) {
+        if (!$destinationButton) {
             return;
         }
 
@@ -201,7 +201,7 @@ 
         $lastSlice = $newButtons->slice($newDestinationKey, null);
 
         $newButtons = $firstSlice->push($targetButton);
-        $lastSlice->each(function ($item, $key) use ($newButtons) {
+        $lastSlice->each(function($item, $key) use ($newButtons) {
             $newButtons->push($item);
         });
 

src/app/Library/CrudPanel/CrudButton.php

Spacing +1 added lines, -1 removed lines

@@ -388,7 +388,7 @@
     {
         $itemExists = $this->collection()->contains('name', $this->name);
 
-        if (! $itemExists) {
+        if (!$itemExists) {
             if ($this->position == 'beginning') {
                 $this->collection()->prepend($this);
             } else {

src/helpers.php

Spacing +14 added lines, -14 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-if (! function_exists('backpack_url')) {
+if (!function_exists('backpack_url')) {
     /**
      * Appends the configured backpack prefix and returns
      * the URL using the standard Laravel helpers.
@@ -11,13 +11,13 @@ 
      */
     function backpack_url($path = null, $parameters = [], $secure = null)
     {
-        $path = ! $path || (substr($path, 0, 1) == '/') ? $path : '/'.$path;
+        $path = !$path || (substr($path, 0, 1) == '/') ? $path : '/'.$path;
 
         return url(config('backpack.base.route_prefix', 'admin').$path, $parameters, $secure);
     }
 }
 
-if (! function_exists('backpack_authentication_column')) {
+if (!function_exists('backpack_authentication_column')) {
     /**
      * Return the username column name.
      * The Laravel default (and Backpack default) is 'email'.
@@ -30,7 +30,7 @@ 
     }
 }
 
-if (! function_exists('backpack_users_have_email')) {
+if (!function_exists('backpack_users_have_email')) {
     /**
      * Check if the email column is present on the user table.
      *
@@ -45,7 +45,7 @@ 
     }
 }
 
-if (! function_exists('backpack_avatar_url')) {
+if (!function_exists('backpack_avatar_url')) {
     /**
      * Returns the avatar URL of a user.
      *
@@ -78,7 +78,7 @@ 
     }
 }
 
-if (! function_exists('backpack_middleware')) {
+if (!function_exists('backpack_middleware')) {
     /**
      * Return the key of the middleware used across Backpack.
      * That middleware checks if the visitor is an admin.
@@ -93,7 +93,7 @@ 
     }
 }
 
-if (! function_exists('backpack_guard_name')) {
+if (!function_exists('backpack_guard_name')) {
     /*
      * Returns the name of the guard defined
      * by the application config
@@ -104,7 +104,7 @@ 
     }
 }
 
-if (! function_exists('backpack_auth')) {
+if (!function_exists('backpack_auth')) {
     /*
      * Returns the user instance if it exists
      * of the currently authenticated admin
@@ -116,7 +116,7 @@ 
     }
 }
 
-if (! function_exists('backpack_user')) {
+if (!function_exists('backpack_user')) {
     /*
      * Returns back a user instance without
      * the admin guard, however allows you
@@ -128,7 +128,7 @@ 
     }
 }
 
-if (! function_exists('mb_ucfirst')) {
+if (!function_exists('mb_ucfirst')) {
     /**
      * Capitalize the first letter of a string,
      * even if that string is multi-byte (non-latin alphabet).
@@ -150,7 +150,7 @@ 
     }
 }
 
-if (! function_exists('backpack_view')) {
+if (!function_exists('backpack_view')) {
     /**
      * Returns a new displayable view based on the configured backpack view namespace.
      * If that view doesn't exist, it will load the one from the original theme.
@@ -170,7 +170,7 @@ 
 
         $returnView = $theme.$view;
 
-        if (! view()->exists($returnView)) {
+        if (!view()->exists($returnView)) {
             $returnView = $originalTheme.$view;
         }
 
@@ -178,7 +178,7 @@ 
     }
 }
 
-if (! function_exists('square_brackets_to_dots')) {
+if (!function_exists('square_brackets_to_dots')) {
     /**
      * Turns a string from bracket-type array to dot-notation array.
      * Ex: array[0][property] turns into array.0.property.
@@ -195,7 +195,7 @@ 
     }
 }
 
-if (! function_exists('is_countable')) {
+if (!function_exists('is_countable')) {
     /**
      * We need this because is_countable was only introduced in PHP 7.3,
      * and in PHP 7.2 you should check if count() argument is really countable.

src/app/Library/CrudPanel/Traits/Update.php

Spacing +3 added lines, -3 removed lines

@@ -52,7 +52,7 @@ 
 
         foreach ($fields as &$field) {
             // set the value
-            if (! isset($field['value'])) {
+            if (!isset($field['value'])) {
                 if (isset($field['subfields'])) {
                     $field['value'] = [];
                     foreach ($field['subfields'] as $subfield) {
@@ -65,7 +65,7 @@ 
         }
 
         // always have a hidden input for the entry id
-        if (! array_key_exists('id', $fields)) {
+        if (!array_key_exists('id', $fields)) {
             $fields['id'] = [
                 'name'  => $entry->getKeyName(),
                 'value' => $entry->getKey(),
@@ -91,7 +91,7 @@ 
 
             $relation_array = explode('.', $relational_entity);
 
-            $relatedModel = $relatedModel = array_reduce(array_splice($relation_array, 0, -1), function ($obj, $method) {
+            $relatedModel = $relatedModel = array_reduce(array_splice($relation_array, 0, -1), function($obj, $method) {
                 return $obj->{$method} ? $obj->{$method} : $obj;
             }, $model);
 

src/app/Library/CrudPanel/Traits/FieldsProtectedMethods.php

Spacing +10 added lines, -10 removed lines

@@ -69,7 +69,7 @@ 
      */
     public function overwriteFieldNameFromDotNotationToArray($field)
     {
-        if (! is_array($field['name']) && strpos($field['name'], '.') !== false) {
+        if (!is_array($field['name']) && strpos($field['name'], '.') !== false) {
             $entity_array = explode('.', $field['name']);
             $name_string = '';
 
@@ -96,7 +96,7 @@ 
             return ['name' => $field];
         }
 
-        if (is_array($field) && ! isset($field['name'])) {
+        if (is_array($field) && !isset($field['name'])) {
             abort(500, 'All fields must have their name defined');
         }
 
@@ -154,13 +154,13 @@ 
     protected function makeSureFieldHasRelationshipData($field)
     {
         // only do this if "entity" is defined on the field
-        if (! isset($field['entity'])) {
+        if (!isset($field['entity'])) {
             return $field;
         }
 
         $extraFieldAttributes = $this->inferFieldAttributesFromRelationship($field);
 
-        if (! empty($extraFieldAttributes)) {
+        if (!empty($extraFieldAttributes)) {
             $field = array_merge($field, $extraFieldAttributes);
         } else {
             abort(500, 'Unable to process relationship data: '.$field['name']);
@@ -172,7 +172,7 @@ 
     protected function overwriteFieldNameFromEntity($field)
     {
         // if the entity doesn't have a dot, it means we don't need to overwrite the name
-        if (! Str::contains($field['entity'], '.')) {
+        if (!Str::contains($field['entity'], '.')) {
             return $field;
         }
 
@@ -184,7 +184,7 @@ 
         if (count(explode('.', $field['entity'])) == count(explode('.', $this->getOnlyRelationEntity($field)))) {
             $field['name'] = implode('.', array_slice(explode('.', $field['entity']), 0, -1));
             $relation = $this->getRelationInstance($field);
-            if (! empty($field['name'])) {
+            if (!empty($field['name'])) {
                 $field['name'] .= '.';
             }
             $field['name'] .= $relation->getForeignKeyName();
@@ -197,7 +197,7 @@ 
     {
         // if there's a model defined, but no attribute
         // guess an attribute using the indentifiableAttribute functionality in CrudTrait
-        if (isset($field['model']) && ! isset($field['attribute'])) {
+        if (isset($field['model']) && !isset($field['attribute'])) {
             $field['attribute'] = call_user_func([(new $field['model']), 'identifiableAttribute']);
         }
 
@@ -213,7 +213,7 @@ 
      */
     protected function makeSureFieldHasLabel($field)
     {
-        if (! isset($field['label'])) {
+        if (!isset($field['label'])) {
             $name = is_array($field['name']) ? $field['name'][0] : $field['name'];
             $name = str_replace('_id', '', $name);
             $field['label'] = mb_ucfirst(str_replace('_', ' ', $name));
@@ -231,7 +231,7 @@ 
      */
     protected function makeSureFieldHasType($field)
     {
-        if (! isset($field['type'])) {
+        if (!isset($field['type'])) {
             $field['type'] = isset($field['relation_type']) ? $this->inferFieldTypeFromFieldRelation($field) : $this->inferFieldTypeFromDbColumnType($field['name']);
         }
 
@@ -248,7 +248,7 @@ 
     {
         // if a tab was mentioned, we should enable it
         if (isset($field['tab'])) {
-            if (! $this->tabsEnabled()) {
+            if (!$this->tabsEnabled()) {
                 $this->enableTabs();
             }
         }

src/app/Library/CrudPanel/Traits/Columns.php

Spacing +6 added lines, -6 removed lines

@@ -114,7 +114,7 @@ 
      */
     public function makeFirstColumn()
     {
-        if (! $this->columns()) {
+        if (!$this->columns()) {
             return false;
         }
 
@@ -159,7 +159,7 @@ 
      */
     public function removeColumns($columns)
     {
-        if (! empty($columns)) {
+        if (!empty($columns)) {
             foreach ($columns as $columnKey) {
                 $this->removeColumn($columnKey);
             }
@@ -252,7 +252,7 @@ 
     {
         $columns = $this->columns();
 
-        return collect($columns)->pluck('entity')->reject(function ($value, $key) {
+        return collect($columns)->pluck('entity')->reject(function($value, $key) {
             return $value == null;
         })->toArray();
     }
@@ -329,7 +329,7 @@ 
      */
     public function hasColumnWhere($attribute, $value)
     {
-        $match = Arr::first($this->columns(), function ($column, $columnKey) use ($attribute, $value) {
+        $match = Arr::first($this->columns(), function($column, $columnKey) use ($attribute, $value) {
             return isset($column[$attribute]) && $column[$attribute] == $value;
         });
 
@@ -345,7 +345,7 @@ 
      */
     public function firstColumnWhere($attribute, $value)
     {
-        return Arr::first($this->columns(), function ($column, $columnKey) use ($attribute, $value) {
+        return Arr::first($this->columns(), function($column, $columnKey) use ($attribute, $value) {
             return isset($column[$attribute]) && $column[$attribute] == $value;
         });
     }
@@ -378,7 +378,7 @@ 
 
         // check if it's a method on the model,
         // that means it's a relationship
-        if (! $columnExistsInDb && method_exists($this->model, $column['name'])) {
+        if (!$columnExistsInDb && method_exists($this->model, $column['name'])) {
             $relatedModel = $this->model->{$column['name']}()->getRelated();
             $column['entity'] = $column['name'];
             $column['model'] = get_class($relatedModel);