Show - Code Metrics - Inspection of "changelog" - Laravel-Backpack/CRUD - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 6bda91...26ffdc )

by Cristian

created 2018-07-07 14:51 UTC

Show A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	45
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes

Metric	Value
dl	0
loc	45
rs	10
c	0
b	0
f	0
wmc	6
lcom	1
cbo	0

1 Method

Rating	Name	Duplication	Size	Complexity
B	show()	0	35	6

<?php

namespace Backpack\CRUD\app\Http\Controllers\Operations;

trait Show
{
    /**
     * Display the specified resource.
     *
     * @param int $id
     *
     * @return Response

     */
    public function show($id)
    {
        $this->crud->hasAccessOrFail('show');
class MyClass { }

$x = new MyClass();
$x->foo = true;

        // get entry ID from Request (makes sure its the last ID for nested resources)
        $id = $this->crud->getCurrentEntryId() ?? $id;

        // set columns from db
        $this->crud->setFromDb();

        // cycle through columns
        foreach ($this->crud->columns as $key => $column) {
            // remove any autoset relationship columns
            if (array_key_exists('model', $column) && array_key_exists('autoset', $column) && $column['autoset']) {
                $this->crud->removeColumn($column['name']);
            }

            // remove the row_number column, since it doesn't make sense in this context
            if ($column['type'] == 'row_number') {
                $this->crud->removeColumn($column['name']);
            }
        }

        // get the info for that entry
        $this->data['entry'] = $this->crud->getEntry($id);
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->data['crud'] = $this->crud;
        $this->data['title'] = trans('backpack::crud.preview').' '.$this->crud->entity_name;

        // remove preview button from stack:line
        $this->crud->removeButton('preview');
        $this->crud->removeButton('delete');

        // load the view from /resources/views/vendor/backpack/crud/ if it exists, otherwise load the one in the package
        return view($this->crud->getShowView(), $this->data);
    }
}


1			<?php
2
3			namespace Backpack\CRUD\app\Http\Controllers\Operations;
4
5			trait Show
6			{
7			/**
8			* Display the specified resource.
9			*
10			* @param int $id
11			*
12			* @return Response
			0 ignored issues – show Documentation introduced 2017-04-18 11:15 UTC by Report Bug Copy Issue Report Should the return type not be `\Illuminate\View\View\|\I...\Contracts\View\Factory`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
13			*/
14			public function show($id)
15			{
16			$this->crud->hasAccessOrFail('show');
			0 ignored issues – show Bug introduced 2018-07-07 11:26 UTC by Report Bug Copy Issue Report The property `crud` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
17
18			// get entry ID from Request (makes sure its the last ID for nested resources)
19			$id = $this->crud->getCurrentEntryId() ?? $id;
20
21			// set columns from db
22			$this->crud->setFromDb();
23
24			// cycle through columns
25			foreach ($this->crud->columns as $key => $column) {
26			// remove any autoset relationship columns
27			if (array_key_exists('model', $column) && array_key_exists('autoset', $column) && $column['autoset']) {
28			$this->crud->removeColumn($column['name']);
29			}
30
31			// remove the row_number column, since it doesn't make sense in this context
32			if ($column['type'] == 'row_number') {
33			$this->crud->removeColumn($column['name']);
34			}
35			}
36
37			// get the info for that entry
38			$this->data['entry'] = $this->crud->getEntry($id);
			0 ignored issues – show Bug introduced 2016-09-26 11:32 UTC by Report Bug Copy Issue Report The property `data` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
39			$this->data['crud'] = $this->crud;
40			$this->data['title'] = trans('backpack::crud.preview').' '.$this->crud->entity_name;
41
42			// remove preview button from stack:line
43			$this->crud->removeButton('preview');
44			$this->crud->removeButton('delete');
45
46			// load the view from /resources/views/vendor/backpack/crud/ if it exists, otherwise load the one in the package
47			return view($this->crud->getShowView(), $this->data);
48			}
49			}
50

Laravel-Backpack / CRUD

Scrutinizer GitHub App not installed

Push — master ( 6bda91...26ffdc )

Show A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

1 Method

Duplication Side-by-Side

Filter issues like