Backpack\CRUD\app\Http\Controllers\Operations\Create

Complexity

Total Complexity

6

Size/Duplication

Total Lines	57
Duplicated Lines	8.77 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	create()	0	13	1
A	storeCrud()	5	28	5

<?php

namespace Backpack\CRUD\app\Http\Controllers\Operations;

trait Create
{
    /**
     * Show the form for creating inserting a new row.
     *
     * @return Response

Should the return type not be \Illuminate\View\View|\Illuminate\Contracts\View\Factory?

     */
    public function create()
    {
        $this->crud->hasAccessOrFail('create');

The property crud does not exist. Did you maybe forget to declare it?

        // prepare the fields you need to show
        $this->data['crud'] = $this->crud;

The property data does not exist. Did you maybe forget to declare it?

        $this->data['saveAction'] = $this->getSaveAction();

It seems like getSaveAction() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $this->data['fields'] = $this->crud->getCreateFields();
        $this->data['title'] = trans('backpack::crud.add').' '.$this->crud->entity_name;

        // load the view from /resources/views/vendor/backpack/crud/ if it exists, otherwise load the one in the package
        return view($this->crud->getCreateView(), $this->data);
    }

    /**
     * Store a newly created resource in the database.
     *
     * @param StoreRequest $request - type injection used for validation using Requests

Should the type for parameter $request not be null|StoreRequest?

     *
     * @return \Illuminate\Http\RedirectResponse
     */
    public function storeCrud(StoreRequest $request = null)
    {
        $this->crud->hasAccessOrFail('create');

        // fallback to global request instance
        if (is_null($request)) {
            $request = \Request::instance();
        }

        // replace empty values with NULL, so that it will work with MySQL strict mode on
        foreach ($request->input() as $key => $value) {

This code seems to be duplicated across your project.

            if (empty($value) && $value !== '0') {
                $request->request->set($key, null);
            }
        }

        // insert item in the db
        $item = $this->crud->create($request->except(['save_action', '_token', '_method', 'current_tab']));
        $this->data['entry'] = $this->crud->entry = $item;

        // show a success message
        \Alert::success(trans('backpack::crud.insert_success'))->flash();

        // save the redirect choice for next time
        $this->setSaveAction();

It seems like setSaveAction() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        return $this->performSaveAction($item->getKey());

It seems like performSaveAction() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }
}