Laravel-Backpack / CRUD

src/app/Library/CrudPanel/Traits/FakeFields.php

Doc Comments -2 removed lines

@@ -10,8 +10,6 @@
      * plus the '_token' and 'redirect_after_save' variables.
      *
      * @param array    $requestInput The request input.
-     * @param string   $form         The CRUD form. Can be 'create' or 'update' . Default is 'create'.
-     * @param int|bool $id           The CRUD entry id in the case of the 'update' form.
      *
      * @see \Illuminate\Http\Request::all() For an example on how to get the request input.
      *

Spacing +2 added lines, -2 removed lines

@@ -29,7 +29,7 @@ 
                 $fakeFieldKey = isset($field['store_in']) ? $field['store_in'] : 'extras';
                 $this->addCompactedField($requestInput, $field['name'], $fakeFieldKey);
 
-                if (! in_array($fakeFieldKey, $compactedFakeFields)) {
+                if (!in_array($fakeFieldKey, $compactedFakeFields)) {
                     $compactedFakeFields[] = $fakeFieldKey;
                 }
             }
@@ -37,7 +37,7 @@ 
 
         // json_encode all fake_value columns if applicable in the database, so they can be properly stored and interpreted
         foreach ($compactedFakeFields as $value) {
-            if (! (property_exists($this->model, 'translatable') && in_array($value, $this->model->getTranslatableAttributes(), true)) && $this->model->shouldEncodeFake($value)) {
+            if (!(property_exists($this->model, 'translatable') && in_array($value, $this->model->getTranslatableAttributes(), true)) && $this->model->shouldEncodeFake($value)) {
                 $requestInput[$value] = json_encode($requestInput[$value]);
             }
         }

src/app/Library/CrudPanel/Traits/Fields.php

Doc Comments -7 removed lines

@@ -22,7 +22,6 @@ 
      * Add a field to the create/update form or both.
      *
      * @param string|array $field The new field.
-     * @param string       $form  The CRUD form. Can be 'create', 'update' or 'both'. Default is 'both'.
      *
      * @return self
      */
@@ -70,7 +69,6 @@ 
      * Add multiple fields to the create/update form or both.
      *
      * @param array  $fields The new fields.
-     * @param string $form   The CRUD form. Can be 'create', 'update' or 'both'. Default is 'both'.
      */
     public function addFields($fields)
     {
@@ -85,7 +83,6 @@ 
      * Move the most recently added field after the given target field.
      *
      * @param string $targetFieldName The target field name.
-     * @param string $form            The CRUD form. Can be 'create', 'update' or 'both'. Default is 'both'.
      */
     public function afterField($targetFieldName)
     {
@@ -98,7 +95,6 @@ 
      * Move the most recently added field before the given target field.
      *
      * @param string $targetFieldName The target field name.
-     * @param string $form            The CRUD form. Can be 'create', 'update' or 'both'. Default is 'both'.
      */
     public function beforeField($targetFieldName)
     {
@@ -141,7 +137,6 @@ 
      * Remove a certain field from the create/update/both forms by its name.
      *
      * @param string $name Field name (as defined with the addField() procedure)
-     * @param string $form update/create/both
      */
     public function removeField($name)
     {
@@ -330,8 +325,6 @@ 
      * Check if the create/update form has upload fields.
      * Upload fields are the ones that have "upload" => true defined on them.
      *
-     * @param  string   $form create/update/both - defaults to 'both'
-     * @param  bool|int $id   id of the entity - defaults to false
      *
      * @return bool
      */

Spacing +12 added lines, -12 removed lines

@@ -38,23 +38,23 @@ 
 
         // if this is a relation type field and no corresponding model was specified, get it from the relation method
         // defined in the main model
-        if (isset($newField['entity']) && ! isset($newField['model'])) {
+        if (isset($newField['entity']) && !isset($newField['model'])) {
             $newField['model'] = $this->getRelationModel($newField['entity']);
         }
 
         // if the label is missing, we should set it
-        if (! isset($newField['label'])) {
+        if (!isset($newField['label'])) {
             $newField['label'] = mb_ucfirst(str_replace('_', ' ', $newField['name']));
         }
 
         // if the field type is missing, we should set it
-        if (! isset($newField['type'])) {
+        if (!isset($newField['type'])) {
             $newField['type'] = $this->getFieldTypeFromDbColumnType($newField['name']);
         }
 
         // if a tab was mentioned, we should enable it
         if (isset($newField['tab'])) {
-            if (! $this->tabsEnabled()) {
+            if (!$this->tabsEnabled()) {
                 $this->enableTabs();
             }
         }
@@ -89,7 +89,7 @@ 
      */
     public function afterField($targetFieldName)
     {
-        $this->transformFields(function ($fields) use ($targetFieldName) {
+        $this->transformFields(function($fields) use ($targetFieldName) {
             return $this->moveField($fields, $targetFieldName, false);
         });
     }
@@ -102,7 +102,7 @@ 
      */
     public function beforeField($targetFieldName)
     {
-        $this->transformFields(function ($fields) use ($targetFieldName) {
+        $this->transformFields(function($fields) use ($targetFieldName) {
             return $this->moveField($fields, $targetFieldName, true);
         });
     }
@@ -145,7 +145,7 @@ 
      */
     public function removeField($name)
     {
-        $this->transformFields(function ($fields) use ($name) {
+        $this->transformFields(function($fields) use ($name) {
             array_forget($fields, $name);
 
             return $fields;
@@ -159,7 +159,7 @@ 
      */
     public function removeFields($array_of_names)
     {
-        if (! empty($array_of_names)) {
+        if (!empty($array_of_names)) {
             foreach ($array_of_names as $name) {
                 $this->removeField($name);
             }
@@ -172,7 +172,7 @@ 
     public function removeAllFields()
     {
         $current_fields = $this->getCurrentFields();
-        if (! empty($current_fields)) {
+        if (!empty($current_fields)) {
             foreach ($current_fields as $field) {
                 $this->removeField($field['name']);
             }
@@ -246,7 +246,7 @@ 
                 $jsonCastables = ['array', 'object', 'json'];
                 $fieldCasting = $casted_attributes[$field['name']];
 
-                if (in_array($fieldCasting, $jsonCastables) && isset($data[$field['name']]) && ! empty($data[$field['name']]) && ! is_array($data[$field['name']])) {
+                if (in_array($fieldCasting, $jsonCastables) && isset($data[$field['name']]) && !empty($data[$field['name']]) && !is_array($data[$field['name']])) {
                     try {
                         $data[$field['name']] = json_decode($data[$field['name']]);
                     } catch (\Exception $e) {
@@ -275,7 +275,7 @@ 
      */
     public function orderFields($order)
     {
-        $this->transformFields(function ($fields) use ($order) {
+        $this->transformFields(function($fields) use ($order) {
             return $this->applyOrderToFields($fields, $order);
         });
     }
@@ -338,7 +338,7 @@ 
     public function hasUploadFields()
     {
         $fields = $this->getFields();
-        $upload_fields = array_where($fields, function ($value, $key) {
+        $upload_fields = array_where($fields, function($value, $key) {
             return isset($value['upload']) && $value['upload'] == true;
         });
 

src/app/Library/CrudPanel/Traits/Operations.php

Doc Comments +2 added lines, -2 removed lines

@@ -56,7 +56,7 @@ 
     /**
      * Convenience method to make sure all calls are made to a particular operation.
      *
-     * @param  string|array     $operation      Operation name in string form
+     * @param  string|array     $operations      Operation name in string form
      * @param  bool|\Closure    $closure        Code that calls CrudPanel methods.
      * @return void
      */
@@ -70,7 +70,7 @@ 
      * Allc configurations are put inside that operation's namespace.
      * Ex: show.configuration.
      *
-     * @param  string|array     $operation      Operation name in string form
+     * @param  string|array     $operations      Operation name in string form
      * @param  bool|\Closure    $closure        Code that calls CrudPanel methods.
      * @return void
      */

src/app/Library/CrudPanel/Traits/Query.php

Doc Comments +1 added lines, -1 removed lines

@@ -62,7 +62,7 @@
      * Order results of the query in a custom way.
      *
      * @param  array $column           Column array with all attributes
-     * @param  string $column_direction ASC or DESC
+     * @param  string $columnDirection ASC or DESC
      *
      * @return \Illuminate\Database\Eloquent\Builder
      */

Spacing +1 added lines, -1 removed lines

@@ -68,7 +68,7 @@
      */
     public function customOrderBy($column, $columnDirection = 'asc')
     {
-        if (! isset($column['orderLogic'])) {
+        if (!isset($column['orderLogic'])) {
             return $this->query;
         }
 

src/app/Library/CrudPanel/Traits/Search.php

Doc Comments +2 added lines, -1 removed lines

@@ -35,6 +35,7 @@ 
 
     /**
      * Apply the search logic for each CRUD column.
+     * @param string $searchTerm
      */
     public function applySearchLogicForColumn($query, $column, $searchTerm)
     {
@@ -230,7 +231,7 @@ 
      *
      * @param string   $view
      * @param array    $column
-     * @param object   $entry
+     * @param \Illuminate\Database\Eloquent\Model   $entry
      * @param bool|int $rowNumber The number shown to the user as row number (index)
      *
      * @return string

Unused Use Statements +1 added lines, -1 removed lines

@@ -2,8 +2,8 @@
 
 namespace Backpack\CRUD\app\Library\CrudPanel\Traits;
 
-use Validator;
 use Carbon\Carbon;
+use Validator;
 
 trait Search
 {

Indentation +4 added lines, -4 removed lines

@@ -210,10 +210,10 @@
         // add the details_row button to the first column
         if ($this->getOperationSetting('detailsRow')) {
             $details_row_button = \View::make('crud::columns.details_row_button')
-                                           ->with('crud', $this)
-                                           ->with('entry', $entry)
-                                           ->with('row_number', $rowNumber)
-                                           ->render();
+                                            ->with('crud', $this)
+                                            ->with('entry', $entry)
+                                            ->with('row_number', $rowNumber)
+                                            ->render();
             $row_items[0] = $details_row_button.$row_items[0];
         }
 

Spacing +4 added lines, -4 removed lines

@@ -22,9 +22,9 @@ 
      */
     public function applySearchTerm($searchTerm)
     {
-        return $this->query->where(function ($query) use ($searchTerm) {
+        return $this->query->where(function($query) use ($searchTerm) {
             foreach ($this->columns() as $column) {
-                if (! isset($column['type'])) {
+                if (!isset($column['type'])) {
                     abort(400, 'Missing column type when trying to apply search term.');
                 }
 
@@ -82,7 +82,7 @@ 
 
                 case 'select':
                 case 'select_multiple':
-                    $query->orWhereHas($column['entity'], function ($q) use ($column, $searchTerm) {
+                    $query->orWhereHas($column['entity'], function($q) use ($column, $searchTerm) {
                         $q->where($column['attribute'], 'like', '%'.$searchTerm.'%');
                     });
                     break;
@@ -274,7 +274,7 @@ 
      */
     private function renderCellView($view, $column, $entry, $rowNumber = false)
     {
-        if (! view()->exists($view)) {
+        if (!view()->exists($view)) {
             $view = 'crud::columns.text'; // fallback to text column
         }
 

src/app/Library/CrudPanel/Traits/Settings.php

Doc Comments +1 added lines, -1 removed lines

@@ -102,7 +102,7 @@
      * Defaults to the current operation.
      *
      * @param  string   $key   Has no operation prepended. (ex: exportButtons)
-     * @return mixed      [description]
+     * @return boolean      [description]
      */
     public function hasOperationSetting(string $key, $operation = null)
     {

Spacing +1 added lines, -1 removed lines

@@ -49,7 +49,7 @@
      */
     public function settings()
     {
-        return \Arr::sort($this->settings, function ($value, $key) {
+        return \Arr::sort($this->settings, function($value, $key) {
             return $key;
         });
     }

src/app/Library/CrudPanel/Traits/Tabs.php

Doc Comments +3 added lines

@@ -35,6 +35,9 @@
         return ! $this->tabsEnabled();
     }
 
+    /**
+     * @param string $type
+     */
     public function setTabsType($type)
     {
         $this->enableTabs();

Spacing +7 added lines, -7 removed lines

@@ -32,7 +32,7 @@ 
      */
     public function tabsDisabled()
     {
-        return ! $this->tabsEnabled();
+        return !$this->tabsEnabled();
     }
 
     public function setTabsType($type)
@@ -114,8 +114,8 @@ 
     {
         $all_fields = $this->getCurrentFields();
 
-        $fields_without_a_tab = collect($all_fields)->filter(function ($value, $key) {
-            return ! isset($value['tab']);
+        $fields_without_a_tab = collect($all_fields)->filter(function($value, $key) {
+            return !isset($value['tab']);
         });
 
         return $fields_without_a_tab;
@@ -131,7 +131,7 @@ 
         if ($this->tabExists($label)) {
             $all_fields = $this->getCurrentFields();
 
-            $fields_for_current_tab = collect($all_fields)->filter(function ($value, $key) use ($label) {
+            $fields_for_current_tab = collect($all_fields)->filter(function($value, $key) use ($label) {
                 return isset($value['tab']) && $value['tab'] == $label;
             });
 
@@ -150,11 +150,11 @@ 
         $fields = $this->getCurrentFields();
 
         $fields_with_tabs = collect($fields)
-            ->filter(function ($value, $key) {
+            ->filter(function($value, $key) {
                 return isset($value['tab']);
             })
-            ->each(function ($value, $key) use (&$tabs) {
-                if (! in_array($value['tab'], $tabs)) {
+            ->each(function($value, $key) use (&$tabs) {
+                if (!in_array($value['tab'], $tabs)) {
                     $tabs[] = $value['tab'];
                 }
             });

src/app/Library/CrudPanel/Traits/Validation.php

Doc Comments -1 removed lines

@@ -88,7 +88,6 @@
      * for the given operation.
      *
      * @param string $inputKey Field or input name.
-     * @param string $operation create / update
      *
      * @return bool
      */

Spacing +1 added lines, -1 removed lines

@@ -94,7 +94,7 @@
      */
     public function isRequired($inputKey)
     {
-        if (! $this->hasOperationSetting('requiredFields')) {
+        if (!$this->hasOperationSetting('requiredFields')) {
             return false;
         }
 

src/app/Models/Traits/CrudTrait.php

Doc Comments +1 added lines, -1 removed lines

@@ -69,7 +69,7 @@
      *
      * @param array $columns - the database columns that contain the JSONs
      *
-     * @return Model
+     * @return CrudTrait
      */
     public function withFakes($columns = [])
     {

Unused Use Statements +2 added lines, -2 removed lines

@@ -3,9 +3,9 @@
 namespace Backpack\CRUD\app\Models\Traits;
 
 use DB;
-use Traversable;
-use Illuminate\Support\Facades\Config;
 use Illuminate\Database\Eloquent\Model;
+use Illuminate\Support\Facades\Config;
+use Traversable;
 
 trait CrudTrait
 {

Spacing +6 added lines, -6 removed lines

@@ -69,7 +69,7 @@ 
         $conn->getDoctrineSchemaManager()->getDatabasePlatform()->registerDoctrineTypeMapping('json', 'json_array');
         $conn->getDoctrineSchemaManager()->getDatabasePlatform()->registerDoctrineTypeMapping('jsonb', 'json_array');
 
-        return ! $conn->getDoctrineColumn($table, $column_name)->getNotnull();
+        return !$conn->getDoctrineColumn($table, $column_name)->getNotnull();
     }
 
     /*
@@ -86,7 +86,7 @@ 
     public function addFakes($columns = ['extras'])
     {
         foreach ($columns as $key => $column) {
-            if (! isset($this->attributes[$column])) {
+            if (!isset($this->attributes[$column])) {
                 continue;
             }
 
@@ -134,7 +134,7 @@ 
      */
     public function shouldDecodeFake($column)
     {
-        return ! in_array($column, array_keys($this->casts));
+        return !in_array($column, array_keys($this->casts));
     }
 
     /**
@@ -145,7 +145,7 @@ 
      */
     public function shouldEncodeFake($column)
     {
-        return ! in_array($column, array_keys($this->casts));
+        return !in_array($column, array_keys($this->casts));
     }
 
     /*
@@ -219,7 +219,7 @@ 
     public function uploadMultipleFilesToDisk($value, $attribute_name, $disk, $destination_path)
     {
         $request = \Request::instance();
-        if (! is_array($this->{$attribute_name})) {
+        if (!is_array($this->{$attribute_name})) {
             $attribute_value = json_decode($this->{$attribute_name}, true) ?? [];
         } else {
             $attribute_value = $this->{$attribute_name};
@@ -231,7 +231,7 @@ 
         if ($files_to_clear) {
             foreach ($files_to_clear as $key => $filename) {
                 \Storage::disk($disk)->delete($filename);
-                $attribute_value = array_where($attribute_value, function ($value, $key) use ($filename) {
+                $attribute_value = array_where($attribute_value, function($value, $key) use ($filename) {
                     return $value != $filename;
                 });
             }