Laravel-Backpack / CRUD

src/app/Http/Middleware/CheckIfAdmin.php

Doc Comments +1 added lines, -1 removed lines

@@ -29,7 +29,7 @@
     /**
      * Answer to unauthorized access request.
      *
-     * @param [type] $request [description]
+     * @param \Illuminate\Http\Request $request [description]
      *
      * @return [type] [description]
      */

Spacing +1 added lines, -1 removed lines

@@ -56,7 +56,7 @@
             return $this->respondToUnauthorizedRequest($request);
         }
 
-        if (! $this->checkIfUserIsAdmin(backpack_user())) {
+        if (!$this->checkIfUserIsAdmin(backpack_user())) {
             return $this->respondToUnauthorizedRequest($request);
         }
 

src/app/Http/Requests/AccountInfoRequest.php

Unused Use Statements +1 added lines, -1 removed lines

@@ -2,8 +2,8 @@
 
 namespace Backpack\CRUD\app\Http\Requests;
 
-use Illuminate\Validation\Rule;
 use Illuminate\Foundation\Http\FormRequest;
+use Illuminate\Validation\Rule;
 
 class AccountInfoRequest extends FormRequest
 {

src/app/Http/Requests/ChangePasswordRequest.php

Unused Use Statements +1 added lines, -1 removed lines

@@ -2,8 +2,8 @@
 
 namespace Backpack\CRUD\app\Http\Requests;
 
-use Illuminate\Support\Facades\Hash;
 use Illuminate\Foundation\Http\FormRequest;
+use Illuminate\Support\Facades\Hash;
 
 class ChangePasswordRequest extends FormRequest
 {

Spacing +2 added lines, -2 removed lines

@@ -41,9 +41,9 @@
      */
     public function withValidator($validator)
     {
-        $validator->after(function ($validator) {
+        $validator->after(function($validator) {
             // check old password matches
-            if (! Hash::check($this->input('old_password'), backpack_auth()->user()->password)) {
+            if (!Hash::check($this->input('old_password'), backpack_auth()->user()->password)) {
                 $validator->errors()->add('old_password', trans('backpack::base.old_password_incorrect'));
             }
         });

src/app/Library/CrudPanel/CrudPanel.php

Unused Use Statements +17 added lines, -17 removed lines

@@ -2,33 +2,33 @@
 
 namespace Backpack\CRUD\app\Library\CrudPanel;
 
-use Illuminate\Database\Eloquent\Collection;
-use Backpack\CRUD\app\Library\CrudPanel\Traits\Read;
-use Backpack\CRUD\app\Library\CrudPanel\Traits\Tabs;
-use Backpack\CRUD\app\Library\CrudPanel\Traits\Query;
-use Backpack\CRUD\app\Library\CrudPanel\Traits\Views;
 use Backpack\CRUD\app\Library\CrudPanel\Traits\Access;
+use Backpack\CRUD\app\Library\CrudPanel\Traits\AutoFocus;
+use Backpack\CRUD\app\Library\CrudPanel\Traits\AutoSet;
+use Backpack\CRUD\app\Library\CrudPanel\Traits\Buttons;
+use Backpack\CRUD\app\Library\CrudPanel\Traits\Columns;
 use Backpack\CRUD\app\Library\CrudPanel\Traits\Create;
 use Backpack\CRUD\app\Library\CrudPanel\Traits\Delete;
 use Backpack\CRUD\app\Library\CrudPanel\Traits\Errors;
+use Backpack\CRUD\app\Library\CrudPanel\Traits\FakeColumns;
+use Backpack\CRUD\app\Library\CrudPanel\Traits\FakeFields;
 use Backpack\CRUD\app\Library\CrudPanel\Traits\Fields;
-use Backpack\CRUD\app\Library\CrudPanel\Traits\Search;
-use Backpack\CRUD\app\Library\CrudPanel\Traits\Update;
-use Backpack\CRUD\app\Library\CrudPanel\Traits\AutoSet;
-use Backpack\CRUD\app\Library\CrudPanel\Traits\Buttons;
-use Backpack\CRUD\app\Library\CrudPanel\Traits\Columns;
 use Backpack\CRUD\app\Library\CrudPanel\Traits\Filters;
-use Backpack\CRUD\app\Library\CrudPanel\Traits\Reorder;
-use Backpack\CRUD\app\Library\CrudPanel\Traits\Settings;
-use Backpack\CRUD\app\Library\CrudPanel\Traits\AutoFocus;
+use Backpack\CRUD\app\Library\CrudPanel\Traits\HeadingsAndTitles;
 use Backpack\CRUD\app\Library\CrudPanel\Traits\Macroable;
-use Backpack\CRUD\app\Library\CrudPanel\Traits\FakeFields;
 use Backpack\CRUD\app\Library\CrudPanel\Traits\Operations;
-use Backpack\CRUD\app\Library\CrudPanel\Traits\Validation;
-use Backpack\CRUD\app\Library\CrudPanel\Traits\FakeColumns;
+use Backpack\CRUD\app\Library\CrudPanel\Traits\Query;
+use Backpack\CRUD\app\Library\CrudPanel\Traits\Read;
+use Backpack\CRUD\app\Library\CrudPanel\Traits\Reorder;
 use Backpack\CRUD\app\Library\CrudPanel\Traits\SaveActions;
-use Backpack\CRUD\app\Library\CrudPanel\Traits\HeadingsAndTitles;
+use Backpack\CRUD\app\Library\CrudPanel\Traits\Search;
+use Backpack\CRUD\app\Library\CrudPanel\Traits\Settings;
+use Backpack\CRUD\app\Library\CrudPanel\Traits\Tabs;
+use Backpack\CRUD\app\Library\CrudPanel\Traits\Update;
+use Backpack\CRUD\app\Library\CrudPanel\Traits\Validation;
+use Backpack\CRUD\app\Library\CrudPanel\Traits\Views;
 use Backpack\CRUD\app\Library\CrudPanel\Traits\ViewsAndRestoresRevisions;
+use Illuminate\Database\Eloquent\Collection;
 
 class CrudPanel
 {

Spacing +11 added lines, -11 removed lines

@@ -76,11 +76,11 @@ 
      */
     public function setModel($model_namespace)
     {
-        if (! class_exists($model_namespace)) {
+        if (!class_exists($model_namespace)) {
             throw new \Exception('The model does not exist.', 500);
         }
 
-        if (! method_exists($model_namespace, 'hasCrudTrait')) {
+        if (!method_exists($model_namespace, 'hasCrudTrait')) {
             throw new \Exception('Please use CrudTrait on the model.', 500);
         }
 
@@ -143,7 +143,7 @@ 
     {
         $complete_route = $route.'.index';
 
-        if (! \Route::has($complete_route)) {
+        if (!\Route::has($complete_route)) {
             throw new \Exception('There are no routes for this route name.', 404);
         }
 
@@ -244,7 +244,7 @@ 
      */
     public function getFirstOfItsTypeInArray($type, $array)
     {
-        return array_first($array, function ($item) use ($type) {
+        return array_first($array, function($item) use ($type) {
             return $item['type'] == $type;
         });
     }
@@ -261,8 +261,8 @@ 
 
     public function sync($type, $fields, $attributes)
     {
-        if (! empty($this->{$type})) {
-            $this->{$type} = array_map(function ($field) use ($fields, $attributes) {
+        if (!empty($this->{$type})) {
+            $this->{$type} = array_map(function($field) use ($fields, $attributes) {
                 if (in_array($field['name'], (array) $fields)) {
                     $field = array_merge($field, $attributes);
                 }
@@ -294,15 +294,15 @@ 
     {
         $relationArray = explode('.', $relationString);
 
-        if (! isset($length)) {
+        if (!isset($length)) {
             $length = count($relationArray);
         }
 
-        if (! isset($model)) {
+        if (!isset($model)) {
             $model = $this->model;
         }
 
-        $result = array_reduce(array_splice($relationArray, 0, $length), function ($obj, $method) {
+        $result = array_reduce(array_splice($relationArray, 0, $length), function($obj, $method) {
             return $obj->$method()->getRelated();
         }, $model);
 
@@ -352,7 +352,7 @@ 
         $relation = $model->{$firstRelationName};
 
         $results = [];
-        if (! empty($relation)) {
+        if (!empty($relation)) {
             if ($relation instanceof Collection) {
                 $currentResults = $relation->toArray();
             } else {
@@ -361,7 +361,7 @@ 
 
             array_shift($relationArray);
 
-            if (! empty($relationArray)) {
+            if (!empty($relationArray)) {
                 foreach ($currentResults as $currentResult) {
                     $results = array_merge($results, $this->getRelationModelInstances($currentResult, implode('.', $relationArray)));
                 }

src/app/Library/CrudPanel/Traits/Access.php

Doc Comments +2 added lines, -2 removed lines

@@ -50,7 +50,7 @@ 
     /**
      * Check if any operations are allowed for a Crud Panel. Return false if not.
      *
-     * @param array $operation_array
+     * @param boolean $operation_array
      * @return bool
      */
     public function hasAccessToAny($operation_array)
@@ -67,7 +67,7 @@ 
     /**
      * Check if all operations are allowed for a Crud Panel. Return false if not.
      *
-     * @param array $operation_array Permissions.
+     * @param string $operation_array Permissions.
      * @return bool
      */
     public function hasAccessToAll($operation_array)

Spacing +3 added lines, -3 removed lines

@@ -33,7 +33,7 @@ 
             $this->set($op.'.access', false);
         }
 
-        return ! $this->hasAccessToAny($operation);
+        return !$this->hasAccessToAny($operation);
     }
 
     /**
@@ -73,7 +73,7 @@ 
     public function hasAccessToAll($operation_array)
     {
         foreach ((array) $operation_array as $key => $operation) {
-            if (! $this->get($operation.'.access')) {
+            if (!$this->get($operation.'.access')) {
                 return false;
             }
         }
@@ -90,7 +90,7 @@ 
      */
     public function hasAccessOrFail($operation)
     {
-        if (! $this->get($operation.'.access')) {
+        if (!$this->get($operation.'.access')) {
             throw new AccessDeniedException(trans('backpack::crud.unauthorized_access', ['access' => $operation]));
         }
 

src/app/Library/CrudPanel/Traits/AutoFocus.php

Doc Comments +3 added lines

@@ -12,6 +12,9 @@
         return $this->getOperationSetting('autoFocusOnFirstField');
     }
 
+    /**
+     * @param boolean $value
+     */
     public function setAutoFocusOnFirstField($value)
     {
         return $this->setOperationSetting('autoFocusOnFirstField', (bool) $value);

src/app/Library/CrudPanel/Traits/Buttons.php

Doc Comments +6 added lines

@@ -95,6 +95,12 @@
     public $type = 'view';
     public $content;
 
+    /**
+     * @param string $stack
+     * @param string $name
+     * @param string $type
+     * @param string $content
+     */
     public function __construct($stack, $name, $type, $content)
     {
         $this->stack = $stack;

Spacing +5 added lines, -5 removed lines

@@ -92,7 +92,7 @@ 
          */
         $button = $this->buttons()->firstWhere('name', $name);
 
-        if (! $button) {
+        if (!$button) {
             abort(500, 'CRUD Button "'.$name.'" not found. Please check the button exists before you modify it.');
         }
 
@@ -113,7 +113,7 @@ 
      */
     public function removeButton($name, $stack = null)
     {
-        $this->setOperationSetting('buttons', $this->buttons()->reject(function ($button) use ($name, $stack) {
+        $this->setOperationSetting('buttons', $this->buttons()->reject(function($button) use ($name, $stack) {
             return $stack == null ? $button->name == $name : ($button->stack == $stack) && ($button->name == $name);
         }));
     }
@@ -124,7 +124,7 @@ 
      */
     public function removeButtons($names, $stack = null)
     {
-        if (! empty($names)) {
+        if (!empty($names)) {
             foreach ($names as $name) {
                 $this->removeButton($name, $stack);
             }
@@ -138,14 +138,14 @@ 
 
     public function removeAllButtonsFromStack($stack)
     {
-        $this->setOperationSetting('buttons', $this->buttons()->reject(function ($button) use ($stack) {
+        $this->setOperationSetting('buttons', $this->buttons()->reject(function($button) use ($stack) {
             return $button->stack == $stack;
         }));
     }
 
     public function removeButtonFromStack($name, $stack)
     {
-        $this->setOperationSetting('buttons', $this->buttons()->reject(function ($button) use ($name, $stack) {
+        $this->setOperationSetting('buttons', $this->buttons()->reject(function($button) use ($name, $stack) {
             return $button->name == $name && $button->stack == $stack;
         }));
     }

src/app/Library/CrudPanel/Traits/Columns.php

Doc Comments +2 added lines, -2 removed lines

@@ -160,7 +160,7 @@ 
 
     /**
      * Move this column to be first in the columns list.
-     * @return bool|null
+     * @return false|null
      */
     public function makeFirstColumn()
     {
@@ -237,7 +237,7 @@ 
     /**
      * Remove a column from the CRUD panel by name.
      *
-     * @param string $column The column key.
+     * @param string $columnKey The column key.
      */
     public function removeColumn($columnKey)
     {

Spacing +14 added lines, -15 removed lines

@@ -63,7 +63,7 @@ 
     public function addColumn($column)
     {
         // if a string was passed, not an array, change it to an array
-        if (! is_array($column)) {
+        if (!is_array($column)) {
             $column = ['name' => $column];
         }
 
@@ -71,7 +71,7 @@ 
         $column_with_details = $this->addDefaultLabel($column);
 
         // make sure the column has a name
-        if (! array_key_exists('name', $column_with_details)) {
+        if (!array_key_exists('name', $column_with_details)) {
             $column_with_details['name'] = 'anonymous_column_'.str_random(5);
         }
 
@@ -79,27 +79,27 @@ 
         $columnExistsInDb = $this->hasColumn($this->model->getTable(), $column_with_details['name']);
 
         // make sure the column has a type
-        if (! array_key_exists('type', $column_with_details)) {
+        if (!array_key_exists('type', $column_with_details)) {
             $column_with_details['type'] = 'text';
         }
 
         // make sure the column has a key
-        if (! array_key_exists('key', $column_with_details)) {
+        if (!array_key_exists('key', $column_with_details)) {
             $column_with_details['key'] = $column_with_details['name'];
         }
 
         // make sure the column has a tableColumn boolean
-        if (! array_key_exists('tableColumn', $column_with_details)) {
+        if (!array_key_exists('tableColumn', $column_with_details)) {
             $column_with_details['tableColumn'] = $columnExistsInDb ? true : false;
         }
 
         // make sure the column has a orderable boolean
-        if (! array_key_exists('orderable', $column_with_details)) {
+        if (!array_key_exists('orderable', $column_with_details)) {
             $column_with_details['orderable'] = $columnExistsInDb ? true : false;
         }
 
         // make sure the column has a searchLogic
-        if (! array_key_exists('searchLogic', $column_with_details)) {
+        if (!array_key_exists('searchLogic', $column_with_details)) {
             $column_with_details['searchLogic'] = $columnExistsInDb ? true : false;
         }
 
@@ -108,14 +108,14 @@ 
 
         // make sure the column has a priority in terms of visibility
         // if no priority has been defined, use the order in the array plus one
-        if (! array_key_exists('priority', $column_with_details)) {
+        if (!array_key_exists('priority', $column_with_details)) {
             $position_in_columns_array = (int) array_search($column_with_details['key'], array_keys($this->columns()));
             $columnsArray[$column_with_details['key']]['priority'] = $position_in_columns_array + 1;
         }
 
         // if this is a relation type field and no corresponding model was specified, get it from the relation method
         // defined in the main model
-        if (isset($column_with_details['entity']) && ! isset($column_with_details['model'])) {
+        if (isset($column_with_details['entity']) && !isset($column_with_details['model'])) {
             $columnsArray[$column_with_details['key']]['model'] = $this->getRelationModel($column_with_details['entity']);
         }
 
@@ -164,7 +164,7 @@ 
      */
     public function makeFirstColumn()
     {
-        if (! $this->columns()) {
+        if (!$this->columns()) {
             return false;
         }
 
@@ -186,8 +186,7 @@ 
         $columnsArray = $this->columns();
 
         if (array_key_exists($targetColumnName, $columnsArray)) {
-            $targetColumnPosition = $before ? array_search($targetColumnName, array_keys($columnsArray)) :
-                array_search($targetColumnName, array_keys($columnsArray)) + 1;
+            $targetColumnPosition = $before ? array_search($targetColumnName, array_keys($columnsArray)) : array_search($targetColumnName, array_keys($columnsArray)) + 1;
 
             $element = array_pop($columnsArray);
             $beginningPart = array_slice($columnsArray, 0, $targetColumnPosition, true);
@@ -225,7 +224,7 @@ 
      */
     public function addDefaultLabel($array)
     {
-        if (! array_key_exists('label', (array) $array) && array_key_exists('name', (array) $array)) {
+        if (!array_key_exists('label', (array) $array) && array_key_exists('name', (array) $array)) {
             $array = array_merge(['label' => mb_ucfirst($this->makeLabel($array['name']))], $array);
 
             return $array;
@@ -253,7 +252,7 @@ 
      */
     public function removeColumns($columns)
     {
-        if (! empty($columns)) {
+        if (!empty($columns)) {
             foreach ($columns as $columnKey) {
                 $this->removeColumn($columnKey);
             }
@@ -331,7 +330,7 @@ 
     {
         $columns = $this->columns();
 
-        return collect($columns)->pluck('entity')->reject(function ($value, $key) {
+        return collect($columns)->pluck('entity')->reject(function($value, $key) {
             return $value == null;
         })->toArray();
     }

src/app/Library/CrudPanel/Traits/Create.php

Doc Comments +1 added lines, -1 removed lines

@@ -159,7 +159,7 @@
      * @param \Illuminate\Database\Eloquent\Model $item          The current CRUD model.
      * @param array                               $formattedData The form data.
      *
-     * @return bool|null
+     * @return false|null
      */
     private function createRelationsForItem($item, $formattedData)
     {

Unused Use Statements +1 added lines, -1 removed lines

@@ -2,8 +2,8 @@
 
 namespace Backpack\CRUD\app\Library\CrudPanel\Traits;
 
-use Illuminate\Database\Eloquent\Relations\HasOne;
 use Illuminate\Database\Eloquent\Relations\BelongsTo;
+use Illuminate\Database\Eloquent\Relations\HasOne;
 
 trait Create
 {

Spacing +4 added lines, -4 removed lines

@@ -81,7 +81,7 @@ 
     {
         $all_relation_fields = $this->getRelationFields();
 
-        return array_where($all_relation_fields, function ($value, $key) {
+        return array_where($all_relation_fields, function($value, $key) {
             return isset($value['pivot']) && $value['pivot'];
         });
     }
@@ -156,7 +156,7 @@ 
      */
     private function createRelationsForItem($item, $formattedData)
     {
-        if (! isset($formattedData['relations'])) {
+        if (!isset($formattedData['relations'])) {
             return false;
         }
 
@@ -213,11 +213,11 @@ 
                 $key = implode('.relations.', explode('.', $relationField['entity']));
                 $fieldData = array_get($relationData, 'relations.'.$key, []);
 
-                if (! array_key_exists('model', $fieldData)) {
+                if (!array_key_exists('model', $fieldData)) {
                     $fieldData['model'] = $relationField['model'];
                 }
 
-                if (! array_key_exists('parent', $fieldData)) {
+                if (!array_key_exists('parent', $fieldData)) {
                     $fieldData['parent'] = $this->getRelationModel($relationField['entity'], -1);
                 }