Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Passed
Pull Request — master (#2938)
by Cristian
08:20
created
src/app/Library/CrudPanel/CrudPanel.php 1 patch
Spacing   +19 added lines, -19 removed lines patch added patch discarded remove patch
@@ -100,11 +100,11 @@  discard block
 block discarded – undo
100 100
      */
101 101
     public function setModel($model_namespace)
102 102
     {
103
-        if (! class_exists($model_namespace)) {
103
+        if (!class_exists($model_namespace)) {
104 104
             throw new \Exception('The model does not exist.', 500);
105 105
         }
106 106
 
107
-        if (! method_exists($model_namespace, 'hasCrudTrait')) {
107
+        if (!method_exists($model_namespace, 'hasCrudTrait')) {
108 108
             throw new \Exception('Please use CrudTrait on the model.', 500);
109 109
         }
110 110
 
@@ -167,7 +167,7 @@  discard block
 block discarded – undo
167 167
     {
168 168
         $complete_route = $route.'.index';
169 169
 
170
-        if (! \Route::has($complete_route)) {
170
+        if (!\Route::has($complete_route)) {
171 171
             throw new \Exception('There are no routes for this route name.', 404);
172 172
         }
173 173
 
@@ -268,7 +268,7 @@  discard block
 block discarded – undo
268 268
      */
269 269
     public function getFirstOfItsTypeInArray($type, $array)
270 270
     {
271
-        return Arr::first($array, function ($item) use ($type) {
271
+        return Arr::first($array, function($item) use ($type) {
272 272
             return $item['type'] == $type;
273 273
         });
274 274
     }
@@ -285,8 +285,8 @@  discard block
 block discarded – undo
285 285
 
286 286
     public function sync($type, $fields, $attributes)
287 287
     {
288
-        if (! empty($this->{$type})) {
289
-            $this->{$type} = array_map(function ($field) use ($fields, $attributes) {
288
+        if (!empty($this->{$type})) {
289
+            $this->{$type} = array_map(function($field) use ($fields, $attributes) {
290 290
                 if (in_array($field['name'], (array) $fields)) {
291 291
                     $field = array_merge($field, $attributes);
292 292
                 }
@@ -317,15 +317,15 @@  discard block
 block discarded – undo
317 317
     {
318 318
         $relationArray = explode('.', $relationString);
319 319
 
320
-        if (! isset($length)) {
320
+        if (!isset($length)) {
321 321
             $length = count($relationArray);
322 322
         }
323 323
 
324
-        if (! isset($model)) {
324
+        if (!isset($model)) {
325 325
             $model = $this->model;
326 326
         }
327 327
 
328
-        $result = array_reduce(array_splice($relationArray, 0, $length), function ($obj, $method) {
328
+        $result = array_reduce(array_splice($relationArray, 0, $length), function($obj, $method) {
329 329
             try {
330 330
                 $result = $obj->$method();
331 331
 
@@ -361,7 +361,7 @@  discard block
 block discarded – undo
361 361
             if (is_array($entries)) {
362 362
                 //if attribute does not exist in main array we have more than one entry OR the attribute
363 363
                 //is an acessor that is not in $appends property of model.
364
-                if (! isset($entries[$attribute])) {
364
+                if (!isset($entries[$attribute])) {
365 365
                     //we first check if we don't have the attribute because it's and acessor that is not in appends.
366 366
                     if ($model_instance->hasGetMutator($attribute) && isset($entries[$modelKey])) {
367 367
                         $entry_in_database = $model_instance->find($entries[$modelKey]);
@@ -401,21 +401,21 @@  discard block
 block discarded – undo
401 401
      */
402 402
     public function parseTranslatableAttributes($model, $attribute, $value)
403 403
     {
404
-        if (! method_exists($model, 'isTranslatableAttribute')) {
404
+        if (!method_exists($model, 'isTranslatableAttribute')) {
405 405
             return $value;
406 406
         }
407 407
 
408
-        if (! $model->isTranslatableAttribute($attribute)) {
408
+        if (!$model->isTranslatableAttribute($attribute)) {
409 409
             return $value;
410 410
         }
411 411
 
412
-        if (! is_array($value)) {
412
+        if (!is_array($value)) {
413 413
             $decodedAttribute = json_decode($value, true);
414 414
         } else {
415 415
             $decodedAttribute = $value;
416 416
         }
417 417
 
418
-        if (is_array($decodedAttribute) && ! empty($decodedAttribute)) {
418
+        if (is_array($decodedAttribute) && !empty($decodedAttribute)) {
419 419
             if (isset($decodedAttribute[app()->getLocale()])) {
420 420
                 return $decodedAttribute[app()->getLocale()];
421 421
             } else {
@@ -443,21 +443,21 @@  discard block
 block discarded – undo
443 443
         $currentResults = [];
444 444
 
445 445
         $results = [];
446
-        if (! is_null($relation)) {
447
-            if ($relation instanceof Collection && ! $relation->isEmpty()) {
446
+        if (!is_null($relation)) {
447
+            if ($relation instanceof Collection && !$relation->isEmpty()) {
448 448
                 $currentResults[get_class($relation->first())] = $relation->toArray();
449
-            } elseif (is_array($relation) && ! empty($relation)) {
449
+            } elseif (is_array($relation) && !empty($relation)) {
450 450
                 $currentResults[get_class($relation->first())] = $relation;
451 451
             } else {
452 452
                 //relation must be App\Models\Article or App\Models\Category
453
-                if (! $relation instanceof Collection && ! empty($relation)) {
453
+                if (!$relation instanceof Collection && !empty($relation)) {
454 454
                     $currentResults[get_class($relation)] = $relation->toArray();
455 455
                 }
456 456
             }
457 457
 
458 458
             array_shift($relationArray);
459 459
 
460
-            if (! empty($relationArray)) {
460
+            if (!empty($relationArray)) {
461 461
                 foreach ($currentResults as $model => $currentResult) {
462 462
                     $results[$model] = array_merge($results[$model], $this->getRelatedEntries($currentResult, implode('.', $relationArray)));
463 463
                 }
Please login to merge, or discard this patch.
src/app/Console/Commands/AddCustomRouteContent.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -72,7 +72,7 @@  discard block
 block discarded – undo
72 72
 
73 73
             $process = new Process($command, null, null, null, 300, null);
74 74
 
75
-            $process->run(function ($type, $buffer) {
75
+            $process->run(function($type, $buffer) {
76 76
                 if (Process::ERR === $type) {
77 77
                     $this->line($buffer);
78 78
                 } else {
@@ -81,7 +81,7 @@  discard block
 block discarded – undo
81 81
             });
82 82
 
83 83
             // executes after the command finishes
84
-            if (! $process->isSuccessful()) {
84
+            if (!$process->isSuccessful()) {
85 85
                 throw new ProcessFailedException($process);
86 86
             }
87 87
 
@@ -100,7 +100,7 @@  discard block
 block discarded – undo
100 100
 
101 101
         // otherwise, in case the last line HAS been modified
102 102
         // return the last line that has an ending in it
103
-        $possible_end_lines = array_filter($file_lines, function ($k) {
103
+        $possible_end_lines = array_filter($file_lines, function($k) {
104 104
             return strpos($k, '});') === 0;
105 105
         });
106 106
 
@@ -121,7 +121,7 @@  discard block
 block discarded – undo
121 121
      */
122 122
     private function getLastLineNumberThatContains($needle, $haystack)
123 123
     {
124
-        $matchingLines = array_filter($haystack, function ($k) use ($needle) {
124
+        $matchingLines = array_filter($haystack, function($k) use ($needle) {
125 125
             return strpos($k, $needle) !== false;
126 126
         });
127 127
 
Please login to merge, or discard this patch.
src/app/Console/Commands/AddSidebarContent.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -71,7 +71,7 @@
 block discarded – undo
71 71
      */
72 72
     private function getLastLineNumberThatContains($needle, $haystack)
73 73
     {
74
-        $matchingLines = array_filter($haystack, function ($k) use ($needle) {
74
+        $matchingLines = array_filter($haystack, function($k) use ($needle) {
75 75
             return strpos($k, $needle) !== false;
76 76
         });
77 77
 
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Filters.php 1 patch
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -73,7 +73,7 @@  discard block
 block discarded – undo
73 73
         $this->enableFilters();
74 74
 
75 75
         // check if another filter with the same name exists
76
-        if (! isset($options['name'])) {
76
+        if (!isset($options['name'])) {
77 77
             abort(500, 'All your filters need names.');
78 78
         } else {
79 79
             // make sure we check against the converted camel name before adding.
@@ -123,7 +123,7 @@  discard block
 block discarded – undo
123 123
     {
124 124
         $unappliedFilters = $this->filters()->where('applied', false);
125 125
         if ($unappliedFilters->count()) {
126
-            $unappliedFilters->each(function ($filter) {
126
+            $unappliedFilters->each(function($filter) {
127 127
                 $filter->apply();
128 128
             });
129 129
         }
@@ -173,7 +173,7 @@  discard block
 block discarded – undo
173 173
     {
174 174
         $filter = $this->filters()->firstWhere('name', $name);
175 175
 
176
-        if (! $filter) {
176
+        if (!$filter) {
177 177
             abort(500, 'CRUD Filter "'.$name.'" not found. Please check the filter exists before you modify it.');
178 178
         }
179 179
 
@@ -188,7 +188,7 @@  discard block
 block discarded – undo
188 188
 
189 189
     public function replaceFilter($name, $newFilter)
190 190
     {
191
-        $newFilters = $this->filters()->map(function ($filter, $key) use ($name, $newFilter) {
191
+        $newFilters = $this->filters()->map(function($filter, $key) use ($name, $newFilter) {
192 192
             if ($filter->name != $name) {
193 193
                 return $filter;
194 194
             }
@@ -201,7 +201,7 @@  discard block
 block discarded – undo
201 201
 
202 202
     public function removeFilter($name)
203 203
     {
204
-        $strippedCollection = $this->filters()->reject(function ($filter) use ($name) {
204
+        $strippedCollection = $this->filters()->reject(function($filter) use ($name) {
205 205
             return $filter->name == $name;
206 206
         });
207 207
 
@@ -244,7 +244,7 @@  discard block
 block discarded – undo
244 244
      */
245 245
     public function makeFirstFilter()
246 246
     {
247
-        if (! $this->filters()) {
247
+        if (!$this->filters()) {
248 248
             return false;
249 249
         }
250 250
 
@@ -274,15 +274,15 @@  discard block
 block discarded – undo
274 274
         $destinationFilter = $this->firstFilterWhere('name', $destination);
275 275
         $destinationKey = $this->getFilterKey($destination);
276 276
         $newDestinationKey = ($where == 'before' ? $destinationKey : $destinationKey + 1);
277
-        $newFilters = $this->filters()->filter(function ($value, $key) use ($target) {
277
+        $newFilters = $this->filters()->filter(function($value, $key) use ($target) {
278 278
             return $value->name != $target;
279 279
         });
280 280
 
281
-        if (! $targetFilter) {
281
+        if (!$targetFilter) {
282 282
             return;
283 283
         }
284 284
 
285
-        if (! $destinationFilter) {
285
+        if (!$destinationFilter) {
286 286
             return;
287 287
         }
288 288
 
@@ -290,7 +290,7 @@  discard block
 block discarded – undo
290 290
         $lastSlice = $newFilters->slice($newDestinationKey, null);
291 291
 
292 292
         $newFilters = $firstSlice->push($targetFilter);
293
-        $lastSlice->each(function ($item, $key) use ($newFilters) {
293
+        $lastSlice->each(function($item, $key) use ($newFilters) {
294 294
             $newFilters->push($item);
295 295
         });
296 296
 
Please login to merge, or discard this patch.
src/app/Http/Controllers/Operations/FetchOperation.php 1 patch
Spacing   +6 added lines, -8 removed lines patch added patch discarded remove patch
@@ -45,8 +45,8 @@  discard block
 block discarded – undo
45 45
         // otherwise assume the arguments are actually the configuration array
46 46
         $config = [];
47 47
 
48
-        if (! is_array($arg)) {
49
-            if (! class_exists($arg)) {
48
+        if (!is_array($arg)) {
49
+            if (!class_exists($arg)) {
50 50
                 return response()->json(['error' => 'Class: '.$arg.' does not exists'], 500);
51 51
             }
52 52
             $config['model'] = $arg;
@@ -76,8 +76,7 @@  discard block
 block discarded – undo
76 76
 
77 77
         if ($search_string === false) {
78 78
             return ($config['paginate'] !== false) ?
79
-            $config['query']->paginate($config['paginate']) :
80
-            $config['query']->get();
79
+            $config['query']->paginate($config['paginate']) : $config['query']->get();
81 80
         }
82 81
 
83 82
         $textColumnTypes = ['string', 'json_string', 'text', 'longText', 'json_array'];
@@ -88,8 +87,8 @@  discard block
 block discarded – undo
88 87
         // .... 'query' => function($model) { return $model->where('active', 1); }
89 88
         // So it reads: SELECT ... WHERE active = 1 AND (XXX = x OR YYY = y) and not SELECT ... WHERE active = 1 AND XXX = x OR YYY = y;
90 89
 
91
-        if (! empty($config['query']->getQuery()->wheres)) {
92
-            $config['query'] = $config['query']->where(function ($query) use ($model_instance, $config, $search_string, $textColumnTypes) {
90
+        if (!empty($config['query']->getQuery()->wheres)) {
91
+            $config['query'] = $config['query']->where(function($query) use ($model_instance, $config, $search_string, $textColumnTypes) {
93 92
                 foreach ((array) $config['searchable_attributes'] as $k => $searchColumn) {
94 93
                     $operation = ($k == 0) ? 'where' : 'orWhere';
95 94
                     $columnType = $model_instance->getColumnType($searchColumn);
@@ -118,7 +117,6 @@  discard block
 block discarded – undo
118 117
 
119 118
         // return the results with or without pagination
120 119
         return ($config['paginate'] !== false) ?
121
-                    $config['query']->paginate($config['paginate']) :
122
-                    $config['query']->get();
120
+                    $config['query']->paginate($config['paginate']) : $config['query']->get();
123 121
     }
124 122
 }
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Create.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -82,7 +82,7 @@  discard block
 block discarded – undo
82 82
     {
83 83
         $all_relation_fields = $this->getRelationFields();
84 84
 
85
-        return Arr::where($all_relation_fields, function ($value, $key) {
85
+        return Arr::where($all_relation_fields, function($value, $key) {
86 86
             return isset($value['pivot']) && $value['pivot'];
87 87
         });
88 88
     }
@@ -139,7 +139,7 @@  discard block
 block discarded – undo
139 139
                             $field_data = json_decode($data[$field['name']], true);
140 140
 
141 141
                             //we grab from the request the specific data for this pivot
142
-                            $pivot_data = Arr::first(Arr::where($field_data, function ($item) use ($pivot_id, $field) {
142
+                            $pivot_data = Arr::first(Arr::where($field_data, function($item) use ($pivot_id, $field) {
143 143
                                 return $item[$field['name']] === $pivot_id;
144 144
                             }));
145 145
 
@@ -183,11 +183,11 @@  discard block
 block discarded – undo
183 183
      */
184 184
     private function createRelationsForItem($item, $formattedData)
185 185
     {
186
-        if (! isset($formattedData['relations'])) {
186
+        if (!isset($formattedData['relations'])) {
187 187
             return false;
188 188
         }
189 189
         foreach ($formattedData['relations'] as $relationMethod => $relationData) {
190
-            if (! isset($relationData['model'])) {
190
+            if (!isset($relationData['model'])) {
191 191
                 continue;
192 192
             }
193 193
             $model = $relationData['model'];
@@ -241,13 +241,13 @@  discard block
 block discarded – undo
241 241
         foreach ($relation_fields as $relation_field) {
242 242
             $attributeKey = $this->parseRelationFieldNamesFromHtml([$relation_field])[0]['name'];
243 243
 
244
-            if (! is_null(Arr::get($data, $attributeKey)) && $relation_field['pivot'] !== true) {
244
+            if (!is_null(Arr::get($data, $attributeKey)) && $relation_field['pivot'] !== true) {
245 245
                 $key = implode('.relations.', explode('.', $this->getOnlyRelationEntity($relation_field)));
246 246
                 $fieldData = Arr::get($relationData, 'relations.'.$key, []);
247
-                if (! array_key_exists('model', $fieldData)) {
247
+                if (!array_key_exists('model', $fieldData)) {
248 248
                     $fieldData['model'] = $relation_field['model'];
249 249
                 }
250
-                if (! array_key_exists('parent', $fieldData)) {
250
+                if (!array_key_exists('parent', $fieldData)) {
251 251
                     $fieldData['parent'] = $this->getRelationModel($attributeKey, -1);
252 252
                 }
253 253
                 $relatedAttribute = Arr::last(explode('.', $attributeKey));
@@ -268,7 +268,7 @@  discard block
 block discarded – undo
268 268
 
269 269
         $related_method = Arr::last($entity_array);
270 270
 
271
-        if (! method_exists($relation_model, $related_method)) {
271
+        if (!method_exists($relation_model, $related_method)) {
272 272
             if (count($entity_array) <= 1) {
273 273
                 return $relation_field['entity'];
274 274
             } else {
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Update.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -52,7 +52,7 @@  discard block
 block discarded – undo
52 52
 
53 53
         foreach ($fields as &$field) {
54 54
             // set the value
55
-            if (! isset($field['value'])) {
55
+            if (!isset($field['value'])) {
56 56
                 if (isset($field['subfields'])) {
57 57
                     $field['value'] = [];
58 58
                     foreach ($field['subfields'] as $subfield) {
@@ -65,7 +65,7 @@  discard block
 block discarded – undo
65 65
         }
66 66
 
67 67
         // always have a hidden input for the entry id
68
-        if (! array_key_exists('id', $fields)) {
68
+        if (!array_key_exists('id', $fields)) {
69 69
             $fields['id'] = [
70 70
                 'name'  => $entry->getKeyName(),
71 71
                 'value' => $entry->getKey(),
@@ -91,7 +91,7 @@  discard block
 block discarded – undo
91 91
 
92 92
             $relation_array = explode('.', $relational_entity);
93 93
 
94
-            $relatedModel = $relatedModel = array_reduce(array_splice($relation_array, 0, -1), function ($obj, $method) {
94
+            $relatedModel = $relatedModel = array_reduce(array_splice($relation_array, 0, -1), function($obj, $method) {
95 95
                 return $obj->{$method} ? $obj->{$method} : $obj;
96 96
             }, $model);
97 97
 
@@ -104,7 +104,7 @@  discard block
 block discarded – undo
104 104
                 // extra attributes on it. It's a Repeatable Field so its values are sent as json.
105 105
                 if (isset($field['pivot']) && $field['pivot'] && isset($field['fields']) && is_array($field['fields'])) {
106 106
                     //we remove the first field from repeatable because it is our relation.
107
-                    $pivot_fields = Arr::where($field['fields'], function ($item) use ($field) {
107
+                    $pivot_fields = Arr::where($field['fields'], function($item) use ($field) {
108 108
                         return $field['name'] != $item['name'];
109 109
                     });
110 110
 
Please login to merge, or discard this patch.