Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Test Setup Failed
Pull Request — master (#2940)
by Cristian
11:54
created
src/app/Library/CrudPanel/Traits/ColumnsProtectedMethods.php 1 patch
Spacing   +7 added lines, -8 removed lines patch added patch discarded remove patch
@@ -49,7 +49,7 @@  discard block
 block discarded – undo
49 49
             $column = ['name' => $column];
50 50
         }
51 51
 
52
-        if (is_array($column) && ! isset($column['name'])) {
52
+        if (is_array($column) && !isset($column['name'])) {
53 53
             $column['name'] = 'anonymous_column_'.Str::random(5);
54 54
         }
55 55
 
@@ -65,7 +65,7 @@  discard block
 block discarded – undo
65 65
      */
66 66
     protected function makeSureColumnHasLabel($column)
67 67
     {
68
-        if (! isset($column['label'])) {
68
+        if (!isset($column['label'])) {
69 69
             $column['label'] = mb_ucfirst($this->makeLabel($column['name']));
70 70
         }
71 71
 
@@ -146,7 +146,7 @@  discard block
 block discarded – undo
146 146
      */
147 147
     protected function makeSureColumnHasKey($column)
148 148
     {
149
-        if (! isset($column['key'])) {
149
+        if (!isset($column['key'])) {
150 150
             $column['key'] = str_replace('.', '__', $column['name']);
151 151
         }
152 152
 
@@ -164,7 +164,7 @@  discard block
 block discarded – undo
164 164
      */
165 165
     protected function makeSureColumnHasWrapper($column)
166 166
     {
167
-        if (! isset($column['wrapper'])) {
167
+        if (!isset($column['wrapper'])) {
168 168
             $column['wrapper'] = [];
169 169
         }
170 170
 
@@ -255,7 +255,7 @@  discard block
 block discarded – undo
255 255
     {
256 256
         // if this is a relation type field and no corresponding model was specified,
257 257
         // get it from the relation method defined in the main model
258
-        if (isset($column['entity']) && $column['entity'] !== false && ! isset($column['model'])) {
258
+        if (isset($column['entity']) && $column['entity'] !== false && !isset($column['model'])) {
259 259
             $column['model'] = $this->getRelationModel($column['entity']);
260 260
         }
261 261
 
@@ -276,8 +276,7 @@  discard block
 block discarded – undo
276 276
         $columnsArray = $this->columns();
277 277
 
278 278
         if (array_key_exists($targetColumnName, $columnsArray)) {
279
-            $targetColumnPosition = $before ? array_search($targetColumnName, array_keys($columnsArray)) :
280
-                array_search($targetColumnName, array_keys($columnsArray)) + 1;
279
+            $targetColumnPosition = $before ? array_search($targetColumnName, array_keys($columnsArray)) : array_search($targetColumnName, array_keys($columnsArray)) + 1;
281 280
 
282 281
             $element = array_pop($columnsArray);
283 282
             $beginningPart = array_slice($columnsArray, 0, $targetColumnPosition, true);
@@ -299,7 +298,7 @@  discard block
 block discarded – undo
299 298
     {
300 299
         static $cache = [];
301 300
 
302
-        if (! $this->driverIsSql()) {
301
+        if (!$this->driverIsSql()) {
303 302
             return true;
304 303
         }
305 304
 
Please login to merge, or discard this patch.
src/app/Http/Controllers/Operations/ShowOperation.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -30,25 +30,25 @@
 block discarded – undo
30 30
         $this->crud->allowAccess('show');
31 31
         $this->crud->setOperationSetting('setFromDb', true);
32 32
 
33
-        $this->crud->operation('show', function () {
33
+        $this->crud->operation('show', function() {
34 34
             $this->crud->loadDefaultOperationSettingsFromConfig();
35 35
 
36
-            if (! method_exists($this, 'setupShowOperation')) {
36
+            if (!method_exists($this, 'setupShowOperation')) {
37 37
                 $this->autoSetupShowOperation();
38 38
             }
39 39
         });
40 40
 
41
-        $this->crud->operation('list', function () {
41
+        $this->crud->operation('list', function() {
42 42
             $this->crud->addButton('line', 'show', 'view', 'crud::buttons.show', 'beginning');
43 43
         });
44 44
 
45
-        $this->crud->operation(['create', 'update'], function () {
45
+        $this->crud->operation(['create', 'update'], function() {
46 46
             $this->crud->addSaveAction([
47 47
                 'name' => 'save_and_preview',
48
-                'visible' => function ($crud) {
48
+                'visible' => function($crud) {
49 49
                     return $crud->hasAccess('show');
50 50
                 },
51
-                'redirect' => function ($crud, $request, $itemId = null) {
51
+                'redirect' => function($crud, $request, $itemId = null) {
52 52
                     $itemId = $itemId ?: $request->input('id');
53 53
                     $redirectUrl = $crud->route.'/'.$itemId.'/show';
54 54
                     if ($request->has('_locale')) {
Please login to merge, or discard this patch.
src/app/Models/Traits/HasRelationshipFields.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -67,7 +67,7 @@  discard block
 block discarded – undo
67 67
         [$conn, $table] = self::getConnectionAndTable();
68 68
 
69 69
         // MongoDB columns are alway nullable
70
-        if (! in_array($conn->getConfig()['driver'], CRUD::getSqlDriverList())) {
70
+        if (!in_array($conn->getConfig()['driver'], CRUD::getSqlDriverList())) {
71 71
             return true;
72 72
         }
73 73
 
@@ -77,7 +77,7 @@  discard block
 block discarded – undo
77 77
             // check for NOT NULL
78 78
             $notNull = $column->getNotnull();
79 79
             // return the value of nullable (aka the inverse of NOT NULL)
80
-            return ! $notNull;
80
+            return !$notNull;
81 81
         } catch (\Exception $e) {
82 82
             return true;
83 83
         }
@@ -94,7 +94,7 @@  discard block
 block discarded – undo
94 94
         [$conn, $table] = self::getConnectionAndTable();
95 95
 
96 96
         // MongoDB columns don't have default values
97
-        if (! in_array($conn->getConfig()['driver'], CRUD::getSqlDriverList())) {
97
+        if (!in_array($conn->getConfig()['driver'], CRUD::getSqlDriverList())) {
98 98
             return false;
99 99
         }
100 100
 
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Validation.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -29,10 +29,10 @@  discard block
 block discarded – undo
29 29
         // construct the validation rules array
30 30
         // (eg. ['name' => 'required|min:2'])
31 31
         $rules = collect($fields)
32
-                    ->filter(function ($value, $key) {
32
+                    ->filter(function($value, $key) {
33 33
                         // only keep fields where 'validationRules' attribute is defined
34 34
                         return array_key_exists('validationRules', $value);
35
-                    })->map(function ($item, $key) {
35
+                    })->map(function($item, $key) {
36 36
                         // only keep the rules, not the entire field definition
37 37
                         return $item['validationRules'];
38 38
                     })->toArray();
@@ -41,10 +41,10 @@  discard block
 block discarded – undo
41 41
         // (eg. ['title.required' => 'You gotta write smth man.'])
42 42
         $messages = [];
43 43
         collect($fields)
44
-                    ->filter(function ($value, $key) {
44
+                    ->filter(function($value, $key) {
45 45
                         // only keep fields where 'validationMessages' attribute is defined
46 46
                         return array_key_exists('validationMessages', $value);
47
-                    })->each(function ($item, $key) use (&$messages) {
47
+                    })->each(function($item, $key) use (&$messages) {
48 48
                         foreach ($item['validationMessages'] as $rule => $message) {
49 49
                             $messages[$key.'.'.$rule] = $message;
50 50
                         }
@@ -74,7 +74,7 @@  discard block
 block discarded – undo
74 74
      */
75 75
     public function setValidation($classOrRulesArray = false, $messages = [])
76 76
     {
77
-        if (! $classOrRulesArray) {
77
+        if (!$classOrRulesArray) {
78 78
             $this->setValidationFromFields();
79 79
         } elseif (is_array($classOrRulesArray)) {
80 80
             $this->setValidationFromArray($classOrRulesArray, $messages);
@@ -202,7 +202,7 @@  discard block
 block discarded – undo
202 202
      */
203 203
     public function isRequired($inputKey)
204 204
     {
205
-        if (! $this->hasOperationSetting('requiredFields')) {
205
+        if (!$this->hasOperationSetting('requiredFields')) {
206 206
             return false;
207 207
         }
208 208
 
Please login to merge, or discard this patch.
src/resources/views/crud/fields/table.blade.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -3,7 +3,7 @@  discard block
 block discarded – undo
3 3
 <?php
4 4
     $max = isset($field['max']) && (int) $field['max'] > 0 ? $field['max'] : -1;
5 5
     $min = isset($field['min']) && (int) $field['min'] > 0 ? $field['min'] : -1;
6
-    $item_name = strtolower(isset($field['entity_singular']) && ! empty($field['entity_singular']) ? $field['entity_singular'] : $field['label']);
6
+    $item_name = strtolower(isset($field['entity_singular']) && !empty($field['entity_singular']) ? $field['entity_singular'] : $field['label']);
7 7
 
8 8
     $items = old_empty_or_null($field['name'], '') ?? $field['value'] ?? $field['default'] ?? '';
9 9
 
@@ -15,12 +15,12 @@  discard block
 block discarded – undo
15 15
         } else {
16 16
             $items = '[]';
17 17
         }
18
-    } elseif (is_string($items) && ! is_array(json_decode($items))) {
18
+    } elseif (is_string($items) && !is_array(json_decode($items))) {
19 19
         $items = '[]';
20 20
     }
21 21
 
22 22
     // make sure columns are defined
23
-    if (! isset($field['columns'])) {
23
+    if (!isset($field['columns'])) {
24 24
         $field['columns'] = ['value' => 'Value'];
25 25
     }
26 26
 
Please login to merge, or discard this patch.
src/resources/views/crud/fields/date_range.blade.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -3,11 +3,11 @@  discard block
 block discarded – undo
3 3
 <?php
4 4
     // if the column has been cast to Carbon or Date (using attribute casting)
5 5
     // get the value as a date string
6
-    if (! function_exists('formatDate')) {
6
+    if (!function_exists('formatDate')) {
7 7
         function formatDate($entry, $dateFieldName)
8 8
         {
9 9
             $formattedDate = null;
10
-            if (isset($entry) && ! empty($entry->{$dateFieldName})) {
10
+            if (isset($entry) && !empty($entry->{$dateFieldName})) {
11 11
                 $dateField = $entry->{$dateFieldName};
12 12
                 if ($dateField instanceof \Carbon\CarbonInterface) {
13 13
                     $formattedDate = $dateField->format('Y-m-d H:i:s');
@@ -21,7 +21,7 @@  discard block
 block discarded – undo
21 21
     }
22 22
 
23 23
     if (isset($field['value'])) {
24
-        if (isset($entry) && ! is_array($field['value'])) {
24
+        if (isset($entry) && !is_array($field['value'])) {
25 25
             $start_value = formatDate($entry, $field['name'][0]);
26 26
             $end_value = formatDate($entry, $field['name'][1]);
27 27
         } elseif (is_array($field['value'])) { // gets here when inside repeatable
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Search.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -21,9 +21,9 @@  discard block
 block discarded – undo
21 21
      */
22 22
     public function applySearchTerm($searchTerm)
23 23
     {
24
-        return $this->query->where(function ($query) use ($searchTerm) {
24
+        return $this->query->where(function($query) use ($searchTerm) {
25 25
             foreach ($this->columns() as $column) {
26
-                if (! isset($column['type'])) {
26
+                if (!isset($column['type'])) {
27 27
                     abort(400, 'Missing column type when trying to apply search term.');
28 28
                 }
29 29
 
@@ -81,7 +81,7 @@  discard block
 block discarded – undo
81 81
 
82 82
                 case 'select':
83 83
                 case 'select_multiple':
84
-                    $query->orWhereHas($column['entity'], function ($q) use ($column, $searchTerm) {
84
+                    $query->orWhereHas($column['entity'], function($q) use ($column, $searchTerm) {
85 85
                         $q->where($this->getColumnWithTableNamePrefixed($q, $column['attribute']), 'like', '%'.$searchTerm.'%');
86 86
                     });
87 87
                     break;
@@ -270,13 +270,13 @@  discard block
 block discarded – undo
270 270
         if (isset($column['type'])) {
271 271
             // create a list of paths to column blade views
272 272
             // including the configured view_namespaces
273
-            $columnPaths = array_map(function ($item) use ($column) {
273
+            $columnPaths = array_map(function($item) use ($column) {
274 274
                 return $item.'.'.$column['type'];
275 275
             }, config('backpack.crud.view_namespaces.columns'));
276 276
 
277 277
             // but always fall back to the stock 'text' column
278 278
             // if a view doesn't exist
279
-            if (! in_array('crud::columns.text', $columnPaths)) {
279
+            if (!in_array('crud::columns.text', $columnPaths)) {
280 280
                 $columnPaths[] = 'crud::columns.text';
281 281
             }
282 282
 
@@ -303,7 +303,7 @@  discard block
 block discarded – undo
303 303
      */
304 304
     private function renderCellView($view, $column, $entry, $rowNumber = false)
305 305
     {
306
-        if (! view()->exists($view)) {
306
+        if (!view()->exists($view)) {
307 307
             $view = 'crud::columns.text'; // fallback to text column
308 308
         }
309 309
 
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Update.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -56,7 +56,7 @@  discard block
 block discarded – undo
56 56
         }
57 57
 
58 58
         // always have a hidden input for the entry id
59
-        if (! array_key_exists('id', $fields)) {
59
+        if (!array_key_exists('id', $fields)) {
60 60
             $fields['id'] = [
61 61
                 'name'  => $entry->getKeyName(),
62 62
                 'value' => $entry->getKey(),
@@ -98,7 +98,7 @@  discard block
 block discarded – undo
98 98
     {
99 99
         [$related_model, $relation_method] = $this->getModelAndMethodFromEntity($model, $field);
100 100
 
101
-        if (! method_exists($related_model, $relation_method)) {
101
+        if (!method_exists($related_model, $relation_method)) {
102 102
             return $related_model->{$relation_method};
103 103
         }
104 104
 
@@ -110,11 +110,11 @@  discard block
 block discarded – undo
110 110
             case 'BelongsToMany':
111 111
             case 'MorphToMany':
112 112
                 // use subfields aka. pivotFields
113
-                if (! isset($field['subfields'])) {
113
+                if (!isset($field['subfields'])) {
114 114
                     return $related_model->{$relation_method};
115 115
                 }
116 116
                 // we want to exclude the "self pivot field" since we already have it.
117
-                $pivot_fields = Arr::where($field['subfields'], function ($item) use ($field) {
117
+                $pivot_fields = Arr::where($field['subfields'], function($item) use ($field) {
118 118
                     return $field['name'] != $item['name'];
119 119
                 });
120 120
 
@@ -144,13 +144,13 @@  discard block
 block discarded – undo
144 144
                 break;
145 145
             case 'HasOne':
146 146
             case 'MorphOne':
147
-                if (! method_exists($related_model, $relation_method)) {
147
+                if (!method_exists($related_model, $relation_method)) {
148 148
                     return;
149 149
                 }
150 150
 
151 151
                 $related_entry = $related_model->{$relation_method};
152 152
 
153
-                if (! $related_entry) {
153
+                if (!$related_entry) {
154 154
                     return;
155 155
                 }
156 156
 
@@ -183,7 +183,7 @@  discard block
 block discarded – undo
183 183
 
184 184
         $relation_array = explode('.', $relational_entity);
185 185
 
186
-        $related_model = array_reduce(array_splice($relation_array, 0, -1), function ($obj, $method) {
186
+        $related_model = array_reduce(array_splice($relation_array, 0, -1), function($obj, $method) {
187 187
             $method = Str::endsWith($method, '_id') ? Str::replaceLast('_id', '', $method) : $method;
188 188
 
189 189
             return $obj->{$method} ? $obj->{$method} : $obj;
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/CrudButton.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -274,7 +274,7 @@  discard block
 block discarded – undo
274 274
     {
275 275
         $type = $this->name;
276 276
 
277
-        $paths = array_map(function ($item) use ($type) {
277
+        $paths = array_map(function($item) use ($type) {
278 278
             return $item.'.'.$type;
279 279
         }, config('backpack.crud.view_namespaces.buttons'));
280 280
 
@@ -440,7 +440,7 @@  discard block
 block discarded – undo
440 440
     {
441 441
         $itemExists = $this->collection()->contains('name', $this->name);
442 442
 
443
-        if (! $itemExists) {
443
+        if (!$itemExists) {
444 444
             if ($this->position == 'beginning') {
445 445
                 $this->collection()->prepend($this);
446 446
             } else {
Please login to merge, or discard this patch.