AdminController::notFound() - Code Metrics - Inspection of "Added Backpack fallback route" - Laravel-Backpack/CRUD - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Pull Request — master (#3447)

unknown

created 2021-01-06 21:02 UTC

AdminController::notFound() A

↳ Parent: AdminController

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	1
nc	1
nop	0
dl	0
loc	3
rs	10
c	0
b	0
f	0

<?php

namespace Backpack\CRUD\app\Http\Controllers;

use Illuminate\Routing\Controller;

class AdminController extends Controller
{
    protected $data = []; // the information we send to the view

    /**
     * Create a new controller instance.
     */
    public function __construct()
    {
        $this->middleware(backpack_middleware());
    }

    /**
     * Show the admin dashboard.
     *
     * @return \Illuminate\Http\Response
     */
    public function dashboard()
    {
        $this->data['title'] = trans('backpack::base.dashboard'); // set the page title
        $this->data['breadcrumbs'] = [
            trans('backpack::crud.admin')     => backpack_url('dashboard'),
            trans('backpack::base.dashboard') => false,
        ];

        return view(backpack_view('dashboard'), $this->data);

    }

    /**
     * Redirect to the dashboard.
     *
     * @return \Illuminate\Routing\Redirector|\Illuminate\Http\RedirectResponse
     */
    public function redirect()
    {
        // The '/admin' route is not to be used as a page, because it breaks the menu's active state.
        return redirect(backpack_url('dashboard'));
    }

    /**
     * Show the 404 error page.
     *
     * @return \Illuminate\Http\Response
     */
    public function notFound()
    {
        return view('errors.404');

    }
}


1			<?php
2
3			namespace Backpack\CRUD\app\Http\Controllers;
4
5			use Illuminate\Routing\Controller;
6
7			class AdminController extends Controller
8			{
9			protected $data = []; // the information we send to the view
10
11			/**
12			* Create a new controller instance.
13			*/
14			public function __construct()
15			{
16			$this->middleware(backpack_middleware());
17			}
18
19			/**
20			* Show the admin dashboard.
21			*
22			* @return \Illuminate\Http\Response
23			*/
24			public function dashboard()
25			{
26			$this->data['title'] = trans('backpack::base.dashboard'); // set the page title
27			$this->data['breadcrumbs'] = [
28			trans('backpack::crud.admin') => backpack_url('dashboard'),
29			trans('backpack::base.dashboard') => false,
30			];
31
32			return view(backpack_view('dashboard'), $this->data);
			0 ignored issues – show Bug Best Practice introduced 2020-03-16 09:46 UTC by Report Bug Copy Issue Report The expression `return view(backpack_vie...shboard'), $this->data)` returns the type `Illuminate\View\View` which is incompatible with the documented return type `Illuminate\Http\Response`. Loading history...
33			}
34
35			/**
36			* Redirect to the dashboard.
37			*
38			* @return \Illuminate\Routing\Redirector\|\Illuminate\Http\RedirectResponse
39			*/
40			public function redirect()
41			{
42			// The '/admin' route is not to be used as a page, because it breaks the menu's active state.
43			return redirect(backpack_url('dashboard'));
44			}
45
46			/**
47			* Show the 404 error page.
48			*
49			* @return \Illuminate\Http\Response
50			*/
51			public function notFound()
52			{
53			return view('errors.404');
			0 ignored issues – show Bug Best Practice introduced 2021-01-06 21:14 UTC by Report Bug Copy Issue Report The expression `return view('errors.404')` returns the type `Illuminate\View\View` which is incompatible with the documented return type `Illuminate\Http\Response`. Loading history...
54			}
55			}
56

Laravel-Backpack / CRUD

Scrutinizer GitHub App not installed

Pull Request — master (#3447)

AdminController::notFound() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like