Laravel-Backpack /
CRUD
We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.
| Total Complexity | 65 |
| Total Lines | 374 |
| Duplicated Lines | 0 % |
| Changes | 6 | ||
| Bugs | 1 | Features | 1 |
Complex classes like FieldsProtectedMethods often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use FieldsProtectedMethods, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 8 | trait FieldsProtectedMethods |
||
| 9 | { |
||
| 10 | /** |
||
| 11 | * If field has entity we want to get the relation type from it. |
||
| 12 | * |
||
| 13 | * @param array $field |
||
| 14 | * @return array |
||
| 15 | */ |
||
| 16 | public function makeSureFieldHasRelationType($field) |
||
| 17 | { |
||
| 18 | $field['relation_type'] = $field['relation_type'] ?? $this->inferRelationTypeFromRelationship($field); |
||
|
Bug
introduced
by
|
|||
| 19 | |||
| 20 | return $field; |
||
| 21 | } |
||
| 22 | |||
| 23 | /** |
||
| 24 | * If field has entity we want to make sure it also has a model for that relation. |
||
| 25 | * |
||
| 26 | * @param array $field |
||
| 27 | * @return array |
||
| 28 | */ |
||
| 29 | public function makeSureFieldHasModel($field) |
||
| 34 | } |
||
| 35 | |||
| 36 | /** |
||
| 37 | * Based on relation type we can guess if pivot is set. |
||
| 38 | * |
||
| 39 | * @param array $field |
||
| 40 | * @return array |
||
| 41 | */ |
||
| 42 | public function makeSureFieldHasPivot($field) |
||
| 43 | { |
||
| 44 | $field['pivot'] = $field['pivot'] ?? $this->guessIfFieldHasPivotFromRelationType($field['relation_type']); |
||
| 45 | |||
| 46 | return $field; |
||
| 47 | } |
||
| 48 | |||
| 49 | /** |
||
| 50 | * Based on relation type we can try to guess if it is a multiple field. |
||
| 51 | * |
||
| 52 | * @param array $field |
||
| 53 | * @return array |
||
| 54 | */ |
||
| 55 | public function makeSureFieldHasMultiple($field) |
||
| 62 | } |
||
| 63 | |||
| 64 | /** |
||
| 65 | * In case field name is dot notation we want to convert it to a valid HTML array field name for validation purposes. |
||
| 66 | * |
||
| 67 | * @param array $field |
||
| 68 | * @return array |
||
| 69 | */ |
||
| 70 | public function overwriteFieldNameFromDotNotationToArray($field) |
||
| 71 | { |
||
| 72 | if (strpos($field['name'], '.') !== false) { |
||
| 73 | $entity_array = explode('.', $field['name']); |
||
| 74 | $name_string = ''; |
||
| 75 | |||
| 76 | foreach ($entity_array as $key => $array_entity) { |
||
| 77 | $name_string .= ($key == 0) ? $array_entity : '['.$array_entity.']'; |
||
| 78 | } |
||
| 79 | |||
| 80 | $field['name'] = $name_string; |
||
| 81 | } |
||
| 82 | |||
| 83 | return $field; |
||
| 84 | } |
||
| 85 | |||
| 86 | /** |
||
| 87 | * Run the field name overwrite in multiple fields. |
||
| 88 | * |
||
| 89 | * @param array $fields |
||
| 90 | * @return array |
||
| 91 | */ |
||
| 92 | public function overwriteFieldNamesFromDotNotationToArray($fields) |
||
| 99 | } |
||
| 100 | |||
| 101 | /** |
||
| 102 | * If the field_definition_array array is a string, it means the programmer was lazy |
||
| 103 | * and has only passed the name of the field. Turn that into a proper array. |
||
| 104 | * |
||
| 105 | * @param string|array $field The field definition array (or string). |
||
| 106 | * @return array |
||
| 107 | */ |
||
| 108 | protected function makeSureFieldHasName($field) |
||
| 109 | { |
||
| 110 | if (empty($field)) { |
||
| 111 | abort(500, 'Field name can\'t be empty'); |
||
| 112 | } |
||
| 113 | |||
| 114 | if (is_string($field)) { |
||
| 115 | return ['name' => Str::replace(' ', '', $field)]; |
||
| 116 | } |
||
| 117 | |||
| 118 | if (is_array($field) && ! isset($field['name'])) { |
||
| 119 | abort(500, 'All fields must have their name defined'); |
||
| 120 | } |
||
| 121 | |||
| 122 | $field['name'] = Str::replace(' ', '', $field['name']); |
||
| 123 | |||
| 124 | return $field; |
||
| 125 | } |
||
| 126 | |||
| 127 | /** |
||
| 128 | * If entity is not present, but it looks like the field SHOULD be a relationship field, |
||
| 129 | * try to determine the method on the model that defines the relationship, and pass it to |
||
| 130 | * the field as 'entity'. |
||
| 131 | * |
||
| 132 | * @param array $field |
||
| 133 | * @return array |
||
| 134 | */ |
||
| 135 | protected function makeSureFieldHasEntity($field) |
||
| 136 | { |
||
| 137 | $model = isset($field['baseModel']) ? (new $field['baseModel']) : $this->model; |
||
| 138 | |||
| 139 | if (isset($field['entity'])) { |
||
| 140 | return $field; |
||
| 141 | } |
||
| 142 | |||
| 143 | // by default, entity is false if we cannot link it with guessing functions to a relation |
||
| 144 | $field['entity'] = false; |
||
| 145 | |||
| 146 | //if the name is dot notation we are sure it's a relationship |
||
| 147 | if (strpos($field['name'], '.') !== false) { |
||
| 148 | $possibleMethodName = Str::of($field['name'])->before('.'); |
||
| 149 | // check model method for possibility of being a relationship |
||
| 150 | $field['entity'] = $this->modelMethodIsRelationship($model, $possibleMethodName) ? $field['name'] : false; |
||
| 151 | |||
| 152 | return $field; |
||
| 153 | } |
||
| 154 | |||
| 155 | // if there's a method on the model with this name |
||
| 156 | if (method_exists($model, $field['name'])) { |
||
| 157 | // check model method for possibility of being a relationship |
||
| 158 | $field['entity'] = $this->modelMethodIsRelationship($model, $field['name']); |
||
| 159 | |||
| 160 | return $field; |
||
| 161 | } |
||
| 162 | |||
| 163 | // if the name ends with _id and that method exists, |
||
| 164 | // we can probably use it as an entity |
||
| 165 | if (Str::endsWith($field['name'], '_id')) { |
||
| 166 | $possibleMethodName = Str::replaceLast('_id', '', $field['name']); |
||
| 167 | |||
| 168 | if (method_exists($model, $possibleMethodName)) { |
||
| 169 | // check model method for possibility of being a relationship |
||
| 170 | $field['entity'] = $this->modelMethodIsRelationship($model, $possibleMethodName); |
||
| 171 | |||
| 172 | return $field; |
||
| 173 | } |
||
| 174 | } |
||
| 175 | |||
| 176 | return $field; |
||
| 177 | } |
||
| 178 | |||
| 179 | protected function makeSureFieldHasAttribute($field) |
||
| 197 | } |
||
| 198 | |||
| 199 | /** |
||
| 200 | * Set the label of a field, if it's missing, by capitalizing the name and replacing |
||
| 201 | * underscores with spaces. |
||
| 202 | * |
||
| 203 | * @param array $field Field definition array. |
||
| 204 | * @return array Field definition array that contains label too. |
||
| 205 | */ |
||
| 206 | protected function makeSureFieldHasLabel($field) |
||
| 215 | } |
||
| 216 | |||
| 217 | /** |
||
| 218 | * Set the type of a field, if it's missing, by inferring it from the |
||
| 219 | * db column type. |
||
| 220 | * |
||
| 221 | * @param array $field Field definition array. |
||
| 222 | * @return array Field definition array that contains type too. |
||
| 223 | */ |
||
| 224 | protected function makeSureFieldHasType($field) |
||
| 231 | } |
||
| 232 | |||
| 233 | protected function inferFieldTypeFromRelationType($relationType) |
||
| 247 | } |
||
| 248 | } |
||
| 249 | |||
| 250 | /** |
||
| 251 | * If a field has subfields, go through each subfield and guess |
||
| 252 | * its attribute, filling in whatever is missing. |
||
| 253 | * |
||
| 254 | * @param array $field Field definition array. |
||
| 255 | * @return array The improved definition of that field (a better 'subfields' array) |
||
| 256 | */ |
||
| 257 | protected function makeSureSubfieldsHaveNecessaryAttributes($field) |
||
| 258 | { |
||
| 259 | if (! isset($field['subfields']) || ! is_array($field['subfields'])) { |
||
| 260 | return $field; |
||
| 261 | } |
||
| 262 | |||
| 263 | if (! is_multidimensional_array($field['subfields'], true)) { |
||
| 264 | abort(500, 'Subfields of «'.$field['name'].'» are malformed. Make sure you provide an array of subfields.'); |
||
| 265 | } |
||
| 266 | |||
| 267 | foreach ($field['subfields'] as $key => $subfield) { |
||
| 268 | if (empty($subfield) || ! isset($subfield['name'])) { |
||
| 269 | abort(500, 'A subfield of «'.$field['name'].'» is malformed. Subfield attribute name can\'t be empty.'); |
||
| 270 | } |
||
| 271 | |||
| 272 | // make sure the field definition is an array |
||
| 273 | if (is_string($subfield)) { |
||
| 274 | $subfield = ['name' => $subfield]; |
||
| 275 | } |
||
| 276 | |||
| 277 | $subfield['name'] = Str::replace(' ', '', $subfield['name']); |
||
| 278 | |||
| 279 | $subfield['parentFieldName'] = $field['name']; |
||
| 280 | |||
| 281 | if (! isset($field['model'])) { |
||
| 282 | // we're inside a simple 'repeatable' with no model/relationship, so |
||
| 283 | // we assume all subfields are supposed to be text fields |
||
| 284 | $subfield['type'] = $subfield['type'] ?? 'text'; |
||
| 285 | $subfield['entity'] = $subfield['entity'] ?? false; |
||
| 286 | } else { |
||
| 287 | // we should use 'model' as the `baseModel` for all subfields, so that when |
||
| 288 | // we look if `category()` relationship exists on the model, we look on |
||
| 289 | // the model this repeatable represents, not the main CRUD model |
||
| 290 | $currentEntity = $subfield['baseEntity'] ?? $field['entity']; |
||
| 291 | $subfield['baseModel'] = $subfield['baseModel'] ?? $field['model']; |
||
| 292 | $subfield['baseEntity'] = isset($field['baseEntity']) ? $field['baseEntity'].'.'.$currentEntity : $currentEntity; |
||
| 293 | $subfield['baseFieldName'] = is_array($subfield['name']) ? implode(',', $subfield['name']) : $subfield['name']; |
||
| 294 | $subfield['baseFieldName'] = Str::afterLast($subfield['baseFieldName'], '.'); |
||
| 295 | } |
||
| 296 | |||
| 297 | $field['subfields'][$key] = $this->makeSureFieldHasNecessaryAttributes($subfield); |
||
| 298 | } |
||
| 299 | |||
| 300 | // when field has any of `many` relations we need to append either the pivot selector for the `ToMany` or the |
||
| 301 | // local key for the `many` relations. Other relations don't need any special treatment when used as subfields. |
||
| 302 | if (isset($field['relation_type'])) { |
||
| 303 | switch ($field['relation_type']) { |
||
| 304 | case 'MorphToMany': |
||
| 305 | case 'BelongsToMany': |
||
| 306 | $pivotSelectorField = static::getPivotFieldStructure($field); |
||
| 307 | |||
| 308 | $pivot = Arr::where($field['subfields'], function ($item) use ($pivotSelectorField) { |
||
| 309 | return $item['name'] === $pivotSelectorField['name']; |
||
| 310 | }); |
||
| 311 | |||
| 312 | if (! empty($pivot)) { |
||
| 313 | break; |
||
| 314 | } |
||
| 315 | |||
| 316 | $this->setupFieldValidation($pivotSelectorField, $field['name']); |
||
| 317 | $field['subfields'] = Arr::prepend($field['subfields'], $pivotSelectorField); |
||
| 318 | |||
| 319 | break; |
||
| 320 | case 'MorphMany': |
||
| 321 | case 'HasMany': |
||
| 322 | $entity = isset($field['baseEntity']) ? $field['baseEntity'].'.'.$field['entity'] : $field['entity']; |
||
| 323 | $relationInstance = $this->getRelationInstance(['entity' => $entity]); |
||
| 324 | |||
| 325 | $localKeyField = Arr::where($field['subfields'], function ($item) use ($relationInstance) { |
||
| 326 | return $item['name'] === $relationInstance->getRelated()->getKeyName(); |
||
| 327 | }); |
||
| 328 | |||
| 329 | if (! empty($localKeyField)) { |
||
| 330 | break; |
||
| 331 | } |
||
| 332 | |||
| 333 | $field['subfields'] = Arr::prepend($field['subfields'], [ |
||
| 334 | 'name' => $relationInstance->getRelated()->getKeyName(), |
||
| 335 | 'type' => 'hidden', |
||
| 336 | ]); |
||
| 337 | break; |
||
| 338 | } |
||
| 339 | } |
||
| 340 | |||
| 341 | return $field; |
||
| 342 | } |
||
| 343 | |||
| 344 | /** |
||
| 345 | * Enable the tabs functionality, if a field has a tab defined. |
||
| 346 | * |
||
| 347 | * @param array $field Field definition array. |
||
| 348 | * @return void |
||
| 349 | */ |
||
| 350 | protected function enableTabsIfFieldUsesThem($field) |
||
| 351 | { |
||
| 352 | // if a tab was mentioned, we should enable it |
||
| 353 | if (isset($field['tab'])) { |
||
| 354 | if (! $this->tabsEnabled()) { |
||
| 355 | $this->enableTabs(); |
||
| 356 | } |
||
| 357 | } |
||
| 358 | } |
||
| 359 | |||
| 360 | /** |
||
| 361 | * Add a field to the current operation, using the Settings API. |
||
| 362 | * |
||
| 363 | * @param array $field Field definition array. |
||
| 364 | */ |
||
| 365 | protected function addFieldToOperationSettings($field) |
||
| 366 | { |
||
| 367 | $allFields = $this->getOperationSetting('fields'); |
||
| 368 | $allFields = array_merge($this->getCleanStateFields(), [$field['name'] => $field]); |
||
| 369 | |||
| 370 | $this->setOperationSetting('fields', $allFields); |
||
| 371 | } |
||
| 372 | |||
| 373 | /** |
||
| 374 | * Get the string that should be used as an array key, for the attributive array |
||
| 375 | * where the fields are stored for the current operation. |
||
| 376 | * |
||
| 377 | * @deprecated v6 |
||
| 378 | */ |
||
| 379 | protected function getFieldKey(array $field): string |
||
| 382 | } |
||
| 383 | } |
||
| 384 |
Loading history...
