Laravel-Backpack / CRUD

src/CrudUsageStats.php

Doc Comments +2 added lines, -2 removed lines

@@ -10,7 +10,7 @@ 
      * Check if the application is running in normal conditions
      * (production env, not in console, not in unit tests).
      *
-     * @return void
+     * @return boolean
      */
     private function runningInProduction()
     {
@@ -86,7 +86,7 @@ 
      * @param  string $method  HTTP Method to use for the request.
      * @param  string $url     URL to point the request at.
      * @param  array $payload  The data you want sent to the URL.
-     * @return void
+     * @return boolean
      */
     private function makeCurlRequest($method, $url, $payload)
     {

Spacing +1 added lines, -1 removed lines

@@ -38,7 +38,7 @@
     private function sendUsageStats()
     {
         // only send usage stats in production
-        if (! $this->runningInProduction()) {
+        if (!$this->runningInProduction()) {
             return;
         }
 

src/resources/views/columns/array_count.blade.php

Spacing +1 added lines, -1 removed lines

@@ -2,7 +2,7 @@
 <span>
     <?php
     $array = $entry->{$column['name']};
-    $suffix = isset($column['suffix'])?$column['suffix']:'items';
+    $suffix = isset($column['suffix']) ? $column['suffix'] : 'items';
 
     // the value should be an array wether or not attribute casting is used
     if (!is_array($array)) {

tests/Unit/CrudPanel/CrudPanelTabsTest.php

Unused Use Statements +1 added lines, -1 removed lines

@@ -2,8 +2,8 @@
 
 namespace Backpack\CRUD\Tests\Unit\CrudPanel;
 
-use Illuminate\Support\Facades\DB;
 use Backpack\CRUD\Tests\Unit\Models\Article;
+use Illuminate\Support\Facades\DB;
 
 class CrudPanelTabsTest extends BaseDBCrudPanelTest
 {

src/PanelTraits/Buttons.php

Spacing +4 added lines, -4 removed lines

@@ -107,7 +107,7 @@ 
          */
         $button = $this->buttons()->firstWhere('name', $name);
 
-        if (! $button) {
+        if (!$button) {
             abort(500, 'CRUD Button "'.$name.'" not found. Please check the button exists before you modify it.');
         }
 
@@ -128,7 +128,7 @@ 
      */
     public function removeButton($name, $stack = null)
     {
-        $this->buttons = $this->buttons->reject(function ($button) use ($name, $stack) {
+        $this->buttons = $this->buttons->reject(function($button) use ($name, $stack) {
             return $stack == null ? $button->name == $name : ($button->stack == $stack) && ($button->name == $name);
         });
     }
@@ -140,14 +140,14 @@ 
 
     public function removeAllButtonsFromStack($stack)
     {
-        $this->buttons = $this->buttons->reject(function ($button) use ($stack) {
+        $this->buttons = $this->buttons->reject(function($button) use ($stack) {
             return $button->stack == $stack;
         });
     }
 
     public function removeButtonFromStack($name, $stack)
     {
-        $this->buttons = $this->buttons->reject(function ($button) use ($name, $stack) {
+        $this->buttons = $this->buttons->reject(function($button) use ($name, $stack) {
             return $button->name == $name && $button->stack == $stack;
         });
     }

Doc Comments +13 added lines, -1 removed lines

@@ -62,6 +62,9 @@ 
         $this->addButton($stack, $name, 'model_function', $model_function_name, $position);
     }
 
+    /**
+     * @param string $view
+     */
     public function addButtonFromView($stack, $name, $view, $position = false)
     {
         $view = 'vendor.backpack.crud.buttons.'.$view;
@@ -98,7 +101,7 @@ 
      * @param  string $name          The button name.
      * @param  array  $modifications The attributes and their new values.
      *
-     * @return CrudButton                The button that has suffered the changes, for daisychaining methods.
+     * @return Collection                The button that has suffered the changes, for daisychaining methods.
      */
     public function modifyButton($name, $modifications = null)
     {
@@ -138,6 +141,9 @@ 
         $this->buttons = collect([]);
     }
 
+    /**
+     * @param string $stack
+     */
     public function removeAllButtonsFromStack($stack)
     {
         $this->buttons = $this->buttons->reject(function ($button) use ($stack) {
@@ -160,6 +166,12 @@ 
     public $type = 'view';
     public $content;
 
+    /**
+     * @param string $stack
+     * @param string $name
+     * @param string $type
+     * @param string $content
+     */
     public function __construct($stack, $name, $type, $content)
     {
         $this->stack = $stack;

src/PanelTraits/Tabs.php

Spacing +7 added lines, -7 removed lines

@@ -35,7 +35,7 @@ 
      */
     public function tabsDisabled()
     {
-        return ! $this->tabsEnabled;
+        return !$this->tabsEnabled;
     }
 
     public function setTabsType($type)
@@ -116,8 +116,8 @@ 
     {
         $all_fields = $this->getCurrentFields();
 
-        $fields_without_a_tab = collect($all_fields)->filter(function ($value, $key) {
-            return ! isset($value['tab']);
+        $fields_without_a_tab = collect($all_fields)->filter(function($value, $key) {
+            return !isset($value['tab']);
         });
 
         return $fields_without_a_tab;
@@ -133,7 +133,7 @@ 
         if ($this->tabExists($label)) {
             $all_fields = $this->getCurrentFields();
 
-            $fields_for_current_tab = collect($all_fields)->filter(function ($value, $key) use ($label) {
+            $fields_for_current_tab = collect($all_fields)->filter(function($value, $key) use ($label) {
                 return isset($value['tab']) && $value['tab'] == $label;
             });
 
@@ -152,11 +152,11 @@ 
         $fields = $this->getCurrentFields();
 
         $fields_with_tabs = collect($fields)
-            ->filter(function ($value, $key) {
+            ->filter(function($value, $key) {
                 return isset($value['tab']);
             })
-            ->each(function ($value, $key) use (&$tabs) {
-                if (! in_array($value['tab'], $tabs)) {
+            ->each(function($value, $key) use (&$tabs) {
+                if (!in_array($value['tab'], $tabs)) {
                     $tabs[] = $value['tab'];
                 }
             });

src/resources/views/columns/select_from_array.blade.php

Indentation +18 added lines, -18 removed lines

@@ -1,24 +1,24 @@
 {{-- select_from_array column --}}
 <span>
 	<?php
-		if ($entry->{$column['name']} !== null) {
-			if (is_array($entry->{$column['name']})) {
-				$array_of_values = [];
+        if ($entry->{$column['name']} !== null) {
+            if (is_array($entry->{$column['name']})) {
+                $array_of_values = [];
 
-				foreach ($entry->{$column['name']} as $key => $value) {
-					$array_of_values[] = $column['options'][$value];
-				}
+                foreach ($entry->{$column['name']} as $key => $value) {
+                    $array_of_values[] = $column['options'][$value];
+                }
 
-				if (count($array_of_values) > 1) {
-					echo implode(', ', $array_of_values);
-				} else {
-					echo $array_of_values;
-				}
-			} else {
-				echo $column['options'][$entry->{$column['name']}];
-			}
-	    } else {
-	    	echo "-";
-	    }
-	?>
+                if (count($array_of_values) > 1) {
+                    echo implode(', ', $array_of_values);
+                } else {
+                    echo $array_of_values;
+                }
+            } else {
+                echo $column['options'][$entry->{$column['name']}];
+            }
+        } else {
+            echo "-";
+        }
+    ?>
 </span>

src/CrudPanel.php

Spacing +13 added lines, -13 removed lines

@@ -90,11 +90,11 @@ 
      */
     public function setModel($model_namespace)
     {
-        if (! class_exists($model_namespace)) {
+        if (!class_exists($model_namespace)) {
             throw new \Exception('The model does not exist.', 500);
         }
 
-        if (! method_exists($model_namespace, 'hasCrudTrait')) {
+        if (!method_exists($model_namespace, 'hasCrudTrait')) {
             throw new \Exception('Please use CrudTrait on the model.', 500);
         }
 
@@ -147,7 +147,7 @@ 
     {
         $complete_route = $route.'.index';
 
-        if (! \Route::has($complete_route)) {
+        if (!\Route::has($complete_route)) {
             throw new \Exception('There are no routes for this route name.', 404);
         }
 
@@ -248,7 +248,7 @@ 
      */
     public function getFirstOfItsTypeInArray($type, $array)
     {
-        return array_first($array, function ($item) use ($type) {
+        return array_first($array, function($item) use ($type) {
             return $item['type'] == $type;
         });
     }
@@ -265,8 +265,8 @@ 
 
     public function sync($type, $fields, $attributes)
     {
-        if (! empty($this->{$type})) {
-            $this->{$type} = array_map(function ($field) use ($fields, $attributes) {
+        if (!empty($this->{$type})) {
+            $this->{$type} = array_map(function($field) use ($fields, $attributes) {
                 if (in_array($field['name'], (array) $fields)) {
                     $field = array_merge($field, $attributes);
                 }
@@ -298,8 +298,8 @@ 
                 }
             }
 
-            return $this->{$items} = array_merge($elements, array_filter($this->{$items}, function ($item) use ($items) {
-                return ! in_array($item['name'], $this->sort[$items]);
+            return $this->{$items} = array_merge($elements, array_filter($this->{$items}, function($item) use ($items) {
+                return !in_array($item['name'], $this->sort[$items]);
             }));
         }
 
@@ -328,15 +328,15 @@ 
     {
         $relationArray = explode('.', $relationString);
 
-        if (! isset($length)) {
+        if (!isset($length)) {
             $length = count($relationArray);
         }
 
-        if (! isset($model)) {
+        if (!isset($model)) {
             $model = $this->model;
         }
 
-        $result = array_reduce(array_splice($relationArray, 0, $length), function ($obj, $method) {
+        $result = array_reduce(array_splice($relationArray, 0, $length), function($obj, $method) {
             return $obj->$method()->getRelated();
         }, $model);
 
@@ -386,7 +386,7 @@ 
         $relation = $model->{$firstRelationName};
 
         $results = [];
-        if (! empty($relation)) {
+        if (!empty($relation)) {
             if ($relation instanceof Collection) {
                 $currentResults = $relation->toArray();
             } else {
@@ -395,7 +395,7 @@ 
 
             array_shift($relationArray);
 
-            if (! empty($relationArray)) {
+            if (!empty($relationArray)) {
                 foreach ($currentResults as $currentResult) {
                     $results = array_merge($results, $this->getRelationModelInstances($currentResult, implode('.', $relationArray)));
                 }

Unused Use Statements +15 added lines, -15 removed lines

@@ -2,31 +2,31 @@
 
 namespace Backpack\CRUD;
 
-use Backpack\CRUD\PanelTraits\Read;
-use Backpack\CRUD\PanelTraits\Tabs;
-use Backpack\CRUD\PanelTraits\Query;
-use Backpack\CRUD\PanelTraits\Views;
 use Backpack\CRUD\PanelTraits\Access;
+use Backpack\CRUD\PanelTraits\AutoFocus;
+use Backpack\CRUD\PanelTraits\AutoSet;
+use Backpack\CRUD\PanelTraits\Buttons;
+use Backpack\CRUD\PanelTraits\Columns;
 use Backpack\CRUD\PanelTraits\Create;
 use Backpack\CRUD\PanelTraits\Delete;
 use Backpack\CRUD\PanelTraits\Errors;
+use Backpack\CRUD\PanelTraits\FakeColumns;
+use Backpack\CRUD\PanelTraits\FakeFields;
 use Backpack\CRUD\PanelTraits\Fields;
-use Backpack\CRUD\PanelTraits\Search;
-use Backpack\CRUD\PanelTraits\Update;
-use Backpack\CRUD\PanelTraits\AutoSet;
-use Backpack\CRUD\PanelTraits\Buttons;
-use Backpack\CRUD\PanelTraits\Columns;
 use Backpack\CRUD\PanelTraits\Filters;
-use Backpack\CRUD\PanelTraits\Reorder;
-use Backpack\CRUD\PanelTraits\AutoFocus;
+use Backpack\CRUD\PanelTraits\HeadingsAndTitle;
 use Backpack\CRUD\PanelTraits\Macroable;
-use Backpack\CRUD\PanelTraits\FakeFields;
 use Backpack\CRUD\PanelTraits\Operations;
-use Backpack\CRUD\PanelTraits\FakeColumns;
-use Illuminate\Database\Eloquent\Collection;
+use Backpack\CRUD\PanelTraits\Query;
+use Backpack\CRUD\PanelTraits\Read;
+use Backpack\CRUD\PanelTraits\Reorder;
 use Backpack\CRUD\PanelTraits\RequiredFields;
-use Backpack\CRUD\PanelTraits\HeadingsAndTitle;
+use Backpack\CRUD\PanelTraits\Search;
+use Backpack\CRUD\PanelTraits\Tabs;
+use Backpack\CRUD\PanelTraits\Update;
+use Backpack\CRUD\PanelTraits\Views;
 use Backpack\CRUD\PanelTraits\ViewsAndRestoresRevisions;
+use Illuminate\Database\Eloquent\Collection;
 
 class CrudPanel
 {

src/app/Http/Controllers/Operations/Reorder.php

Spacing +1 added lines, -1 removed lines

@@ -16,7 +16,7 @@
         $this->crud->hasAccessOrFail('reorder');
         $this->crud->setOperation('Reorder');
 
-        if (! $this->crud->isReorderEnabled()) {
+        if (!$this->crud->isReorderEnabled()) {
             abort(403, 'Reorder is disabled.');
         }
 

src/app/Http/Controllers/Operations/Revisions.php

Spacing +1 added lines, -1 removed lines

@@ -46,7 +46,7 @@
         $this->crud->setOperation('Revisions');
 
         $revisionId = \Request::input('revision_id', false);
-        if (! $revisionId) {
+        if (!$revisionId) {
             abort(500, 'Can\'t restore revision without revision_id');
         } else {
             $this->crud->restoreRevision($id, $revisionId); // do the update