Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Test Failed
Pull Request — master (#2311)
by Cristian
17:53
created
src/app/Http/Controllers/Operations/ListOperation.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -41,7 +41,7 @@  discard block
 block discarded – undo
41 41
     {
42 42
         $this->crud->allowAccess('list');
43 43
 
44
-        $this->crud->operation('list', function () {
44
+        $this->crud->operation('list', function() {
45 45
             $this->crud->loadDefaultOperationSettingsFromConfig();
46 46
         });
47 47
     }
@@ -112,8 +112,8 @@  discard block
 block discarded – undo
112 112
         // if there was an order set, this will be the last one (after all others were applied)
113 113
         $orderBy = $this->crud->query->getQuery()->orders;
114 114
         $hasOrderByPrimaryKey = false;
115
-        collect($orderBy)->each(function ($item, $key) use ($hasOrderByPrimaryKey) {
116
-            if (! isset($item['column'])) {
115
+        collect($orderBy)->each(function($item, $key) use ($hasOrderByPrimaryKey) {
116
+            if (!isset($item['column'])) {
117 117
                 return false;
118 118
             }
119 119
 
@@ -123,7 +123,7 @@  discard block
 block discarded – undo
123 123
                 return false;
124 124
             }
125 125
         });
126
-        if (! $hasOrderByPrimaryKey) {
126
+        if (!$hasOrderByPrimaryKey) {
127 127
             $this->crud->query->orderByDesc($this->crud->model->getKeyName());
128 128
         }
129 129
 
Please login to merge, or discard this patch.
src/app/Http/Controllers/CrudController.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -27,7 +27,7 @@
 block discarded – undo
27 27
 
28 28
         // call the setup function inside this closure to also have the request there
29 29
         // this way, developers can use things stored in session (auth variables, etc)
30
-        $this->middleware(function ($request, $next) {
30
+        $this->middleware(function($request, $next) {
31 31
             // make a new CrudPanel object, from the one stored in Laravel's service container
32 32
             $this->crud = app()->make('crud');
33 33
             // ensure crud has the latest request
Please login to merge, or discard this patch.
tests/Unit/Http/CrudControllerTest.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -19,7 +19,7 @@
 block discarded – undo
19 19
         $controller = '\Backpack\CRUD\Tests\Unit\Http\Controllers\UserCrudController';
20 20
         $app['router']->get('users/{id}/edit', "$controller@edit");
21 21
         $app['router']->put('users/{id}', "$controller@update");
22
-        $app->singleton('crud', function ($app) {
22
+        $app->singleton('crud', function($app) {
23 23
             return new CrudPanel($app);
24 24
         });
25 25
     }
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/CrudPanel.php 1 patch
Spacing   +12 added lines, -12 removed lines patch added patch discarded remove patch
@@ -69,7 +69,7 @@  discard block
 block discarded – undo
69 69
      */
70 70
     public function setRequest($request = null)
71 71
     {
72
-        if (! $request) {
72
+        if (!$request) {
73 73
             $request = \Request::instance();
74 74
         }
75 75
         $this->request = $request;
@@ -89,11 +89,11 @@  discard block
 block discarded – undo
89 89
      */
90 90
     public function setModel($model_namespace)
91 91
     {
92
-        if (! class_exists($model_namespace)) {
92
+        if (!class_exists($model_namespace)) {
93 93
             throw new \Exception('The model does not exist.', 500);
94 94
         }
95 95
 
96
-        if (! method_exists($model_namespace, 'hasCrudTrait')) {
96
+        if (!method_exists($model_namespace, 'hasCrudTrait')) {
97 97
             throw new \Exception('Please use CrudTrait on the model.', 500);
98 98
         }
99 99
 
@@ -156,7 +156,7 @@  discard block
 block discarded – undo
156 156
     {
157 157
         $complete_route = $route.'.index';
158 158
 
159
-        if (! \Route::has($complete_route)) {
159
+        if (!\Route::has($complete_route)) {
160 160
             throw new \Exception('There are no routes for this route name.', 404);
161 161
         }
162 162
 
@@ -257,7 +257,7 @@  discard block
 block discarded – undo
257 257
      */
258 258
     public function getFirstOfItsTypeInArray($type, $array)
259 259
     {
260
-        return array_first($array, function ($item) use ($type) {
260
+        return array_first($array, function($item) use ($type) {
261 261
             return $item['type'] == $type;
262 262
         });
263 263
     }
@@ -274,8 +274,8 @@  discard block
 block discarded – undo
274 274
 
275 275
     public function sync($type, $fields, $attributes)
276 276
     {
277
-        if (! empty($this->{$type})) {
278
-            $this->{$type} = array_map(function ($field) use ($fields, $attributes) {
277
+        if (!empty($this->{$type})) {
278
+            $this->{$type} = array_map(function($field) use ($fields, $attributes) {
279 279
                 if (in_array($field['name'], (array) $fields)) {
280 280
                     $field = array_merge($field, $attributes);
281 281
                 }
@@ -306,15 +306,15 @@  discard block
 block discarded – undo
306 306
     {
307 307
         $relationArray = explode('.', $relationString);
308 308
 
309
-        if (! isset($length)) {
309
+        if (!isset($length)) {
310 310
             $length = count($relationArray);
311 311
         }
312 312
 
313
-        if (! isset($model)) {
313
+        if (!isset($model)) {
314 314
             $model = $this->model;
315 315
         }
316 316
 
317
-        $result = array_reduce(array_splice($relationArray, 0, $length), function ($obj, $method) {
317
+        $result = array_reduce(array_splice($relationArray, 0, $length), function($obj, $method) {
318 318
             return $obj->$method()->getRelated();
319 319
         }, $model);
320 320
 
@@ -364,7 +364,7 @@  discard block
 block discarded – undo
364 364
         $relation = $model->{$firstRelationName};
365 365
 
366 366
         $results = [];
367
-        if (! empty($relation)) {
367
+        if (!empty($relation)) {
368 368
             if ($relation instanceof Collection) {
369 369
                 $currentResults = $relation->toArray();
370 370
             } else {
@@ -373,7 +373,7 @@  discard block
 block discarded – undo
373 373
 
374 374
             array_shift($relationArray);
375 375
 
376
-            if (! empty($relationArray)) {
376
+            if (!empty($relationArray)) {
377 377
                 foreach ($currentResults as $currentResult) {
378 378
                     $results = array_merge($results, $this->getRelationModelInstances($currentResult, implode('.', $relationArray)));
379 379
                 }
Please login to merge, or discard this patch.
src/app/Console/Commands/Install.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -88,7 +88,7 @@  discard block
 block discarded – undo
88 88
                     $createUploadDirectoryCommand = 'mkdir -p public/uploads';
89 89
                     break;
90 90
                 case '\\': // windows
91
-                    if (! file_exists('public\uploads')) {
91
+                    if (!file_exists('public\uploads')) {
92 92
                         $createUploadDirectoryCommand = 'mkdir public\uploads';
93 93
                     }
94 94
                     break;
@@ -133,7 +133,7 @@  discard block
 block discarded – undo
133 133
         $this->echo('info', $beforeNotice ? ' '.$beforeNotice : $command);
134 134
 
135 135
         $process = new Process($command, null, null, null, $this->option('timeout'));
136
-        $process->run(function ($type, $buffer) {
136
+        $process->run(function($type, $buffer) {
137 137
             if (Process::ERR === $type) {
138 138
                 $this->echo('comment', $buffer);
139 139
             } else {
@@ -142,7 +142,7 @@  discard block
 block discarded – undo
142 142
         });
143 143
 
144 144
         // executes after the command finishes
145
-        if (! $process->isSuccessful()) {
145
+        if (!$process->isSuccessful()) {
146 146
             throw new ProcessFailedException($process);
147 147
         }
148 148
 
Please login to merge, or discard this patch.
src/resources/views/crud/columns/select_from_array.blade.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -10,7 +10,7 @@
 block discarded – undo
10 10
                 $array_of_values = [];
11 11
 
12 12
                 foreach ($values as $key => $value) {
13
-                    if (! is_null($value)) {
13
+                    if (!is_null($value)) {
14 14
                         $array_of_values[] = $column['options'][$value] ?? $value;
15 15
                     } else {
16 16
                         echo '-';
Please login to merge, or discard this patch.
src/app/Models/Traits/CrudTrait.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -72,7 +72,7 @@  discard block
 block discarded – undo
72 72
             //check if column exists in database
73 73
             $conn->getDoctrineColumn($table, $column_name);
74 74
 
75
-            return ! $conn->getDoctrineColumn($table, $column_name)->getNotnull();
75
+            return !$conn->getDoctrineColumn($table, $column_name)->getNotnull();
76 76
         } catch (\Exception $e) {
77 77
             return true;
78 78
         }
@@ -92,7 +92,7 @@  discard block
 block discarded – undo
92 92
     public function addFakes($columns = ['extras'])
93 93
     {
94 94
         foreach ($columns as $key => $column) {
95
-            if (! isset($this->attributes[$column])) {
95
+            if (!isset($this->attributes[$column])) {
96 96
                 continue;
97 97
             }
98 98
 
@@ -141,7 +141,7 @@  discard block
 block discarded – undo
141 141
      */
142 142
     public function shouldDecodeFake($column)
143 143
     {
144
-        return ! in_array($column, array_keys($this->casts));
144
+        return !in_array($column, array_keys($this->casts));
145 145
     }
146 146
 
147 147
     /**
@@ -153,7 +153,7 @@  discard block
 block discarded – undo
153 153
      */
154 154
     public function shouldEncodeFake($column)
155 155
     {
156
-        return ! in_array($column, array_keys($this->casts));
156
+        return !in_array($column, array_keys($this->casts));
157 157
     }
158 158
 
159 159
     /*
@@ -224,7 +224,7 @@  discard block
 block discarded – undo
224 224
      */
225 225
     public function uploadMultipleFilesToDisk($value, $attribute_name, $disk, $destination_path)
226 226
     {
227
-        if (! is_array($this->{$attribute_name})) {
227
+        if (!is_array($this->{$attribute_name})) {
228 228
             $attribute_value = json_decode($this->{$attribute_name}, true) ?? [];
229 229
         } else {
230 230
             $attribute_value = $this->{$attribute_name};
@@ -236,7 +236,7 @@  discard block
 block discarded – undo
236 236
         if ($files_to_clear) {
237 237
             foreach ($files_to_clear as $key => $filename) {
238 238
                 \Storage::disk($disk)->delete($filename);
239
-                $attribute_value = array_where($attribute_value, function ($value, $key) use ($filename) {
239
+                $attribute_value = array_where($attribute_value, function($value, $key) use ($filename) {
240 240
                     return $value != $filename;
241 241
                 });
242 242
             }
Please login to merge, or discard this patch.
src/app/Http/Controllers/Operations/InlineCreateOperation.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -57,7 +57,7 @@  discard block
 block discarded – undo
57 57
      */
58 58
     public function getInlineCreateModal()
59 59
     {
60
-        if (! request()->has('entity')) {
60
+        if (!request()->has('entity')) {
61 61
             abort(400, 'No "entity" inside the request.');
62 62
         }
63 63
 
@@ -80,17 +80,17 @@  discard block
 block discarded – undo
80 80
      */
81 81
     public function inlineRefreshOptions()
82 82
     {
83
-        if (! request()->has('field')) {
83
+        if (!request()->has('field')) {
84 84
             abort(400, 'No "field" inside the request.');
85 85
         }
86 86
 
87 87
         $field = $this->crud->fields()[request()->get('field')];
88 88
         $options = [];
89 89
 
90
-        if (! empty($field)) {
90
+        if (!empty($field)) {
91 91
             $relatedModelInstance = new $field['model']();
92 92
 
93
-            if (! isset($field['options'])) {
93
+            if (!isset($field['options'])) {
94 94
                 $options = $field['model']::all()->pluck($field['attribute'], $relatedModelInstance->getKeyName());
95 95
             } else {
96 96
                 $options = call_user_func($field['options'], $field['model']::query()->pluck($field['attribute'], $relatedModelInstance->getKeyName()));
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Fields.php 1 patch
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -55,7 +55,7 @@  discard block
 block discarded – undo
55 55
      */
56 56
     public function afterField($targetFieldName)
57 57
     {
58
-        $this->transformFields(function ($fields) use ($targetFieldName) {
58
+        $this->transformFields(function($fields) use ($targetFieldName) {
59 59
             return $this->moveField($fields, $targetFieldName, false);
60 60
         });
61 61
     }
@@ -67,7 +67,7 @@  discard block
 block discarded – undo
67 67
      */
68 68
     public function beforeField($targetFieldName)
69 69
     {
70
-        $this->transformFields(function ($fields) use ($targetFieldName) {
70
+        $this->transformFields(function($fields) use ($targetFieldName) {
71 71
             return $this->moveField($fields, $targetFieldName, true);
72 72
         });
73 73
     }
@@ -79,7 +79,7 @@  discard block
 block discarded – undo
79 79
      */
80 80
     public function removeField($name)
81 81
     {
82
-        $this->transformFields(function ($fields) use ($name) {
82
+        $this->transformFields(function($fields) use ($name) {
83 83
             array_forget($fields, $name);
84 84
 
85 85
             return $fields;
@@ -93,7 +93,7 @@  discard block
 block discarded – undo
93 93
      */
94 94
     public function removeFields($array_of_names)
95 95
     {
96
-        if (! empty($array_of_names)) {
96
+        if (!empty($array_of_names)) {
97 97
             foreach ($array_of_names as $name) {
98 98
                 $this->removeField($name);
99 99
             }
@@ -106,7 +106,7 @@  discard block
 block discarded – undo
106 106
     public function removeAllFields()
107 107
     {
108 108
         $current_fields = $this->getCurrentFields();
109
-        if (! empty($current_fields)) {
109
+        if (!empty($current_fields)) {
110 110
             foreach ($current_fields as $field) {
111 111
                 $this->removeField($field['name']);
112 112
             }
@@ -180,7 +180,7 @@  discard block
 block discarded – undo
180 180
                 $jsonCastables = ['array', 'object', 'json'];
181 181
                 $fieldCasting = $casted_attributes[$field['name']];
182 182
 
183
-                if (in_array($fieldCasting, $jsonCastables) && isset($data[$field['name']]) && ! empty($data[$field['name']]) && ! is_array($data[$field['name']])) {
183
+                if (in_array($fieldCasting, $jsonCastables) && isset($data[$field['name']]) && !empty($data[$field['name']]) && !is_array($data[$field['name']])) {
184 184
                     try {
185 185
                         $data[$field['name']] = json_decode($data[$field['name']]);
186 186
                     } catch (\Exception $e) {
@@ -209,7 +209,7 @@  discard block
 block discarded – undo
209 209
      */
210 210
     public function orderFields($order)
211 211
     {
212
-        $this->transformFields(function ($fields) use ($order) {
212
+        $this->transformFields(function($fields) use ($order) {
213 213
             return $this->applyOrderToFields($fields, $order);
214 214
         });
215 215
     }
@@ -236,7 +236,7 @@  discard block
 block discarded – undo
236 236
     public function hasUploadFields()
237 237
     {
238 238
         $fields = $this->getFields();
239
-        $upload_fields = array_where($fields, function ($value, $key) {
239
+        $upload_fields = array_where($fields, function($value, $key) {
240 240
             return isset($value['upload']) && $value['upload'] == true;
241 241
         });
242 242
 
@@ -299,7 +299,7 @@  discard block
 block discarded – undo
299 299
         $alreadyLoaded = $this->getLoadedFieldTypes();
300 300
         $type = $this->getFieldTypeWithNamespace($field);
301 301
 
302
-        if (! in_array($type, $this->getLoadedFieldTypes(), true)) {
302
+        if (!in_array($type, $this->getLoadedFieldTypes(), true)) {
303 303
             $alreadyLoaded[] = $type;
304 304
             $this->setLoadedFieldTypes($alreadyLoaded);
305 305
 
@@ -340,7 +340,7 @@  discard block
 block discarded – undo
340 340
      */
341 341
     public function fieldTypeNotLoaded($field)
342 342
     {
343
-        return ! in_array($this->getFieldTypeWithNamespace($field), $this->getLoadedFieldTypes());
343
+        return !in_array($this->getFieldTypeWithNamespace($field), $this->getLoadedFieldTypes());
344 344
     }
345 345
 
346 346
     /**
Please login to merge, or discard this patch.