Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Completed
Pull Request — master (#1997)
by Cristian
09:43
created
src/helpers.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-if (! function_exists('square_brackets_to_dots')) {
3
+if (!function_exists('square_brackets_to_dots')) {
4 4
     /**
5 5
      * Turns a string from bracket-type array to dot-notation array.
6 6
      * Ex: array[0][property] turns into array.0.property.
@@ -17,7 +17,7 @@  discard block
 block discarded – undo
17 17
     }
18 18
 }
19 19
 
20
-if (! function_exists('is_countable')) {
20
+if (!function_exists('is_countable')) {
21 21
     /**
22 22
      * We need this because is_countable was only introduced in PHP 7.3,
23 23
      * and in PHP 7.2 you should check if count() argument is really countable.
Please login to merge, or discard this patch.
src/resources/views/columns/select_from_array.blade.php 1 patch
Indentation   +18 added lines, -18 removed lines patch added patch discarded remove patch
@@ -5,24 +5,24 @@
 block discarded – undo
5 5
 
6 6
 <span>
7 7
 	<?php
8
-		if ($values !== null) {
9
-			if (is_array($values)) {
10
-				$array_of_values = [];
8
+        if ($values !== null) {
9
+            if (is_array($values)) {
10
+                $array_of_values = [];
11 11
 
12
-				foreach ($values as $key => $value) {
13
-					$array_of_values[] = $column['options'][$value];
14
-				}
12
+                foreach ($values as $key => $value) {
13
+                    $array_of_values[] = $column['options'][$value];
14
+                }
15 15
 
16
-				if (count($array_of_values) > 1) {
17
-					echo implode(', ', $array_of_values);
18
-				} else {
19
-					echo $array_of_values;
20
-				}
21
-			} else {
22
-				echo $column['options'][$values];
23
-			}
24
-	    } else {
25
-	    	echo "-";
26
-	    }
27
-	?>
16
+                if (count($array_of_values) > 1) {
17
+                    echo implode(', ', $array_of_values);
18
+                } else {
19
+                    echo $array_of_values;
20
+                }
21
+            } else {
22
+                echo $column['options'][$values];
23
+            }
24
+        } else {
25
+            echo "-";
26
+        }
27
+    ?>
28 28
 </span>
29 29
\ No newline at end of file
Please login to merge, or discard this patch.
src/PanelTraits/AutoSet.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -17,12 +17,12 @@  discard block
 block discarded – undo
17 17
      */
18 18
     public function setFromDb()
19 19
     {
20
-        if (! $this->driverIsMongoDb()) {
20
+        if (!$this->driverIsMongoDb()) {
21 21
             $this->setDoctrineTypesMapping();
22 22
             $this->getDbColumnTypes();
23 23
         }
24 24
 
25
-        array_map(function ($field) {
25
+        array_map(function($field) {
26 26
             $new_field = [
27 27
                 'name'       => $field,
28 28
                 'label'      => $this->makeLabel($field),
@@ -33,14 +33,14 @@  discard block
 block discarded – undo
33 33
                 'attributes' => [],
34 34
                 'autoset'    => true,
35 35
             ];
36
-            if (! isset($this->create_fields[$field])) {
36
+            if (!isset($this->create_fields[$field])) {
37 37
                 $this->create_fields[$field] = $new_field;
38 38
             }
39
-            if (! isset($this->update_fields[$field])) {
39
+            if (!isset($this->update_fields[$field])) {
40 40
                 $this->update_fields[$field] = $new_field;
41 41
             }
42 42
 
43
-            if (! in_array($field, $this->model->getHidden()) && ! isset($this->columns[$field])) {
43
+            if (!in_array($field, $this->model->getHidden()) && !isset($this->columns[$field])) {
44 44
                 $this->addColumn([
45 45
                     'name'  => $field,
46 46
                     'label' => $this->makeLabel($field),
@@ -96,7 +96,7 @@  discard block
 block discarded – undo
96 96
      */
97 97
     public function getFieldTypeFromDbColumnType($field)
98 98
     {
99
-        if (! array_key_exists($field, $this->db_column_types)) {
99
+        if (!array_key_exists($field, $this->db_column_types)) {
100 100
             return 'text';
101 101
         }
102 102
 
@@ -162,7 +162,7 @@  discard block
 block discarded – undo
162 162
         $types = ['enum' => 'string'];
163 163
         $platform = \DB::getDoctrineConnection()->getDatabasePlatform();
164 164
         foreach ($types as $type_key => $type_value) {
165
-            if (! $platform->hasDoctrineTypeMappingFor($type_key)) {
165
+            if (!$platform->hasDoctrineTypeMappingFor($type_key)) {
166 166
                 $platform->registerDoctrineTypeMapping($type_key, $type_value);
167 167
             }
168 168
         }
@@ -221,7 +221,7 @@  discard block
 block discarded – undo
221 221
             // Automatically-set columns should be both in the database, and in the $fillable variable on the Eloquent Model
222 222
             $columns = $this->model->getConnection()->getSchemaBuilder()->getColumnListing($this->model->getTable());
223 223
 
224
-            if (! empty($fillable)) {
224
+            if (!empty($fillable)) {
225 225
                 $columns = array_intersect($columns, $fillable);
226 226
             }
227 227
         }
Please login to merge, or discard this patch.
src/resources/views/reorder.blade.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -68,10 +68,10 @@
 block discarded – undo
68 68
             <ol class="sortable mt-0">
69 69
             <?php
70 70
                 $all_entries = collect($entries->all())->sortBy('lft')->keyBy($crud->getModel()->getKeyName());
71
-                $root_entries = $all_entries->filter(function ($item) {
71
+                $root_entries = $all_entries->filter(function($item) {
72 72
                     return $item->parent_id == 0;
73 73
                 });
74
-                foreach ($root_entries as $key => $entry){
74
+                foreach ($root_entries as $key => $entry) {
75 75
                     $root_entries[$key] = tree_element($entry, $key, $all_entries, $crud);
76 76
                 }
77 77
             ?>
Please login to merge, or discard this patch.
src/app/Http/Controllers/Operations/CreateOperation.php 1 patch
Unused Use Statements   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -2,8 +2,8 @@
 block discarded – undo
2 2
 
3 3
 namespace Backpack\CRUD\app\Http\Controllers\Operations;
4 4
 
5
-use Illuminate\Support\Facades\Route;
6 5
 use Illuminate\Http\Request as StoreRequest;
6
+use Illuminate\Support\Facades\Route;
7 7
 
8 8
 trait CreateOperation
9 9
 {
Please login to merge, or discard this patch.
src/app/Http/Controllers/Operations/UpdateOperation.php 2 patches
Unused Use Statements   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -2,8 +2,8 @@
 block discarded – undo
2 2
 
3 3
 namespace Backpack\CRUD\app\Http\Controllers\Operations;
4 4
 
5
-use Illuminate\Support\Facades\Route;
6 5
 use Illuminate\Http\Request as UpdateRequest;
6
+use Illuminate\Support\Facades\Route;
7 7
 
8 8
 trait UpdateOperation
9 9
 {
Please login to merge, or discard this patch.
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -9,7 +9,6 @@
 block discarded – undo
9 9
     /**
10 10
      * Define which routes are needed for this operation.
11 11
      *
12
-     * @param  string $name       Name of the current entity (singular). Used as first URL segment.
13 12
      * @param  string $routeName    Prefix of the route name.
14 13
      * @param  string $controller Name of the current CrudController.
15 14
      */
Please login to merge, or discard this patch.
src/app/Http/Controllers/Operations/BulkCloneOperation.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -24,7 +24,6 @@
 block discarded – undo
24 24
     /**
25 25
      * Create duplicates of multiple entries in the datatabase.
26 26
      *
27
-     * @param int $id
28 27
      *
29 28
      * @return Response
30 29
      */
Please login to merge, or discard this patch.
src/app/Http/Controllers/Operations/CloneOperation.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -26,7 +26,7 @@
 block discarded – undo
26 26
      *
27 27
      * @param int $id
28 28
      *
29
-     * @return Response
29
+     * @return string
30 30
      */
31 31
     public function clone($id)
32 32
     {
Please login to merge, or discard this patch.
src/resources/views/fields/datetime.blade.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,7 @@
 block discarded – undo
3 3
 <?php
4 4
 // if the column has been cast to Carbon or Date (using attribute casting)
5 5
 // get the value as a date string
6
-if (isset($field['value']) && ( $field['value'] instanceof \Carbon\CarbonInterface )) {
6
+if (isset($field['value']) && ($field['value'] instanceof \Carbon\CarbonInterface)) {
7 7
     $field['value'] = $field['value']->toDateTimeString();
8 8
 }
9 9
 ?>
Please login to merge, or discard this patch.