Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Passed
Pull Request — main (#5626)
by Cristian
26:28 queued 11:38
created
tests/config/CrudPanel/BaseCrudPanel.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -24,7 +24,7 @@  discard block
 block discarded – undo
24 24
     {
25 25
         parent::setUp();
26 26
 
27
-        $this->app->singleton('crud', function ($app) {
27
+        $this->app->singleton('crud', function($app) {
28 28
             return new CrudPanel($app);
29 29
         });
30 30
         $this->crudPanel = app('crud');
@@ -43,7 +43,7 @@  discard block
 block discarded – undo
43 43
         $app['config']->set('database.default', 'testing');
44 44
         $app['config']->set('backpack.base.route_prefix', 'admin');
45 45
 
46
-        $app->bind('App\Http\Middleware\CheckIfAdmin', function () {
46
+        $app->bind('App\Http\Middleware\CheckIfAdmin', function() {
47 47
             return new class
48 48
             {
49 49
                 public function handle($request, $next)
Please login to merge, or discard this patch.
src/app/Console/Commands/AddCustomRouteContent.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -43,7 +43,7 @@  discard block
 block discarded – undo
43 43
     {
44 44
         $routeFilePath = base_path($this->option('route-file'));
45 45
 
46
-        if (! file_exists($routeFilePath)) {
46
+        if (!file_exists($routeFilePath)) {
47 47
             if ($routeFilePath !== base_path($this->backpackCustomRouteFile)) {
48 48
                 $this->info('The route file <fg=blue>'.$routeFilePath.'</> does not exist. Please create it first.');
49 49
 
@@ -100,7 +100,7 @@  discard block
 block discarded – undo
100 100
 
101 101
     private function cleanContentArray(array $content)
102 102
     {
103
-        return array_filter(array_map(function ($line) {
103
+        return array_filter(array_map(function($line) {
104 104
             $lineText = trim($line);
105 105
             if ($lineText === '' ||
106 106
                 $lineText === '\n' ||
@@ -133,7 +133,7 @@  discard block
 block discarded – undo
133 133
      */
134 134
     private function getLastLineNumberThatContains($needle, $haystack)
135 135
     {
136
-        $matchingLines = array_filter($haystack, function ($k) use ($needle) {
136
+        $matchingLines = array_filter($haystack, function($k) use ($needle) {
137 137
             return strpos($k, $needle) !== false;
138 138
         });
139 139
 
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Input.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -98,7 +98,7 @@  discard block
 block discarded – undo
98 98
         }
99 99
 
100 100
         //remove fields that are not in the submitted form input
101
-        $relationFields = array_filter($relationFields, function ($field) use ($input) {
101
+        $relationFields = array_filter($relationFields, function($field) use ($input) {
102 102
             return Arr::has($input, $field['name']) || isset($input[$field['name']]) || Arr::has($input, Str::afterLast($field['name'], '.'));
103 103
         });
104 104
 
@@ -177,7 +177,7 @@  discard block
 block discarded – undo
177 177
 
178 178
             // when using dot notation if relationMethod is not set we are sure we want to exclude those relations.
179 179
             if ($this->getOnlyRelationEntity($field) !== $field['entity']) {
180
-                if (! $relationMethod) {
180
+                if (!$relationMethod) {
181 181
                     $excludedFields[] = $nameToExclude;
182 182
                 }
183 183
 
@@ -191,8 +191,8 @@  discard block
 block discarded – undo
191 191
             }
192 192
         }
193 193
 
194
-        return Arr::where($input, function ($item, $key) use ($excludedFields) {
195
-            return ! in_array($key, $excludedFields);
194
+        return Arr::where($input, function($item, $key) use ($excludedFields) {
195
+            return !in_array($key, $excludedFields);
196 196
         });
197 197
     }
198 198
 
@@ -218,7 +218,7 @@  discard block
 block discarded – undo
218 218
                 $jsonCastables = ['array', 'object', 'json'];
219 219
                 $fieldCasting = $casted_attributes[$field['name']];
220 220
 
221
-                if (in_array($fieldCasting, $jsonCastables) && isset($input[$field['name']]) && ! empty($input[$field['name']]) && ! is_array($input[$field['name']])) {
221
+                if (in_array($fieldCasting, $jsonCastables) && isset($input[$field['name']]) && !empty($input[$field['name']]) && !is_array($input[$field['name']])) {
222 222
                     try {
223 223
                         $input[$field['name']] = json_decode($input[$field['name']]);
224 224
                     } catch (\Exception $e) {
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Fields.php 1 patch
Spacing   +13 added lines, -13 removed lines patch added patch discarded remove patch
@@ -136,7 +136,7 @@  discard block
 block discarded – undo
136 136
      */
137 137
     public function afterField($targetFieldName)
138 138
     {
139
-        $this->transformFields(function ($fields) use ($targetFieldName) {
139
+        $this->transformFields(function($fields) use ($targetFieldName) {
140 140
             return $this->moveField($fields, $targetFieldName, false);
141 141
         });
142 142
     }
@@ -148,7 +148,7 @@  discard block
 block discarded – undo
148 148
      */
149 149
     public function beforeField($targetFieldName)
150 150
     {
151
-        $this->transformFields(function ($fields) use ($targetFieldName) {
151
+        $this->transformFields(function($fields) use ($targetFieldName) {
152 152
             return $this->moveField($fields, $targetFieldName, true);
153 153
         });
154 154
     }
@@ -160,7 +160,7 @@  discard block
 block discarded – undo
160 160
      */
161 161
     public function makeFirstField()
162 162
     {
163
-        if (! $this->fields()) {
163
+        if (!$this->fields()) {
164 164
             return false;
165 165
         }
166 166
 
@@ -175,7 +175,7 @@  discard block
 block discarded – undo
175 175
      */
176 176
     public function removeField($name)
177 177
     {
178
-        $this->transformFields(function ($fields) use ($name) {
178
+        $this->transformFields(function($fields) use ($name) {
179 179
             Arr::forget($fields, $name);
180 180
 
181 181
             return $fields;
@@ -189,7 +189,7 @@  discard block
 block discarded – undo
189 189
      */
190 190
     public function removeFields($array_of_names)
191 191
     {
192
-        if (! empty($array_of_names)) {
192
+        if (!empty($array_of_names)) {
193 193
             foreach ($array_of_names as $name) {
194 194
                 $this->removeField($name);
195 195
             }
@@ -202,7 +202,7 @@  discard block
 block discarded – undo
202 202
     public function removeAllFields()
203 203
     {
204 204
         $current_fields = $this->getCleanStateFields();
205
-        if (! empty($current_fields)) {
205
+        if (!empty($current_fields)) {
206 206
             foreach ($current_fields as $field) {
207 207
                 $this->removeField($field['name']);
208 208
             }
@@ -290,7 +290,7 @@  discard block
 block discarded – undo
290 290
      */
291 291
     public function orderFields($order)
292 292
     {
293
-        $this->transformFields(function ($fields) use ($order) {
293
+        $this->transformFields(function($fields) use ($order) {
294 294
             return $this->applyOrderToFields($fields, $order);
295 295
         });
296 296
     }
@@ -314,7 +314,7 @@  discard block
 block discarded – undo
314 314
     public function hasUploadFields()
315 315
     {
316 316
         $fields = $this->getCleanStateFields();
317
-        $upload_fields = Arr::where($fields, function ($value, $key) {
317
+        $upload_fields = Arr::where($fields, function($value, $key) {
318 318
             // check if any subfields have uploads
319 319
             if (isset($value['subfields'])) {
320 320
                 foreach ($value['subfields'] as $subfield) {
@@ -386,7 +386,7 @@  discard block
 block discarded – undo
386 386
         $alreadyLoaded = $this->getLoadedFieldTypes();
387 387
         $type = $this->getFieldTypeWithNamespace($field);
388 388
 
389
-        if (! in_array($type, $this->getLoadedFieldTypes(), true)) {
389
+        if (!in_array($type, $this->getLoadedFieldTypes(), true)) {
390 390
             $alreadyLoaded[] = $type;
391 391
             $this->setLoadedFieldTypes($alreadyLoaded);
392 392
 
@@ -427,7 +427,7 @@  discard block
 block discarded – undo
427 427
      */
428 428
     public function fieldTypeNotLoaded($field)
429 429
     {
430
-        return ! in_array($this->getFieldTypeWithNamespace($field), $this->getLoadedFieldTypes());
430
+        return !in_array($this->getFieldTypeWithNamespace($field), $this->getLoadedFieldTypes());
431 431
     }
432 432
 
433 433
     /**
@@ -439,7 +439,7 @@  discard block
 block discarded – undo
439 439
     {
440 440
         $fieldNamesArray = array_column($this->getCleanStateFields(), 'name');
441 441
 
442
-        return array_reduce($fieldNamesArray, function ($names, $item) {
442
+        return array_reduce($fieldNamesArray, function($names, $item) {
443 443
             if (strpos($item, ',') === false) {
444 444
                 $names[] = $item;
445 445
 
@@ -490,7 +490,7 @@  discard block
 block discarded – undo
490 490
      */
491 491
     public function hasFieldWhere($attribute, $value)
492 492
     {
493
-        $match = Arr::first($this->getCleanStateFields(), function ($field, $fieldKey) use ($attribute, $value) {
493
+        $match = Arr::first($this->getCleanStateFields(), function($field, $fieldKey) use ($attribute, $value) {
494 494
             return isset($field[$attribute]) && $field[$attribute] == $value;
495 495
         });
496 496
 
@@ -506,7 +506,7 @@  discard block
 block discarded – undo
506 506
      */
507 507
     public function firstFieldWhere($attribute, $value)
508 508
     {
509
-        return Arr::first($this->getCleanStateFields(), function ($field, $fieldKey) use ($attribute, $value) {
509
+        return Arr::first($this->getCleanStateFields(), function($field, $fieldKey) use ($attribute, $value) {
510 510
             return isset($field[$attribute]) && $field[$attribute] == $value;
511 511
         });
512 512
     }
Please login to merge, or discard this patch.
src/app/Models/Traits/HasIdentifiableAttribute.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -55,7 +55,7 @@  discard block
 block discarded – undo
55 55
         // we get the first column from database
56 56
         // that is NOT indexed (usually primary, foreign keys)
57 57
         foreach ($columnNames as $columnName) {
58
-            if (! in_array($columnName, $indexes)) {
58
+            if (!in_array($columnName, $indexes)) {
59 59
                 //check for convention "field<_id>" in case developer didn't add foreign key constraints.
60 60
                 if (strpos($columnName, '_id') !== false) {
61 61
                     continue;
@@ -67,7 +67,7 @@  discard block
 block discarded – undo
67 67
 
68 68
         // in case everything fails we just return the first column in database
69 69
         $firstColumnInTable = Arr::first($columnNames);
70
-        if (! empty($firstColumnInTable)) {
70
+        if (!empty($firstColumnInTable)) {
71 71
             return $firstColumnInTable;
72 72
         }
73 73
 
Please login to merge, or discard this patch.
tests/config/database/migrations/2024_07_30_000000_create_reorder_table.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -13,7 +13,7 @@
 block discarded – undo
13 13
      */
14 14
     public function up()
15 15
     {
16
-        Schema::create('reorders', function (Blueprint $table) {
16
+        Schema::create('reorders', function(Blueprint $table) {
17 17
             $table->increments('id');
18 18
             $table->string('name');
19 19
             $table->bigInteger('parent_id')->nullable();
Please login to merge, or discard this patch.
tests/BaseTestClass.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -25,7 +25,7 @@  discard block
 block discarded – undo
25 25
             (array) config('backpack.base.middleware_key', 'admin'),
26 26
             'prefix' => config('backpack.base.route_prefix', 'admin'),
27 27
         ],
28
-            function () {
28
+            function() {
29 29
                 Route::get('articles/{id}/show/{detail}', ['as' => 'article.show.detail', 'action' => 'Backpack\CRUD\Tests\config\Http\Controllers\ArticleCrudController@detail']);
30 30
                 Route::crud('users', 'Backpack\CRUD\Tests\config\Http\Controllers\UserCrudController');
31 31
                 Route::crud('articles', 'Backpack\CRUD\Tests\config\Http\Controllers\ArticleCrudController');
@@ -45,7 +45,7 @@  discard block
 block discarded – undo
45 45
     protected function setupUserCreateRequest()
46 46
     {
47 47
         $request = request()->create('/admin/users/create', 'POST', ['name' => 'foo']);
48
-        $request->setRouteResolver(function () use ($request) {
48
+        $request->setRouteResolver(function() use ($request) {
49 49
             return (new RouteInstance('POST', 'admin/users/create', ['UserCrudController', 'create']))->bind($request);
50 50
         });
51 51
         $this->crudPanel->setRequest($request);
Please login to merge, or discard this patch.
tests/Unit/CrudPanel/CrudPanelQueryTest.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -32,7 +32,7 @@  discard block
 block discarded – undo
32 32
 
33 33
     public function testItCanAddAClauseToTheQueryUsingAClosure()
34 34
     {
35
-        $closure = function ($query) {
35
+        $closure = function($query) {
36 36
             $query->where('id', 1);
37 37
         };
38 38
 
@@ -51,7 +51,7 @@  discard block
 block discarded – undo
51 51
 
52 52
     public function testItCanAddABaseClauseToTheQueryUsingAClosure()
53 53
     {
54
-        $closure = function ($query) {
54
+        $closure = function($query) {
55 55
             $query->where('id', 1);
56 56
         };
57 57
 
@@ -115,7 +115,7 @@  discard block
 block discarded – undo
115 115
         $this->crudPanel->addColumn([
116 116
             'name' => 'name',
117 117
             'type' => 'text',
118
-            'orderLogic' => function ($query, $column, $direction) {
118
+            'orderLogic' => function($query, $column, $direction) {
119 119
                 $query->orderBy('name', $direction);
120 120
             },
121 121
         ]);
Please login to merge, or discard this patch.
tests/Unit/CrudPanel/CrudPanelSaveActionsTest.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -25,13 +25,13 @@  discard block
 block discarded – undo
25 25
         $this->singleSaveAction = [
26 26
             'name' => 'save_action_one',
27 27
             'button_text' => 'custom',
28
-            'redirect' => function ($crud, $request, $itemId) {
28
+            'redirect' => function($crud, $request, $itemId) {
29 29
                 return 'https://backpackforlaravel.com';
30 30
             },
31
-            'referrer_url' => function ($crud, $request, $itemId) {
31
+            'referrer_url' => function($crud, $request, $itemId) {
32 32
                 return 'https://backpackforlaravel.com';
33 33
             },
34
-            'visible' => function ($crud) {
34
+            'visible' => function($crud) {
35 35
                 return true;
36 36
             },
37 37
         ];
@@ -39,19 +39,19 @@  discard block
 block discarded – undo
39 39
         $this->multipleSaveActions = [
40 40
             [
41 41
                 'name' => 'save_action_one',
42
-                'redirect' => function ($crud, $request, $itemId) {
42
+                'redirect' => function($crud, $request, $itemId) {
43 43
                     return $crud->route;
44 44
                 },
45
-                'visible' => function ($crud) {
45
+                'visible' => function($crud) {
46 46
                     return true;
47 47
                 },
48 48
             ],
49 49
             [
50 50
                 'name' => 'save_action_two',
51
-                'redirect' => function ($crud, $request, $itemId) {
51
+                'redirect' => function($crud, $request, $itemId) {
52 52
                     return $crud->route;
53 53
                 },
54
-                'visible' => function ($crud) {
54
+                'visible' => function($crud) {
55 55
                     return true;
56 56
                 },
57 57
             ],
Please login to merge, or discard this patch.