CollectionRepository::getItems() - Code Metrics - Inspection of "[POC][WIP] backpack smart components" - Laravel-Backpack/CRUD - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — main (#4854)

by Pedro

created 2022-12-25 10:24 UTC

CollectionRepository::getItems() A

↳ Parent: CollectionRepository

Complexity

Conditions	2
Paths	2

Size

Total Lines	6
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	2
eloc	3
c	1
b	0
f	0
nc	2
nop	0
dl	0
loc	6
rs	10

<?php

namespace Backpack\CRUD\app\Library\Components;

use Backpack\CRUD\app\Library\Components\Interfaces\Components\SmartComponentInterface;
filter:
    dependency_paths: ["lib/*"]
use Closure;
use Illuminate\Support\Collection;

class CollectionRepository
{
    public function __construct(private Closure $getCollection, private Closure $saveCollection)
    {
    }

    public function addItem($key, $value, $save = true)
    {
        $items = $this->getItems();
        $items[$key] = $value;
        ! $save ?: $this->save($items->toArray());
    }

    public function getItems(): Collection
    {
        if ($this->getCollection) {
            $collection = ($this->getCollection)();

            return collect($collection);
        }
interface ReturnsInt {
    public function returnsIntHinted(): int;
}

class MyClass implements ReturnsInt {
    public function returnsIntHinted(): int
    {
        if (foo()) {
            return 123;
        }
        // here: null is implicitly returned
    }
}
    }

    public function removeItem($attribute, $save = true)
    {
        $items = $this->getItems()->filter(function ($collectionItem, $key) use ($attribute) {
        $items = $this->getItems()->filter(function ($collectionItem, /** @scrutinizer ignore-unused */ $key) use ($attribute) {
            return $collectionItem->getName() !== $attribute;
        });

        ! $save ?: $this->save($items);
    }

    private function save($collection)
    {
        if (is_callable($this->saveCollection)) {
            ($this->saveCollection)($collection);
        }
    }

    public function setItemAttributes($key, $attributes)
    {
        $this->addItem($key, $attributes);
    }

    public function getItemByName($name)
    {
        return $this->getItems()->first(function ($item, $key) use ($name) {
            return $key === $name;
        });
    }

    public function replaceItem(SmartComponentInterface $item)
    {
        $items = $this->removeItem($item, false);
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
        $items = $this->addItem($item, false);
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();

        $this->save($items);
    }

    public function getAttribute($attribute)
    {
        return $this->attributes[$attribute];

    }
}


Laravel-Backpack / CRUD

Scrutinizer GitHub App not installed

Pull Request — main (#4854)

CollectionRepository::getItems() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like