MultipleAttribute - Code Metrics - Inspection of "[POC][WIP] backpack smart components" - Laravel-Backpack/CRUD - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — main (#4854)

by Pedro

created 2022-12-25 10:24 UTC

MultipleAttribute A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	28
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	15
c	1
b	0
f	0
dl	0
loc	28
rs	10
wmc	10

3 Methods

Rating	Name	Size	Complexity
A	getAttributeName()	3	1
B	getDefault()	16	8
A	getValidationRules()	3	1

<?php

namespace Backpack\CRUD\app\Library\Components\Attributes;

use Backpack\CRUD\app\Library\Components\AttributeCollection;
use Backpack\CRUD\app\Library\Components\Interfaces\AttributeInterface;

class MultipleAttribute extends BaseAttribute implements AttributeInterface
{
    public static function getDefault(AttributeCollection $attributes)
    {
        switch ($attributes->getAttributeValue('relation_type')) {
            case 'BelongsToMany':
            case 'HasMany':
            case 'HasManyThrough':
            case 'HasOneOrMany':
            case 'MorphMany':
            case 'MorphOneOrMany':
            case 'MorphToMany':
                return true;
            default:
                return false;
        }

        return false;
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}
    }

    public static function getValidationRules(): array
    {
        return ['nullable|string'];
    }

    public static function getAttributeName(): string
    {
        return 'relation_type';
    }
}


1			<?php
2
3			namespace Backpack\CRUD\app\Library\Components\Attributes;
4
5			use Backpack\CRUD\app\Library\Components\AttributeCollection;
6			use Backpack\CRUD\app\Library\Components\Interfaces\AttributeInterface;
7
8			class MultipleAttribute extends BaseAttribute implements AttributeInterface
9			{
10			public static function getDefault(AttributeCollection $attributes)
11			{
12			switch ($attributes->getAttributeValue('relation_type')) {
13			case 'BelongsToMany':
14			case 'HasMany':
15			case 'HasManyThrough':
16			case 'HasOneOrMany':
17			case 'MorphMany':
18			case 'MorphOneOrMany':
19			case 'MorphToMany':
20			return true;
21			default:
22			return false;
23			}
24
25			return false;
			0 ignored issues – show Unused Code introduced 2022-12-20 13:11 UTC by Report Bug Copy Issue Report `return false` is not reachable. This check looks for unreachable code. It uses sophisticated control flow analysis techniques to find statements which will never be executed. Unreachable code is most often the result of `return`, `die` or `exit` statements that have been added for debug purposes. function fx() { try { doSomething(); return true; } catch (\Exception $e) { return false; } return false; } In the above example, the last `return false` will never be executed, because a return statement has already been met in every possible execution path. Loading history...
26			}
27
28			public static function getValidationRules(): array
29			{
30			return ['nullable\|string'];
31			}
32
33			public static function getAttributeName(): string
34			{
35			return 'relation_type';
36			}
37			}
38

Laravel-Backpack / CRUD

Scrutinizer GitHub App not installed

Pull Request — main (#4854)

MultipleAttribute A

Complexity

Size/Duplication

Importance

3 Methods

Duplication Side-by-Side

Filter issues like