Backpack\CRUD\app\Library\Uploaders\Validation\ValidUploadMultiple::validate()

Complexity

Conditions	12
Paths	31

Size

Total Lines	58
Code Lines	32

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	1	Features	0

<?php
    public function validate(string $attribute, mixed $value, Closure $fail): void
    {
        if (! is_array($value)) {
            try {
                $value = json_decode($value, true);
            } catch(\Exception $e) {
                $fail('Unable to determine the value type');

                return;
            }
        }
        // `upload_multiple` sends [[0 => null]] (null after `ConvertEmptyStringsToNull`) when nothing changes on the field
        // for that reason we need to manually check what we are getting from the request
        if (CrudPanelFacade::getCurrentEntry() !== false) {

The method getCurrentEntry() does not exist on Backpack\CRUD\app\Library\CrudPanel\CrudPanelFacade. Since you implemented __callStatic, consider adding a @method annotation.

            $filesToClear = CrudPanelFacade::getRequest()->input('clear_'.$attribute) ?? [];

The method getRequest() does not exist on Backpack\CRUD\app\Library\CrudPanel\CrudPanelFacade. Since you implemented __callStatic, consider adding a @method annotation.

            $previousFiles = CrudPanelFacade::getCurrentEntry()->{$attribute} ?? [];

            if (is_string($previousFiles) && ! isset(CrudPanelFacade::getCurrentEntry()->getCasts()[$attribute])) {
                $previousFiles = json_decode($previousFiles, true);
            }

            $previousFilesWithoutCleared[$attribute] = array_diff($previousFiles, $filesToClear);

$previousFilesWithoutCleared was never initialized. Although not strictly required by PHP, it is generally a good practice to add $previousFilesWithoutCleared = array(); before regardless.

            // we are only going to check if the deleted files could break the validation rules
            if (count($value) === 1 && empty($value[0])) {
                $validator = Validator::make($previousFilesWithoutCleared, [
                    $attribute => $this->arrayRules,
                ], $this->validator->customMessages, $this->validator->customAttributes);

Accessing customMessages on the interface Illuminate\Contracts\Validation\Validator suggest that you code against a concrete implementation. How about adding an instanceof check?

Accessing customAttributes on the interface Illuminate\Contracts\Validation\Validator suggest that you code against a concrete implementation. How about adding an instanceof check?

                if ($validator->fails()) {
                    $fail($validator->errors()->first($attribute));
                }

                return;
            }

            // we are now going to check if the previous files - deleted files + new files still pass the validation
            $previousFilesWithoutClearedPlusNewFiles[$attribute] = array_merge($previousFilesWithoutCleared[$attribute], $value);

$previousFilesWithoutClearedPlusNewFiles was never initialized. Although not strictly required by PHP, it is generally a good practice to add $previousFilesWithoutClearedPlusNewFiles = array(); before regardless.

            $validator = Validator::make($previousFilesWithoutClearedPlusNewFiles, [
                $attribute => $this->arrayRules,
            ], $this->validator->customMessages, $this->validator->customAttributes);

            if ($validator->fails()) {
                $fail($validator->errors()->first($attribute));

                return;
            }
        }

        // we are now going to perform the file validation on the actual files
        foreach ($value as $file) {
            $validator = Validator::make([$attribute => $file], [
                $attribute => $this->fileRules,
            ], $this->validator->customMessages, $this->validator->customAttributes);

            if ($validator->fails()) {
                $fail($validator->errors()->first($attribute));
            }