Laravel-Backpack / CRUD

src/app/Http/Controllers/CrudFeatures/Revisions.php

Spacing +1 added lines, -1 removed lines

@@ -41,7 +41,7 @@
         $this->crud->hasAccessOrFail('revisions');
 
         $revisionId = \Request::input('revision_id', false);
-        if (! $revisionId) {
+        if (!$revisionId) {
             abort(500, 'Can\'t restore revision without revision_id');
         } else {
             $this->crud->restoreRevision($id, $revisionId); // do the update

src/app/Http/Controllers/CrudController.php

Unused Use Statements +5 added lines, -7 removed lines

@@ -3,19 +3,17 @@
 namespace Backpack\CRUD\app\Http\Controllers;
 
 use Backpack\CRUD\CrudPanel;
-use Illuminate\Http\Request;
-use Illuminate\Support\Facades\Form as Form;
+use Backpack\CRUD\app\Http\Controllers\CrudFeatures\AjaxTable;
+use Backpack\CRUD\app\Http\Controllers\CrudFeatures\Reorder;
 use Illuminate\Foundation\Bus\DispatchesJobs;
-use Illuminate\Routing\Controller as BaseController;
 use Illuminate\Foundation\Validation\ValidatesRequests;
-use Backpack\CRUD\app\Http\Controllers\CrudFeatures\Reorder;
-use Backpack\CRUD\app\Http\Controllers\CrudFeatures\AjaxTable;
+use Illuminate\Http\Request;
+use Illuminate\Routing\Controller as BaseController;
 // CRUD Traits for non-core features
 use Backpack\CRUD\app\Http\Controllers\CrudFeatures\Revisions;
 use Backpack\CRUD\app\Http\Controllers\CrudFeatures\SaveActions;
-use Backpack\CRUD\app\Http\Requests\CrudRequest as StoreRequest;
-use Backpack\CRUD\app\Http\Requests\CrudRequest as UpdateRequest;
 use Backpack\CRUD\app\Http\Controllers\CrudFeatures\ShowDetailsRow;
+use Backpack\CRUD\app\Http\Requests\CrudRequest as UpdateRequest;
 
 class CrudController extends BaseController
 {

Spacing +2 added lines, -2 removed lines

@@ -33,12 +33,12 @@
 
     public function __construct()
     {
-        if (! $this->crud) {
+        if (!$this->crud) {
             $this->crud = app()->make(CrudPanel::class);
 
             // call the setup function inside this closure to also have the request there
             // this way, developers can use things stored in session (auth variables, etc)
-            $this->middleware(function ($request, $next) {
+            $this->middleware(function($request, $next) {
                 $this->request = $request;
                 $this->crud->request = $request;
                 $this->setup();

src/CrudServiceProvider.php

Unused Use Statements -1 removed lines

@@ -2,7 +2,6 @@
 
 namespace Backpack\CRUD;
 
-use Route;
 use Illuminate\Support\ServiceProvider;
 
 class CrudServiceProvider extends ServiceProvider

Spacing +3 added lines, -3 removed lines

@@ -74,7 +74,7 @@ 
      */
     public function register()
     {
-        $this->app->bind('CRUD', function ($app) {
+        $this->app->bind('CRUD', function($app) {
             return new CRUD($app);
         });
 
@@ -92,7 +92,7 @@ 
         $loader->alias('Image', \Intervention\Image\Facades\Image::class);
 
         // map the elfinder prefix
-        if (! \Config::get('elfinder.route.prefix')) {
+        if (!\Config::get('elfinder.route.prefix')) {
             \Config::set('elfinder.route.prefix', \Config::get('backpack.base.route_prefix').'/elfinder');
         }
     }
@@ -112,7 +112,7 @@ 
     {
         $crudPubPath = public_path('vendor/backpack/crud');
 
-        if (! is_dir($crudPubPath)) {
+        if (!is_dir($crudPubPath)) {
             return true;
         }
 

src/resources/views/fields/checklist_dependency.blade.php

Indentation +4 added lines, -4 removed lines

@@ -23,13 +23,13 @@
             }
         }
 
-      //for update form, get initial state of the entity
-      if( isset($id) && $id ){
+        //for update form, get initial state of the entity
+        if( isset($id) && $id ){
 
         //get entity with relations for primary dependency
         $entity_dependencies = $entity_model->with($primary_dependency['entity'])
-          ->with($primary_dependency['entity'].'.'.$primary_dependency['entity_secondary'])
-          ->find($id);
+            ->with($primary_dependency['entity'].'.'.$primary_dependency['entity_secondary'])
+            ->find($id);
 
             $secondaries_from_primary = [];
 

Spacing +1 added lines, -1 removed lines

@@ -24,7 +24,7 @@
         }
 
       //for update form, get initial state of the entity
-      if( isset($id) && $id ){
+      if (isset($id) && $id) {
 
         //get entity with relations for primary dependency
         $entity_dependencies = $entity_model->with($primary_dependency['entity'])

src/PanelTraits/Tabs.php

Spacing +7 added lines, -7 removed lines

@@ -29,7 +29,7 @@ 
 
     public function tabsDisabled()
     {
-        return ! $this->tabsEnabled;
+        return !$this->tabsEnabled;
     }
 
     public function setTabsType($type)
@@ -91,8 +91,8 @@ 
     {
         $all_fields = $this->getCurrentFields();
 
-        $fields_without_a_tab = collect($all_fields)->filter(function ($value, $key) {
-            return ! isset($value['tab']);
+        $fields_without_a_tab = collect($all_fields)->filter(function($value, $key) {
+            return !isset($value['tab']);
         });
 
         return $fields_without_a_tab;
@@ -103,7 +103,7 @@ 
         if ($this->tabExists($label)) {
             $all_fields = $this->getCurrentFields();
 
-            $fields_for_current_tab = collect($all_fields)->filter(function ($value, $key) use ($label) {
+            $fields_for_current_tab = collect($all_fields)->filter(function($value, $key) use ($label) {
                 return isset($value['tab']) && $value['tab'] == $label;
             });
 
@@ -119,11 +119,11 @@ 
         $fields = $this->getCurrentFields();
 
         $fields_with_tabs = collect($fields)
-            ->filter(function ($value, $key) {
+            ->filter(function($value, $key) {
                 return isset($value['tab']);
             })
-            ->each(function ($value, $key) use (&$tabs) {
-                if (! in_array($value['tab'], $tabs)) {
+            ->each(function($value, $key) use (&$tabs) {
+                if (!in_array($value['tab'], $tabs)) {
                     $tabs[] = $value['tab'];
                 }
             });

Doc Comments +3 added lines

@@ -22,6 +22,9 @@
         return $this->tabsEnabled;
     }
 
+    /**
+     * @return boolean
+     */
     public function tabsEnabled()
     {
         return $this->tabsEnabled;

src/resources/lang/pt/crud.php

Indentation +1 added lines, -1 removed lines

@@ -65,7 +65,7 @@
     'delete_confirmation_not_deleted_title'       => 'Não apagado',
     'delete_confirmation_not_deleted_message'     => 'Está tudo bem!. O item não foi apagado.',
 
-     // DataTables translation
+        // DataTables translation
     'emptyTable'     => 'Sem dados disponíveis na tabela',
     'info'           => 'A mostrar _START_ a _END_ de _TOTAL_ registos',
     'infoEmpty'      => 'A mostrar 0 a 0 de 0 registos',

src/CrudPanel.php

Spacing +8 added lines, -8 removed lines

@@ -84,7 +84,7 @@ 
      */
     public function setModel($model_namespace)
     {
-        if (! class_exists($model_namespace)) {
+        if (!class_exists($model_namespace)) {
             throw new \Exception('This model does not exist.', 404);
         }
 
@@ -125,7 +125,7 @@ 
     {
         $complete_route = $route.'.index';
 
-        if (! \Route::has($complete_route)) {
+        if (!\Route::has($complete_route)) {
             throw new \Exception('There are no routes for this route name.', 404);
         }
 
@@ -175,7 +175,7 @@ 
      */
     public function getFirstOfItsTypeInArray($type, $array)
     {
-        return array_first($array, function ($item) use ($type) {
+        return array_first($array, function($item) use ($type) {
             return $item['type'] == $type;
         });
     }
@@ -192,8 +192,8 @@ 
 
     public function sync($type, $fields, $attributes)
     {
-        if (! empty($this->{$type})) {
-            $this->{$type} = array_map(function ($field) use ($fields, $attributes) {
+        if (!empty($this->{$type})) {
+            $this->{$type} = array_map(function($field) use ($fields, $attributes) {
                 if (in_array($field['name'], (array) $fields)) {
                     $field = array_merge($field, $attributes);
                 }
@@ -219,8 +219,8 @@ 
                 }
             }
 
-            return $this->{$items} = array_merge($elements, array_filter($this->{$items}, function ($item) use ($items) {
-                return ! in_array($item['name'], $this->sort[$items]);
+            return $this->{$items} = array_merge($elements, array_filter($this->{$items}, function($item) use ($items) {
+                return !in_array($item['name'], $this->sort[$items]);
             }));
         }
 
@@ -243,7 +243,7 @@ 
      */
     private function getRelationModel($relationString)
     {
-        $result = array_reduce(explode('.', $relationString), function ($obj, $method) {
+        $result = array_reduce(explode('.', $relationString), function($obj, $method) {
             return $obj->$method()->getRelated();
         }, $this->model);
 

Doc Comments +1 added lines

@@ -123,6 +123,7 @@
      *
      * @param [string] Route name.
      * @param [array] Parameters.
+     * @param string $route
      */
     public function setRouteName($route, $parameters = [])
     {

Unused Use Statements +12 added lines, -12 removed lines

@@ -2,25 +2,25 @@
 
 namespace Backpack\CRUD;
 
-use Backpack\CRUD\PanelTraits\Read;
-use Backpack\CRUD\PanelTraits\Tabs;
-use Backpack\CRUD\PanelTraits\Query;
-use Backpack\CRUD\PanelTraits\Views;
 use Backpack\CRUD\PanelTraits\Access;
+use Backpack\CRUD\PanelTraits\AutoFocus;
+use Backpack\CRUD\PanelTraits\AutoSet;
+use Backpack\CRUD\PanelTraits\Buttons;
+use Backpack\CRUD\PanelTraits\Columns;
 use Backpack\CRUD\PanelTraits\Create;
 use Backpack\CRUD\PanelTraits\Delete;
 use Backpack\CRUD\PanelTraits\Errors;
+use Backpack\CRUD\PanelTraits\FakeColumns;
+use Backpack\CRUD\PanelTraits\FakeFields;
 use Backpack\CRUD\PanelTraits\Fields;
-use Backpack\CRUD\PanelTraits\Search;
-use Backpack\CRUD\PanelTraits\Update;
-use Backpack\CRUD\PanelTraits\AutoSet;
-use Backpack\CRUD\PanelTraits\Buttons;
-use Backpack\CRUD\PanelTraits\Columns;
 use Backpack\CRUD\PanelTraits\Filters;
+use Backpack\CRUD\PanelTraits\Query;
+use Backpack\CRUD\PanelTraits\Read;
 use Backpack\CRUD\PanelTraits\Reorder;
-use Backpack\CRUD\PanelTraits\AutoFocus;
-use Backpack\CRUD\PanelTraits\FakeFields;
-use Backpack\CRUD\PanelTraits\FakeColumns;
+use Backpack\CRUD\PanelTraits\Search;
+use Backpack\CRUD\PanelTraits\Tabs;
+use Backpack\CRUD\PanelTraits\Update;
+use Backpack\CRUD\PanelTraits\Views;
 use Backpack\CRUD\PanelTraits\ViewsAndRestoresRevisions;
 
 class CrudPanel

src/PanelTraits/FakeColumns.php

Spacing +3 added lines, -3 removed lines

@@ -24,19 +24,19 @@
             if (isset($field['fake']) && $field['fake'] == true) {
                 // add it to the request in its appropriate variable - the one defined, if defined
                 if (isset($field['store_in'])) {
-                    if (! in_array($field['store_in'], $fakeFieldsColumnsArray, true)) {
+                    if (!in_array($field['store_in'], $fakeFieldsColumnsArray, true)) {
                         array_push($fakeFieldsColumnsArray, $field['store_in']);
                     }
                 } else {
                     //otherwise in the one defined in the $crud variable
-                    if (! in_array('extras', $fakeFieldsColumnsArray, true)) {
+                    if (!in_array('extras', $fakeFieldsColumnsArray, true)) {
                         array_push($fakeFieldsColumnsArray, 'extras');
                     }
                 }
             }
         }
 
-        if (! count($fakeFieldsColumnsArray)) {
+        if (!count($fakeFieldsColumnsArray)) {
             $fakeFieldsColumnsArray = ['extras'];
         }
 

Doc Comments +1 added lines, -1 removed lines

@@ -9,7 +9,7 @@
      * been found.
      *
      * @param string $form The CRUD form. Can be 'create', 'update' or 'both'. Default is 'create'.
-     * @param int|bool $id Optional entity ID needed in the case of the update form.
+     * @param integer $id Optional entity ID needed in the case of the update form.
      * @return array The fake columns array.
      */
     public function getFakeColumnsAsArray($form = 'create', $id = false)

src/PanelTraits/Buttons.php

Spacing +3 added lines, -3 removed lines

@@ -94,7 +94,7 @@ 
      */
     public function removeButton($name, $stack = null)
     {
-        $this->buttons = $this->buttons->reject(function ($button) use ($name, $stack) {
+        $this->buttons = $this->buttons->reject(function($button) use ($name, $stack) {
             return $stack == null ? $button->name == $name : ($button->stack == $stack) && ($button->name == $name);
         });
     }
@@ -106,14 +106,14 @@ 
 
     public function removeAllButtonsFromStack($stack)
     {
-        $this->buttons = $this->buttons->reject(function ($button) use ($stack) {
+        $this->buttons = $this->buttons->reject(function($button) use ($stack) {
             return $button->stack == $stack;
         });
     }
 
     public function removeButtonFromStack($name, $stack)
     {
-        $this->buttons = $this->buttons->reject(function ($button) use ($name, $stack) {
+        $this->buttons = $this->buttons->reject(function($button) use ($name, $stack) {
             return $button->name == $name && $button->stack == $stack;
         });
     }

Doc Comments +12 added lines

@@ -59,6 +59,9 @@ 
         $this->addButton($stack, $name, 'model_function', $model_function_name, $position);
     }
 
+    /**
+     * @param string $view
+     */
     public function addButtonFromView($stack, $name, $view, $position = false)
     {
         $view = 'vendor.backpack.crud.buttons.'.$view;
@@ -104,6 +107,9 @@ 
         $this->buttons = collect([]);
     }
 
+    /**
+     * @param string $stack
+     */
     public function removeAllButtonsFromStack($stack)
     {
         $this->buttons = $this->buttons->reject(function ($button) use ($stack) {
@@ -126,6 +132,12 @@ 
     public $type = 'view';
     public $content;
 
+    /**
+     * @param string $stack
+     * @param string $name
+     * @param string $type
+     * @param string $content
+     */
     public function __construct($stack, $name, $type, $content)
     {
         $this->stack = $stack;