Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Passed
Pull Request — master (#3826)
by
unknown
15:58
created
src/app/Library/CrudPanel/Traits/Read.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -56,7 +56,7 @@  discard block
 block discarded – undo
56 56
      */
57 57
     public function getEntry($id)
58 58
     {
59
-        if (! $this->entry) {
59
+        if (!$this->entry) {
60 60
             $this->entry = $this->model->findOrFail($id);
61 61
             $this->entry = $this->entry->withFakes();
62 62
         }
@@ -258,7 +258,7 @@  discard block
 block discarded – undo
258 258
                 // we will apply the same labels as the values to the menu if developer didn't
259 259
                 $this->abortIfInvalidPageLength($menu[0]);
260 260
 
261
-                if (! isset($menu[1]) || ! is_array($menu[1])) {
261
+                if (!isset($menu[1]) || !is_array($menu[1])) {
262 262
                     $menu[1] = $menu[0];
263 263
                 }
264 264
             } else {
Please login to merge, or discard this patch.
src/app/Http/Controllers/Operations/ListOperation.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -41,7 +41,7 @@  discard block
 block discarded – undo
41 41
     {
42 42
         $this->crud->allowAccess('list');
43 43
 
44
-        $this->crud->operation('list', function () {
44
+        $this->crud->operation('list', function() {
45 45
             $this->crud->loadDefaultOperationSettingsFromConfig();
46 46
         });
47 47
     }
@@ -99,7 +99,7 @@  discard block
 block discarded – undo
99 99
                 $column_number = (int) $order['column'];
100 100
                 $column_direction = (strtolower((string) $order['dir']) == 'asc' ? 'ASC' : 'DESC');
101 101
                 $column = $this->crud->findColumnById($column_number);
102
-                if ($column['tableColumn'] && ! isset($column['orderLogic'])) {
102
+                if ($column['tableColumn'] && !isset($column['orderLogic'])) {
103 103
                     // apply the current orderBy rules
104 104
                     $this->crud->orderByWithPrefix($column['name'], $column_direction);
105 105
                 }
@@ -119,12 +119,12 @@  discard block
 block discarded – undo
119 119
         $table = $this->crud->model->getTable();
120 120
         $key = $this->crud->model->getKeyName();
121 121
 
122
-        $hasOrderByPrimaryKey = collect($orderBy)->some(function ($item) use ($key, $table) {
122
+        $hasOrderByPrimaryKey = collect($orderBy)->some(function($item) use ($key, $table) {
123 123
             return (isset($item['column']) && $item['column'] === $key)
124 124
                 || (isset($item['sql']) && str_contains($item['sql'], "$table.$key"));
125 125
         });
126 126
 
127
-        if (! $hasOrderByPrimaryKey) {
127
+        if (!$hasOrderByPrimaryKey) {
128 128
             $this->crud->orderByWithPrefix($this->crud->model->getKeyName(), 'DESC');
129 129
         }
130 130
 
Please login to merge, or discard this patch.
src/app/Console/Commands/AddCustomRouteContent.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -83,7 +83,7 @@  discard block
 block discarded – undo
83 83
 
84 84
         // otherwise, in case the last line HAS been modified
85 85
         // return the last line that has an ending in it
86
-        $possible_end_lines = array_filter($file_lines, function ($k) {
86
+        $possible_end_lines = array_filter($file_lines, function($k) {
87 87
             return strpos($k, '});') === 0;
88 88
         });
89 89
 
@@ -104,7 +104,7 @@  discard block
 block discarded – undo
104 104
      */
105 105
     private function getLastLineNumberThatContains($needle, $haystack)
106 106
     {
107
-        $matchingLines = array_filter($haystack, function ($k) use ($needle) {
107
+        $matchingLines = array_filter($haystack, function($k) use ($needle) {
108 108
             return strpos($k, $needle) !== false;
109 109
         });
110 110
 
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Relationships.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -55,7 +55,7 @@  discard block
 block discarded – undo
55 55
         $relation_model = $this->getRelationModel($relation_field['entity'], -1);
56 56
         $related_method = Str::afterLast($relation_field['entity'], '.');
57 57
 
58
-        if (! method_exists($relation_model, $related_method)) {
58
+        if (!method_exists($relation_model, $related_method)) {
59 59
             return Str::beforeLast($relation_field['entity'], '.');
60 60
         }
61 61
 
@@ -194,7 +194,7 @@  discard block
 block discarded – undo
194 194
         return collect($this->fields())
195 195
             ->where('model')
196 196
             ->whereIn('relation_type', $relation_types)
197
-            ->filter(function ($item) {
197
+            ->filter(function($item) {
198 198
                 $related_model = get_class($this->model->{Str::before($item['entity'], '.')}()->getRelated());
199 199
 
200 200
                 return Str::contains($item['entity'], '.') && $item['model'] !== $related_model ? false : true;
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/FieldsProtectedMethods.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -69,7 +69,7 @@  discard block
 block discarded – undo
69 69
      */
70 70
     public function overwriteFieldNameFromDotNotationToArray($field)
71 71
     {
72
-        if (! is_array($field['name']) && strpos($field['name'], '.') !== false) {
72
+        if (!is_array($field['name']) && strpos($field['name'], '.') !== false) {
73 73
             $entity_array = explode('.', $field['name']);
74 74
             $name_string = '';
75 75
 
@@ -96,7 +96,7 @@  discard block
 block discarded – undo
96 96
             return ['name' => $field];
97 97
         }
98 98
 
99
-        if (is_array($field) && ! isset($field['name'])) {
99
+        if (is_array($field) && !isset($field['name'])) {
100 100
             abort(500, 'All fields must have their name defined');
101 101
         }
102 102
 
@@ -154,7 +154,7 @@  discard block
 block discarded – undo
154 154
     protected function overwriteFieldNameFromEntity($field)
155 155
     {
156 156
         // if the entity doesn't have a dot, it means we don't need to overwrite the name
157
-        if (! Str::contains($field['entity'], '.')) {
157
+        if (!Str::contains($field['entity'], '.')) {
158 158
             return $field;
159 159
         }
160 160
 
@@ -166,7 +166,7 @@  discard block
 block discarded – undo
166 166
         if (count(explode('.', $field['entity'])) == count(explode('.', $this->getOnlyRelationEntity($field)))) {
167 167
             $field['name'] = implode('.', array_slice(explode('.', $field['entity']), 0, -1));
168 168
             $relation = $this->getRelationInstance($field);
169
-            if (! empty($field['name'])) {
169
+            if (!empty($field['name'])) {
170 170
                 $field['name'] .= '.';
171 171
             }
172 172
             $field['name'] .= $relation->getForeignKeyName();
@@ -179,7 +179,7 @@  discard block
 block discarded – undo
179 179
     {
180 180
         // if there's a model defined, but no attribute
181 181
         // guess an attribute using the identifiableAttribute functionality in CrudTrait
182
-        if (isset($field['model']) && ! isset($field['attribute']) && method_exists($field['model'], 'identifiableAttribute')) {
182
+        if (isset($field['model']) && !isset($field['attribute']) && method_exists($field['model'], 'identifiableAttribute')) {
183 183
             $field['attribute'] = call_user_func([(new $field['model']), 'identifiableAttribute']);
184 184
         }
185 185
 
@@ -195,7 +195,7 @@  discard block
 block discarded – undo
195 195
      */
196 196
     protected function makeSureFieldHasLabel($field)
197 197
     {
198
-        if (! isset($field['label'])) {
198
+        if (!isset($field['label'])) {
199 199
             $name = is_array($field['name']) ? $field['name'][0] : $field['name'];
200 200
             $name = str_replace('_id', '', $name);
201 201
             $field['label'] = mb_ucfirst(str_replace('_', ' ', $name));
@@ -213,7 +213,7 @@  discard block
 block discarded – undo
213 213
      */
214 214
     protected function makeSureFieldHasType($field)
215 215
     {
216
-        if (! isset($field['type'])) {
216
+        if (!isset($field['type'])) {
217 217
             $field['type'] = isset($field['relation_type']) ? $this->inferFieldTypeFromFieldRelation($field) : $this->inferFieldTypeFromDbColumnType($field['name']);
218 218
         }
219 219
 
@@ -230,7 +230,7 @@  discard block
 block discarded – undo
230 230
     {
231 231
         // if a tab was mentioned, we should enable it
232 232
         if (isset($field['tab'])) {
233
-            if (! $this->tabsEnabled()) {
233
+            if (!$this->tabsEnabled()) {
234 234
                 $this->enableTabs();
235 235
             }
236 236
         }
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Create.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -85,7 +85,7 @@  discard block
 block discarded – undo
85 85
     {
86 86
         $all_relation_fields = $this->getRelationFields();
87 87
 
88
-        return Arr::where($all_relation_fields, function ($value, $key) {
88
+        return Arr::where($all_relation_fields, function($value, $key) {
89 89
             return isset($value['pivot']) && $value['pivot'];
90 90
         });
91 91
     }
@@ -164,11 +164,11 @@  discard block
 block discarded – undo
164 164
      */
165 165
     private function createRelationsForItem($item, $formattedData)
166 166
     {
167
-        if (! isset($formattedData['relations'])) {
167
+        if (!isset($formattedData['relations'])) {
168 168
             return false;
169 169
         }
170 170
         foreach ($formattedData['relations'] as $relationMethod => $relationData) {
171
-            if (! isset($relationData['model'])) {
171
+            if (!isset($relationData['model'])) {
172 172
                 continue;
173 173
             }
174 174
             $model = $relationData['model'];
@@ -222,13 +222,13 @@  discard block
 block discarded – undo
222 222
         foreach ($relation_fields as $relation_field) {
223 223
             $attributeKey = $this->parseRelationFieldNamesFromHtml([$relation_field])[0]['name'];
224 224
 
225
-            if (! is_null(Arr::get($data, $attributeKey)) && isset($relation_field['pivot']) && $relation_field['pivot'] !== true) {
225
+            if (!is_null(Arr::get($data, $attributeKey)) && isset($relation_field['pivot']) && $relation_field['pivot'] !== true) {
226 226
                 $key = implode('.relations.', explode('.', $this->getOnlyRelationEntity($relation_field)));
227 227
                 $fieldData = Arr::get($relationData, 'relations.'.$key, []);
228
-                if (! array_key_exists('model', $fieldData)) {
228
+                if (!array_key_exists('model', $fieldData)) {
229 229
                     $fieldData['model'] = $relation_field['model'];
230 230
                 }
231
-                if (! array_key_exists('parent', $fieldData)) {
231
+                if (!array_key_exists('parent', $fieldData)) {
232 232
                     $fieldData['parent'] = $this->getRelationModel($attributeKey, -1);
233 233
                 }
234 234
                 $relatedAttribute = Arr::last(explode('.', $attributeKey));
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/ColumnsProtectedMethods.php 1 patch
Spacing   +12 added lines, -13 removed lines patch added patch discarded remove patch
@@ -49,7 +49,7 @@  discard block
 block discarded – undo
49 49
             $column = ['name' => $column];
50 50
         }
51 51
 
52
-        if (is_array($column) && ! isset($column['name'])) {
52
+        if (is_array($column) && !isset($column['name'])) {
53 53
             $column['name'] = 'anonymous_column_'.Str::random(5);
54 54
         }
55 55
 
@@ -65,7 +65,7 @@  discard block
 block discarded – undo
65 65
      */
66 66
     protected function makeSureColumnHasLabel($column)
67 67
     {
68
-        if (! isset($column['label'])) {
68
+        if (!isset($column['label'])) {
69 69
             $column['label'] = mb_ucfirst($this->makeLabel($column['name']));
70 70
         }
71 71
 
@@ -82,11 +82,11 @@  discard block
 block discarded – undo
82 82
     {
83 83
         $could_be_relation = isset($column['entity']) && $column['entity'] !== false;
84 84
 
85
-        if (! isset($column['type']) && $could_be_relation) {
85
+        if (!isset($column['type']) && $could_be_relation) {
86 86
             $column['type'] = 'relationship';
87 87
         }
88 88
 
89
-        if (! isset($column['type'])) {
89
+        if (!isset($column['type'])) {
90 90
             $column['type'] = 'text';
91 91
         }
92 92
 
@@ -103,7 +103,7 @@  discard block
 block discarded – undo
103 103
      */
104 104
     protected function makeSureColumnHasKey($column)
105 105
     {
106
-        if (! isset($column['key'])) {
106
+        if (!isset($column['key'])) {
107 107
             $column['key'] = str_replace('.', '__', $column['name']);
108 108
         }
109 109
 
@@ -121,7 +121,7 @@  discard block
 block discarded – undo
121 121
      */
122 122
     protected function makeSureColumnHasWrapper($column)
123 123
     {
124
-        if (! isset($column['wrapper'])) {
124
+        if (!isset($column['wrapper'])) {
125 125
             $column['wrapper'] = [];
126 126
         }
127 127
 
@@ -146,7 +146,7 @@  discard block
 block discarded – undo
146 146
             // if the first part of the string exists as method,
147 147
             // it is a relationship
148 148
             if (method_exists($this->model, $possibleMethodName)) {
149
-                if (! $this->makeSureMethodDoesNotRequireParameters($this->model, $possibleMethodName)) {
149
+                if (!$this->makeSureMethodDoesNotRequireParameters($this->model, $possibleMethodName)) {
150 150
                     $column['entity'] = false;
151 151
                 }
152 152
                 $column['entity'] = isset($column['entity']) ? $column['entity'] : $column['name'];
@@ -157,7 +157,7 @@  discard block
 block discarded – undo
157 157
 
158 158
         // if there's a method on the model with this name
159 159
         if (method_exists($this->model, $column['name'])) {
160
-            if (! $this->makeSureMethodDoesNotRequireParameters($this->model, $column['name'])) {
160
+            if (!$this->makeSureMethodDoesNotRequireParameters($this->model, $column['name'])) {
161 161
                 $column['entity'] = false;
162 162
             }
163 163
             $column['entity'] = isset($column['entity']) ? $column['entity'] : $column['name'];
@@ -171,7 +171,7 @@  discard block
 block discarded – undo
171 171
             $possibleMethodName = Str::replaceLast('_id', '', $column['name']);
172 172
 
173 173
             if (method_exists($this->model, $possibleMethodName)) {
174
-                if (! $this->makeSureMethodDoesNotRequireParameters($this->model, $possibleMethodName)) {
174
+                if (!$this->makeSureMethodDoesNotRequireParameters($this->model, $possibleMethodName)) {
175 175
                     $column['entity'] = false;
176 176
                 }
177 177
 
@@ -213,7 +213,7 @@  discard block
 block discarded – undo
213 213
     {
214 214
         // if this is a relation type field and no corresponding model was specified,
215 215
         // get it from the relation method defined in the main model
216
-        if (isset($column['entity']) && $column['entity'] !== false && ! isset($column['model'])) {
216
+        if (isset($column['entity']) && $column['entity'] !== false && !isset($column['model'])) {
217 217
             $column['model'] = $this->getRelationModel($column['entity']);
218 218
         }
219 219
 
@@ -234,8 +234,7 @@  discard block
 block discarded – undo
234 234
         $columnsArray = $this->columns();
235 235
 
236 236
         if (array_key_exists($targetColumnName, $columnsArray)) {
237
-            $targetColumnPosition = $before ? array_search($targetColumnName, array_keys($columnsArray)) :
238
-                array_search($targetColumnName, array_keys($columnsArray)) + 1;
237
+            $targetColumnPosition = $before ? array_search($targetColumnName, array_keys($columnsArray)) : array_search($targetColumnName, array_keys($columnsArray)) + 1;
239 238
 
240 239
             $element = array_pop($columnsArray);
241 240
             $beginningPart = array_slice($columnsArray, 0, $targetColumnPosition, true);
@@ -258,7 +257,7 @@  discard block
 block discarded – undo
258 257
     {
259 258
         static $cache = [];
260 259
 
261
-        if (! $this->driverIsSql()) {
260
+        if (!$this->driverIsSql()) {
262 261
             return true;
263 262
         }
264 263
 
Please login to merge, or discard this patch.