Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Passed
Push — master ( 239e60...69a3cf )
by Cristian
01:51 queued 13s
created
tests/Unit/CrudPanel/BaseCrudPanelTest.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -24,7 +24,7 @@
 block discarded – undo
24 24
     {
25 25
         parent::setUp();
26 26
 
27
-        $this->app->singleton('crud', function ($app) {
27
+        $this->app->singleton('crud', function($app) {
28 28
             return new CrudPanel($app);
29 29
         });
30 30
         $this->crudPanel = app('crud');
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/CrudFilter.php 2 patches
Braces   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -389,10 +389,12 @@
 block discarded – undo
389 389
         return $this->fallbackLogic($value);
390 390
     }
391 391
 
392
-    public function else($value)
392
+    public function else {
393
+        ($value)
393 394
     {
394 395
         return $this->fallbackLogic($value);
395 396
     }
397
+    }
396 398
 
397 399
     // ---------------
398 400
     // PRIVATE METHODS
Please login to merge, or discard this patch.
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -84,7 +84,7 @@  discard block
 block discarded – undo
84 84
      */
85 85
     public function wasNotApplied()
86 86
     {
87
-        return ! $this->applied;
87
+        return !$this->applied;
88 88
     }
89 89
 
90 90
     /**
@@ -105,7 +105,7 @@  discard block
 block discarded – undo
105 105
 
106 106
         $input = $input ?? new ParameterBag($this->crud()->getRequest()->all());
107 107
 
108
-        if (! $input->has($this->name)) {
108
+        if (!$input->has($this->name)) {
109 109
             // if fallback logic was supplied and is a closure
110 110
             if (is_callable($this->fallbackLogic)) {
111 111
                 return ($this->fallbackLogic)();
@@ -285,7 +285,7 @@  discard block
 block discarded – undo
285 285
      */
286 286
     public function values($value)
287 287
     {
288
-        $this->values = (! is_string($value) && is_callable($value)) ? $value() : $value;
288
+        $this->values = (!is_string($value) && is_callable($value)) ? $value() : $value;
289 289
 
290 290
         return $this->save();
291 291
     }
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Fields.php 1 patch
Spacing   +13 added lines, -13 removed lines patch added patch discarded remove patch
@@ -62,7 +62,7 @@  discard block
 block discarded – undo
62 62
      */
63 63
     public function afterField($targetFieldName)
64 64
     {
65
-        $this->transformFields(function ($fields) use ($targetFieldName) {
65
+        $this->transformFields(function($fields) use ($targetFieldName) {
66 66
             return $this->moveField($fields, $targetFieldName, false);
67 67
         });
68 68
     }
@@ -74,7 +74,7 @@  discard block
 block discarded – undo
74 74
      */
75 75
     public function beforeField($targetFieldName)
76 76
     {
77
-        $this->transformFields(function ($fields) use ($targetFieldName) {
77
+        $this->transformFields(function($fields) use ($targetFieldName) {
78 78
             return $this->moveField($fields, $targetFieldName, true);
79 79
         });
80 80
     }
@@ -86,7 +86,7 @@  discard block
 block discarded – undo
86 86
      */
87 87
     public function makeFirstField()
88 88
     {
89
-        if (! $this->fields()) {
89
+        if (!$this->fields()) {
90 90
             return false;
91 91
         }
92 92
 
@@ -101,7 +101,7 @@  discard block
 block discarded – undo
101 101
      */
102 102
     public function removeField($name)
103 103
     {
104
-        $this->transformFields(function ($fields) use ($name) {
104
+        $this->transformFields(function($fields) use ($name) {
105 105
             Arr::forget($fields, $name);
106 106
 
107 107
             return $fields;
@@ -115,7 +115,7 @@  discard block
 block discarded – undo
115 115
      */
116 116
     public function removeFields($array_of_names)
117 117
     {
118
-        if (! empty($array_of_names)) {
118
+        if (!empty($array_of_names)) {
119 119
             foreach ($array_of_names as $name) {
120 120
                 $this->removeField($name);
121 121
             }
@@ -128,7 +128,7 @@  discard block
 block discarded – undo
128 128
     public function removeAllFields()
129 129
     {
130 130
         $current_fields = $this->getCurrentFields();
131
-        if (! empty($current_fields)) {
131
+        if (!empty($current_fields)) {
132 132
             foreach ($current_fields as $field) {
133 133
                 $this->removeField($field['name']);
134 134
             }
@@ -220,7 +220,7 @@  discard block
 block discarded – undo
220 220
                 $jsonCastables = ['array', 'object', 'json'];
221 221
                 $fieldCasting = $casted_attributes[$field['name']];
222 222
 
223
-                if (in_array($fieldCasting, $jsonCastables) && isset($data[$field['name']]) && ! empty($data[$field['name']]) && ! is_array($data[$field['name']])) {
223
+                if (in_array($fieldCasting, $jsonCastables) && isset($data[$field['name']]) && !empty($data[$field['name']]) && !is_array($data[$field['name']])) {
224 224
                     try {
225 225
                         $data[$field['name']] = json_decode($data[$field['name']]);
226 226
                     } catch (\Exception $e) {
@@ -249,7 +249,7 @@  discard block
 block discarded – undo
249 249
      */
250 250
     public function orderFields($order)
251 251
     {
252
-        $this->transformFields(function ($fields) use ($order) {
252
+        $this->transformFields(function($fields) use ($order) {
253 253
             return $this->applyOrderToFields($fields, $order);
254 254
         });
255 255
     }
@@ -276,7 +276,7 @@  discard block
 block discarded – undo
276 276
     public function hasUploadFields()
277 277
     {
278 278
         $fields = $this->getFields();
279
-        $upload_fields = Arr::where($fields, function ($value, $key) {
279
+        $upload_fields = Arr::where($fields, function($value, $key) {
280 280
             return isset($value['upload']) && $value['upload'] == true;
281 281
         });
282 282
 
@@ -339,7 +339,7 @@  discard block
 block discarded – undo
339 339
         $alreadyLoaded = $this->getLoadedFieldTypes();
340 340
         $type = $this->getFieldTypeWithNamespace($field);
341 341
 
342
-        if (! in_array($type, $this->getLoadedFieldTypes(), true)) {
342
+        if (!in_array($type, $this->getLoadedFieldTypes(), true)) {
343 343
             $alreadyLoaded[] = $type;
344 344
             $this->setLoadedFieldTypes($alreadyLoaded);
345 345
 
@@ -380,7 +380,7 @@  discard block
 block discarded – undo
380 380
      */
381 381
     public function fieldTypeNotLoaded($field)
382 382
     {
383
-        return ! in_array($this->getFieldTypeWithNamespace($field), $this->getLoadedFieldTypes());
383
+        return !in_array($this->getFieldTypeWithNamespace($field), $this->getLoadedFieldTypes());
384 384
     }
385 385
 
386 386
     /**
@@ -421,7 +421,7 @@  discard block
 block discarded – undo
421 421
      */
422 422
     public function hasFieldWhere($attribute, $value)
423 423
     {
424
-        $match = Arr::first($this->fields(), function ($field, $fieldKey) use ($attribute, $value) {
424
+        $match = Arr::first($this->fields(), function($field, $fieldKey) use ($attribute, $value) {
425 425
             return isset($field[$attribute]) && $field[$attribute] == $value;
426 426
         });
427 427
 
@@ -437,7 +437,7 @@  discard block
 block discarded – undo
437 437
      */
438 438
     public function firstFieldWhere($attribute, $value)
439 439
     {
440
-        return Arr::first($this->fields(), function ($field, $fieldKey) use ($attribute, $value) {
440
+        return Arr::first($this->fields(), function($field, $fieldKey) use ($attribute, $value) {
441 441
             return isset($field[$attribute]) && $field[$attribute] == $value;
442 442
         });
443 443
     }
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Buttons.php 1 patch
Spacing   +13 added lines, -13 removed lines patch added patch discarded remove patch
@@ -25,7 +25,7 @@  discard block
 block discarded – undo
25 25
         $otherButtons = collect([]);
26 26
 
27 27
         // we get the buttons that belong to the specified stack
28
-        $stackButtons = $this->buttons()->reject(function ($item) use ($stack, $otherButtons) {
28
+        $stackButtons = $this->buttons()->reject(function($item) use ($stack, $otherButtons) {
29 29
             if ($item->stack != $stack) {
30 30
                 // if the button does not belong to this stack we just add it for merging later
31 31
                 $otherButtons->push($item);
@@ -37,8 +37,8 @@  discard block
 block discarded – undo
37 37
         });
38 38
 
39 39
         // we parse the ordered buttons
40
-        collect($order)->each(function ($btnKey) use ($newButtons, $stackButtons) {
41
-            if (! $button = $stackButtons->where('name', $btnKey)->first()) {
40
+        collect($order)->each(function($btnKey) use ($newButtons, $stackButtons) {
41
+            if (!$button = $stackButtons->where('name', $btnKey)->first()) {
42 42
                 abort(500, 'Button name [«'.$btnKey.'»] not found.');
43 43
             }
44 44
             $newButtons->push($button);
@@ -48,7 +48,7 @@  discard block
 block discarded – undo
48 48
         // we add the remaining buttons to the end of the ordered ones
49 49
         if (count($newButtons) < count($stackButtons)) {
50 50
             foreach ($stackButtons as $button) {
51
-                if (! $newButtons->where('name', $button->name)->first()) {
51
+                if (!$newButtons->where('name', $button->name)->first()) {
52 52
                     $newButtons->push($button);
53 53
                 }
54 54
             }
@@ -114,7 +114,7 @@  discard block
 block discarded – undo
114 114
          */
115 115
         $button = $this->buttons()->firstWhere('name', $name);
116 116
 
117
-        if (! $button) {
117
+        if (!$button) {
118 118
             abort(500, 'CRUD Button "'.$name.'" not found. Please check the button exists before you modify it.');
119 119
         }
120 120
 
@@ -135,7 +135,7 @@  discard block
 block discarded – undo
135 135
      */
136 136
     public function removeButton($name, $stack = null)
137 137
     {
138
-        $this->setOperationSetting('buttons', $this->buttons()->reject(function ($button) use ($name, $stack) {
138
+        $this->setOperationSetting('buttons', $this->buttons()->reject(function($button) use ($name, $stack) {
139 139
             return $stack == null ? $button->name == $name : ($button->stack == $stack) && ($button->name == $name);
140 140
         }));
141 141
     }
@@ -146,7 +146,7 @@  discard block
 block discarded – undo
146 146
      */
147 147
     public function removeButtons($names, $stack = null)
148 148
     {
149
-        if (! empty($names)) {
149
+        if (!empty($names)) {
150 150
             foreach ($names as $name) {
151 151
                 $this->removeButton($name, $stack);
152 152
             }
@@ -160,14 +160,14 @@  discard block
 block discarded – undo
160 160
 
161 161
     public function removeAllButtonsFromStack($stack)
162 162
     {
163
-        $this->setOperationSetting('buttons', $this->buttons()->reject(function ($button) use ($stack) {
163
+        $this->setOperationSetting('buttons', $this->buttons()->reject(function($button) use ($stack) {
164 164
             return $button->stack == $stack;
165 165
         }));
166 166
     }
167 167
 
168 168
     public function removeButtonFromStack($name, $stack)
169 169
     {
170
-        $this->setOperationSetting('buttons', $this->buttons()->reject(function ($button) use ($name, $stack) {
170
+        $this->setOperationSetting('buttons', $this->buttons()->reject(function($button) use ($name, $stack) {
171 171
             return $button->name == $name && $button->stack == $stack;
172 172
         }));
173 173
     }
@@ -185,15 +185,15 @@  discard block
 block discarded – undo
185 185
         $destinationButton = $this->firstButtonWhere('name', $destination);
186 186
         $destinationKey = $this->getButtonKey($destination);
187 187
         $newDestinationKey = ($where == 'before' ? $destinationKey : $destinationKey + 1);
188
-        $newButtons = $this->buttons()->filter(function ($value, $key) use ($target) {
188
+        $newButtons = $this->buttons()->filter(function($value, $key) use ($target) {
189 189
             return $value->name != $target;
190 190
         });
191 191
 
192
-        if (! $targetButton) {
192
+        if (!$targetButton) {
193 193
             return;
194 194
         }
195 195
 
196
-        if (! $destinationButton) {
196
+        if (!$destinationButton) {
197 197
             return;
198 198
         }
199 199
 
@@ -201,7 +201,7 @@  discard block
 block discarded – undo
201 201
         $lastSlice = $newButtons->slice($newDestinationKey, null);
202 202
 
203 203
         $newButtons = $firstSlice->push($targetButton);
204
-        $lastSlice->each(function ($item, $key) use ($newButtons) {
204
+        $lastSlice->each(function($item, $key) use ($newButtons) {
205 205
             $newButtons->push($item);
206 206
         });
207 207
 
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/CrudButton.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -388,7 +388,7 @@
 block discarded – undo
388 388
     {
389 389
         $itemExists = $this->collection()->contains('name', $this->name);
390 390
 
391
-        if (! $itemExists) {
391
+        if (!$itemExists) {
392 392
             if ($this->position == 'beginning') {
393 393
                 $this->collection()->prepend($this);
394 394
             } else {
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Update.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -52,7 +52,7 @@  discard block
 block discarded – undo
52 52
 
53 53
         foreach ($fields as &$field) {
54 54
             // set the value
55
-            if (! isset($field['value'])) {
55
+            if (!isset($field['value'])) {
56 56
                 if (isset($field['subfields'])) {
57 57
                     $field['value'] = [];
58 58
                     foreach ($field['subfields'] as $subfield) {
@@ -65,7 +65,7 @@  discard block
 block discarded – undo
65 65
         }
66 66
 
67 67
         // always have a hidden input for the entry id
68
-        if (! array_key_exists('id', $fields)) {
68
+        if (!array_key_exists('id', $fields)) {
69 69
             $fields['id'] = [
70 70
                 'name'  => $entry->getKeyName(),
71 71
                 'value' => $entry->getKey(),
@@ -91,7 +91,7 @@  discard block
 block discarded – undo
91 91
 
92 92
             $relation_array = explode('.', $relational_entity);
93 93
 
94
-            $relatedModel = $relatedModel = array_reduce(array_splice($relation_array, 0, -1), function ($obj, $method) {
94
+            $relatedModel = $relatedModel = array_reduce(array_splice($relation_array, 0, -1), function($obj, $method) {
95 95
                 return $obj->{$method} ? $obj->{$method} : $obj;
96 96
             }, $model);
97 97
 
Please login to merge, or discard this patch.
src/app/Console/Commands/AddSidebarContent.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -71,7 +71,7 @@
 block discarded – undo
71 71
      */
72 72
     private function getLastLineNumberThatContains($needle, $haystack)
73 73
     {
74
-        $matchingLines = array_filter($haystack, function ($k) use ($needle) {
74
+        $matchingLines = array_filter($haystack, function($k) use ($needle) {
75 75
             return strpos($k, $needle) !== false;
76 76
         });
77 77
 
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/CrudPanel.php 1 patch
Spacing   +16 added lines, -16 removed lines patch added patch discarded remove patch
@@ -101,11 +101,11 @@  discard block
 block discarded – undo
101 101
      */
102 102
     public function setModel($model_namespace)
103 103
     {
104
-        if (! class_exists($model_namespace)) {
104
+        if (!class_exists($model_namespace)) {
105 105
             throw new \Exception('The model does not exist.', 500);
106 106
         }
107 107
 
108
-        if (! method_exists($model_namespace, 'hasCrudTrait')) {
108
+        if (!method_exists($model_namespace, 'hasCrudTrait')) {
109 109
             throw new \Exception('Please use CrudTrait on the model.', 500);
110 110
         }
111 111
 
@@ -168,7 +168,7 @@  discard block
 block discarded – undo
168 168
     {
169 169
         $complete_route = $route.'.index';
170 170
 
171
-        if (! \Route::has($complete_route)) {
171
+        if (!\Route::has($complete_route)) {
172 172
             throw new \Exception('There are no routes for this route name.', 404);
173 173
         }
174 174
 
@@ -269,7 +269,7 @@  discard block
 block discarded – undo
269 269
      */
270 270
     public function getFirstOfItsTypeInArray($type, $array)
271 271
     {
272
-        return Arr::first($array, function ($item) use ($type) {
272
+        return Arr::first($array, function($item) use ($type) {
273 273
             return $item['type'] == $type;
274 274
         });
275 275
     }
@@ -286,8 +286,8 @@  discard block
 block discarded – undo
286 286
 
287 287
     public function sync($type, $fields, $attributes)
288 288
     {
289
-        if (! empty($this->{$type})) {
290
-            $this->{$type} = array_map(function ($field) use ($fields, $attributes) {
289
+        if (!empty($this->{$type})) {
290
+            $this->{$type} = array_map(function($field) use ($fields, $attributes) {
291 291
                 if (in_array($field['name'], (array) $fields)) {
292 292
                     $field = array_merge($field, $attributes);
293 293
                 }
@@ -318,15 +318,15 @@  discard block
 block discarded – undo
318 318
     {
319 319
         $relationArray = explode('.', $relationString);
320 320
 
321
-        if (! isset($length)) {
321
+        if (!isset($length)) {
322 322
             $length = count($relationArray);
323 323
         }
324 324
 
325
-        if (! isset($model)) {
325
+        if (!isset($model)) {
326 326
             $model = $this->model;
327 327
         }
328 328
 
329
-        $result = array_reduce(array_splice($relationArray, 0, $length), function ($obj, $method) {
329
+        $result = array_reduce(array_splice($relationArray, 0, $length), function($obj, $method) {
330 330
             try {
331 331
                 $result = $obj->$method();
332 332
 
@@ -362,7 +362,7 @@  discard block
 block discarded – undo
362 362
             if (is_array($entries)) {
363 363
                 //if attribute does not exist in main array we have more than one entry OR the attribute
364 364
                 //is an acessor that is not in $appends property of model.
365
-                if (! isset($entries[$attribute])) {
365
+                if (!isset($entries[$attribute])) {
366 366
                     //we first check if we don't have the attribute because it's and acessor that is not in appends.
367 367
                     if ($model_instance->hasGetMutator($attribute) && isset($entries[$modelKey])) {
368 368
                         $entry_in_database = $model_instance->find($entries[$modelKey]);
@@ -402,21 +402,21 @@  discard block
 block discarded – undo
402 402
      */
403 403
     public function parseTranslatableAttributes($model, $attribute, $value)
404 404
     {
405
-        if (! method_exists($model, 'isTranslatableAttribute')) {
405
+        if (!method_exists($model, 'isTranslatableAttribute')) {
406 406
             return $value;
407 407
         }
408 408
 
409
-        if (! $model->isTranslatableAttribute($attribute)) {
409
+        if (!$model->isTranslatableAttribute($attribute)) {
410 410
             return $value;
411 411
         }
412 412
 
413
-        if (! is_array($value)) {
413
+        if (!is_array($value)) {
414 414
             $decodedAttribute = json_decode($value, true);
415 415
         } else {
416 416
             $decodedAttribute = $value;
417 417
         }
418 418
 
419
-        if (is_array($decodedAttribute) && ! empty($decodedAttribute)) {
419
+        if (is_array($decodedAttribute) && !empty($decodedAttribute)) {
420 420
             if (isset($decodedAttribute[app()->getLocale()])) {
421 421
                 return $decodedAttribute[app()->getLocale()];
422 422
             } else {
@@ -443,7 +443,7 @@  discard block
 block discarded – undo
443 443
         $relation = $model->{$firstRelationName};
444 444
 
445 445
         $results = [];
446
-        if (! is_null($relation)) {
446
+        if (!is_null($relation)) {
447 447
             if ($relation instanceof Collection) {
448 448
                 $currentResults = $relation->all();
449 449
             } elseif (is_array($relation)) {
@@ -456,7 +456,7 @@  discard block
 block discarded – undo
456 456
 
457 457
             array_shift($relationArray);
458 458
 
459
-            if (! empty($relationArray)) {
459
+            if (!empty($relationArray)) {
460 460
                 foreach ($currentResults as $currentResult) {
461 461
                     $results = array_merge_recursive($results, $this->getRelatedEntries($currentResult, implode('.', $relationArray)));
462 462
                 }
Please login to merge, or discard this patch.
src/resources/views/crud/fields/page_or_link.blade.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -46,7 +46,7 @@  discard block
 block discarded – undo
46 46
         </div>
47 47
         <div class="col-sm-9">
48 48
             <!-- external link input -->
49
-              <div class="page_or_link_value page_or_link_external_link <?php if (! isset($entry) || $entry->$entry_type != 'external_link') {
49
+              <div class="page_or_link_value page_or_link_external_link <?php if (!isset($entry) || $entry->$entry_type != 'external_link') {
50 50
     echo 'd-none';
51 51
 } ?>">
52 52
                 <input
@@ -65,7 +65,7 @@  discard block
 block discarded – undo
65 65
                     >
66 66
               </div>
67 67
               <!-- internal link input -->
68
-              <div class="page_or_link_value page_or_link_internal_link <?php if (! isset($entry) || $entry->$entry_type != 'internal_link') {
68
+              <div class="page_or_link_value page_or_link_internal_link <?php if (!isset($entry) || $entry->$entry_type != 'internal_link') {
69 69
     echo 'd-none';
70 70
 } ?>">
71 71
                 <input
Please login to merge, or discard this patch.