Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Passed
Push — master ( 7f2dab...3db1a3 )
by Cristian
40:27 queued 25:20
created
src/app/Http/Controllers/Operations/ListOperation.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -41,7 +41,7 @@  discard block
 block discarded – undo
41 41
     {
42 42
         $this->crud->allowAccess('list');
43 43
 
44
-        $this->crud->operation('list', function () {
44
+        $this->crud->operation('list', function() {
45 45
             $this->crud->loadDefaultOperationSettingsFromConfig();
46 46
         });
47 47
     }
@@ -116,12 +116,12 @@  discard block
 block discarded – undo
116 116
         $table = $this->crud->model->getTable();
117 117
         $key = $this->crud->model->getKeyName();
118 118
 
119
-        $hasOrderByPrimaryKey = collect($orderBy)->some(function ($item) use ($key, $table) {
119
+        $hasOrderByPrimaryKey = collect($orderBy)->some(function($item) use ($key, $table) {
120 120
             return (isset($item['column']) && $item['column'] === $key)
121 121
                 || (isset($item['sql']) && str_contains($item['sql'], "$table.$key"));
122 122
         });
123 123
 
124
-        if (! $hasOrderByPrimaryKey) {
124
+        if (!$hasOrderByPrimaryKey) {
125 125
             $this->crud->orderByWithPrefix($this->crud->model->getKeyName(), 'DESC');
126 126
         }
127 127
 
Please login to merge, or discard this patch.
src/helpers.php 1 patch
Spacing   +16 added lines, -16 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-if (! function_exists('backpack_url')) {
3
+if (!function_exists('backpack_url')) {
4 4
     /**
5 5
      * Appends the configured backpack prefix and returns
6 6
      * the URL using the standard Laravel helpers.
@@ -11,13 +11,13 @@  discard block
 block discarded – undo
11 11
      */
12 12
     function backpack_url($path = null, $parameters = [], $secure = null)
13 13
     {
14
-        $path = ! $path || (substr($path, 0, 1) == '/') ? $path : '/'.$path;
14
+        $path = !$path || (substr($path, 0, 1) == '/') ? $path : '/'.$path;
15 15
 
16 16
         return url(config('backpack.base.route_prefix', 'admin').$path, $parameters, $secure);
17 17
     }
18 18
 }
19 19
 
20
-if (! function_exists('backpack_authentication_column')) {
20
+if (!function_exists('backpack_authentication_column')) {
21 21
     /**
22 22
      * Return the username column name.
23 23
      * The Laravel default (and Backpack default) is 'email'.
@@ -30,7 +30,7 @@  discard block
 block discarded – undo
30 30
     }
31 31
 }
32 32
 
33
-if (! function_exists('backpack_form_input')) {
33
+if (!function_exists('backpack_form_input')) {
34 34
     /**
35 35
      * Parse the submitted input in request('form') to an usable array.
36 36
      * Joins the multiple[] fields in a single key and transform the dot notation fields into arrayed ones.
@@ -59,7 +59,7 @@  discard block
 block discarded – undo
59 59
             }
60 60
 
61 61
             if (is_null($input_arg)) {
62
-                if (! isset($result[$input_key])) {
62
+                if (!isset($result[$input_key])) {
63 63
                     $result[$input_key] = $start ? [$row['value']] : $row['value'];
64 64
                 } else {
65 65
                     array_push($result[$input_key], $row['value']);
@@ -73,7 +73,7 @@  discard block
 block discarded – undo
73 73
     }
74 74
 }
75 75
 
76
-if (! function_exists('backpack_users_have_email')) {
76
+if (!function_exists('backpack_users_have_email')) {
77 77
     /**
78 78
      * Check if the email column is present on the user table.
79 79
      *
@@ -88,7 +88,7 @@  discard block
 block discarded – undo
88 88
     }
89 89
 }
90 90
 
91
-if (! function_exists('backpack_avatar_url')) {
91
+if (!function_exists('backpack_avatar_url')) {
92 92
     /**
93 93
      * Returns the avatar URL of a user.
94 94
      *
@@ -121,7 +121,7 @@  discard block
 block discarded – undo
121 121
     }
122 122
 }
123 123
 
124
-if (! function_exists('backpack_middleware')) {
124
+if (!function_exists('backpack_middleware')) {
125 125
     /**
126 126
      * Return the key of the middleware used across Backpack.
127 127
      * That middleware checks if the visitor is an admin.
@@ -136,7 +136,7 @@  discard block
 block discarded – undo
136 136
     }
137 137
 }
138 138
 
139
-if (! function_exists('backpack_guard_name')) {
139
+if (!function_exists('backpack_guard_name')) {
140 140
     /*
141 141
      * Returns the name of the guard defined
142 142
      * by the application config
@@ -147,7 +147,7 @@  discard block
 block discarded – undo
147 147
     }
148 148
 }
149 149
 
150
-if (! function_exists('backpack_auth')) {
150
+if (!function_exists('backpack_auth')) {
151 151
     /*
152 152
      * Returns the user instance if it exists
153 153
      * of the currently authenticated admin
@@ -159,7 +159,7 @@  discard block
 block discarded – undo
159 159
     }
160 160
 }
161 161
 
162
-if (! function_exists('backpack_user')) {
162
+if (!function_exists('backpack_user')) {
163 163
     /*
164 164
      * Returns back a user instance without
165 165
      * the admin guard, however allows you
@@ -171,7 +171,7 @@  discard block
 block discarded – undo
171 171
     }
172 172
 }
173 173
 
174
-if (! function_exists('mb_ucfirst')) {
174
+if (!function_exists('mb_ucfirst')) {
175 175
     /**
176 176
      * Capitalize the first letter of a string,
177 177
      * even if that string is multi-byte (non-latin alphabet).
@@ -193,7 +193,7 @@  discard block
 block discarded – undo
193 193
     }
194 194
 }
195 195
 
196
-if (! function_exists('backpack_view')) {
196
+if (!function_exists('backpack_view')) {
197 197
     /**
198 198
      * Returns a new displayable view based on the configured backpack view namespace.
199 199
      * If that view doesn't exist, it will load the one from the original theme.
@@ -213,7 +213,7 @@  discard block
 block discarded – undo
213 213
 
214 214
         $returnView = $theme.$view;
215 215
 
216
-        if (! view()->exists($returnView)) {
216
+        if (!view()->exists($returnView)) {
217 217
             $returnView = $originalTheme.$view;
218 218
         }
219 219
 
@@ -221,7 +221,7 @@  discard block
 block discarded – undo
221 221
     }
222 222
 }
223 223
 
224
-if (! function_exists('square_brackets_to_dots')) {
224
+if (!function_exists('square_brackets_to_dots')) {
225 225
     /**
226 226
      * Turns a string from bracket-type array to dot-notation array.
227 227
      * Ex: array[0][property] turns into array.0.property.
@@ -238,7 +238,7 @@  discard block
 block discarded – undo
238 238
     }
239 239
 }
240 240
 
241
-if (! function_exists('is_countable')) {
241
+if (!function_exists('is_countable')) {
242 242
     /**
243 243
      * We need this because is_countable was only introduced in PHP 7.3,
244 244
      * and in PHP 7.2 you should check if count() argument is really countable.
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Columns.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -114,7 +114,7 @@  discard block
 block discarded – undo
114 114
      */
115 115
     public function makeFirstColumn()
116 116
     {
117
-        if (! $this->columns()) {
117
+        if (!$this->columns()) {
118 118
             return false;
119 119
         }
120 120
 
@@ -159,7 +159,7 @@  discard block
 block discarded – undo
159 159
      */
160 160
     public function removeColumns($columns)
161 161
     {
162
-        if (! empty($columns)) {
162
+        if (!empty($columns)) {
163 163
             foreach ($columns as $columnKey) {
164 164
                 $this->removeColumn($columnKey);
165 165
             }
@@ -252,8 +252,8 @@  discard block
 block discarded – undo
252 252
     {
253 253
         $columns = $this->columns();
254 254
 
255
-        return collect($columns)->pluck('entity')->reject(function ($value, $key) {
256
-            return ! $value;
255
+        return collect($columns)->pluck('entity')->reject(function($value, $key) {
256
+            return !$value;
257 257
         })->toArray();
258 258
     }
259 259
 
@@ -329,7 +329,7 @@  discard block
 block discarded – undo
329 329
      */
330 330
     public function hasColumnWhere($attribute, $value)
331 331
     {
332
-        $match = Arr::first($this->columns(), function ($column, $columnKey) use ($attribute, $value) {
332
+        $match = Arr::first($this->columns(), function($column, $columnKey) use ($attribute, $value) {
333 333
             return isset($column[$attribute]) && $column[$attribute] == $value;
334 334
         });
335 335
 
@@ -345,7 +345,7 @@  discard block
 block discarded – undo
345 345
      */
346 346
     public function firstColumnWhere($attribute, $value)
347 347
     {
348
-        return Arr::first($this->columns(), function ($column, $columnKey) use ($attribute, $value) {
348
+        return Arr::first($this->columns(), function($column, $columnKey) use ($attribute, $value) {
349 349
             return isset($column[$attribute]) && $column[$attribute] == $value;
350 350
         });
351 351
     }
@@ -395,8 +395,8 @@  discard block
 block discarded – undo
395 395
      */
396 396
     public function countColumnsWithoutActions()
397 397
     {
398
-        return collect($this->columns())->filter(function ($column, $key) {
399
-            return ! isset($column['hasActions']) || $column['hasActions'] == false;
398
+        return collect($this->columns())->filter(function($column, $key) {
399
+            return !isset($column['hasActions']) || $column['hasActions'] == false;
400 400
         })->count();
401 401
     }
402 402
 
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/AutoSet.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -16,7 +16,7 @@  discard block
 block discarded – undo
16 16
             $this->getDbColumnTypes();
17 17
         }
18 18
 
19
-        array_map(function ($field) {
19
+        array_map(function($field) {
20 20
             $new_field = [
21 21
                 'name'       => $field,
22 22
                 'label'      => $this->makeLabel($field),
@@ -28,11 +28,11 @@  discard block
 block discarded – undo
28 28
                 'autoset'    => true,
29 29
             ];
30 30
 
31
-            if (! isset($this->fields()[$field])) {
31
+            if (!isset($this->fields()[$field])) {
32 32
                 $this->addField($new_field);
33 33
             }
34 34
 
35
-            if (! in_array($field, $this->model->getHidden()) && ! in_array($field, $this->columns())) {
35
+            if (!in_array($field, $this->model->getHidden()) && !in_array($field, $this->columns())) {
36 36
                 $this->addColumn([
37 37
                     'name'    => $field,
38 38
                     'label'   => $this->makeLabel($field),
@@ -110,7 +110,7 @@  discard block
 block discarded – undo
110 110
 
111 111
         $dbColumnTypes = $this->getDbColumnTypes();
112 112
 
113
-        if (! isset($dbColumnTypes[$fieldName])) {
113
+        if (!isset($dbColumnTypes[$fieldName])) {
114 114
             return 'text';
115 115
         }
116 116
 
@@ -168,7 +168,7 @@  discard block
 block discarded – undo
168 168
         $types = ['enum' => 'string'];
169 169
         $platform = $this->getSchema()->getConnection()->getDoctrineSchemaManager()->getDatabasePlatform();
170 170
         foreach ($types as $type_key => $type_value) {
171
-            if (! $platform->hasDoctrineTypeMappingFor($type_key)) {
171
+            if (!$platform->hasDoctrineTypeMappingFor($type_key)) {
172 172
                 $platform->registerDoctrineTypeMapping($type_key, $type_value);
173 173
             }
174 174
         }
@@ -221,13 +221,13 @@  discard block
 block discarded – undo
221 221
     {
222 222
         $fillable = $this->model->getFillable();
223 223
 
224
-        if (! $this->driverIsSql()) {
224
+        if (!$this->driverIsSql()) {
225 225
             $columns = $fillable;
226 226
         } else {
227 227
             // Automatically-set columns should be both in the database, and in the $fillable variable on the Eloquent Model
228 228
             $columns = $this->model->getConnection()->getSchemaBuilder()->getColumnListing($this->model->getTable());
229 229
 
230
-            if (! empty($fillable)) {
230
+            if (!empty($fillable)) {
231 231
                 $columns = array_intersect($columns, $fillable);
232 232
             }
233 233
         }
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/ColumnsProtectedMethods.php 1 patch
Spacing   +9 added lines, -10 removed lines patch added patch discarded remove patch
@@ -49,7 +49,7 @@  discard block
 block discarded – undo
49 49
             $column = ['name' => $column];
50 50
         }
51 51
 
52
-        if (is_array($column) && ! isset($column['name'])) {
52
+        if (is_array($column) && !isset($column['name'])) {
53 53
             $column['name'] = 'anonymous_column_'.Str::random(5);
54 54
         }
55 55
 
@@ -65,7 +65,7 @@  discard block
 block discarded – undo
65 65
      */
66 66
     protected function makeSureColumnHasLabel($column)
67 67
     {
68
-        if (! isset($column['label'])) {
68
+        if (!isset($column['label'])) {
69 69
             $column['label'] = mb_ucfirst($this->makeLabel($column['name']));
70 70
         }
71 71
 
@@ -82,11 +82,11 @@  discard block
 block discarded – undo
82 82
     {
83 83
         $could_be_relation = isset($column['entity']) && $column['entity'] !== false;
84 84
 
85
-        if (! isset($column['type']) && $could_be_relation) {
85
+        if (!isset($column['type']) && $could_be_relation) {
86 86
             $column['type'] = 'relationship';
87 87
         }
88 88
 
89
-        if (! isset($column['type'])) {
89
+        if (!isset($column['type'])) {
90 90
             $column['type'] = 'text';
91 91
         }
92 92
 
@@ -103,7 +103,7 @@  discard block
 block discarded – undo
103 103
      */
104 104
     protected function makeSureColumnHasKey($column)
105 105
     {
106
-        if (! isset($column['key'])) {
106
+        if (!isset($column['key'])) {
107 107
             $column['key'] = str_replace('.', '__', $column['name']);
108 108
         }
109 109
 
@@ -121,7 +121,7 @@  discard block
 block discarded – undo
121 121
      */
122 122
     protected function makeSureColumnHasWrapper($column)
123 123
     {
124
-        if (! isset($column['wrapper'])) {
124
+        if (!isset($column['wrapper'])) {
125 125
             $column['wrapper'] = [];
126 126
         }
127 127
 
@@ -185,7 +185,7 @@  discard block
 block discarded – undo
185 185
     {
186 186
         // if this is a relation type field and no corresponding model was specified,
187 187
         // get it from the relation method defined in the main model
188
-        if (isset($column['entity']) && $column['entity'] !== false && ! isset($column['model'])) {
188
+        if (isset($column['entity']) && $column['entity'] !== false && !isset($column['model'])) {
189 189
             $column['model'] = $this->getRelationModel($column['entity']);
190 190
         }
191 191
 
@@ -206,8 +206,7 @@  discard block
 block discarded – undo
206 206
         $columnsArray = $this->columns();
207 207
 
208 208
         if (array_key_exists($targetColumnName, $columnsArray)) {
209
-            $targetColumnPosition = $before ? array_search($targetColumnName, array_keys($columnsArray)) :
210
-                array_search($targetColumnName, array_keys($columnsArray)) + 1;
209
+            $targetColumnPosition = $before ? array_search($targetColumnName, array_keys($columnsArray)) : array_search($targetColumnName, array_keys($columnsArray)) + 1;
211 210
 
212 211
             $element = array_pop($columnsArray);
213 212
             $beginningPart = array_slice($columnsArray, 0, $targetColumnPosition, true);
@@ -230,7 +229,7 @@  discard block
 block discarded – undo
230 229
     {
231 230
         static $cache = [];
232 231
 
233
-        if (! $this->driverIsSql()) {
232
+        if (!$this->driverIsSql()) {
234 233
             return true;
235 234
         }
236 235
 
Please login to merge, or discard this patch.
src/app/Http/Controllers/Operations/FetchOperation.php 1 patch
Spacing   +6 added lines, -8 removed lines patch added patch discarded remove patch
@@ -46,8 +46,8 @@  discard block
 block discarded – undo
46 46
         // otherwise assume the arguments are actually the configuration array
47 47
         $config = [];
48 48
 
49
-        if (! is_array($arg)) {
50
-            if (! class_exists($arg)) {
49
+        if (!is_array($arg)) {
50
+            if (!class_exists($arg)) {
51 51
                 return response()->json(['error' => 'Class: '.$arg.' does not exists'], 500);
52 52
             }
53 53
             $config['model'] = $arg;
@@ -77,8 +77,7 @@  discard block
 block discarded – undo
77 77
 
78 78
         if ($search_string === false) {
79 79
             return ($config['paginate'] !== false) ?
80
-            $config['query']->paginate($config['paginate']) :
81
-            $config['query']->get();
80
+            $config['query']->paginate($config['paginate']) : $config['query']->get();
82 81
         }
83 82
 
84 83
         $textColumnTypes = ['string', 'json_string', 'text', 'longText', 'json_array', 'json'];
@@ -89,8 +88,8 @@  discard block
 block discarded – undo
89 88
         // .... 'query' => function($model) { return $model->where('active', 1); }
90 89
         // So it reads: SELECT ... WHERE active = 1 AND (XXX = x OR YYY = y) and not SELECT ... WHERE active = 1 AND XXX = x OR YYY = y;
91 90
 
92
-        if (! empty($config['query']->getQuery()->wheres)) {
93
-            $config['query'] = $config['query']->where(function ($query) use ($model_instance, $config, $search_string, $textColumnTypes) {
91
+        if (!empty($config['query']->getQuery()->wheres)) {
92
+            $config['query'] = $config['query']->where(function($query) use ($model_instance, $config, $search_string, $textColumnTypes) {
94 93
                 foreach ((array) $config['searchable_attributes'] as $k => $searchColumn) {
95 94
                     $operation = ($k == 0) ? 'where' : 'orWhere';
96 95
                     $columnType = $model_instance->getColumnType($searchColumn);
@@ -122,7 +121,6 @@  discard block
 block discarded – undo
122 121
 
123 122
         // return the results with or without pagination
124 123
         return ($config['paginate'] !== false) ?
125
-                    $config['query']->paginate($config['paginate']) :
126
-                    $config['query']->get();
124
+                    $config['query']->paginate($config['paginate']) : $config['query']->get();
127 125
     }
128 126
 }
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Validation.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -98,7 +98,7 @@  discard block
 block discarded – undo
98 98
                         // Convert dot to array notation
99 99
                         $key = \Str::of($key)
100 100
                             ->explode('.')
101
-                            ->map(function ($value, $key) {
101
+                            ->map(function($value, $key) {
102 102
                                 return $key ? "[$value]" : $value;
103 103
                             })
104 104
                             ->join('');
@@ -123,7 +123,7 @@  discard block
 block discarded – undo
123 123
      */
124 124
     public function isRequired($inputKey)
125 125
     {
126
-        if (! $this->hasOperationSetting('requiredFields')) {
126
+        if (!$this->hasOperationSetting('requiredFields')) {
127 127
             return false;
128 128
         }
129 129
 
Please login to merge, or discard this patch.