Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Completed
Pull Request — master (#1417)
by Owen
08:08
created
tests/config/database/migrations/2017_09_05_000000_create_users_table.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -13,7 +13,7 @@
 block discarded – undo
13 13
      */
14 14
     public function up()
15 15
     {
16
-        Schema::create('users', function (Blueprint $table) {
16
+        Schema::create('users', function(Blueprint $table) {
17 17
             $table->increments('id');
18 18
             $table->string('name');
19 19
             $table->string('email')->unique();
Please login to merge, or discard this patch.
config/database/migrations/2017_09_06_000001_create_column_types_table.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -15,7 +15,7 @@
 block discarded – undo
15 15
         // uncomment the next statement to map strings to enum types in doctrine and get over the 'Unknown database type enum' DBAL error
16 16
         // Schema::getConnection()->getDoctrineSchemaManager()->getDatabasePlatform()->registerDoctrineTypeMapping('enum', 'string');
17 17
 
18
-        Schema::create('column_types', function ($table) {
18
+        Schema::create('column_types', function($table) {
19 19
             $table->bigInteger('bigIntegerCol');
20 20
             $table->binary('binaryCol');
21 21
             $table->boolean('booleanCol');
Please login to merge, or discard this patch.
tests/Unit/CrudPanel/CrudPanelButtonsTest.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -217,7 +217,7 @@
 block discarded – undo
217 217
 
218 218
     private function getButtonByName($name)
219 219
     {
220
-        return $this->crudPanel->buttons->first(function ($value) use ($name) {
220
+        return $this->crudPanel->buttons->first(function($value) use ($name) {
221 221
             return $value->name == $name;
222 222
         });
223 223
     }
Please login to merge, or discard this patch.
src/PanelTraits/Fields.php 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -26,28 +26,28 @@  discard block
 block discarded – undo
26 26
 
27 27
         // if this is a relation type field and no corresponding model was specified, get it from the relation method
28 28
         // defined in the main model
29
-        if (isset($completeFieldsArray['entity']) && ! isset($completeFieldsArray['model'])) {
29
+        if (isset($completeFieldsArray['entity']) && !isset($completeFieldsArray['model'])) {
30 30
             $completeFieldsArray['model'] = $this->getRelationModel($completeFieldsArray['entity']);
31 31
         }
32 32
 
33 33
         // if the label is missing, we should set it
34
-        if (! isset($completeFieldsArray['label'])) {
34
+        if (!isset($completeFieldsArray['label'])) {
35 35
             $completeFieldsArray['label'] = ucfirst($completeFieldsArray['name']);
36 36
         }
37 37
 
38 38
         // if the field type is missing, we should set it
39
-        if (! isset($completeFieldsArray['type'])) {
39
+        if (!isset($completeFieldsArray['type'])) {
40 40
             $completeFieldsArray['type'] = $this->getFieldTypeFromDbColumnType($completeFieldsArray['name']);
41 41
         }
42 42
 
43 43
         // if a tab was mentioned, we should enable it
44 44
         if (isset($completeFieldsArray['tab'])) {
45
-            if (! $this->tabsEnabled()) {
45
+            if (!$this->tabsEnabled()) {
46 46
                 $this->enableTabs();
47 47
             }
48 48
         }
49 49
 
50
-        $this->transformFields($form, function ($fields) use ($completeFieldsArray) {
50
+        $this->transformFields($form, function($fields) use ($completeFieldsArray) {
51 51
             $fields[$completeFieldsArray['name']] = $completeFieldsArray;
52 52
 
53 53
             return $fields;
@@ -79,7 +79,7 @@  discard block
 block discarded – undo
79 79
      */
80 80
     public function afterField($targetFieldName, $form = 'both')
81 81
     {
82
-        $this->transformFields($form, function ($fields) use ($targetFieldName) {
82
+        $this->transformFields($form, function($fields) use ($targetFieldName) {
83 83
             return $this->moveField($fields, $targetFieldName, false);
84 84
         });
85 85
     }
@@ -92,7 +92,7 @@  discard block
 block discarded – undo
92 92
      */
93 93
     public function beforeField($targetFieldName, $form = 'both')
94 94
     {
95
-        $this->transformFields($form, function ($fields) use ($targetFieldName) {
95
+        $this->transformFields($form, function($fields) use ($targetFieldName) {
96 96
             return $this->moveField($fields, $targetFieldName, true);
97 97
         });
98 98
     }
@@ -134,7 +134,7 @@  discard block
 block discarded – undo
134 134
      */
135 135
     public function removeField($name, $form = 'both')
136 136
     {
137
-        $this->transformFields($form, function ($fields) use ($name) {
137
+        $this->transformFields($form, function($fields) use ($name) {
138 138
             array_forget($fields, $name);
139 139
 
140 140
             return $fields;
@@ -149,7 +149,7 @@  discard block
 block discarded – undo
149 149
      */
150 150
     public function removeFields($array_of_names, $form = 'both')
151 151
     {
152
-        if (! empty($array_of_names)) {
152
+        if (!empty($array_of_names)) {
153 153
             foreach ($array_of_names as $name) {
154 154
                 $this->removeField($name, $form);
155 155
             }
@@ -212,7 +212,7 @@  discard block
 block discarded – undo
212 212
                 $jsonCastables = ['array', 'object', 'json'];
213 213
                 $fieldCasting = $casted_attributes[$field['name']];
214 214
 
215
-                if (in_array($fieldCasting, $jsonCastables) && isset($data[$field['name']]) && ! empty($data[$field['name']]) && ! is_array($data[$field['name']])) {
215
+                if (in_array($fieldCasting, $jsonCastables) && isset($data[$field['name']]) && !empty($data[$field['name']]) && !is_array($data[$field['name']])) {
216 216
                     try {
217 217
                         $data[$field['name']] = json_decode($data[$field['name']]);
218 218
                     } catch (\Exception $e) {
@@ -243,7 +243,7 @@  discard block
 block discarded – undo
243 243
      */
244 244
     public function orderFields($order, $form = 'both')
245 245
     {
246
-        $this->transformFields($form, function ($fields) use ($order) {
246
+        $this->transformFields($form, function($fields) use ($order) {
247 247
             return $this->applyOrderToFields($fields, $order);
248 248
         });
249 249
     }
Please login to merge, or discard this patch.
src/ModelTraits/SpatieTranslatable/SlugService.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -49,7 +49,7 @@
 block discarded – undo
49 49
      */
50 50
     protected function makeSlugUnique(string $slug, array $config, string $attribute): string
51 51
     {
52
-        if (! $config['unique']) {
52
+        if (!$config['unique']) {
53 53
             return $slug;
54 54
         }
55 55
 
Please login to merge, or discard this patch.
src/app/Http/Controllers/CrudController.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -33,12 +33,12 @@
 block discarded – undo
33 33
 
34 34
     public function __construct()
35 35
     {
36
-        if (! $this->crud) {
36
+        if (!$this->crud) {
37 37
             $this->crud = app()->make(CrudPanel::class);
38 38
 
39 39
             // call the setup function inside this closure to also have the request there
40 40
             // this way, developers can use things stored in session (auth variables, etc)
41
-            $this->middleware(function ($request, $next) {
41
+            $this->middleware(function($request, $next) {
42 42
                 $this->request = $request;
43 43
                 $this->crud->request = $request;
44 44
                 $this->setup();
Please login to merge, or discard this patch.
src/PanelTraits/FakeFields.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -29,7 +29,7 @@  discard block
 block discarded – undo
29 29
                 $fakeFieldKey = isset($field['store_in']) ? $field['store_in'] : 'extras';
30 30
                 $this->addCompactedField($requestInput, $field['name'], $fakeFieldKey);
31 31
 
32
-                if (! in_array($fakeFieldKey, $compactedFakeFields)) {
32
+                if (!in_array($fakeFieldKey, $compactedFakeFields)) {
33 33
                     $compactedFakeFields[] = $fakeFieldKey;
34 34
                 }
35 35
             }
@@ -37,7 +37,7 @@  discard block
 block discarded – undo
37 37
 
38 38
         // json_encode all fake_value columns if applicable in the database, so they can be properly stored and interpreted
39 39
         foreach ($compactedFakeFields as $value) {
40
-            if (! (property_exists($this->model, 'translatable') && in_array($value, $this->model->getTranslatableAttributes(), true)) && $this->model->shouldEncodeFake($value)) {
40
+            if (!(property_exists($this->model, 'translatable') && in_array($value, $this->model->getTranslatableAttributes(), true)) && $this->model->shouldEncodeFake($value)) {
41 41
                 $requestInput[$value] = json_encode($requestInput[$value]);
42 42
             }
43 43
         }
Please login to merge, or discard this patch.
src/CrudTrait.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -57,7 +57,7 @@  discard block
 block discarded – undo
57 57
         $conn->getDoctrineSchemaManager()->getDatabasePlatform()->registerDoctrineTypeMapping('json', 'json_array');
58 58
         $conn->getDoctrineSchemaManager()->getDatabasePlatform()->registerDoctrineTypeMapping('jsonb', 'json_array');
59 59
 
60
-        return ! $conn->getDoctrineColumn($table, $column_name)->getNotnull();
60
+        return !$conn->getDoctrineColumn($table, $column_name)->getNotnull();
61 61
     }
62 62
 
63 63
     /*
@@ -76,7 +76,7 @@  discard block
 block discarded – undo
76 76
         foreach ($columns as $key => $column) {
77 77
             $column_contents = $this->{$column};
78 78
 
79
-            if (! is_object($this->{$column})) {
79
+            if (!is_object($this->{$column})) {
80 80
                 $column_contents = json_decode($this->{$column});
81 81
             }
82 82
 
@@ -99,7 +99,7 @@  discard block
 block discarded – undo
99 99
     {
100 100
         $model = '\\'.get_class($this);
101 101
 
102
-        if (! count($columns)) {
102
+        if (!count($columns)) {
103 103
             $columns = (property_exists($model, 'fakeColumns')) ? $this->fakeColumns : ['extras'];
104 104
         }
105 105
 
@@ -116,7 +116,7 @@  discard block
 block discarded – undo
116 116
      */
117 117
     public function shouldEncodeFake($column)
118 118
     {
119
-        return ! in_array($column, array_keys($this->casts));
119
+        return !in_array($column, array_keys($this->casts));
120 120
     }
121 121
 
122 122
     /*
@@ -199,7 +199,7 @@  discard block
 block discarded – undo
199 199
             $attribute_value = (array) $this->{$attribute_name};
200 200
             foreach ($files_to_clear as $key => $filename) {
201 201
                 \Storage::disk($disk)->delete($filename);
202
-                $attribute_value = array_where($attribute_value, function ($value, $key) use ($filename) {
202
+                $attribute_value = array_where($attribute_value, function($value, $key) use ($filename) {
203 203
                     return $value != $filename;
204 204
                 });
205 205
             }
Please login to merge, or discard this patch.
src/PanelTraits/Columns.php 1 patch
Spacing   +14 added lines, -15 removed lines patch added patch discarded remove patch
@@ -64,7 +64,7 @@  discard block
 block discarded – undo
64 64
     public function addColumn($column)
65 65
     {
66 66
         // if a string was passed, not an array, change it to an array
67
-        if (! is_array($column)) {
67
+        if (!is_array($column)) {
68 68
             $column = ['name' => $column];
69 69
         }
70 70
 
@@ -72,7 +72,7 @@  discard block
 block discarded – undo
72 72
         $column_with_details = $this->addDefaultLabel($column);
73 73
 
74 74
         // make sure the column has a name
75
-        if (! array_key_exists('name', $column_with_details)) {
75
+        if (!array_key_exists('name', $column_with_details)) {
76 76
             $column_with_details['name'] = 'anonymous_column_'.str_random(5);
77 77
         }
78 78
 
@@ -80,27 +80,27 @@  discard block
 block discarded – undo
80 80
         $columnExistsInDb = $this->hasColumn($this->model->getTable(), $column_with_details['name']);
81 81
 
82 82
         // make sure the column has a type
83
-        if (! array_key_exists('type', $column_with_details)) {
83
+        if (!array_key_exists('type', $column_with_details)) {
84 84
             $column_with_details['type'] = 'text';
85 85
         }
86 86
 
87 87
         // make sure the column has a key
88
-        if (! array_key_exists('key', $column_with_details)) {
88
+        if (!array_key_exists('key', $column_with_details)) {
89 89
             $column_with_details['key'] = $column_with_details['name'];
90 90
         }
91 91
 
92 92
         // make sure the column has a tableColumn boolean
93
-        if (! array_key_exists('tableColumn', $column_with_details)) {
93
+        if (!array_key_exists('tableColumn', $column_with_details)) {
94 94
             $column_with_details['tableColumn'] = $columnExistsInDb ? true : false;
95 95
         }
96 96
 
97 97
         // make sure the column has a orderable boolean
98
-        if (! array_key_exists('orderable', $column_with_details)) {
98
+        if (!array_key_exists('orderable', $column_with_details)) {
99 99
             $column_with_details['orderable'] = $columnExistsInDb ? true : false;
100 100
         }
101 101
 
102 102
         // make sure the column has a searchLogic
103
-        if (! array_key_exists('searchLogic', $column_with_details)) {
103
+        if (!array_key_exists('searchLogic', $column_with_details)) {
104 104
             $column_with_details['searchLogic'] = $columnExistsInDb ? true : false;
105 105
         }
106 106
 
@@ -108,7 +108,7 @@  discard block
 block discarded – undo
108 108
 
109 109
         // if this is a relation type field and no corresponding model was specified, get it from the relation method
110 110
         // defined in the main model
111
-        if (isset($column_with_details['entity']) && ! isset($column_with_details['model'])) {
111
+        if (isset($column_with_details['entity']) && !isset($column_with_details['model'])) {
112 112
             $column_with_details['model'] = $this->getRelationModel($column_with_details['entity']);
113 113
         }
114 114
 
@@ -162,8 +162,7 @@  discard block
 block discarded – undo
162 162
         $targetColumnName = is_array($targetColumn) ? $targetColumn['name'] : $targetColumn;
163 163
 
164 164
         if (array_key_exists($targetColumnName, $this->columns)) {
165
-            $targetColumnPosition = $before ? array_search($targetColumnName, array_keys($this->columns)) :
166
-                array_search($targetColumnName, array_keys($this->columns)) + 1;
165
+            $targetColumnPosition = $before ? array_search($targetColumnName, array_keys($this->columns)) : array_search($targetColumnName, array_keys($this->columns)) + 1;
167 166
 
168 167
             $element = array_pop($this->columns);
169 168
             $beginningPart = array_slice($this->columns, 0, $targetColumnPosition, true);
@@ -197,7 +196,7 @@  discard block
 block discarded – undo
197 196
      */
198 197
     public function addDefaultLabel($array)
199 198
     {
200
-        if (! array_key_exists('label', (array) $array) && array_key_exists('name', (array) $array)) {
199
+        if (!array_key_exists('label', (array) $array) && array_key_exists('name', (array) $array)) {
201 200
             $array = array_merge(['label' => ucfirst($this->makeLabel($array['name']))], $array);
202 201
 
203 202
             return $array;
@@ -223,7 +222,7 @@  discard block
 block discarded – undo
223 222
      */
224 223
     public function removeColumns($columns)
225 224
     {
226
-        if (! empty($columns)) {
225
+        if (!empty($columns)) {
227 226
             foreach ($columns as $columnName) {
228 227
                 $this->removeColumn($columnName);
229 228
             }
@@ -244,8 +243,8 @@  discard block
 block discarded – undo
244 243
      */
245 244
     public function remove($entity, $fields)
246 245
     {
247
-        return array_values(array_filter($this->{$entity}, function ($field) use ($fields) {
248
-            return ! in_array($field['name'], (array) $fields);
246
+        return array_values(array_filter($this->{$entity}, function($field) use ($fields) {
247
+            return !in_array($field['name'], (array) $fields);
249 248
         }));
250 249
     }
251 250
 
@@ -290,7 +289,7 @@  discard block
 block discarded – undo
290 289
     {
291 290
         $columns = $this->getColumns();
292 291
 
293
-        return collect($columns)->pluck('entity')->reject(function ($value, $key) {
292
+        return collect($columns)->pluck('entity')->reject(function($value, $key) {
294 293
             return $value == null;
295 294
         })->toArray();
296 295
     }
Please login to merge, or discard this patch.