Reorder - Code Metrics - Inspection of "separates crud features into traits; fixes #128; f..." - Laravel-Backpack/CRUD - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 7a24d5...09959f )

by Cristian

created 2016-09-26 11:29 UTC

Reorder A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	49
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes	1
Bugs	1	Features	0

Metric	Value
dl	0
loc	49
rs	10
c	1
b	1
f	0
wmc	4
lcom	1
cbo	1

2 Methods

Rating	Name	Duplication	Size	Complexity
A	reorder()	0	16	2
A	saveReorder()	0	14	2

<?php

namespace Backpack\CRUD\app\Http\Controllers\CrudFeatures;

trait Reorder {

	/**
     *  Reorder the items in the database using the Nested Set pattern.
     *
     *	Database columns needed: id, parent_id, lft, rgt, depth, name/title
     *
     *  @return Response

     */
    public function reorder()
    {
        $this->crud->hasAccessOrFail('reorder');
class MyClass { }

$x = new MyClass();
$x->foo = true;

        if (! $this->crud->isReorderEnabled()) {
            abort(403, 'Reorder is disabled.');
        }

        // get all results for that entity
        $this->data['entries'] = $this->crud->getEntries();
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->data['crud'] = $this->crud;
        $this->data['title'] = trans('backpack::crud.reorder').' '.$this->crud->entity_name;

        // load the view from /resources/views/vendor/backpack/crud/ if it exists, otherwise load the one in the package
        return view('crud::reorder', $this->data);
    }

    /**
     * Save the new order, using the Nested Set pattern.
     *
     * Database columns needed: id, parent_id, lft, rgt, depth, name/title
     *
     * @return
     */
    public function saveReorder()
    {
        $this->crud->hasAccessOrFail('reorder');

        $all_entries = \Request::input('tree');

        if (count($all_entries)) {
            $count = $this->crud->updateTreeOrder($all_entries);
        } else {
            return false;
        }

        return 'success for '.$count.' items';
    }

}

1			<?php
2
3			namespace Backpack\CRUD\app\Http\Controllers\CrudFeatures;
4
5			trait Reorder {
6
7			/**
8			* Reorder the items in the database using the Nested Set pattern.
9			*
10			* Database columns needed: id, parent_id, lft, rgt, depth, name/title
11			*
12			* @return Response
			0 ignored issues – show Documentation introduced 2016-09-26 11:32 UTC by Report Bug Copy Issue Report Should the return type not be `\Illuminate\View\View\|\I...\Contracts\View\Factory`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
13			*/
14			public function reorder()
15			{
16			$this->crud->hasAccessOrFail('reorder');
			0 ignored issues – show Bug introduced 2016-09-26 11:32 UTC by Report Bug Copy Issue Report The property `crud` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
17
18			if (! $this->crud->isReorderEnabled()) {
19			abort(403, 'Reorder is disabled.');
20			}
21
22			// get all results for that entity
23			$this->data['entries'] = $this->crud->getEntries();
			0 ignored issues – show Bug introduced 2016-09-26 11:32 UTC by Report Bug Copy Issue Report The property `data` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
24			$this->data['crud'] = $this->crud;
25			$this->data['title'] = trans('backpack::crud.reorder').' '.$this->crud->entity_name;
26
27			// load the view from /resources/views/vendor/backpack/crud/ if it exists, otherwise load the one in the package
28			return view('crud::reorder', $this->data);
29			}
30
31			/**
32			* Save the new order, using the Nested Set pattern.
33			*
34			* Database columns needed: id, parent_id, lft, rgt, depth, name/title
35			*
36			* @return
37			*/
38			public function saveReorder()
39			{
40			$this->crud->hasAccessOrFail('reorder');
41
42			$all_entries = \Request::input('tree');
43
44			if (count($all_entries)) {
45			$count = $this->crud->updateTreeOrder($all_entries);
46			} else {
47			return false;
48			}
49
50			return 'success for '.$count.' items';
51			}
52
53			}

Laravel-Backpack / CRUD

Scrutinizer GitHub App not installed

Push — master ( 7a24d5...09959f )

Reorder A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

Duplication Side-by-Side

Filter issues like