Laravel-Backpack / CRUD

src/app/Library/Auth/VerifiesEmails.php

Spacing +2 added lines, -2 removed lines

@@ -34,11 +34,11 @@
      */
     public function verify(Request $request)
     {
-        if (! hash_equals((string) $request->route('id'), (string) $request->user()->getKey())) {
+        if (!hash_equals((string) $request->route('id'), (string) $request->user()->getKey())) {
             throw new AuthorizationException;
         }
 
-        if (! hash_equals((string) $request->route('hash'), sha1($request->user()->getEmailForVerification()))) {
+        if (!hash_equals((string) $request->route('hash'), sha1($request->user()->getEmailForVerification()))) {
             throw new AuthorizationException;
         }
 

src/app/Library/CrudPanel/Traits/Buttons.php

Doc Comments +14 added lines, -2 removed lines

@@ -16,7 +16,7 @@ 
      *
      *
      * @param string      $stack           Stack where the buttons belongs. Options: top, line, bottom.
-     * @param array       $order           Ordered name of the buttons. ['update', 'delete', 'show']
+     * @param string[]       $order           Ordered name of the buttons. ['update', 'delete', 'show']
      */
     public function orderButtons(string $stack, array $order)
     {
@@ -106,6 +106,9 @@ 
         $this->addButton($stack, $name, 'model_function', $model_function_name, $position);
     }
 
+    /**
+     * @param string $view
+     */
     public function addButtonFromView($stack, $name, $view, $position = false)
     {
         $view = 'crud::buttons.'.$view;
@@ -163,7 +166,7 @@ 
     }
 
     /**
-     * @param array       $names Button names
+     * @param string[]       $names Button names
      * @param string|null $stack Optional stack name.
      */
     public function removeButtons($names, $stack = null)
@@ -180,6 +183,9 @@ 
         $this->setOperationSetting('buttons', collect());
     }
 
+    /**
+     * @param string $stack
+     */
     public function removeAllButtonsFromStack($stack)
     {
         $this->setOperationSetting('buttons', $this->buttons()->reject(function ($button) use ($stack) {
@@ -202,6 +208,12 @@ 
     public $type = 'view';
     public $content;
 
+    /**
+     * @param string $stack
+     * @param string $name
+     * @param string $type
+     * @param string $content
+     */
     public function __construct($stack, $name, $type, $content)
     {
         $this->stack = $stack;

Spacing +9 added lines, -9 removed lines

@@ -24,7 +24,7 @@ 
         $otherButtons = collect([]);
 
         // we get the buttons that belong to the specified stack
-        $stackButtons = $this->buttons()->reject(function ($item) use ($stack, $otherButtons) {
+        $stackButtons = $this->buttons()->reject(function($item) use ($stack, $otherButtons) {
             if ($item->stack != $stack) {
                 // if the button does not belong to this stack we just add it for merging later
                 $otherButtons->push($item);
@@ -36,8 +36,8 @@ 
         });
 
         // we parse the ordered buttons
-        collect($order)->each(function ($btnKey) use ($newButtons, $stackButtons) {
-            if (! $button = $stackButtons->where('name', $btnKey)->first()) {
+        collect($order)->each(function($btnKey) use ($newButtons, $stackButtons) {
+            if (!$button = $stackButtons->where('name', $btnKey)->first()) {
                 abort(500, 'Button name [«'.$btnKey.'»] not found.');
             }
             $newButtons->push($button);
@@ -47,7 +47,7 @@ 
         // we add the remaining buttons to the end of the ordered ones
         if (count($newButtons) < count($stackButtons)) {
             foreach ($stackButtons as $button) {
-                if (! $newButtons->where('name', $button->name)->first()) {
+                if (!$newButtons->where('name', $button->name)->first()) {
                     $newButtons->push($button);
                 }
             }
@@ -136,7 +136,7 @@ 
          */
         $button = $this->buttons()->firstWhere('name', $name);
 
-        if (! $button) {
+        if (!$button) {
             abort(500, 'CRUD Button "'.$name.'" not found. Please check the button exists before you modify it.');
         }
 
@@ -157,7 +157,7 @@ 
      */
     public function removeButton($name, $stack = null)
     {
-        $this->setOperationSetting('buttons', $this->buttons()->reject(function ($button) use ($name, $stack) {
+        $this->setOperationSetting('buttons', $this->buttons()->reject(function($button) use ($name, $stack) {
             return $stack == null ? $button->name == $name : ($button->stack == $stack) && ($button->name == $name);
         }));
     }
@@ -168,7 +168,7 @@ 
      */
     public function removeButtons($names, $stack = null)
     {
-        if (! empty($names)) {
+        if (!empty($names)) {
             foreach ($names as $name) {
                 $this->removeButton($name, $stack);
             }
@@ -182,14 +182,14 @@ 
 
     public function removeAllButtonsFromStack($stack)
     {
-        $this->setOperationSetting('buttons', $this->buttons()->reject(function ($button) use ($stack) {
+        $this->setOperationSetting('buttons', $this->buttons()->reject(function($button) use ($stack) {
             return $button->stack == $stack;
         }));
     }
 
     public function removeButtonFromStack($name, $stack)
     {
-        $this->setOperationSetting('buttons', $this->buttons()->reject(function ($button) use ($name, $stack) {
+        $this->setOperationSetting('buttons', $this->buttons()->reject(function($button) use ($name, $stack) {
             return $button->name == $name && $button->stack == $stack;
         }));
     }

src/app/Models/Traits/HasEnumFields.php

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 namespace Backpack\CRUD\app\Models\Traits;
 
 use DB;
-use Illuminate\Database\Eloquent\Model;
 use Illuminate\Support\Facades\Config;
 
 /*

src/app/Models/Traits/HasFakeFields.php

Doc Comments +1 added lines, -1 removed lines

@@ -43,7 +43,7 @@
      *
      * @param array $columns - the database columns that contain the JSONs
      *
-     * @return Model
+     * @return HasFakeFields
      */
     public function withFakes($columns = [])
     {

Spacing +3 added lines, -3 removed lines

@@ -20,7 +20,7 @@ 
     public function addFakes($columns = ['extras'])
     {
         foreach ($columns as $key => $column) {
-            if (! isset($this->attributes[$column])) {
+            if (!isset($this->attributes[$column])) {
                 continue;
             }
 
@@ -69,7 +69,7 @@ 
      */
     public function shouldDecodeFake($column)
     {
-        return ! in_array($column, array_keys($this->casts));
+        return !in_array($column, array_keys($this->casts));
     }
 
     /**
@@ -81,6 +81,6 @@ 
      */
     public function shouldEncodeFake($column)
     {
-        return ! in_array($column, array_keys($this->casts));
+        return !in_array($column, array_keys($this->casts));
     }
 }

src/app/Models/Traits/HasRelationshipFields.php

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 namespace Backpack\CRUD\app\Models\Traits;
 
 use DB;
-use Illuminate\Database\Eloquent\Model;
 use Illuminate\Support\Facades\Config;
 
 /*

Spacing +1 added lines, -1 removed lines

@@ -84,7 +84,7 @@
             // check for NOT NULL
             $notNull = $column->getNotnull();
             // return the value of nullable (aka the inverse of NOT NULL)
-            return ! $notNull;
+            return !$notNull;
         } catch (\Exception $e) {
             return true;
         }

src/app/Models/Traits/HasTranslatableFields.php

Unused Use Statements -2 removed lines

@@ -2,8 +2,6 @@
 
 namespace Backpack\CRUD\app\Models\Traits;
 
-use Illuminate\Database\Eloquent\Model;
-
 /*
 |--------------------------------------------------------------------------
 | Methods for working with translatable models.

tests/Unit/CrudPanel/CrudPanelAutoSetTest.php

Doc Comments +4 added lines

@@ -839,6 +839,10 @@
     }
 
     // allow us to run crud panel private/protected methods like `inferFieldTypeFromDbColumnType`
+
+    /**
+     * @param string $methodName
+     */
     public function invokeMethod(&$object, $methodName, array $parameters = [])
     {
         $reflection = new \ReflectionClass(get_class($object));

src/app/Models/Traits/HasUploadFields.php

Spacing +2 added lines, -2 removed lines

@@ -75,7 +75,7 @@ 
      */
     public function uploadMultipleFilesToDisk($value, $attribute_name, $disk, $destination_path)
     {
-        if (! is_array($this->{$attribute_name})) {
+        if (!is_array($this->{$attribute_name})) {
             $attribute_value = json_decode($this->{$attribute_name}, true) ?? [];
         } else {
             $attribute_value = $this->{$attribute_name};
@@ -87,7 +87,7 @@ 
         if ($files_to_clear) {
             foreach ($files_to_clear as $key => $filename) {
                 \Storage::disk($disk)->delete($filename);
-                $attribute_value = Arr::where($attribute_value, function ($value, $key) use ($filename) {
+                $attribute_value = Arr::where($attribute_value, function($value, $key) use ($filename) {
                     return $value != $filename;
                 });
             }

src/app/Http/Controllers/CrudController.php

Spacing +1 added lines, -1 removed lines

@@ -32,7 +32,7 @@
         //
         // It's done inside a middleware closure in order to have
         // the complete request inside the CrudPanel object.
-        $this->middleware(function ($request, $next) {
+        $this->middleware(function($request, $next) {
             $this->crud = app()->make('crud');
             $this->crud->setRequest($request);