Laravel-Backpack / CRUD

src/app/Library/CrudPanel/Traits/SaveActions.php

Spacing +15 added lines, -16 removed lines

@@ -46,7 +46,7 @@ 
      */
     public function getSaveActionByOrder($order)
     {
-        return array_filter($this->getOperationSetting('save_actions'), function ($arr) use ($order) {
+        return array_filter($this->getOperationSetting('save_actions'), function($arr) use ($order) {
             return $arr['order'] == $order;
         });
     }
@@ -80,7 +80,7 @@ 
         $orderCounter = $this->getOperationSetting('save_actions') !== null ? (count($this->getOperationSetting('save_actions')) + 1) : 1;
         //check for some mandatory fields
         $saveAction['name'] ?? abort(500, 'Please define save action name.');
-        $saveAction['redirect'] = $saveAction['redirect'] ?? function ($crud, $request, $itemId) {
+        $saveAction['redirect'] = $saveAction['redirect'] ?? function($crud, $request, $itemId) {
             return $request->has('http_referrer') ? $request->get('http_referrer') : $crud->route;
         };
         $saveAction['visible'] = $saveAction['visible'] ?? true;
@@ -89,7 +89,7 @@ 
 
         $actions = $this->getOperationSetting('save_actions') ?? [];
 
-        if (! in_array($saveAction['name'], $actions)) {
+        if (!in_array($saveAction['name'], $actions)) {
             $actions[$saveAction['name']] = $saveAction;
         }
 
@@ -106,7 +106,7 @@ 
     public function orderSaveAction(string $saveAction, int $wantedOrder)
     {
         $actions = $this->getOperationSetting('save_actions') ?? [];
-        if (! empty($actions)) {
+        if (!empty($actions)) {
             $replaceOrder = isset($actions[$saveAction]) ? $actions[$saveAction]['order'] : count($actions) + 1;
 
             foreach ($actions as $key => $sv) {
@@ -197,7 +197,7 @@ 
     public function orderSaveActions(array $saveActions)
     {
         foreach ($saveActions as $sv => $order) {
-            if (! is_int($order)) {
+            if (!is_int($order)) {
                 $this->orderSaveAction($order, $sv + 1);
             } else {
                 $this->orderSaveAction($sv, $order);
@@ -214,7 +214,7 @@ 
     {
         $actions = $this->getOperationSetting('save_actions') ?? [];
 
-        uasort($actions, function ($a, $b) {
+        uasort($actions, function($a, $b) {
             return $a['order'] <=> $b['order'];
         });
 
@@ -236,7 +236,7 @@ 
             }
         }
 
-        return array_filter($actions, function ($action) {
+        return array_filter($actions, function($action) {
             return $action['visible'] == true;
         }, ARRAY_FILTER_USE_BOTH);
     }
@@ -300,8 +300,7 @@ 
      */
     public function setSaveAction($forceSaveAction = null)
     {
-        $saveAction = $forceSaveAction ?:
-            \Request::input('save_action', $this->getFallBackSaveAction());
+        $saveAction = $forceSaveAction ?: \Request::input('save_action', $this->getFallBackSaveAction());
 
         $showBubble = $this->getOperationSetting('showSaveActionChange') ?? config('backpack.crud.operations.'.$this->getCurrentOperation().'.showSaveActionChange') ?? true;
 
@@ -369,20 +368,20 @@ 
         $defaultSaveActions = [
             [
                 'name' => 'save_and_back',
-                'visible' => function ($crud) {
+                'visible' => function($crud) {
                     return $crud->hasAccess('list');
                 },
-                'redirect' => function ($crud, $request, $itemId = null) {
+                'redirect' => function($crud, $request, $itemId = null) {
                     return $request->has('http_referrer') ? $request->get('http_referrer') : $crud->route;
                 },
                 'button_text' => trans('backpack::crud.save_action_save_and_back'),
             ],
             [
                 'name' => 'save_and_edit',
-                'visible' => function ($crud) {
+                'visible' => function($crud) {
                     return $crud->hasAccess('update');
                 },
-                'redirect' => function ($crud, $request, $itemId = null) {
+                'redirect' => function($crud, $request, $itemId = null) {
                     $itemId = $itemId ?: $request->input('id');
                     $redirectUrl = $crud->route.'/'.$itemId.'/edit';
                     if ($request->has('locale')) {
@@ -394,17 +393,17 @@ 
 
                     return $redirectUrl;
                 },
-                'referrer_url' => function ($crud, $request, $itemId) {
+                'referrer_url' => function($crud, $request, $itemId) {
                     return url($crud->route.'/'.$itemId.'/edit');
                 },
                 'button_text' => trans('backpack::crud.save_action_save_and_edit'),
             ],
             [
                 'name' => 'save_and_new',
-                'visible' => function ($crud) {
+                'visible' => function($crud) {
                     return $crud->hasAccess('create');
                 },
-                'redirect' => function ($crud, $request, $itemId = null) {
+                'redirect' => function($crud, $request, $itemId = null) {
                     return $this->route.'/create';
                 },
                 'button_text' => trans('backpack::crud.save_action_save_and_new'),

Doc Comments +2 added lines, -3 removed lines

@@ -155,7 +155,7 @@ 
     /**
      * Allow the developer to remove multiple save actions from settings.
      *
-     * @param array $saveActions
+     * @param string[] $saveActions
      * @return void
      */
     public function removeSaveActions(array $saveActions)
@@ -183,7 +183,6 @@ 
     /**
      * Allow the developer to unset all save actions.
      *
-     * @param string $saveAction
      * @return void
      */
     public function removeAllSaveActions()
@@ -194,7 +193,7 @@ 
     /**
      * Allows the developer to set save actions order. It could be ['action1','action2'] or ['action1' => 1, 'action2' => 2].
      *
-     * @param array $saveActions
+     * @param string[] $saveActions
      * @return void
      */
     public function orderSaveActions(array $saveActions)

src/resources/views/crud/columns/select_from_array.blade.php

Spacing +1 added lines, -1 removed lines

@@ -10,7 +10,7 @@
                 $array_of_values = [];
 
                 foreach ($values as $key => $value) {
-                    if (! is_null($value)) {
+                    if (!is_null($value)) {
                         $array_of_values[] = $column['options'][$value] ?? $value;
                     } else {
                         echo '-';

src/app/Library/CrudPanel/Traits/AutoSet.php

Doc Comments +1 added lines, -1 removed lines

@@ -89,7 +89,7 @@
     /**
      * Infer a field type, judging from the database column type.
      *
-     * @param string $field Field name.
+     * @param string $fieldName Field name.
      *
      * @return string Field type.
      */

Spacing +7 added lines, -7 removed lines

@@ -12,12 +12,12 @@ 
      */
     public function setFromDb()
     {
-        if (! $this->driverIsMongoDb()) {
+        if (!$this->driverIsMongoDb()) {
             $this->setDoctrineTypesMapping();
             $this->getDbColumnTypes();
         }
 
-        array_map(function ($field) {
+        array_map(function($field) {
             $new_field = [
                 'name'       => $field,
                 'label'      => $this->makeLabel($field),
@@ -29,11 +29,11 @@ 
                 'autoset'    => true,
             ];
 
-            if (! isset($this->fields()[$field])) {
+            if (!isset($this->fields()[$field])) {
                 $this->addField($new_field);
             }
 
-            if (! in_array($field, $this->model->getHidden()) && ! in_array($field, $this->columns())) {
+            if (!in_array($field, $this->model->getHidden()) && !in_array($field, $this->columns())) {
                 $this->addColumn([
                     'name'    => $field,
                     'label'   => $this->makeLabel($field),
@@ -105,7 +105,7 @@ 
 
         $dbColumnTypes = $this->getDbColumnTypes();
 
-        if (! isset($dbColumnTypes[$fieldName])) {
+        if (!isset($dbColumnTypes[$fieldName])) {
             return 'text';
         }
 
@@ -163,7 +163,7 @@ 
         $types = ['enum' => 'string'];
         $platform = $this->getSchema()->getConnection()->getDoctrineConnection()->getDatabasePlatform();
         foreach ($types as $type_key => $type_value) {
-            if (! $platform->hasDoctrineTypeMappingFor($type_key)) {
+            if (!$platform->hasDoctrineTypeMappingFor($type_key)) {
                 $platform->registerDoctrineTypeMapping($type_key, $type_value);
             }
         }
@@ -222,7 +222,7 @@ 
             // Automatically-set columns should be both in the database, and in the $fillable variable on the Eloquent Model
             $columns = $this->model->getConnection()->getSchemaBuilder()->getColumnListing($this->model->getTable());
 
-            if (! empty($fillable)) {
+            if (!empty($fillable)) {
                 $columns = array_intersect($columns, $fillable);
             }
         }

src/app/Library/CrudPanel/Traits/ColumnsProtectedMethods.php

Spacing +7 added lines, -8 removed lines

@@ -50,7 +50,7 @@ 
 
         // make sure the column has a priority in terms of visibility
         // if no priority has been defined, use the order in the array plus one
-        if (! array_key_exists('priority', $column)) {
+        if (!array_key_exists('priority', $column)) {
             $position_in_columns_array = (int) array_search($column['key'], array_keys($this->columns()));
             $allColumns[$column['key']]['priority'] = $position_in_columns_array + 1;
         }
@@ -71,7 +71,7 @@ 
             $column = ['name' => $column];
         }
 
-        if (is_array($column) && ! isset($column['name'])) {
+        if (is_array($column) && !isset($column['name'])) {
             $column['name'] = 'anonymous_column_'.Str::random(5);
         }
 
@@ -87,7 +87,7 @@ 
      */
     protected function makeSureColumnHasLabel($column)
     {
-        if (! isset($column['label'])) {
+        if (!isset($column['label'])) {
             $column['label'] = mb_ucfirst($this->makeLabel($column['name']));
         }
 
@@ -102,7 +102,7 @@ 
      */
     protected function makeSureColumnHasType($column)
     {
-        if (! isset($column['type'])) {
+        if (!isset($column['type'])) {
             $column['type'] = 'text';
         }
 
@@ -119,7 +119,7 @@ 
      */
     protected function makeSureColumnHasKey($column)
     {
-        if (! isset($column['key'])) {
+        if (!isset($column['key'])) {
             $column['key'] = str_replace('.', '__', $column['name']);
         }
 
@@ -137,7 +137,7 @@ 
     {
         // if this is a relation type field and no corresponding model was specified,
         // get it from the relation method defined in the main model
-        if (isset($column['entity']) && ! isset($column['model'])) {
+        if (isset($column['entity']) && !isset($column['model'])) {
             $column['model'] = $this->getRelationModel($column['entity']);
         }
 
@@ -158,8 +158,7 @@ 
         $columnsArray = $this->columns();
 
         if (array_key_exists($targetColumnName, $columnsArray)) {
-            $targetColumnPosition = $before ? array_search($targetColumnName, array_keys($columnsArray)) :
-                array_search($targetColumnName, array_keys($columnsArray)) + 1;
+            $targetColumnPosition = $before ? array_search($targetColumnName, array_keys($columnsArray)) : array_search($targetColumnName, array_keys($columnsArray)) + 1;
 
             $element = array_pop($columnsArray);
             $beginningPart = array_slice($columnsArray, 0, $targetColumnPosition, true);

tests/Unit/CrudPanel/CrudPanelSaveActionsTest.php

Spacing +6 added lines, -6 removed lines

@@ -21,10 +21,10 @@ 
 
         $this->singleSaveAction = [
             'name' => 'save_action_one',
-            'redirect' => function ($crud, $request, $itemId) {
+            'redirect' => function($crud, $request, $itemId) {
                 return $crud->route;
             },
-            'visible' => function ($crud) {
+            'visible' => function($crud) {
                 return true;
             },
         ];
@@ -32,19 +32,19 @@ 
         $this->multipleSaveActions = [
             [
                 'name' => 'save_action_one',
-                'redirect' => function ($crud, $request, $itemId) {
+                'redirect' => function($crud, $request, $itemId) {
                     return $crud->route;
                 },
-                'visible' => function ($crud) {
+                'visible' => function($crud) {
                     return true;
                 },
             ],
             [
                 'name' => 'save_action_two',
-                'redirect' => function ($crud, $request, $itemId) {
+                'redirect' => function($crud, $request, $itemId) {
                     return $crud->route;
                 },
-                'visible' => function ($crud) {
+                'visible' => function($crud) {
                     return true;
                 },
             ],

src/app/Library/CrudPanel/Traits/Relationships.php

Doc Comments +1 added lines, -1 removed lines

@@ -67,7 +67,7 @@
     /**
      * Gets the relation data from the method in the model.
      *
-     * @param ReflectionMethod $method
+     * @param \ReflectionMethod $method
      * @return array
      */
     public function inferFieldAttributesFromRelationship($method)

Spacing +1 added lines, -1 removed lines

@@ -24,7 +24,7 @@
         }
 
         if (in_array($fieldName, array_column($relations, 'name'))) {
-            return array_filter($relations, function ($arr) use ($fieldName) {
+            return array_filter($relations, function($arr) use ($fieldName) {
                 if (isset($arr['name'])) {
                     return $arr['name'] == $fieldName;
                 }

src/app/Http/Controllers/Operations/InlineCreateOperation.php

Spacing +1 added lines, -1 removed lines

@@ -49,7 +49,7 @@
      */
     public function getInlineCreateModal()
     {
-        if (! request()->has('entity')) {
+        if (!request()->has('entity')) {
             abort(400, 'No "entity" inside the request.');
         }
 

src/app/Http/Controllers/Operations/FetchOperation.php

Spacing +4 added lines, -6 removed lines

@@ -45,8 +45,8 @@ 
         // otherwise assume the arguments are actually the configuration array
         $config = [];
 
-        if (! is_array($arg)) {
-            if (! class_exists($arg)) {
+        if (!is_array($arg)) {
+            if (!class_exists($arg)) {
                 return response()->json(['error' => 'Class: '.$arg.' does not exists'], 500);
             }
             $config['model'] = $arg;
@@ -65,8 +65,7 @@ 
 
         if ($searchString === false) {
             return ($config['paginate'] !== false) ?
-            $config['query']->paginate($config['paginate']) :
-            $config['query']->get();
+            $config['query']->paginate($config['paginate']) : $config['query']->get();
         }
 
         // for each searchable attribute, add a WHERE clause
@@ -83,7 +82,6 @@ 
 
         // return the results with or without pagination
         return ($config['paginate'] !== false) ?
-                    $config['query']->paginate($config['paginate']) :
-                    $config['query']->get();
+                    $config['query']->paginate($config['paginate']) : $config['query']->get();
     }
 }

src/app/Library/Auth/AuthenticatesUsers.php

Doc Comments +1 added lines, -1 removed lines

@@ -123,7 +123,7 @@
      * The user has been authenticated.
      *
      * @param  \Illuminate\Http\Request  $request
-     * @param  mixed  $user
+     * @param  \Illuminate\Contracts\Auth\Authenticatable|null  $user
      * @return mixed
      */
     protected function authenticated(Request $request, $user)