Laravel-Backpack / CRUD

src/app/Http/Controllers/Operations/ListOperation.php

Spacing +4 added lines, -4 removed lines

@@ -41,7 +41,7 @@ 
     {
         $this->crud->allowAccess('list');
 
-        $this->crud->operation('list', function () {
+        $this->crud->operation('list', function() {
             $this->crud->loadDefaultOperationSettingsFromConfig();
         });
     }
@@ -112,8 +112,8 @@ 
         // if there was an order set, this will be the last one (after all others were applied)
         $orderBy = $this->crud->query->getQuery()->orders;
         $hasOrderByPrimaryKey = false;
-        collect($orderBy)->each(function ($item, $key) use ($hasOrderByPrimaryKey) {
-            if (! isset($item['column'])) {
+        collect($orderBy)->each(function($item, $key) use ($hasOrderByPrimaryKey) {
+            if (!isset($item['column'])) {
                 return false;
             }
 
@@ -123,7 +123,7 @@ 
                 return false;
             }
         });
-        if (! $hasOrderByPrimaryKey) {
+        if (!$hasOrderByPrimaryKey) {
             $this->crud->query->orderByDesc($this->crud->model->getKeyName());
         }
 

tests/Unit/Http/CrudControllerTest.php

Unused Use Statements +1 added lines, -1 removed lines

@@ -2,8 +2,8 @@
 
 namespace Backpack\CRUD\Tests\Unit\Http;
 
-use Backpack\CRUD\app\Library\CrudPanel\CrudPanel;
 use Backpack\CRUD\Tests\BaseTest;
+use Backpack\CRUD\app\Library\CrudPanel\CrudPanel;
 
 class CrudControllerTest extends BaseTest
 {

Spacing +1 added lines, -1 removed lines

@@ -21,7 +21,7 @@
         $app['router']->get('users/{id}/edit', "$controller@edit");
         $app['router']->put('users/{id}', "$controller@update");
 
-        $app->singleton('crud', function ($app) {
+        $app->singleton('crud', function($app) {
             return new CrudPanel($app);
         });
     }

src/app/Library/CrudPanel/Traits/Columns.php

Doc Comments +2 added lines, -2 removed lines

@@ -141,7 +141,7 @@ 
     /**
      * Move the most recently added column after the given target column.
      *
-     * @param string|array $targetColumn The target column name or array.
+     * @param string $targetColumn The target column name or array.
      */
     public function afterColumn($targetColumn)
     {
@@ -161,7 +161,7 @@ 
     /**
      * Move this column to be first in the columns list.
      *
-     * @return bool|null
+     * @return false|null
      */
     public function makeFirstColumn()
     {

Spacing +3 added lines, -3 removed lines

@@ -112,7 +112,7 @@ 
      */
     public function makeFirstColumn()
     {
-        if (! $this->columns()) {
+        if (!$this->columns()) {
             return false;
         }
 
@@ -157,7 +157,7 @@ 
      */
     public function removeColumns($columns)
     {
-        if (! empty($columns)) {
+        if (!empty($columns)) {
             foreach ($columns as $columnKey) {
                 $this->removeColumn($columnKey);
             }
@@ -236,7 +236,7 @@ 
     {
         $columns = $this->columns();
 
-        return collect($columns)->pluck('entity')->reject(function ($value, $key) {
+        return collect($columns)->pluck('entity')->reject(function($value, $key) {
             return $value == null;
         })->toArray();
     }

src/app/Console/Commands/Install.php

Doc Comments +1 added lines, -1 removed lines

@@ -30,7 +30,7 @@
     /**
      * Execute the console command.
      *
-     * @return mixed Command-line output
+     * @return false|null Command-line output
      */
     public function handle()
     {

Spacing +3 added lines, -3 removed lines

@@ -94,7 +94,7 @@ 
                     $createUploadDirectoryCommand = ['mkdir', '-p', 'public/uploads'];
                     break;
                 case '\\': // windows
-                    if (! file_exists('public\uploads')) {
+                    if (!file_exists('public\uploads')) {
                         $createUploadDirectoryCommand = ['mkdir', 'public\uploads'];
                     }
                     break;
@@ -147,7 +147,7 @@ 
         $command = is_string($command) ? explode(' ', $command) : $command;
 
         $process = new Process($command, null, null, null, $this->option('timeout'));
-        $process->run(function ($type, $buffer) {
+        $process->run(function($type, $buffer) {
             if (Process::ERR === $type) {
                 $this->echo('comment', $buffer);
             } else {
@@ -156,7 +156,7 @@ 
         });
 
         // executes after the command finishes
-        if (! $process->isSuccessful()) {
+        if (!$process->isSuccessful()) {
             throw new ProcessFailedException($process);
         }
 

src/app/Library/CrudPanel/Traits/Fields.php

Doc Comments +2 added lines, -4 removed lines

@@ -326,8 +326,6 @@ 
      * Check if the create/update form has upload fields.
      * Upload fields are the ones that have "upload" => true defined on them.
      *
-     * @param string   $form create/update/both - defaults to 'both'
-     * @param bool|int $id   id of the entity - defaults to false
      *
      * @return bool
      */
@@ -358,7 +356,7 @@ 
     /**
      * Set an array of field type names as already loaded for the current operation.
      *
-     * @param array $fieldTypes
+     * @param string[] $fieldTypes
      */
     public function setLoadedFieldTypes($fieldTypes)
     {
@@ -369,7 +367,7 @@ 
      * Get a namespaced version of the field type name.
      * Appends the 'view_namespace' attribute of the field to the `type', using dot notation.
      *
-     * @param  mixed $field
+     * @param  string $field
      * @return string Namespaced version of the field type name. Ex: 'text', 'custom.view.path.text'
      */
     public function getFieldTypeWithNamespace($field)

Spacing +10 added lines, -10 removed lines

@@ -61,7 +61,7 @@ 
      */
     public function afterField($targetFieldName)
     {
-        $this->transformFields(function ($fields) use ($targetFieldName) {
+        $this->transformFields(function($fields) use ($targetFieldName) {
             return $this->moveField($fields, $targetFieldName, false);
         });
     }
@@ -73,7 +73,7 @@ 
      */
     public function beforeField($targetFieldName)
     {
-        $this->transformFields(function ($fields) use ($targetFieldName) {
+        $this->transformFields(function($fields) use ($targetFieldName) {
             return $this->moveField($fields, $targetFieldName, true);
         });
     }
@@ -85,7 +85,7 @@ 
      */
     public function removeField($name)
     {
-        $this->transformFields(function ($fields) use ($name) {
+        $this->transformFields(function($fields) use ($name) {
             Arr::forget($fields, $name);
 
             return $fields;
@@ -99,7 +99,7 @@ 
      */
     public function removeFields($array_of_names)
     {
-        if (! empty($array_of_names)) {
+        if (!empty($array_of_names)) {
             foreach ($array_of_names as $name) {
                 $this->removeField($name);
             }
@@ -112,7 +112,7 @@ 
     public function removeAllFields()
     {
         $current_fields = $this->getCurrentFields();
-        if (! empty($current_fields)) {
+        if (!empty($current_fields)) {
             foreach ($current_fields as $field) {
                 $this->removeField($field['name']);
             }
@@ -186,7 +186,7 @@ 
                 $jsonCastables = ['array', 'object', 'json'];
                 $fieldCasting = $casted_attributes[$field['name']];
 
-                if (in_array($fieldCasting, $jsonCastables) && isset($data[$field['name']]) && ! empty($data[$field['name']]) && ! is_array($data[$field['name']])) {
+                if (in_array($fieldCasting, $jsonCastables) && isset($data[$field['name']]) && !empty($data[$field['name']]) && !is_array($data[$field['name']])) {
                     try {
                         $data[$field['name']] = json_decode($data[$field['name']]);
                     } catch (\Exception $e) {
@@ -215,7 +215,7 @@ 
      */
     public function orderFields($order)
     {
-        $this->transformFields(function ($fields) use ($order) {
+        $this->transformFields(function($fields) use ($order) {
             return $this->applyOrderToFields($fields, $order);
         });
     }
@@ -242,7 +242,7 @@ 
     public function hasUploadFields()
     {
         $fields = $this->getFields();
-        $upload_fields = Arr::where($fields, function ($value, $key) {
+        $upload_fields = Arr::where($fields, function($value, $key) {
             return isset($value['upload']) && $value['upload'] == true;
         });
 
@@ -305,7 +305,7 @@ 
         $alreadyLoaded = $this->getLoadedFieldTypes();
         $type = $this->getFieldTypeWithNamespace($field);
 
-        if (! in_array($type, $this->getLoadedFieldTypes(), true)) {
+        if (!in_array($type, $this->getLoadedFieldTypes(), true)) {
             $alreadyLoaded[] = $type;
             $this->setLoadedFieldTypes($alreadyLoaded);
 
@@ -346,7 +346,7 @@ 
      */
     public function fieldTypeNotLoaded($field)
     {
-        return ! in_array($this->getFieldTypeWithNamespace($field), $this->getLoadedFieldTypes());
+        return !in_array($this->getFieldTypeWithNamespace($field), $this->getLoadedFieldTypes());
     }
 
     /**

src/app/Http/Controllers/Auth/LoginController.php

Doc Comments +1 added lines, -1 removed lines

@@ -67,7 +67,7 @@
      *
      * @param \Illuminate\Http\Request $request
      *
-     * @return mixed
+     * @return \Illuminate\Http\RedirectResponse
      */
     protected function loggedOut(Request $request)
     {

src/routes/backpack/custom.php

Spacing +1 added lines, -1 removed lines

@@ -13,5 +13,5 @@
         config('backpack.base.middleware_key', 'admin'),
     ],
     'namespace'  => 'App\Http\Controllers\Admin',
-], function () { // custom admin routes
+], function() { // custom admin routes
 }); // this should be the absolute last line of this file

src/routes/backpack/base.php

Spacing +1 added lines, -1 removed lines

@@ -16,7 +16,7 @@
     'middleware' => config('backpack.base.web_middleware', 'web'),
     'prefix'     => config('backpack.base.route_prefix'),
 ],
-function () {
+function() {
     // if not otherwise configured, setup the auth routes
     if (config('backpack.base.setup_auth_routes')) {
         // Authentication Routes...

src/app/Http/Controllers/Operations/CreateOperation.php

Spacing +2 added lines, -2 removed lines

@@ -41,12 +41,12 @@
     {
         $this->crud->allowAccess('create');
 
-        $this->crud->operation('create', function () {
+        $this->crud->operation('create', function() {
             $this->crud->loadDefaultOperationSettingsFromConfig();
             $this->crud->setupDefaultSaveActions();
         });
 
-        $this->crud->operation('list', function () {
+        $this->crud->operation('list', function() {
             $this->crud->addButton('top', 'create', 'view', 'crud::buttons.create');
         });
     }