Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Passed
Push — add-tests ( da9ce7 )
by Pedro
14:57
created
src/app/Library/CrudPanel/CrudPanel.php 1 patch
Spacing   +17 added lines, -17 removed lines patch added patch discarded remove patch
@@ -109,11 +109,11 @@  discard block
 block discarded – undo
109 109
      */
110 110
     public function setModel($model_namespace)
111 111
     {
112
-        if (! class_exists($model_namespace)) {
112
+        if (!class_exists($model_namespace)) {
113 113
             throw new Exception('The model does not exist.', 500);
114 114
         }
115 115
 
116
-        if (! method_exists($model_namespace, 'hasCrudTrait')) {
116
+        if (!method_exists($model_namespace, 'hasCrudTrait')) {
117 117
             throw new Exception('Please use CrudTrait on the model.', 500);
118 118
         }
119 119
 
@@ -206,7 +206,7 @@  discard block
 block discarded – undo
206 206
 
207 207
         $complete_route = $route.'.index';
208 208
 
209
-        if (! \Route::has($complete_route)) {
209
+        if (!\Route::has($complete_route)) {
210 210
             throw new Exception('There are no routes for this route name.', 404);
211 211
         }
212 212
 
@@ -304,7 +304,7 @@  discard block
 block discarded – undo
304 304
      */
305 305
     public function getFirstOfItsTypeInArray($type, $array)
306 306
     {
307
-        return Arr::first($array, function ($item) use ($type) {
307
+        return Arr::first($array, function($item) use ($type) {
308 308
             return $item['type'] == $type;
309 309
         });
310 310
     }
@@ -324,8 +324,8 @@  discard block
 block discarded – undo
324 324
      */
325 325
     public function sync($type, $fields, $attributes)
326 326
     {
327
-        if (! empty($this->{$type})) {
328
-            $this->{$type} = array_map(function ($field) use ($fields, $attributes) {
327
+        if (!empty($this->{$type})) {
328
+            $this->{$type} = array_map(function($field) use ($fields, $attributes) {
329 329
                 if (in_array($field['name'], (array) $fields)) {
330 330
                     $field = array_merge($field, $attributes);
331 331
                 }
@@ -355,15 +355,15 @@  discard block
 block discarded – undo
355 355
     {
356 356
         $relationArray = explode('.', $relationString);
357 357
 
358
-        if (! isset($length)) {
358
+        if (!isset($length)) {
359 359
             $length = count($relationArray);
360 360
         }
361 361
 
362
-        if (! isset($model)) {
362
+        if (!isset($model)) {
363 363
             $model = $this->model;
364 364
         }
365 365
 
366
-        $result = array_reduce(array_splice($relationArray, 0, $length), function ($obj, $method) {
366
+        $result = array_reduce(array_splice($relationArray, 0, $length), function($obj, $method) {
367 367
             try {
368 368
                 $result = $obj->$method();
369 369
 
@@ -399,7 +399,7 @@  discard block
 block discarded – undo
399 399
             if (is_array($entries)) {
400 400
                 //if attribute does not exist in main array we have more than one entry OR the attribute
401 401
                 //is an accessor that is not in $appends property of model.
402
-                if (! isset($entries[$attribute])) {
402
+                if (!isset($entries[$attribute])) {
403 403
                     //we first check if we don't have the attribute because it's an accessor that is not in appends.
404 404
                     if ($model_instance->hasGetMutator($attribute) && isset($entries[$modelKey])) {
405 405
                         $entry_in_database = $model_instance->find($entries[$modelKey]);
@@ -438,21 +438,21 @@  discard block
 block discarded – undo
438 438
      */
439 439
     public function parseTranslatableAttributes($model, $attribute, $value)
440 440
     {
441
-        if (! method_exists($model, 'isTranslatableAttribute')) {
441
+        if (!method_exists($model, 'isTranslatableAttribute')) {
442 442
             return $value;
443 443
         }
444 444
 
445
-        if (! $model->isTranslatableAttribute($attribute)) {
445
+        if (!$model->isTranslatableAttribute($attribute)) {
446 446
             return $value;
447 447
         }
448 448
 
449
-        if (! is_array($value)) {
449
+        if (!is_array($value)) {
450 450
             $decodedAttribute = json_decode($value, true) ?? ($value !== null ? [$value] : []);
451 451
         } else {
452 452
             $decodedAttribute = $value;
453 453
         }
454 454
 
455
-        if (is_array($decodedAttribute) && ! empty($decodedAttribute)) {
455
+        if (is_array($decodedAttribute) && !empty($decodedAttribute)) {
456 456
             if (isset($decodedAttribute[app()->getLocale()])) {
457 457
                 return $decodedAttribute[app()->getLocale()];
458 458
             } else {
@@ -470,7 +470,7 @@  discard block
 block discarded – undo
470 470
         if (method_exists($model, 'translationEnabled') && $model->translationEnabled()) {
471 471
             $locale = $this->getRequest()->input('_locale', app()->getLocale());
472 472
             if (in_array($locale, array_keys($model->getAvailableLocales()))) {
473
-                $model->setLocale(! is_bool($useFallbackLocale) ? $useFallbackLocale : $locale);
473
+                $model->setLocale(!is_bool($useFallbackLocale) ? $useFallbackLocale : $locale);
474 474
                 $model->useFallbackLocale = (bool) $useFallbackLocale;
475 475
             }
476 476
         }
@@ -493,7 +493,7 @@  discard block
 block discarded – undo
493 493
         $relation = $model->{$firstRelationName};
494 494
 
495 495
         $results = [];
496
-        if (! is_null($relation)) {
496
+        if (!is_null($relation)) {
497 497
             if ($relation instanceof Collection) {
498 498
                 $currentResults = $relation->all();
499 499
             } elseif (is_array($relation)) {
@@ -506,7 +506,7 @@  discard block
 block discarded – undo
506 506
 
507 507
             array_shift($relationArray);
508 508
 
509
-            if (! empty($relationArray)) {
509
+            if (!empty($relationArray)) {
510 510
                 foreach ($currentResults as $currentResult) {
511 511
                     $results = array_merge_recursive($results, $this->getRelatedEntries($currentResult, implode('.', $relationArray)));
512 512
                 }
Please login to merge, or discard this patch.
src/app/Console/Commands/PublishHeaderMetas.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -60,7 +60,7 @@  discard block
 block discarded – undo
60 60
         ];
61 61
 
62 62
         foreach ($filesToPublish as $destination => $stub) {
63
-            if (! is_string($destination)) {
63
+            if (!is_string($destination)) {
64 64
                 $destination = $stub;
65 65
                 $stub = null;
66 66
             }
@@ -71,11 +71,11 @@  discard block
 block discarded – undo
71 71
                 continue;
72 72
             }
73 73
 
74
-            if (! File::isDirectory(dirname($destination))) {
74
+            if (!File::isDirectory(dirname($destination))) {
75 75
                 File::makeDirectory(dirname($destination), 0755, true);
76 76
             }
77 77
 
78
-            if (! $stub) {
78
+            if (!$stub) {
79 79
                 File::copy(__DIR__.'/../../../public/'.basename($destination), $destination);
80 80
                 $this->info("File {$destination} published.");
81 81
                 continue;
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Columns.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -74,7 +74,7 @@  discard block
 block discarded – undo
74 74
     /**
75 75
      * Add a column at the end of the CRUD object's "columns" array and return it.
76 76
      */
77
-    public function addAndReturnColumn(array|string $column): CrudColumn
77
+    public function addAndReturnColumn(array | string $column): CrudColumn
78 78
     {
79 79
         $column = $this->prepareAttributesAndAddColumn($column);
80 80
 
@@ -122,7 +122,7 @@  discard block
 block discarded – undo
122 122
      */
123 123
     public function makeFirstColumn()
124 124
     {
125
-        if (! $this->columns()) {
125
+        if (!$this->columns()) {
126 126
             return false;
127 127
         }
128 128
 
@@ -166,7 +166,7 @@  discard block
 block discarded – undo
166 166
      */
167 167
     public function removeColumns($columns)
168 168
     {
169
-        if (! empty($columns)) {
169
+        if (!empty($columns)) {
170 170
             foreach ($columns as $columnKey) {
171 171
                 $this->removeColumn($columnKey);
172 172
             }
@@ -331,7 +331,7 @@  discard block
 block discarded – undo
331 331
      */
332 332
     public function hasColumnWhere($attribute, $value)
333 333
     {
334
-        $match = Arr::first($this->columns(), function ($column, $columnKey) use ($attribute, $value) {
334
+        $match = Arr::first($this->columns(), function($column, $columnKey) use ($attribute, $value) {
335 335
             return isset($column[$attribute]) && $column[$attribute] == $value;
336 336
         });
337 337
 
@@ -347,7 +347,7 @@  discard block
 block discarded – undo
347 347
      */
348 348
     public function firstColumnWhere($attribute, $value)
349 349
     {
350
-        return Arr::first($this->columns(), function ($column, $columnKey) use ($attribute, $value) {
350
+        return Arr::first($this->columns(), function($column, $columnKey) use ($attribute, $value) {
351 351
             return isset($column[$attribute]) && $column[$attribute] == $value;
352 352
         });
353 353
     }
@@ -396,8 +396,8 @@  discard block
 block discarded – undo
396 396
      */
397 397
     public function countColumnsWithoutActions()
398 398
     {
399
-        return collect($this->columns())->filter(function ($column, $key) {
400
-            return ! isset($column['hasActions']) || $column['hasActions'] == false;
399
+        return collect($this->columns())->filter(function($column, $key) {
400
+            return !isset($column['hasActions']) || $column['hasActions'] == false;
401 401
         })->count();
402 402
     }
403 403
 
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Read.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -54,7 +54,7 @@  discard block
 block discarded – undo
54 54
     {
55 55
         $entry = $this->getCurrentEntry();
56 56
 
57
-        if (! $entry) {
57
+        if (!$entry) {
58 58
             return false;
59 59
         }
60 60
 
@@ -69,7 +69,7 @@  discard block
 block discarded – undo
69 69
      */
70 70
     public function getEntry($id)
71 71
     {
72
-        if (! $this->entry) {
72
+        if (!$this->entry) {
73 73
             if ($this->getOperationSetting('eagerLoadRelationships')) {
74 74
                 $this->eagerLoadRelationshipFields();
75 75
             }
@@ -80,7 +80,7 @@  discard block
 block discarded – undo
80 80
         return $this->entry;
81 81
     }
82 82
 
83
-    private function shouldUseFallbackLocale(): bool|string
83
+    private function shouldUseFallbackLocale(): bool | string
84 84
     {
85 85
         $fallbackRequestValue = $this->getRequest()->get('_fallback_locale');
86 86
 
@@ -96,7 +96,7 @@  discard block
 block discarded – undo
96 96
      */
97 97
     public function getEntryWithLocale($id)
98 98
     {
99
-        if (! $this->entry) {
99
+        if (!$this->entry) {
100 100
             $this->entry = $this->getEntry($id);
101 101
         }
102 102
 
@@ -147,7 +147,7 @@  discard block
 block discarded – undo
147 147
         foreach ($crudObjects as $crudObjectName => $attributes) {
148 148
             $relationString = isset($attributes['entity']) && $attributes['entity'] !== false ? $attributes['entity'] : '';
149 149
 
150
-            if (! $relationString) {
150
+            if (!$relationString) {
151 151
                 continue;
152 152
             }
153 153
 
@@ -213,7 +213,7 @@  discard block
 block discarded – undo
213 213
      */
214 214
     public function enableDetailsRow()
215 215
     {
216
-        if (! backpack_pro()) {
216
+        if (!backpack_pro()) {
217 217
             throw new BackpackProRequiredException('Details row');
218 218
         }
219 219
 
@@ -312,7 +312,7 @@  discard block
 block discarded – undo
312 312
                 // we will apply the same labels as the values to the menu if developer didn't
313 313
                 $this->abortIfInvalidPageLength($menu[0]);
314 314
 
315
-                if (! isset($menu[1]) || ! is_array($menu[1])) {
315
+                if (!isset($menu[1]) || !is_array($menu[1])) {
316 316
                     $menu[1] = $menu[0];
317 317
                 }
318 318
             } else {
@@ -400,7 +400,7 @@  discard block
 block discarded – undo
400 400
      */
401 401
     public function enableExportButtons()
402 402
     {
403
-        if (! backpack_pro()) {
403
+        if (!backpack_pro()) {
404 404
             throw new BackpackProRequiredException('Export buttons');
405 405
         }
406 406
 
Please login to merge, or discard this patch.
src/routes/backpack/custom.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -15,7 +15,7 @@
 block discarded – undo
15 15
         (array) config('backpack.base.middleware_key', 'admin')
16 16
     ),
17 17
     'namespace' => 'App\Http\Controllers\Admin',
18
-], function () { // custom admin routes
18
+], function() { // custom admin routes
19 19
 }); // this should be the absolute last line of this file
20 20
 
21 21
 /**
Please login to merge, or discard this patch.
tests/Unit/CrudPanel/CrudPanelButtonsTest.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -276,7 +276,7 @@  discard block
 block discarded – undo
276 276
     public function testAddButtonFluently()
277 277
     {
278 278
         $button1 = CrudButton::name('lineTest')->to('line')->view('crud::buttons.test')->type('view');
279
-        $button2 = CrudButton::add('modelFunction')->model_function(function () {
279
+        $button2 = CrudButton::add('modelFunction')->model_function(function() {
280 280
             return 'test';
281 281
         })->section('top')->makeFirst();
282 282
         $this->assertEquals($button1->toArray(), $this->crudPanel->buttons()->last()->toArray());
@@ -290,7 +290,7 @@  discard block
 block discarded – undo
290 290
 
291 291
         $this->expectException(\Symfony\Component\HttpKernel\Exception\HttpException::class);
292 292
 
293
-        $this->crudPanel->modifyButton('unknownButton', function ($button) {
293
+        $this->crudPanel->modifyButton('unknownButton', function($button) {
294 294
             $button->name = 'newName';
295 295
         });
296 296
     }
@@ -342,7 +342,7 @@  discard block
 block discarded – undo
342 342
 
343 343
     private function getButtonByName($name)
344 344
     {
345
-        return $this->crudPanel->buttons()->first(function ($value) use ($name) {
345
+        return $this->crudPanel->buttons()->first(function($value) use ($name) {
346 346
             return $value->name == $name;
347 347
         });
348 348
     }
Please login to merge, or discard this patch.
tests/Unit/CrudPanel/CrudPanelAccessTest.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -105,7 +105,7 @@  discard block
 block discarded – undo
105 105
 
106 106
     public function testItCanUseAClosureToResolveAccess()
107 107
     {
108
-        $this->crudPanel->setAccessCondition('list', function () {
108
+        $this->crudPanel->setAccessCondition('list', function() {
109 109
             return true;
110 110
         });
111 111
 
@@ -116,7 +116,7 @@  discard block
 block discarded – undo
116 116
 
117 117
     public function testItCanUseAClosureToResolveAccessForMultipleOperations()
118 118
     {
119
-        $this->crudPanel->setAccessCondition(['list', 'create'], function () {
119
+        $this->crudPanel->setAccessCondition(['list', 'create'], function() {
120 120
             return true;
121 121
         });
122 122
 
@@ -127,7 +127,7 @@  discard block
 block discarded – undo
127 127
 
128 128
     public function testItCanCheckIfAnOperationHasAccessConditions()
129 129
     {
130
-        $this->crudPanel->setAccessCondition(['list', 'create'], function () {
130
+        $this->crudPanel->setAccessCondition(['list', 'create'], function() {
131 131
             return true;
132 132
         });
133 133
 
@@ -137,7 +137,7 @@  discard block
 block discarded – undo
137 137
 
138 138
     public function testItCanCheckAccessToAll()
139 139
     {
140
-        $this->crudPanel->allowAccess(['list', 'create'], function () {
140
+        $this->crudPanel->allowAccess(['list', 'create'], function() {
141 141
             return true;
142 142
         });
143 143
 
@@ -147,7 +147,7 @@  discard block
 block discarded – undo
147 147
 
148 148
     public function testItCanAllowAccessToSomeSpecificOperationWhileDenyingOthers()
149 149
     {
150
-        $this->crudPanel->allowAccess(['list', 'create'], function () {
150
+        $this->crudPanel->allowAccess(['list', 'create'], function() {
151 151
             return true;
152 152
         });
153 153
 
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Reorder.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -26,9 +26,9 @@  discard block
 block discarded – undo
26 26
         $itemKeys = $this->model->query()->select($primaryKey)->get()->pluck($primaryKey);
27 27
 
28 28
         // filter the items that are not in the database and map the request
29
-        $reorderItems = collect($request)->filter(function ($item) use ($itemKeys) {
29
+        $reorderItems = collect($request)->filter(function($item) use ($itemKeys) {
30 30
             return $item['item_id'] !== '' && $item['item_id'] !== null && $itemKeys->contains($item['item_id']);
31
-        })->map(function ($item) use ($primaryKey) {
31
+        })->map(function($item) use ($primaryKey) {
32 32
             $item[$primaryKey] = (int) $item['item_id'];
33 33
             $item['parent_id'] = empty($item['parent_id']) ? null : (int) $item['parent_id'];
34 34
             $item['depth'] = empty($item['depth']) ? null : (int) $item['depth'];
@@ -41,7 +41,7 @@  discard block
 block discarded – undo
41 41
         })->toArray();
42 42
 
43 43
         // wrap the queries in a transaction to avoid partial updates
44
-        DB::transaction(function () use ($reorderItems, $primaryKey, $itemKeys) {
44
+        DB::transaction(function() use ($reorderItems, $primaryKey, $itemKeys) {
45 45
             // create a string of ?,?,?,? to use as bind placeholders for item keys
46 46
             $reorderItemsBindString = implode(',', array_fill(0, count($reorderItems), '?'));
47 47
 
Please login to merge, or discard this patch.
tests/config/CrudPanel/BaseCrudPanel.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -24,7 +24,7 @@  discard block
 block discarded – undo
24 24
     {
25 25
         parent::setUp();
26 26
 
27
-        $this->app->singleton('crud', function ($app) {
27
+        $this->app->singleton('crud', function($app) {
28 28
             return new CrudPanel($app);
29 29
         });
30 30
         $this->crudPanel = app('crud');
@@ -43,7 +43,7 @@  discard block
 block discarded – undo
43 43
         $app['config']->set('database.default', 'testing');
44 44
         $app['config']->set('backpack.base.route_prefix', 'admin');
45 45
 
46
-        $app->bind('App\Http\Middleware\CheckIfAdmin', function () {
46
+        $app->bind('App\Http\Middleware\CheckIfAdmin', function() {
47 47
             return new class
48 48
             {
49 49
                 public function handle($request, $next)
Please login to merge, or discard this patch.