Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Passed
Pull Request — master (#2819)
by Tomoya
07:41
created
src/app/Library/CrudPanel/Traits/Create.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -82,7 +82,7 @@  discard block
 block discarded – undo
82 82
     {
83 83
         $all_relation_fields = $this->getRelationFields();
84 84
 
85
-        return Arr::where($all_relation_fields, function ($value, $key) {
85
+        return Arr::where($all_relation_fields, function($value, $key) {
86 86
             return isset($value['pivot']) && $value['pivot'];
87 87
         });
88 88
     }
@@ -161,11 +161,11 @@  discard block
 block discarded – undo
161 161
      */
162 162
     private function createRelationsForItem($item, $formattedData)
163 163
     {
164
-        if (! isset($formattedData['relations'])) {
164
+        if (!isset($formattedData['relations'])) {
165 165
             return false;
166 166
         }
167 167
         foreach ($formattedData['relations'] as $relationMethod => $relationData) {
168
-            if (! isset($relationData['model'])) {
168
+            if (!isset($relationData['model'])) {
169 169
                 continue;
170 170
             }
171 171
             $model = $relationData['model'];
@@ -219,13 +219,13 @@  discard block
 block discarded – undo
219 219
         foreach ($relation_fields as $relation_field) {
220 220
             $attributeKey = $this->parseRelationFieldNamesFromHtml([$relation_field])[0]['name'];
221 221
 
222
-            if (! is_null(Arr::get($data, $attributeKey)) && $relation_field['pivot'] !== true) {
222
+            if (!is_null(Arr::get($data, $attributeKey)) && $relation_field['pivot'] !== true) {
223 223
                 $key = implode('.relations.', explode('.', $this->getOnlyRelationEntity($relation_field)));
224 224
                 $fieldData = Arr::get($relationData, 'relations.'.$key, []);
225
-                if (! array_key_exists('model', $fieldData)) {
225
+                if (!array_key_exists('model', $fieldData)) {
226 226
                     $fieldData['model'] = $relation_field['model'];
227 227
                 }
228
-                if (! array_key_exists('parent', $fieldData)) {
228
+                if (!array_key_exists('parent', $fieldData)) {
229 229
                     $fieldData['parent'] = $this->getRelationModel($attributeKey, -1);
230 230
                 }
231 231
                 $relatedAttribute = Arr::last(explode('.', $attributeKey));
@@ -246,7 +246,7 @@  discard block
 block discarded – undo
246 246
 
247 247
         $related_method = Arr::last($entity_array);
248 248
 
249
-        if (! method_exists($relation_model, $related_method)) {
249
+        if (!method_exists($relation_model, $related_method)) {
250 250
             if (count($entity_array) <= 1) {
251 251
                 return $relation_field['entity'];
252 252
             } else {
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Update.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -52,7 +52,7 @@  discard block
 block discarded – undo
52 52
 
53 53
         foreach ($fields as &$field) {
54 54
             // set the value
55
-            if (! isset($field['value'])) {
55
+            if (!isset($field['value'])) {
56 56
                 if (isset($field['subfields'])) {
57 57
                     $field['value'] = [];
58 58
                     foreach ($field['subfields'] as $subfield) {
@@ -65,7 +65,7 @@  discard block
 block discarded – undo
65 65
         }
66 66
 
67 67
         // always have a hidden input for the entry id
68
-        if (! array_key_exists('id', $fields)) {
68
+        if (!array_key_exists('id', $fields)) {
69 69
             $fields['id'] = [
70 70
                 'name'  => $entry->getKeyName(),
71 71
                 'value' => $entry->getKey(),
@@ -91,7 +91,7 @@  discard block
 block discarded – undo
91 91
 
92 92
             $relation_array = explode('.', $relational_entity);
93 93
 
94
-            $relatedModel = $relatedModel = array_reduce(array_splice($relation_array, 0, -1), function ($obj, $method) {
94
+            $relatedModel = $relatedModel = array_reduce(array_splice($relation_array, 0, -1), function($obj, $method) {
95 95
                 return $obj->{$method} ? $obj->{$method} : $obj;
96 96
             }, $model);
97 97
 
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/FieldsProtectedMethods.php 1 patch
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -69,7 +69,7 @@  discard block
 block discarded – undo
69 69
      */
70 70
     public function overwriteFieldNameFromDotNotationToArray($field)
71 71
     {
72
-        if (! is_array($field['name']) && strpos($field['name'], '.') !== false) {
72
+        if (!is_array($field['name']) && strpos($field['name'], '.') !== false) {
73 73
             $entity_array = explode('.', $field['name']);
74 74
             $name_string = '';
75 75
 
@@ -96,7 +96,7 @@  discard block
 block discarded – undo
96 96
             return ['name' => $field];
97 97
         }
98 98
 
99
-        if (is_array($field) && ! isset($field['name'])) {
99
+        if (is_array($field) && !isset($field['name'])) {
100 100
             abort(500, 'All fields must have their name defined');
101 101
         }
102 102
 
@@ -154,13 +154,13 @@  discard block
 block discarded – undo
154 154
     protected function makeSureFieldHasRelationshipData($field)
155 155
     {
156 156
         // only do this if "entity" is defined on the field
157
-        if (! isset($field['entity'])) {
157
+        if (!isset($field['entity'])) {
158 158
             return $field;
159 159
         }
160 160
 
161 161
         $extraFieldAttributes = $this->inferFieldAttributesFromRelationship($field);
162 162
 
163
-        if (! empty($extraFieldAttributes)) {
163
+        if (!empty($extraFieldAttributes)) {
164 164
             $field = array_merge($field, $extraFieldAttributes);
165 165
         } else {
166 166
             abort(500, 'Unable to process relationship data: '.$field['name']);
@@ -172,7 +172,7 @@  discard block
 block discarded – undo
172 172
     protected function overwriteFieldNameFromEntity($field)
173 173
     {
174 174
         // if the entity doesn't have a dot, it means we don't need to overwrite the name
175
-        if (! Str::contains($field['entity'], '.')) {
175
+        if (!Str::contains($field['entity'], '.')) {
176 176
             return $field;
177 177
         }
178 178
 
@@ -184,7 +184,7 @@  discard block
 block discarded – undo
184 184
         if (count(explode('.', $field['entity'])) == count(explode('.', $this->getOnlyRelationEntity($field)))) {
185 185
             $field['name'] = implode('.', array_slice(explode('.', $field['entity']), 0, -1));
186 186
             $relation = $this->getRelationInstance($field);
187
-            if (! empty($field['name'])) {
187
+            if (!empty($field['name'])) {
188 188
                 $field['name'] .= '.';
189 189
             }
190 190
             $field['name'] .= $relation->getForeignKeyName();
@@ -197,7 +197,7 @@  discard block
 block discarded – undo
197 197
     {
198 198
         // if there's a model defined, but no attribute
199 199
         // guess an attribute using the indentifiableAttribute functionality in CrudTrait
200
-        if (isset($field['model']) && ! isset($field['attribute'])) {
200
+        if (isset($field['model']) && !isset($field['attribute'])) {
201 201
             $field['attribute'] = call_user_func([(new $field['model']), 'identifiableAttribute']);
202 202
         }
203 203
 
@@ -213,7 +213,7 @@  discard block
 block discarded – undo
213 213
      */
214 214
     protected function makeSureFieldHasLabel($field)
215 215
     {
216
-        if (! isset($field['label'])) {
216
+        if (!isset($field['label'])) {
217 217
             $name = is_array($field['name']) ? $field['name'][0] : $field['name'];
218 218
             $name = str_replace('_id', '', $name);
219 219
             $field['label'] = mb_ucfirst(str_replace('_', ' ', $name));
@@ -231,7 +231,7 @@  discard block
 block discarded – undo
231 231
      */
232 232
     protected function makeSureFieldHasType($field)
233 233
     {
234
-        if (! isset($field['type'])) {
234
+        if (!isset($field['type'])) {
235 235
             $field['type'] = isset($field['relation_type']) ? $this->inferFieldTypeFromFieldRelation($field) : $this->inferFieldTypeFromDbColumnType($field['name']);
236 236
         }
237 237
 
@@ -248,7 +248,7 @@  discard block
 block discarded – undo
248 248
     {
249 249
         // if a tab was mentioned, we should enable it
250 250
         if (isset($field['tab'])) {
251
-            if (! $this->tabsEnabled()) {
251
+            if (!$this->tabsEnabled()) {
252 252
                 $this->enableTabs();
253 253
             }
254 254
         }
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/CrudPanel.php 1 patch
Spacing   +19 added lines, -19 removed lines patch added patch discarded remove patch
@@ -100,11 +100,11 @@  discard block
 block discarded – undo
100 100
      */
101 101
     public function setModel($model_namespace)
102 102
     {
103
-        if (! class_exists($model_namespace)) {
103
+        if (!class_exists($model_namespace)) {
104 104
             throw new \Exception('The model does not exist.', 500);
105 105
         }
106 106
 
107
-        if (! method_exists($model_namespace, 'hasCrudTrait')) {
107
+        if (!method_exists($model_namespace, 'hasCrudTrait')) {
108 108
             throw new \Exception('Please use CrudTrait on the model.', 500);
109 109
         }
110 110
 
@@ -167,7 +167,7 @@  discard block
 block discarded – undo
167 167
     {
168 168
         $complete_route = $route.'.index';
169 169
 
170
-        if (! \Route::has($complete_route)) {
170
+        if (!\Route::has($complete_route)) {
171 171
             throw new \Exception('There are no routes for this route name.', 404);
172 172
         }
173 173
 
@@ -268,7 +268,7 @@  discard block
 block discarded – undo
268 268
      */
269 269
     public function getFirstOfItsTypeInArray($type, $array)
270 270
     {
271
-        return Arr::first($array, function ($item) use ($type) {
271
+        return Arr::first($array, function($item) use ($type) {
272 272
             return $item['type'] == $type;
273 273
         });
274 274
     }
@@ -285,8 +285,8 @@  discard block
 block discarded – undo
285 285
 
286 286
     public function sync($type, $fields, $attributes)
287 287
     {
288
-        if (! empty($this->{$type})) {
289
-            $this->{$type} = array_map(function ($field) use ($fields, $attributes) {
288
+        if (!empty($this->{$type})) {
289
+            $this->{$type} = array_map(function($field) use ($fields, $attributes) {
290 290
                 if (in_array($field['name'], (array) $fields)) {
291 291
                     $field = array_merge($field, $attributes);
292 292
                 }
@@ -317,15 +317,15 @@  discard block
 block discarded – undo
317 317
     {
318 318
         $relationArray = explode('.', $relationString);
319 319
 
320
-        if (! isset($length)) {
320
+        if (!isset($length)) {
321 321
             $length = count($relationArray);
322 322
         }
323 323
 
324
-        if (! isset($model)) {
324
+        if (!isset($model)) {
325 325
             $model = $this->model;
326 326
         }
327 327
 
328
-        $result = array_reduce(array_splice($relationArray, 0, $length), function ($obj, $method) {
328
+        $result = array_reduce(array_splice($relationArray, 0, $length), function($obj, $method) {
329 329
             try {
330 330
                 $result = $obj->$method();
331 331
 
@@ -357,7 +357,7 @@  discard block
 block discarded – undo
357 357
         foreach ($endModels as $model => $entries) {
358 358
             $model_instance = new $model();
359 359
             $modelKey = $model_instance->getKeyName();
360
-            if (is_array($entries) && ! isset($entries[$attribute])) {
360
+            if (is_array($entries) && !isset($entries[$attribute])) {
361 361
                 foreach ($entries as $entry) {
362 362
                     $attributes[$entry[$modelKey]] = $this->parseTranslatableAttributes($model_instance, $attribute, $entry[$attribute]);
363 363
                 }
@@ -382,21 +382,21 @@  discard block
 block discarded – undo
382 382
      */
383 383
     public function parseTranslatableAttributes($model, $attribute, $value)
384 384
     {
385
-        if (! method_exists($model, 'isTranslatableAttribute')) {
385
+        if (!method_exists($model, 'isTranslatableAttribute')) {
386 386
             return $value;
387 387
         }
388 388
 
389
-        if (! $model->isTranslatableAttribute($attribute)) {
389
+        if (!$model->isTranslatableAttribute($attribute)) {
390 390
             return $value;
391 391
         }
392 392
 
393
-        if (! is_array($value)) {
393
+        if (!is_array($value)) {
394 394
             $decodedAttribute = json_decode($value, true);
395 395
         } else {
396 396
             $decodedAttribute = $value;
397 397
         }
398 398
 
399
-        if (is_array($decodedAttribute) && ! empty($decodedAttribute)) {
399
+        if (is_array($decodedAttribute) && !empty($decodedAttribute)) {
400 400
             if (isset($decodedAttribute[app()->getLocale()])) {
401 401
                 return $decodedAttribute[app()->getLocale()];
402 402
             } else {
@@ -424,21 +424,21 @@  discard block
 block discarded – undo
424 424
         $currentResults = [];
425 425
 
426 426
         $results = [];
427
-        if (! is_null($relation)) {
428
-            if ($relation instanceof Collection && ! $relation->isEmpty()) {
427
+        if (!is_null($relation)) {
428
+            if ($relation instanceof Collection && !$relation->isEmpty()) {
429 429
                 $currentResults[get_class($relation->first())] = $relation->toArray();
430
-            } elseif (is_array($relation) && ! empty($relation)) {
430
+            } elseif (is_array($relation) && !empty($relation)) {
431 431
                 $currentResults[get_class($relation->first())] = $relation;
432 432
             } else {
433 433
                 //relation must be App\Models\Article or App\Models\Category
434
-                if (! $relation instanceof Collection && ! empty($relation)) {
434
+                if (!$relation instanceof Collection && !empty($relation)) {
435 435
                     $currentResults[get_class($relation)] = $relation->toArray();
436 436
                 }
437 437
             }
438 438
 
439 439
             array_shift($relationArray);
440 440
 
441
-            if (! empty($relationArray)) {
441
+            if (!empty($relationArray)) {
442 442
                 foreach ($currentResults as $model => $currentResult) {
443 443
                     $results[$model] = array_merge($results[$model], $this->getRelatedEntries($currentResult, implode('.', $relationArray)));
444 444
                 }
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Columns.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -114,7 +114,7 @@  discard block
 block discarded – undo
114 114
      */
115 115
     public function makeFirstColumn()
116 116
     {
117
-        if (! $this->columns()) {
117
+        if (!$this->columns()) {
118 118
             return false;
119 119
         }
120 120
 
@@ -159,7 +159,7 @@  discard block
 block discarded – undo
159 159
      */
160 160
     public function removeColumns($columns)
161 161
     {
162
-        if (! empty($columns)) {
162
+        if (!empty($columns)) {
163 163
             foreach ($columns as $columnKey) {
164 164
                 $this->removeColumn($columnKey);
165 165
             }
@@ -252,7 +252,7 @@  discard block
 block discarded – undo
252 252
     {
253 253
         $columns = $this->columns();
254 254
 
255
-        return collect($columns)->pluck('entity')->reject(function ($value, $key) {
255
+        return collect($columns)->pluck('entity')->reject(function($value, $key) {
256 256
             return $value == null;
257 257
         })->toArray();
258 258
     }
@@ -329,7 +329,7 @@  discard block
 block discarded – undo
329 329
      */
330 330
     public function hasColumnWhere($attribute, $value)
331 331
     {
332
-        $match = Arr::first($this->columns(), function ($column, $columnKey) use ($attribute, $value) {
332
+        $match = Arr::first($this->columns(), function($column, $columnKey) use ($attribute, $value) {
333 333
             return isset($column[$attribute]) && $column[$attribute] == $value;
334 334
         });
335 335
 
@@ -345,7 +345,7 @@  discard block
 block discarded – undo
345 345
      */
346 346
     public function firstColumnWhere($attribute, $value)
347 347
     {
348
-        return Arr::first($this->columns(), function ($column, $columnKey) use ($attribute, $value) {
348
+        return Arr::first($this->columns(), function($column, $columnKey) use ($attribute, $value) {
349 349
             return isset($column[$attribute]) && $column[$attribute] == $value;
350 350
         });
351 351
     }
@@ -378,7 +378,7 @@  discard block
 block discarded – undo
378 378
 
379 379
         // check if it's a method on the model,
380 380
         // that means it's a relationship
381
-        if (! $columnExistsInDb && method_exists($this->model, $column['name'])) {
381
+        if (!$columnExistsInDb && method_exists($this->model, $column['name'])) {
382 382
             $relatedModel = $this->model->{$column['name']}()->getRelated();
383 383
             $column['entity'] = $column['name'];
384 384
             $column['model'] = get_class($relatedModel);
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/ColumnsProtectedMethods.php 1 patch
Spacing   +9 added lines, -10 removed lines patch added patch discarded remove patch
@@ -21,7 +21,7 @@  discard block
 block discarded – undo
21 21
 
22 22
         // make sure the column has a priority in terms of visibility
23 23
         // if no priority has been defined, use the order in the array plus one
24
-        if (! array_key_exists('priority', $column)) {
24
+        if (!array_key_exists('priority', $column)) {
25 25
             $position_in_columns_array = (int) array_search($column['key'], array_keys($this->columns()));
26 26
             $allColumns[$column['key']]['priority'] = $position_in_columns_array + 1;
27 27
         }
@@ -42,7 +42,7 @@  discard block
 block discarded – undo
42 42
             $column = ['name' => $column];
43 43
         }
44 44
 
45
-        if (is_array($column) && ! isset($column['name'])) {
45
+        if (is_array($column) && !isset($column['name'])) {
46 46
             $column['name'] = 'anonymous_column_'.Str::random(5);
47 47
         }
48 48
 
@@ -58,7 +58,7 @@  discard block
 block discarded – undo
58 58
      */
59 59
     protected function makeSureColumnHasLabel($column)
60 60
     {
61
-        if (! isset($column['label'])) {
61
+        if (!isset($column['label'])) {
62 62
             $column['label'] = mb_ucfirst($this->makeLabel($column['name']));
63 63
         }
64 64
 
@@ -75,11 +75,11 @@  discard block
 block discarded – undo
75 75
     {
76 76
         // if it's got a method on the model with the same name
77 77
         // then it should be a relationship
78
-        if (! isset($column['type']) && method_exists($this->model, $column['name'])) {
78
+        if (!isset($column['type']) && method_exists($this->model, $column['name'])) {
79 79
             $column['type'] = 'relationship';
80 80
         }
81 81
 
82
-        if (! isset($column['type'])) {
82
+        if (!isset($column['type'])) {
83 83
             $column['type'] = 'text';
84 84
         }
85 85
 
@@ -96,7 +96,7 @@  discard block
 block discarded – undo
96 96
      */
97 97
     protected function makeSureColumnHasKey($column)
98 98
     {
99
-        if (! isset($column['key'])) {
99
+        if (!isset($column['key'])) {
100 100
             $column['key'] = str_replace('.', '__', $column['name']);
101 101
         }
102 102
 
@@ -114,7 +114,7 @@  discard block
 block discarded – undo
114 114
      */
115 115
     protected function makeSureColumnHasWrapper($column)
116 116
     {
117
-        if (! isset($column['wrapper'])) {
117
+        if (!isset($column['wrapper'])) {
118 118
             $column['wrapper'] = [];
119 119
         }
120 120
 
@@ -132,7 +132,7 @@  discard block
 block discarded – undo
132 132
     {
133 133
         // if this is a relation type field and no corresponding model was specified,
134 134
         // get it from the relation method defined in the main model
135
-        if (isset($column['entity']) && ! isset($column['model'])) {
135
+        if (isset($column['entity']) && !isset($column['model'])) {
136 136
             $column['model'] = $this->getRelationModel($column['entity']);
137 137
         }
138 138
 
@@ -153,8 +153,7 @@  discard block
 block discarded – undo
153 153
         $columnsArray = $this->columns();
154 154
 
155 155
         if (array_key_exists($targetColumnName, $columnsArray)) {
156
-            $targetColumnPosition = $before ? array_search($targetColumnName, array_keys($columnsArray)) :
157
-                array_search($targetColumnName, array_keys($columnsArray)) + 1;
156
+            $targetColumnPosition = $before ? array_search($targetColumnName, array_keys($columnsArray)) : array_search($targetColumnName, array_keys($columnsArray)) + 1;
158 157
 
159 158
             $element = array_pop($columnsArray);
160 159
             $beginningPart = array_slice($columnsArray, 0, $targetColumnPosition, true);
Please login to merge, or discard this patch.