Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Passed
Pull Request — master (#3123)
by Mokhlas
13:13
created
src/app/Console/Commands/Traits/PrettyCommandOutput.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -26,7 +26,7 @@  discard block
 block discarded – undo
26 26
         $command = is_string($command) ? explode(' ', $command) : $command;
27 27
 
28 28
         $process = new Process($command, null, null, null, $this->option('timeout'));
29
-        $process->run(function ($type, $buffer) {
29
+        $process->run(function($type, $buffer) {
30 30
             if (Process::ERR === $type) {
31 31
                 $this->echo('comment', $buffer);
32 32
             } else {
@@ -35,7 +35,7 @@  discard block
 block discarded – undo
35 35
         });
36 36
 
37 37
         // executes after the command finishes
38
-        if (! $process->isSuccessful()) {
38
+        if (!$process->isSuccessful()) {
39 39
             throw new ProcessFailedException($process);
40 40
         }
41 41
 
Please login to merge, or discard this patch.
src/BackpackServiceProvider.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -57,18 +57,18 @@  discard block
 block discarded – undo
57 57
     public function register()
58 58
     {
59 59
         // Bind the CrudPanel object to Laravel's service container
60
-        $this->app->singleton('crud', function ($app) {
60
+        $this->app->singleton('crud', function($app) {
61 61
             return new CrudPanel($app);
62 62
         });
63 63
 
64 64
         // Bind the widgets collection object to Laravel's service container
65
-        $this->app->singleton('widgets', function ($app) {
65
+        $this->app->singleton('widgets', function($app) {
66 66
             return new Collection();
67 67
         });
68 68
 
69 69
         // load a macro for Route,
70 70
         // helps developers load all routes for a CRUD resource in one line
71
-        if (! Route::hasMacro('crud')) {
71
+        if (!Route::hasMacro('crud')) {
72 72
             $this->addRouteMacro();
73 73
         }
74 74
 
@@ -84,7 +84,7 @@  discard block
 block discarded – undo
84 84
         $middleware_key = config('backpack.base.middleware_key');
85 85
         $middleware_class = config('backpack.base.middleware_class');
86 86
 
87
-        if (! is_array($middleware_class)) {
87
+        if (!is_array($middleware_class)) {
88 88
             $router->pushMiddlewareToGroup($middleware_key, $middleware_class);
89 89
 
90 90
             return;
@@ -182,7 +182,7 @@  discard block
 block discarded – undo
182 182
      */
183 183
     private function addRouteMacro()
184 184
     {
185
-        Route::macro('crud', function ($name, $controller) {
185
+        Route::macro('crud', function($name, $controller) {
186 186
             // put together the route name prefix,
187 187
             // as passed to the Route::group() statements
188 188
             $routeName = '';
Please login to merge, or discard this patch.
src/app/Library/Widget.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -144,7 +144,7 @@
 block discarded – undo
144 144
     {
145 145
         $itemExists = $this->collection()->contains('name', $this->attributes['name']);
146 146
 
147
-        if (! $itemExists) {
147
+        if (!$itemExists) {
148 148
             $this->collection()->put($this->attributes['name'], $this);
149 149
         } else {
150 150
             $this->collection()[$this->name] = $this;
Please login to merge, or discard this patch.
src/app/Http/Controllers/Operations/ShowOperation.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -30,21 +30,21 @@
 block discarded – undo
30 30
         $this->crud->allowAccess('show');
31 31
         $this->crud->setOperationSetting('setFromDb', true);
32 32
 
33
-        $this->crud->operation('show', function () {
33
+        $this->crud->operation('show', function() {
34 34
             $this->crud->loadDefaultOperationSettingsFromConfig();
35 35
         });
36 36
 
37
-        $this->crud->operation('list', function () {
37
+        $this->crud->operation('list', function() {
38 38
             $this->crud->addButton('line', 'show', 'view', 'crud::buttons.show', 'beginning');
39 39
         });
40 40
 
41
-        $this->crud->operation(['create', 'update'], function () {
41
+        $this->crud->operation(['create', 'update'], function() {
42 42
             $this->crud->addSaveAction([
43 43
                 'name' => 'save_and_preview',
44
-                'visible' => function ($crud) {
44
+                'visible' => function($crud) {
45 45
                     return $crud->hasAccess('show');
46 46
                 },
47
-                'redirect' => function ($crud, $request, $itemId = null) {
47
+                'redirect' => function($crud, $request, $itemId = null) {
48 48
                     $itemId = $itemId ?: $request->input('id');
49 49
                     $redirectUrl = $crud->route.'/'.$itemId.'/show';
50 50
                     if ($request->has('locale')) {
Please login to merge, or discard this patch.
src/resources/views/crud/fields/table.blade.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -3,7 +3,7 @@  discard block
 block discarded – undo
3 3
 <?php
4 4
     $max = isset($field['max']) && (int) $field['max'] > 0 ? $field['max'] : -1;
5 5
     $min = isset($field['min']) && (int) $field['min'] > 0 ? $field['min'] : -1;
6
-    $item_name = strtolower(isset($field['entity_singular']) && ! empty($field['entity_singular']) ? $field['entity_singular'] : $field['label']);
6
+    $item_name = strtolower(isset($field['entity_singular']) && !empty($field['entity_singular']) ? $field['entity_singular'] : $field['label']);
7 7
 
8 8
     $items = old(square_brackets_to_dots($field['name'])) ?? $field['value'] ?? $field['default'] ?? '';
9 9
 
@@ -15,12 +15,12 @@  discard block
 block discarded – undo
15 15
         } else {
16 16
             $items = '[]';
17 17
         }
18
-    } elseif (is_string($items) && ! is_array(json_decode($items))) {
18
+    } elseif (is_string($items) && !is_array(json_decode($items))) {
19 19
         $items = '[]';
20 20
     }
21 21
 
22 22
     // make sure columns are defined
23
-    if (! isset($field['columns'])) {
23
+    if (!isset($field['columns'])) {
24 24
         $field['columns'] = ['value' => 'Value'];
25 25
     }
26 26
 
Please login to merge, or discard this patch.
tests/Unit/CrudPanel/BaseCrudPanelTest.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -24,7 +24,7 @@
 block discarded – undo
24 24
     {
25 25
         parent::setUp();
26 26
 
27
-        $this->app->singleton('crud', function ($app) {
27
+        $this->app->singleton('crud', function($app) {
28 28
             return new CrudPanel($app);
29 29
         });
30 30
         $this->crudPanel = app('crud');
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/CrudFilter.php 2 patches
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -80,7 +80,7 @@  discard block
 block discarded – undo
80 80
      */
81 81
     public function wasNotApplied()
82 82
     {
83
-        return ! $this->applied;
83
+        return !$this->applied;
84 84
     }
85 85
 
86 86
     /**
@@ -101,7 +101,7 @@  discard block
 block discarded – undo
101 101
 
102 102
         $input = $input ?? new ParameterBag($this->crud()->getRequest()->all());
103 103
 
104
-        if (! $input->has($this->name)) {
104
+        if (!$input->has($this->name)) {
105 105
             return;
106 106
         }
107 107
 
Please login to merge, or discard this patch.
Braces   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -389,10 +389,12 @@
 block discarded – undo
389 389
         return $this->fallbackLogic($value);
390 390
     }
391 391
 
392
-    public function else($value)
392
+    public function else {
393
+        ($value)
393 394
     {
394 395
         return $this->fallbackLogic($value);
395 396
     }
397
+    }
396 398
 
397 399
     // ---------------
398 400
     // PRIVATE METHODS
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Fields.php 1 patch
Spacing   +13 added lines, -13 removed lines patch added patch discarded remove patch
@@ -62,7 +62,7 @@  discard block
 block discarded – undo
62 62
      */
63 63
     public function afterField($targetFieldName)
64 64
     {
65
-        $this->transformFields(function ($fields) use ($targetFieldName) {
65
+        $this->transformFields(function($fields) use ($targetFieldName) {
66 66
             return $this->moveField($fields, $targetFieldName, false);
67 67
         });
68 68
     }
@@ -74,7 +74,7 @@  discard block
 block discarded – undo
74 74
      */
75 75
     public function beforeField($targetFieldName)
76 76
     {
77
-        $this->transformFields(function ($fields) use ($targetFieldName) {
77
+        $this->transformFields(function($fields) use ($targetFieldName) {
78 78
             return $this->moveField($fields, $targetFieldName, true);
79 79
         });
80 80
     }
@@ -86,7 +86,7 @@  discard block
 block discarded – undo
86 86
      */
87 87
     public function makeFirstField()
88 88
     {
89
-        if (! $this->fields()) {
89
+        if (!$this->fields()) {
90 90
             return false;
91 91
         }
92 92
 
@@ -101,7 +101,7 @@  discard block
 block discarded – undo
101 101
      */
102 102
     public function removeField($name)
103 103
     {
104
-        $this->transformFields(function ($fields) use ($name) {
104
+        $this->transformFields(function($fields) use ($name) {
105 105
             Arr::forget($fields, $name);
106 106
 
107 107
             return $fields;
@@ -115,7 +115,7 @@  discard block
 block discarded – undo
115 115
      */
116 116
     public function removeFields($array_of_names)
117 117
     {
118
-        if (! empty($array_of_names)) {
118
+        if (!empty($array_of_names)) {
119 119
             foreach ($array_of_names as $name) {
120 120
                 $this->removeField($name);
121 121
             }
@@ -128,7 +128,7 @@  discard block
 block discarded – undo
128 128
     public function removeAllFields()
129 129
     {
130 130
         $current_fields = $this->getCurrentFields();
131
-        if (! empty($current_fields)) {
131
+        if (!empty($current_fields)) {
132 132
             foreach ($current_fields as $field) {
133 133
                 $this->removeField($field['name']);
134 134
             }
@@ -220,7 +220,7 @@  discard block
 block discarded – undo
220 220
                 $jsonCastables = ['array', 'object', 'json'];
221 221
                 $fieldCasting = $casted_attributes[$field['name']];
222 222
 
223
-                if (in_array($fieldCasting, $jsonCastables) && isset($data[$field['name']]) && ! empty($data[$field['name']]) && ! is_array($data[$field['name']])) {
223
+                if (in_array($fieldCasting, $jsonCastables) && isset($data[$field['name']]) && !empty($data[$field['name']]) && !is_array($data[$field['name']])) {
224 224
                     try {
225 225
                         $data[$field['name']] = json_decode($data[$field['name']]);
226 226
                     } catch (\Exception $e) {
@@ -249,7 +249,7 @@  discard block
 block discarded – undo
249 249
      */
250 250
     public function orderFields($order)
251 251
     {
252
-        $this->transformFields(function ($fields) use ($order) {
252
+        $this->transformFields(function($fields) use ($order) {
253 253
             return $this->applyOrderToFields($fields, $order);
254 254
         });
255 255
     }
@@ -276,7 +276,7 @@  discard block
 block discarded – undo
276 276
     public function hasUploadFields()
277 277
     {
278 278
         $fields = $this->getFields();
279
-        $upload_fields = Arr::where($fields, function ($value, $key) {
279
+        $upload_fields = Arr::where($fields, function($value, $key) {
280 280
             return isset($value['upload']) && $value['upload'] == true;
281 281
         });
282 282
 
@@ -339,7 +339,7 @@  discard block
 block discarded – undo
339 339
         $alreadyLoaded = $this->getLoadedFieldTypes();
340 340
         $type = $this->getFieldTypeWithNamespace($field);
341 341
 
342
-        if (! in_array($type, $this->getLoadedFieldTypes(), true)) {
342
+        if (!in_array($type, $this->getLoadedFieldTypes(), true)) {
343 343
             $alreadyLoaded[] = $type;
344 344
             $this->setLoadedFieldTypes($alreadyLoaded);
345 345
 
@@ -380,7 +380,7 @@  discard block
 block discarded – undo
380 380
      */
381 381
     public function fieldTypeNotLoaded($field)
382 382
     {
383
-        return ! in_array($this->getFieldTypeWithNamespace($field), $this->getLoadedFieldTypes());
383
+        return !in_array($this->getFieldTypeWithNamespace($field), $this->getLoadedFieldTypes());
384 384
     }
385 385
 
386 386
     /**
@@ -421,7 +421,7 @@  discard block
 block discarded – undo
421 421
      */
422 422
     public function hasFieldWhere($attribute, $value)
423 423
     {
424
-        $match = Arr::first($this->fields(), function ($field, $fieldKey) use ($attribute, $value) {
424
+        $match = Arr::first($this->fields(), function($field, $fieldKey) use ($attribute, $value) {
425 425
             return isset($field[$attribute]) && $field[$attribute] == $value;
426 426
         });
427 427
 
@@ -437,7 +437,7 @@  discard block
 block discarded – undo
437 437
      */
438 438
     public function firstFieldWhere($attribute, $value)
439 439
     {
440
-        return Arr::first($this->fields(), function ($field, $fieldKey) use ($attribute, $value) {
440
+        return Arr::first($this->fields(), function($field, $fieldKey) use ($attribute, $value) {
441 441
             return isset($field[$attribute]) && $field[$attribute] == $value;
442 442
         });
443 443
     }
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Buttons.php 1 patch
Spacing   +13 added lines, -13 removed lines patch added patch discarded remove patch
@@ -25,7 +25,7 @@  discard block
 block discarded – undo
25 25
         $otherButtons = collect([]);
26 26
 
27 27
         // we get the buttons that belong to the specified stack
28
-        $stackButtons = $this->buttons()->reject(function ($item) use ($stack, $otherButtons) {
28
+        $stackButtons = $this->buttons()->reject(function($item) use ($stack, $otherButtons) {
29 29
             if ($item->stack != $stack) {
30 30
                 // if the button does not belong to this stack we just add it for merging later
31 31
                 $otherButtons->push($item);
@@ -37,8 +37,8 @@  discard block
 block discarded – undo
37 37
         });
38 38
 
39 39
         // we parse the ordered buttons
40
-        collect($order)->each(function ($btnKey) use ($newButtons, $stackButtons) {
41
-            if (! $button = $stackButtons->where('name', $btnKey)->first()) {
40
+        collect($order)->each(function($btnKey) use ($newButtons, $stackButtons) {
41
+            if (!$button = $stackButtons->where('name', $btnKey)->first()) {
42 42
                 abort(500, 'Button name [«'.$btnKey.'»] not found.');
43 43
             }
44 44
             $newButtons->push($button);
@@ -48,7 +48,7 @@  discard block
 block discarded – undo
48 48
         // we add the remaining buttons to the end of the ordered ones
49 49
         if (count($newButtons) < count($stackButtons)) {
50 50
             foreach ($stackButtons as $button) {
51
-                if (! $newButtons->where('name', $button->name)->first()) {
51
+                if (!$newButtons->where('name', $button->name)->first()) {
52 52
                     $newButtons->push($button);
53 53
                 }
54 54
             }
@@ -114,7 +114,7 @@  discard block
 block discarded – undo
114 114
          */
115 115
         $button = $this->buttons()->firstWhere('name', $name);
116 116
 
117
-        if (! $button) {
117
+        if (!$button) {
118 118
             abort(500, 'CRUD Button "'.$name.'" not found. Please check the button exists before you modify it.');
119 119
         }
120 120
 
@@ -135,7 +135,7 @@  discard block
 block discarded – undo
135 135
      */
136 136
     public function removeButton($name, $stack = null)
137 137
     {
138
-        $this->setOperationSetting('buttons', $this->buttons()->reject(function ($button) use ($name, $stack) {
138
+        $this->setOperationSetting('buttons', $this->buttons()->reject(function($button) use ($name, $stack) {
139 139
             return $stack == null ? $button->name == $name : ($button->stack == $stack) && ($button->name == $name);
140 140
         }));
141 141
     }
@@ -146,7 +146,7 @@  discard block
 block discarded – undo
146 146
      */
147 147
     public function removeButtons($names, $stack = null)
148 148
     {
149
-        if (! empty($names)) {
149
+        if (!empty($names)) {
150 150
             foreach ($names as $name) {
151 151
                 $this->removeButton($name, $stack);
152 152
             }
@@ -160,14 +160,14 @@  discard block
 block discarded – undo
160 160
 
161 161
     public function removeAllButtonsFromStack($stack)
162 162
     {
163
-        $this->setOperationSetting('buttons', $this->buttons()->reject(function ($button) use ($stack) {
163
+        $this->setOperationSetting('buttons', $this->buttons()->reject(function($button) use ($stack) {
164 164
             return $button->stack == $stack;
165 165
         }));
166 166
     }
167 167
 
168 168
     public function removeButtonFromStack($name, $stack)
169 169
     {
170
-        $this->setOperationSetting('buttons', $this->buttons()->reject(function ($button) use ($name, $stack) {
170
+        $this->setOperationSetting('buttons', $this->buttons()->reject(function($button) use ($name, $stack) {
171 171
             return $button->name == $name && $button->stack == $stack;
172 172
         }));
173 173
     }
@@ -185,15 +185,15 @@  discard block
 block discarded – undo
185 185
         $destinationButton = $this->firstButtonWhere('name', $destination);
186 186
         $destinationKey = $this->getButtonKey($destination);
187 187
         $newDestinationKey = ($where == 'before' ? $destinationKey : $destinationKey + 1);
188
-        $newButtons = $this->buttons()->filter(function ($value, $key) use ($target) {
188
+        $newButtons = $this->buttons()->filter(function($value, $key) use ($target) {
189 189
             return $value->name != $target;
190 190
         });
191 191
 
192
-        if (! $targetButton) {
192
+        if (!$targetButton) {
193 193
             return;
194 194
         }
195 195
 
196
-        if (! $destinationButton) {
196
+        if (!$destinationButton) {
197 197
             return;
198 198
         }
199 199
 
@@ -201,7 +201,7 @@  discard block
 block discarded – undo
201 201
         $lastSlice = $newButtons->slice($newDestinationKey, null);
202 202
 
203 203
         $newButtons = $firstSlice->push($targetButton);
204
-        $lastSlice->each(function ($item, $key) use ($newButtons) {
204
+        $lastSlice->each(function($item, $key) use ($newButtons) {
205 205
             $newButtons->push($item);
206 206
         });
207 207
 
Please login to merge, or discard this patch.