CreatePivotableRelationsTables::up() - Code Metrics - Inspection of "Merge pull request #4161 from sang-asia/master" - Laravel-Backpack/CRUD - Measure and Improve Code Quality continuously with Scrutinizer

Test Setup Failed

Push — master ( 9a246a...536d7c )

by Cristian

created 2022-02-10 09:42 UTC

CreatePivotableRelationsTables::up() B

↳ Parent: CreatePivotableRelationsTables

Complexity

Conditions	1
Paths	1

Size

Total Lines	85
Code Lines	59

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
cc	1
eloc	59
c	1
b	0
f	1
nc	1
nop	0
dl	0
loc	85
rs	8.8945

How to fix Long Method

<?php

use Illuminate\Database\Migrations\Migration;
use Illuminate\Database\Schema\Blueprint;
use Illuminate\Support\Facades\Schema;

class CreatePivotableRelationsTables extends Migration
{
    /**
     * Run the migrations.
     *
     * @return void
     */
    public function up()
    {
        Schema::create('comments', function (Blueprint $table) {
            $table->bigIncrements('id');
            $table->string('text')->nullable();
            $table->morphs('commentable');
            $table->timestamps();
        });

        Schema::create('recommendables', function (Blueprint $table) {
            $table->bigIncrements('id');
            $table->string('text')->nullable();
            $table->morphs('recommendable');
            $table->bigInteger('recommend_id');
            $table->timestamps();
        });

        Schema::create('billables', function (Blueprint $table) {
            $table->bigIncrements('id');
            $table->string('text')->nullable();
            $table->morphs('billable');
            $table->bigInteger('bill_id');
            $table->timestamps();
        });

        Schema::create('articles_user', function (Blueprint $table) {
            $table->increments('id');
            $table->integer('article_id')->unsigned();
            $table->integer('user_id')->unsigned();
            $table->string('notes');
            $table->nullableTimestamps();
        });

        Schema::create('recommends', function (Blueprint $table) {
            $table->bigIncrements('id');
            $table->string('title')->nullable();
            $table->timestamps();
        });

        Schema::create('bills', function (Blueprint $table) {
            $table->bigIncrements('id');
            $table->string('title')->nullable();
            $table->timestamps();
        });

        Schema::create('stars', function (Blueprint $table) {
            $table->bigIncrements('id');
            $table->string('starable_type');
            $table->bigInteger('starable_id');
            $table->string('title')->nullable();
        });

        Schema::create('universes', function (Blueprint $table) {
            $table->bigIncrements('id');
            $table->bigInteger('user_id');
            $table->string('title')->nullable();
        });

        Schema::create('planets', function (Blueprint $table) {
            $table->bigIncrements('id');
            $table->bigInteger('user_id')->nullable();
            $table->string('title')->nullable();
        });

        Schema::create('comets', function (Blueprint $table) {
            $table->bigIncrements('id');
            $table->bigInteger('user_id')->default(0);
        });

        Schema::create('bangs', function (Blueprint $table) {
            $table->bigIncrements('id');
            $table->string('name');
        });

        Schema::create('account_details_bang', function (Blueprint $table) {
            $table->bigIncrements('id');
            $table->bigInteger('account_details_id');
            $table->bigInteger('bang_id');
        });

        Schema::create('account_details_bangs_pivot', function (Blueprint $table) {
            $table->bigIncrements('id');
            $table->bigInteger('account_details_id');
            $table->bigInteger('bang_id');
            $table->string('pivot_field');
        });
    }

    public function down()
    {
        Schema::dropIfExists('recommendables');
        Schema::dropIfExists('comments');
        Schema::dropIfExists('recommends');
        Schema::dropIfExists('stars');
        Schema::dropIfExists('billables');
        Schema::dropIfExists('bills');
        Schema::dropIfExists('articles_users');
        Schema::dropIfExists('planets');
        Schema::dropIfExists('universes');
        Schema::dropIfExists('comets');
        Schema::dropIfExists('account_details_bang');
        Schema::dropIfExists('bangs');
        Schema::dropIfExists('account_details_bangs_pivot');
    }
}


1			<?php
2
3			use Illuminate\Database\Migrations\Migration;
4			use Illuminate\Database\Schema\Blueprint;
5			use Illuminate\Support\Facades\Schema;
6
7			class CreatePivotableRelationsTables extends Migration
8			{
9			/**
10			* Run the migrations.
11			*
12			* @return void
13			*/
14			public function up()
15			{
16			Schema::create('comments', function (Blueprint $table) {
17			$table->bigIncrements('id');
18			$table->string('text')->nullable();
19			$table->morphs('commentable');
20			$table->timestamps();
21			});
22
23			Schema::create('recommendables', function (Blueprint $table) {
24			$table->bigIncrements('id');
25			$table->string('text')->nullable();
26			$table->morphs('recommendable');
27			$table->bigInteger('recommend_id');
28			$table->timestamps();
29			});
30
31			Schema::create('billables', function (Blueprint $table) {
32			$table->bigIncrements('id');
33			$table->string('text')->nullable();
34			$table->morphs('billable');
35			$table->bigInteger('bill_id');
36			$table->timestamps();
37			});
38
39			Schema::create('articles_user', function (Blueprint $table) {
40			$table->increments('id');
41			$table->integer('article_id')->unsigned();
42			$table->integer('user_id')->unsigned();
43			$table->string('notes');
44			$table->nullableTimestamps();
45			});
46
47			Schema::create('recommends', function (Blueprint $table) {
48			$table->bigIncrements('id');
49			$table->string('title')->nullable();
50			$table->timestamps();
51			});
52
53			Schema::create('bills', function (Blueprint $table) {
54			$table->bigIncrements('id');
55			$table->string('title')->nullable();
56			$table->timestamps();
57			});
58
59			Schema::create('stars', function (Blueprint $table) {
60			$table->bigIncrements('id');
61			$table->string('starable_type');
62			$table->bigInteger('starable_id');
63			$table->string('title')->nullable();
64			});
65
66			Schema::create('universes', function (Blueprint $table) {
67			$table->bigIncrements('id');
68			$table->bigInteger('user_id');
69			$table->string('title')->nullable();
70			});
71
72			Schema::create('planets', function (Blueprint $table) {
73			$table->bigIncrements('id');
74			$table->bigInteger('user_id')->nullable();
75			$table->string('title')->nullable();
76			});
77
78			Schema::create('comets', function (Blueprint $table) {
79			$table->bigIncrements('id');
80			$table->bigInteger('user_id')->default(0);
81			});
82
83			Schema::create('bangs', function (Blueprint $table) {
84			$table->bigIncrements('id');
85			$table->string('name');
86			});
87
88			Schema::create('account_details_bang', function (Blueprint $table) {
89			$table->bigIncrements('id');
90			$table->bigInteger('account_details_id');
91			$table->bigInteger('bang_id');
92			});
93
94			Schema::create('account_details_bangs_pivot', function (Blueprint $table) {
95			$table->bigIncrements('id');
96			$table->bigInteger('account_details_id');
97			$table->bigInteger('bang_id');
98			$table->string('pivot_field');
99			});
100			}
101
102			public function down()
103			{
104			Schema::dropIfExists('recommendables');
105			Schema::dropIfExists('comments');
106			Schema::dropIfExists('recommends');
107			Schema::dropIfExists('stars');
108			Schema::dropIfExists('billables');
109			Schema::dropIfExists('bills');
110			Schema::dropIfExists('articles_users');
111			Schema::dropIfExists('planets');
112			Schema::dropIfExists('universes');
113			Schema::dropIfExists('comets');
114			Schema::dropIfExists('account_details_bang');
115			Schema::dropIfExists('bangs');
116			Schema::dropIfExists('account_details_bangs_pivot');
117			}
118			}
119

Laravel-Backpack / CRUD

Scrutinizer GitHub App not installed

Push — master ( 9a246a...536d7c )

CreatePivotableRelationsTables::up() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like