Laravel-Backpack /
CRUD
We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.
| Total Complexity | 60 |
| Total Lines | 342 |
| Duplicated Lines | 0 % |
| Changes | 9 | ||
| Bugs | 4 | Features | 2 |
Complex classes like FieldsProtectedMethods often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use FieldsProtectedMethods, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 8 | trait FieldsProtectedMethods |
||
| 9 | { |
||
| 10 | /** |
||
| 11 | * If field has entity we want to get the relation type from it. |
||
| 12 | * |
||
| 13 | * @param array $field |
||
| 14 | * @return array |
||
| 15 | */ |
||
| 16 | public function makeSureFieldHasRelationType($field) |
||
| 17 | { |
||
| 18 | $field['relation_type'] = $field['relation_type'] ?? $this->inferRelationTypeFromRelationship($field); |
||
|
Bug
introduced
by
|
|||
| 19 | |||
| 20 | return $field; |
||
| 21 | } |
||
| 22 | |||
| 23 | /** |
||
| 24 | * If field has entity we want to make sure it also has a model for that relation. |
||
| 25 | * |
||
| 26 | * @param array $field |
||
| 27 | * @return array |
||
| 28 | */ |
||
| 29 | public function makeSureFieldHasModel($field) |
||
| 34 | } |
||
| 35 | |||
| 36 | /** |
||
| 37 | * Based on relation type we can guess if pivot is set. |
||
| 38 | * |
||
| 39 | * @param array $field |
||
| 40 | * @return array |
||
| 41 | */ |
||
| 42 | public function makeSureFieldHasPivot($field) |
||
| 43 | { |
||
| 44 | $field['pivot'] = $field['pivot'] ?? $this->guessIfFieldHasPivotFromRelationType($field['relation_type']); |
||
| 45 | |||
| 46 | return $field; |
||
| 47 | } |
||
| 48 | |||
| 49 | /** |
||
| 50 | * Based on relation type we can try to guess if it is a multiple field. |
||
| 51 | * |
||
| 52 | * @param array $field |
||
| 53 | * @return array |
||
| 54 | */ |
||
| 55 | public function makeSureFieldHasMultiple($field) |
||
| 62 | } |
||
| 63 | |||
| 64 | /** |
||
| 65 | * In case field name is dot notation we want to convert it to a valid HTML array field name for validation purposes. |
||
| 66 | * |
||
| 67 | * @param array $field |
||
| 68 | * @return array |
||
| 69 | */ |
||
| 70 | public function overwriteFieldNameFromDotNotationToArray($field) |
||
| 84 | } |
||
| 85 | |||
| 86 | /** |
||
| 87 | * Run the field name overwrite in multiple fields. |
||
| 88 | * |
||
| 89 | * @param array $fields |
||
| 90 | * @return array |
||
| 91 | */ |
||
| 92 | public function overwriteFieldNamesFromDotNotationToArray($fields) |
||
| 93 | { |
||
| 94 | foreach ($fields as $key => $field) { |
||
| 95 | $fields[$key] = $this->overwriteFieldNameFromDotNotationToArray($field); |
||
| 96 | } |
||
| 97 | |||
| 98 | return $fields; |
||
| 99 | } |
||
| 100 | |||
| 101 | /** |
||
| 102 | * If the field_definition_array array is a string, it means the programmer was lazy |
||
| 103 | * and has only passed the name of the field. Turn that into a proper array. |
||
| 104 | * |
||
| 105 | * @param string|array $field The field definition array (or string). |
||
| 106 | * @return array |
||
| 107 | */ |
||
| 108 | protected function makeSureFieldHasName($field) |
||
| 119 | } |
||
| 120 | |||
| 121 | /** |
||
| 122 | * If entity is not present, but it looks like the field SHOULD be a relationship field, |
||
| 123 | * try to determine the method on the model that defines the relationship, and pass it to |
||
| 124 | * the field as 'entity'. |
||
| 125 | * |
||
| 126 | * @param array $field |
||
| 127 | * @return array |
||
| 128 | */ |
||
| 129 | protected function makeSureFieldHasEntity($field) |
||
| 130 | { |
||
| 131 | $model = isset($field['baseModel']) ? app($field['baseModel']) : $this->model; |
||
| 132 | |||
| 133 | if (isset($field['entity'])) { |
||
| 134 | return $field; |
||
| 135 | } |
||
| 136 | |||
| 137 | // if the name is an array it's definitely not a relationship |
||
| 138 | if (is_array($field['name'])) { |
||
| 139 | return $field; |
||
| 140 | } |
||
| 141 | |||
| 142 | //if the name is dot notation we are sure it's a relationship |
||
| 143 | if (strpos($field['name'], '.') !== false) { |
||
| 144 | $possibleMethodName = Str::of($field['name'])->before('.'); |
||
| 145 | // if it has parameters it's not a relation method. |
||
| 146 | $field['entity'] = $this->modelMethodHasParameters($model, $possibleMethodName) ? false : $field['name']; |
||
| 147 | |||
| 148 | return $field; |
||
| 149 | } |
||
| 150 | |||
| 151 | // if there's a method on the model with this name |
||
| 152 | if (method_exists($model, $field['name'])) { |
||
| 153 | // if it has parameters it's not a relation method. |
||
| 154 | $field['entity'] = $this->modelMethodHasParameters($model, $field['name']) ? false : $field['name']; |
||
| 155 | |||
| 156 | return $field; |
||
| 157 | } |
||
| 158 | |||
| 159 | // if the name ends with _id and that method exists, |
||
| 160 | // we can probably use it as an entity |
||
| 161 | if (Str::endsWith($field['name'], '_id')) { |
||
| 162 | $possibleMethodName = Str::replaceLast('_id', '', $field['name']); |
||
| 163 | |||
| 164 | if (method_exists($model, $possibleMethodName)) { |
||
| 165 | // if it has parameters it's not a relation method. |
||
| 166 | $field['entity'] = $this->modelMethodHasParameters($model, $possibleMethodName) ? false : $possibleMethodName; |
||
| 167 | |||
| 168 | return $field; |
||
| 169 | } |
||
| 170 | } |
||
| 171 | |||
| 172 | return $field; |
||
| 173 | } |
||
| 174 | |||
| 175 | protected function makeSureFieldHasAttribute($field) |
||
| 184 | } |
||
| 185 | |||
| 186 | /** |
||
| 187 | * Set the label of a field, if it's missing, by capitalizing the name and replacing |
||
| 188 | * underscores with spaces. |
||
| 189 | * |
||
| 190 | * @param array $field Field definition array. |
||
| 191 | * @return array Field definition array that contains label too. |
||
| 192 | */ |
||
| 193 | protected function makeSureFieldHasLabel($field) |
||
| 202 | } |
||
| 203 | |||
| 204 | /** |
||
| 205 | * Set the type of a field, if it's missing, by inferring it from the |
||
| 206 | * db column type. |
||
| 207 | * |
||
| 208 | * @param array $field Field definition array. |
||
| 209 | * @return array Field definition array that contains type too. |
||
| 210 | */ |
||
| 211 | protected function makeSureFieldHasType($field) |
||
| 218 | } |
||
| 219 | |||
| 220 | protected function inferFieldTypeFromRelationType($relationType) |
||
| 221 | { |
||
| 222 | if (backpack_pro()) { |
||
| 223 | return 'relationship'; |
||
| 224 | } |
||
| 225 | |||
| 226 | switch ($relationType) { |
||
| 227 | case 'BelongsTo': |
||
| 228 | return 'select'; |
||
| 229 | break; |
||
| 230 | |||
| 231 | case 'BelongsToMany': |
||
| 232 | case 'MorphToMany': |
||
| 233 | return 'select_multiple'; |
||
| 234 | |||
| 235 | default: |
||
| 236 | return 'text'; |
||
| 237 | break; |
||
| 238 | } |
||
| 239 | } |
||
| 240 | |||
| 241 | /** |
||
| 242 | * If a field has subfields, go through each subfield and guess |
||
| 243 | * its attribute, filling in whatever is missing. |
||
| 244 | * |
||
| 245 | * @param array $field Field definition array. |
||
| 246 | * @return array The improved definition of that field (a better 'subfields' array) |
||
| 247 | */ |
||
| 248 | protected function makeSureSubfieldsHaveNecessaryAttributes($field) |
||
| 249 | { |
||
| 250 | if (! isset($field['subfields'])) { |
||
| 251 | return $field; |
||
| 252 | } |
||
| 253 | |||
| 254 | foreach ($field['subfields'] as $key => $subfield) { |
||
| 255 | // make sure the field definition is an array |
||
| 256 | if (is_string($subfield)) { |
||
| 257 | $subfield = ['name' => $subfield]; |
||
| 258 | } |
||
| 259 | |||
| 260 | if (! isset($field['model'])) { |
||
| 261 | // we're inside a simple 'repeatable' with no model/relationship, so |
||
| 262 | // we assume all subfields are supposed to be text fields |
||
| 263 | $subfield['type'] = $subfield['type'] ?? 'text'; |
||
| 264 | $subfield['entity'] = $subfield['entity'] ?? false; |
||
| 265 | } else { |
||
| 266 | // we should use 'model' as the `baseModel` for all subfields, so that when |
||
| 267 | // we look if `category()` relationship exists on the model, we look on |
||
| 268 | // the model this repeatable represents, not the main CRUD model |
||
| 269 | $currentEntity = $subfield['baseEntity'] ?? $field['entity']; |
||
| 270 | $subfield['baseModel'] = $subfield['baseModel'] ?? $field['model']; |
||
| 271 | $subfield['baseEntity'] = isset($field['baseEntity']) ? $field['baseEntity'].'.'.$currentEntity : $currentEntity; |
||
| 272 | } |
||
| 273 | |||
| 274 | $field['subfields'][$key] = $this->makeSureFieldHasNecessaryAttributes($subfield); |
||
| 275 | } |
||
| 276 | |||
| 277 | // when field has any of `many` relations we need to append either the pivot selector for the `ToMany` or the |
||
| 278 | // local key for the `many` relations. Other relations don't need any special treatment when used as subfields. |
||
| 279 | if (isset($field['relation_type'])) { |
||
| 280 | switch ($field['relation_type']) { |
||
| 281 | case 'MorphToMany': |
||
| 282 | case 'BelongsToMany': |
||
| 283 | $pivotSelectorField = static::getPivotFieldStructure($field); |
||
| 284 | $field['subfields'] = Arr::prepend($field['subfields'], $pivotSelectorField); |
||
| 285 | break; |
||
| 286 | case 'MorphMany': |
||
| 287 | case 'HasMany': |
||
| 288 | $entity = isset($field['baseEntity']) ? $field['baseEntity'].'.'.$field['entity'] : $field['entity']; |
||
| 289 | $relationInstance = $this->getRelationInstance(['entity' => $entity]); |
||
| 290 | $field['subfields'] = Arr::prepend($field['subfields'], [ |
||
| 291 | 'name' => $relationInstance->getLocalKeyName(), |
||
| 292 | 'type' => 'hidden', |
||
| 293 | ]); |
||
| 294 | break; |
||
| 295 | } |
||
| 296 | } |
||
| 297 | |||
| 298 | return $field; |
||
| 299 | } |
||
| 300 | |||
| 301 | /** |
||
| 302 | * Enable the tabs functionality, if a field has a tab defined. |
||
| 303 | * |
||
| 304 | * @param array $field Field definition array. |
||
| 305 | * @return void |
||
| 306 | */ |
||
| 307 | protected function enableTabsIfFieldUsesThem($field) |
||
| 308 | { |
||
| 309 | // if a tab was mentioned, we should enable it |
||
| 310 | if (isset($field['tab'])) { |
||
| 311 | if (! $this->tabsEnabled()) { |
||
| 312 | $this->enableTabs(); |
||
| 313 | } |
||
| 314 | } |
||
| 315 | } |
||
| 316 | |||
| 317 | /** |
||
| 318 | * Add a field to the current operation, using the Settings API. |
||
| 319 | * |
||
| 320 | * @param array $field Field definition array. |
||
| 321 | */ |
||
| 322 | protected function addFieldToOperationSettings($field) |
||
| 323 | { |
||
| 324 | $fieldKey = $this->getFieldKey($field); |
||
| 325 | |||
| 326 | $allFields = $this->getOperationSetting('fields'); |
||
| 327 | $allFields = array_merge($this->getCleanStateFields(), [$fieldKey => $field]); |
||
| 328 | |||
| 329 | $this->setOperationSetting('fields', $allFields); |
||
| 330 | } |
||
| 331 | |||
| 332 | /** |
||
| 333 | * Get the string that should be used as an array key, for the attributive array |
||
| 334 | * where the fields are stored for the current operation. |
||
| 335 | * |
||
| 336 | * The array key for the field should be: |
||
| 337 | * - name (if the name is a string) |
||
| 338 | * - name1_name2_name3 (if the name is an array) |
||
| 339 | * |
||
| 340 | * @param array $field Field definition array. |
||
| 341 | * @return string The string that should be used as array key. |
||
| 342 | */ |
||
| 343 | protected function getFieldKey($field) |
||
| 350 | } |
||
| 351 | } |
||
| 352 |
Loading history...
