Laravel-Backpack / CRUD

src/resources/views/list.blade.php

Braces +1 added lines, -2 removed lines

@@ -71,8 +71,7 @@
                             if ($results && $results->count()) {
                                 $results_array = $results->lists($column['attribute'], 'id');
                                 echo implode(', ', $results_array->toArray());
-                                }
-                                else
+                                } else
                                 {
                                 echo '-';
                                 }

src/app/Http/Controllers/CrudController.php

Doc Comments +1 added lines, -1 removed lines

@@ -161,7 +161,7 @@
 	 * Remove the specified resource from storage.
 	 *
 	 * @param  int  $id
-	 * @return string
+	 * @return \Illuminate\Http\Response
 	 */
 	public function destroy($id)
 	{

src/app/Http/Controllers/ToneCrudNestedController.php

Doc Comments +2 added lines, -2 removed lines

@@ -54,7 +54,7 @@ 
      * Store a newly created resource in storage.
      *
      * @param  \Illuminate\Http\Request  $request
-     * @return \Illuminate\Http\Response
+     * @return \Illuminate\Http\RedirectResponse
      */
     public function crudStore(Request $request = null)
     {
@@ -101,7 +101,7 @@ 
      *
      * @param  \Illuminate\Http\Request  $request
      * @param  int  $id
-     * @return \Illuminate\Http\Response
+     * @return \Illuminate\Http\RedirectResponse
      */
     public function crudUpdate($parentId, $id, Request $request = null)
     {

src/resources/views/fields/checklist_dependency.blade.php

Braces +1 added lines, -1 removed lines

@@ -45,7 +45,7 @@
                 $secondary_ids[$second_item] = $second_item;
             }
           }
-        }else{ //create dependecies from relation if not from validate error
+        } else{ //create dependecies from relation if not from validate error
           foreach( $primary_array as $primary_item ){
             foreach($primary_item[$secondary_dependency['entity']] as $second_item ){
                 $secondary_ids[$second_item['id']] = $second_item['id'];

src/Crud.php

Doc Comments +21 added lines, -4 removed lines

@@ -334,6 +334,7 @@ 
      * Delete a row from the database.
      *
      * @param  [int] The id of the item to be deleted.
+     * @param integer $id
      * @return [bool] Deletion confirmation.
      *
      * TODO: should this delete items with relations to it too?
@@ -452,7 +453,8 @@ 
      * Check if a permission is enabled for a Crud Panel. Fail if not.
      *
      * @param  [string] Permission.
-     * @return boolean
+     * @param string $permission
+     * @return boolean|null
      */
     public function hasAccessOrFail($permission)
     {
@@ -481,6 +483,7 @@ 
      * All Create-Read-Update-Delete operations are done using that Eloquent Collection.
      *
      * @param [string] Full model namespace. Ex: App\Models\Article
+     * @param string $model_namespace
      */
     public function setModel($model_namespace)
     {
@@ -508,6 +511,7 @@ 
      *
      * @param [string] Route name.
      * @param [array] Parameters.
+     * @param string $route
      */
     public function setRoute($route)
     {
@@ -540,7 +544,7 @@ 
      * - $this->crud->setRouteName('admin.article')
      * - $this->crud->route = "admin/article"
      *
-     * @return [string]
+     * @return string
      */
     public function getRoute()
     {
@@ -553,6 +557,8 @@ 
      *
      * @param [string] Entity name, in singular. Ex: article
      * @param [string] Entity name, in plural. Ex: articles
+     * @param string $singular
+     * @param string $plural
      */
     public function setEntityNameStrings($singular, $plural) {
         $this->entity_name = $singular;
@@ -731,8 +737,6 @@ 
 
     /**
      * Add a field to the create/update form or both.
-     * @param [string] $name    Field name (the column name in the db in most cases)
-     * @param [array] $options Field-type-specific information.
      * @param string $form    The form to add the field to (create/update/both)
      */
     public function addField($field, $form='both')
@@ -1374,6 +1378,9 @@ 
     //     return array_filter($this->{$entity}[] = $this->syncField($field));
     // }
 
+    /**
+     * @param string $entity
+     */
     public function addMultiple($entity, $field)
     {
         $this->{$entity} = array_filter(array_map([$this, 'syncField'], $fields));
@@ -1398,11 +1405,17 @@ 
     //     return array_values(array_filter($this->{$entity}, function($field) use ($fields) { return !in_array($field['name'], (array)$fields);}));
     // }
 
+    /**
+     * @param string $items
+     */
     public function setSort($items, $order)
     {
         $this->sort[$items] = $order;
     }
 
+    /**
+     * @param string $items
+     */
     public function sort($items)
     {
         if (array_key_exists($items, $this->sort))
@@ -1438,6 +1451,10 @@ 
     }
 
     // face un fel de merge intre ce ii dai si ce e in CRUD
+
+    /**
+     * @param string $entity
+     */
     public function syncRelations($entity)
     {
         foreach ($this->relations as $field => $relation) {

Braces +53 added lines, -27 removed lines

@@ -93,8 +93,7 @@ 
         if ($form == 'create')
         {
             $fields = $this->create_fields;
-        }
-        else
+        } else
         {
             $fields = $this->update_fields;
         }
@@ -308,7 +307,7 @@ 
                         $fields[$k]['value'][] = $entry->{$subfield['name']};
                     }
 
-                }else{
+                } else{
                     $fields[$k]['value'] = $entry->{$field['name']};
                 }
             }
@@ -487,7 +486,9 @@ 
      */
     public function setModel($model_namespace)
     {
-        if (!class_exists($model_namespace)) throw new \Exception('This model does not exist.', 404);
+        if (!class_exists($model_namespace)) {
+            throw new \Exception('This model does not exist.', 404);
+        }
 
         $this->model = new $model_namespace();
         $this->query = $this->model->select('*');
@@ -529,7 +530,9 @@ 
     {
         $complete_route = $route.'.index';
 
-        if (!\Route::has($complete_route)) throw new \Exception('There are no routes for this route name.', 404);
+        if (!\Route::has($complete_route)) {
+            throw new \Exception('There are no routes for this route name.', 404);
+        }
 
         $this->route = route($complete_route, $parameters);
         $this->initButtons();
@@ -585,8 +588,7 @@ 
                 // if label and other details have been defined in the array
                 if (is_array($columns[0])) {
                     $this->addColumn($column);
-                }
-                else
+                } else
                 {
                     $this->addColumn([
                                     'name' => $column,
@@ -745,19 +747,20 @@ 
         if (is_string($field))
         {
             $complete_field_array['name'] = $field;
-        }
-        else
+        } else
         {
             $complete_field_array = $field;
         }
 
         // if the label is missing, we should set it
-        if (!isset($complete_field_array['label']))
-            $complete_field_array['label'] = ucfirst($complete_field_array['name']);
+        if (!isset($complete_field_array['label'])) {
+                    $complete_field_array['label'] = ucfirst($complete_field_array['name']);
+        }
 
         // if the field type is missing, we should set it
-        if (!isset($complete_field_array['type']))
-            $complete_field_array['type'] = $this->getFieldTypeFromDbColumnType($complete_field_array['name']);
+        if (!isset($complete_field_array['type'])) {
+                    $complete_field_array['type'] = $this->getFieldTypeFromDbColumnType($complete_field_array['name']);
+        }
 
         // store the field information into the correct variable on the CRUD object
         switch (strtolower($form)) {
@@ -840,8 +843,9 @@ 
      * @return bool  true/false
      */
     public function checkIfFieldIsFirstOfItsType($field, $fields_array) {
-        if ($field['name'] == $this->getFirstOfItsTypeInArray($field['type'], $fields_array)['name'])
-            return true;
+        if ($field['name'] == $this->getFirstOfItsTypeInArray($field['type'], $fields_array)['name']) {
+                    return true;
+        }
 
         return false;
     }
@@ -998,11 +1002,17 @@ 
      */
     public function getFieldTypeFromDbColumnType($field)
     {
-        if (!array_key_exists($field, $this->field_types)) return 'text';
+        if (!array_key_exists($field, $this->field_types)) {
+            return 'text';
+        }
 
-        if ($field == 'password') return 'password';
+        if ($field == 'password') {
+            return 'password';
+        }
 
-        if ($field == 'email') return 'email';
+        if ($field == 'email') {
+            return 'email';
+        }
 
         switch ($this->field_types[$field]['type'])
         {
@@ -1075,7 +1085,9 @@ 
         $columns = \Schema::getColumnListing($this->model->getTable());
         $fillable = $this->model->getFillable();
 
-        if (!empty($fillable)) $columns = array_intersect($columns, $fillable);
+        if (!empty($fillable)) {
+            $columns = array_intersect($columns, $fillable);
+        }
 
         // but not updated_at, deleted_at
         return array_values(array_diff($columns, [$this->model->getKeyName(), 'updated_at', 'deleted_at']));
@@ -1403,8 +1415,11 @@ 
 
             foreach ($this->{$fields} as $key => $field)
             {
-                if (array_key_exists($field['name'], $this->relations) && $this->relations[$field['name']]['pivot']) $this->{$fields}[$key]['value'] = $this->entry->{$this->relations[$field['name']]['name']}()->lists($this->relations[$field['name']]['model']->getKeyName())->toArray();
-                    else $this->{$fields}[$key]['value'] = $this->entry->{$field['name']};
+                if (array_key_exists($field['name'], $this->relations) && $this->relations[$field['name']]['pivot']) {
+                    $this->{$fields}[$key]['value'] = $this->entry->{$this->relations[$field['name']]['name']}()->lists($this->relations[$field['name']]['model']->getKeyName())->toArray();
+                } else {
+                        $this->{$fields}[$key]['value'] = $this->entry->{$field['name']};
+                    }
             }
         }
     }
@@ -1424,7 +1439,9 @@ 
         if (!empty($this->{$type}))
         {
             $this->{$type} = array_map(function($field) use ($fields, $attributes) {
-                if (in_array($field['name'], (array)$fields)) $field = array_merge($field, $attributes);
+                if (in_array($field['name'], (array)$fields)) {
+                    $field = array_merge($field, $attributes);
+                }
 
                 return $field;
             }, $this->{$type});
@@ -1451,7 +1468,9 @@ 
 
             foreach ($this->sort[$items] as $item)
             {
-                if (is_numeric($key = array_search($item, array_column($this->{$items}, 'name')))) $elements[] = $this->{$items}[$key];
+                if (is_numeric($key = array_search($item, array_column($this->{$items}, 'name')))) {
+                    $elements[] = $this->{$items}[$key];
+                }
             }
 
             return $this->{$items} = array_merge($elements, array_filter($this->{$items}, function($item) use($items) {return !in_array($item['name'], $this->sort[$items]);}));
@@ -1470,9 +1489,13 @@ 
         $order = (array)$order;
         $values = $model->select('*');
 
-        if (!empty($where)) call_user_func_array([$values, $where[0]], array_slice($where, 1));
+        if (!empty($where)) {
+            call_user_func_array([$values, $where[0]], array_slice($where, 1));
+        }
 
-        if (!empty($order)) call_user_func_array([$values, 'orderBy'], $order);
+        if (!empty($order)) {
+            call_user_func_array([$values, 'orderBy'], $order);
+        }
 
         return $values->get()->lists($field, $model->getKeyName())->toArray();
     }
@@ -1481,8 +1504,11 @@ 
     public function syncRelations($entity)
     {
         foreach ($this->relations as $field => $relation) {
-            if ($relation['pivot']) $this->add($entity, ['name' => $field, 'type' => 'multiselect', 'value' => [], 'values' => $this->relations[$field]['values']]);
-                else $this->sync($entity, $field, ['type' => 'select', 'values' => $this->relations[$field]['values']]);
+            if ($relation['pivot']) {
+                $this->add($entity, ['name' => $field, 'type' => 'multiselect', 'value' => [], 'values' => $this->relations[$field]['values']]);
+            } else {
+                    $this->sync($entity, $field, ['type' => 'select', 'values' => $this->relations[$field]['values']]);
+                }
         }
     }