View GitHub Repository CRUD

Schedule Inspection
Subscribe

Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Passed
Pull Request — fix-uploaders (#5518)
by Cristian
26:32 queued 11:32
created
Status
Category
Toggle Patches
tests/Feature/UploadersTest.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch 
@@ -62,7 +62,7 @@  discard block
 
 block discarded – undo
62 62
63 63 
         $this->assertDatabaseHas('uploaders', [
64 64 
             'upload' => 'avatar1.jpg',
65 
-            'upload_multiple' => json_encode(['avatar2.jpg',  'avatar3.jpg']),
65 
+            'upload_multiple' => json_encode(['avatar2.jpg', 'avatar3.jpg']),
66 66 
         ]);
67 67
68 68 
         $this->assertTrue(Storage::disk('uploaders')->exists('avatar1.jpg'));
 
@@ -97,7 +97,7 @@  discard block
 
 block discarded – undo
97 97 
         $response = $this->put($this->testBaseUrl.'/1', [
98 98 
             'upload' => $this->getUploadedFile('avatar4.jpg'),
99 99 
             'upload_multiple' => $this->getUploadedFiles(['avatar5.jpg', 'avatar6.jpg']),
100 
-            'clear_upload_multiple' => ['avatar2.jpg',  'avatar3.jpg'],
100 
+            'clear_upload_multiple' => ['avatar2.jpg', 'avatar3.jpg'],
101 101 
             'id' => 1,
102 102 
         ]);
103 103 
 
@@ -109,7 +109,7 @@  discard block
 
 block discarded – undo
109 109
110 110 
         $this->assertDatabaseHas('uploaders', [
111 111 
             'upload' => 'avatar4.jpg',
112 
-            'upload_multiple' => json_encode(['avatar5.jpg',  'avatar6.jpg']),
112 
+            'upload_multiple' => json_encode(['avatar5.jpg', 'avatar6.jpg']),
113 113 
         ]);
114 114
115 115 
         $files = Storage::disk('uploaders')->allFiles();
 
@@ -138,7 +138,7 @@  discard block
 
 block discarded – undo
138 138
139 139 
         $this->assertDatabaseHas('uploaders', [
140 140 
             'upload' => null,
141 
-            'upload_multiple' => json_encode(['avatar2.jpg',  'avatar3.jpg']),
141 
+            'upload_multiple' => json_encode(['avatar2.jpg', 'avatar3.jpg']),
142 142 
         ]);
143 143
144 144 
         $files = Storage::disk('uploaders')->allFiles();
 
@@ -168,7 +168,7 @@  discard block
 
 block discarded – undo
168 168 
         self::initUploaderWithFiles();
169 169
170 170 
         $response = $this->put($this->testBaseUrl.'/1', [
171 
-            'upload_multiple' => ['avatar2.jpg',  'avatar3.jpg'],
171 
+            'upload_multiple' => ['avatar2.jpg', 'avatar3.jpg'],
172 172 
             'id' => 1,
173 173 
         ]);
174 174 
 
@@ -180,7 +180,7 @@  discard block
 
 block discarded – undo
180 180
181 181 
         $this->assertDatabaseHas('uploaders', [
182 182 
             'upload' => 'avatar1.jpg',
183 
-            'upload_multiple' => json_encode(['avatar2.jpg',  'avatar3.jpg']),
183 
+            'upload_multiple' => json_encode(['avatar2.jpg', 'avatar3.jpg']),
184 184 
         ]);
185 185
186 186 
         $files = Storage::disk('uploaders')->allFiles();
 
@@ -210,7 +210,7 @@  discard block
 
 block discarded – undo
210 210
211 211 
         $this->assertDatabaseHas('uploaders', [
212 212 
             'upload' => 'avatar1.jpg',
213 
-            'upload_multiple' => json_encode(['avatar3.jpg', 'avatar4.jpg',  'avatar5.jpg']),
213 
+            'upload_multiple' => json_encode(['avatar3.jpg', 'avatar4.jpg', 'avatar5.jpg']),
214 214 
         ]);
215 215
216 216 
         $files = Storage::disk('uploaders')->allFiles();
 
@@ -231,7 +231,7 @@  discard block
 
 block discarded – undo
231 231
232 232 
         Uploader::create([
233 233 
             'upload' => 'avatar1.jpg',
234 
-            'upload_multiple' => json_encode(['avatar2.jpg',  'avatar3.jpg']),
234 
+            'upload_multiple' => json_encode(['avatar2.jpg', 'avatar3.jpg']),
235 235 
         ]);
236 236 
     }
237 237
Please login to merge, or discard this patch.
tests/Feature/FakeUploadersTest.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch 
@@ -93,7 +93,7 @@  discard block
 
 block discarded – undo
93 93 
             '_method' => 'PUT',
94 94 
             'upload' => $this->getUploadedFile('avatar4.jpg'),
95 95 
             'upload_multiple' => $this->getUploadedFiles(['avatar5.jpg', 'avatar6.jpg']),
96 
-            'clear_upload_multiple' => ['avatar2.jpg',  'avatar3.jpg'],
96 
+            'clear_upload_multiple' => ['avatar2.jpg', 'avatar3.jpg'],
97 97 
             'id' => 1,
98 98 
         ]);
99 99 
 
@@ -173,7 +173,7 @@  discard block
 
 block discarded – undo
173 173 
         $this->assertDatabaseCount('uploaders', 1);
174 174
175 175 
         $this->assertDatabaseHas('uploaders', [
176 
-            'extras' => json_encode(['upload_multiple' => ['avatar2.jpg',  'avatar3.jpg'], 'upload' => 'avatar1.jpg']),
176 
+            'extras' => json_encode(['upload_multiple' => ['avatar2.jpg', 'avatar3.jpg'], 'upload' => 'avatar1.jpg']),
177 177 
         ]);
178 178
179 179 
         $files = Storage::disk('uploaders')->allFiles();
 
@@ -190,7 +190,7 @@  discard block
 
 block discarded – undo
190 190 
         self::initUploaderWithFiles();
191 191
192 192 
         $response = $this->put($this->testBaseUrl.'/1', [
193 
-            'upload_multiple' => $this->getUploadedFiles(['avatar4.jpg',  'avatar5.jpg']),
193 
+            'upload_multiple' => $this->getUploadedFiles(['avatar4.jpg', 'avatar5.jpg']),
194 194 
             'clear_upload_multiple' => ['avatar2.jpg'],
195 195 
             'id' => 1,
196 196 
         ]);
 
@@ -202,7 +202,7 @@  discard block
 
 block discarded – undo
202 202 
         $this->assertDatabaseCount('uploaders', 1);
203 203
204 204 
         $this->assertDatabaseHas('uploaders', [
205 
-            'extras' => json_encode(['upload_multiple' => ['avatar3.jpg', 'avatar4.jpg',  'avatar5.jpg'], 'upload' => 'avatar1.jpg']),
205 
+            'extras' => json_encode(['upload_multiple' => ['avatar3.jpg', 'avatar4.jpg', 'avatar5.jpg'], 'upload' => 'avatar1.jpg']),
206 206 
         ]);
207 207
208 208 
         $files = Storage::disk('uploaders')->allFiles();
 
@@ -222,7 +222,7 @@  discard block
 
 block discarded – undo
222 222 
         UploadedFile::fake()->image('avatar3.jpg')->storeAs('', 'avatar3.jpg', ['disk' => 'uploaders']);
223 223
224 224 
         FakeUploader::create([
225 
-            'extras' => ['upload' => 'avatar1.jpg', 'upload_multiple' => ['avatar2.jpg',  'avatar3.jpg']],
225 
+            'extras' => ['upload' => 'avatar1.jpg', 'upload_multiple' => ['avatar2.jpg', 'avatar3.jpg']],
226 226 
         ]);
227 227 
     }
228 228
Please login to merge, or discard this patch.
tests/config/HasUploadedFiles.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -13,7 +13,7 @@
 
 block discarded – undo
13 13
14 14 
     protected function getUploadedFiles(array $fileNames, string $mime = 'image/jpg')
15 15 
     {
16 
-        return array_map(function ($fileName) use ($mime) {
16 
+        return array_map(function($fileName) use ($mime) {
17 17 
             return new UploadedFile(__DIR__.'/assets/'.$fileName, $fileName, $mime, null, true);
18 18 
         }, $fileNames);
19 19 
     }
Please login to merge, or discard this patch.
tests/Feature/UploadersValidationTest.php 1 patch
Spacing   +12 added lines, -12 removed lines patch added patch discarded remove patch 
@@ -62,7 +62,7 @@  discard block
 
 block discarded – undo
62 62
63 63 
         $this->assertDatabaseHas('uploaders', [
64 64 
             'upload' => 'avatar1.jpg',
65 
-            'upload_multiple' => json_encode(['avatar2.jpg',  'avatar3.jpg']),
65 
+            'upload_multiple' => json_encode(['avatar2.jpg', 'avatar3.jpg']),
66 66 
         ]);
67 67
68 68 
         $this->assertTrue(Storage::disk('uploaders')->exists('avatar1.jpg'));
 
@@ -97,8 +97,8 @@  discard block
 
 block discarded – undo
97 97
98 98 
         $response = $this->put($this->testBaseUrl.'/1', [
99 99 
             'upload' => $this->getUploadedFile('avatar4.jpg'),
100 
-            'upload_multiple' => $this->getUploadedFiles(['avatar5.jpg',  'avatar6.jpg']),
101 
-            'clear_upload_multiple' => ['avatar2.jpg',  'avatar3.jpg'],
100 
+            'upload_multiple' => $this->getUploadedFiles(['avatar5.jpg', 'avatar6.jpg']),
101 
+            'clear_upload_multiple' => ['avatar2.jpg', 'avatar3.jpg'],
102 102 
             'id' => 1,
103 103 
         ]);
104 104 
 
@@ -110,7 +110,7 @@  discard block
 
 block discarded – undo
110 110
111 111 
         $this->assertDatabaseHas('uploaders', [
112 112 
             'upload' => 'avatar4.jpg',
113 
-            'upload_multiple' => json_encode(['avatar5.jpg',  'avatar6.jpg']),
113 
+            'upload_multiple' => json_encode(['avatar5.jpg', 'avatar6.jpg']),
114 114 
         ]);
115 115
116 116 
         $files = Storage::disk('uploaders')->allFiles();
 
@@ -142,7 +142,7 @@  discard block
 
 block discarded – undo
142 142 
         self::initUploaderWithFiles();
143 143
144 144 
         $response = $this->put($this->testBaseUrl.'/1', [
145 
-            'upload_multiple' => ['avatar2.jpg',  'avatar3.jpg'],
145 
+            'upload_multiple' => ['avatar2.jpg', 'avatar3.jpg'],
146 146 
             'id' => 1,
147 147 
         ]);
148 148 
 
@@ -154,7 +154,7 @@  discard block
 
 block discarded – undo
154 154
155 155 
         $this->assertDatabaseHas('uploaders', [
156 156 
             'upload' => 'avatar1.jpg',
157 
-            'upload_multiple' => json_encode(['avatar2.jpg',  'avatar3.jpg']),
157 
+            'upload_multiple' => json_encode(['avatar2.jpg', 'avatar3.jpg']),
158 158 
         ]);
159 159
160 160 
         $files = Storage::disk('uploaders')->allFiles();
 
@@ -171,7 +171,7 @@  discard block
 
 block discarded – undo
171 171 
         self::initUploaderWithFiles();
172 172
173 173 
         $response = $this->put($this->testBaseUrl.'/1', [
174 
-            'upload_multiple' => $this->getUploadedFiles(['avatar4.jpg',  'avatar5.jpg']),
174 
+            'upload_multiple' => $this->getUploadedFiles(['avatar4.jpg', 'avatar5.jpg']),
175 175 
             'clear_upload_multiple' => ['avatar2.jpg'],
176 176 
             'id' => 1,
177 177 
         ]);
 
@@ -184,7 +184,7 @@  discard block
 
 block discarded – undo
184 184
185 185 
         $this->assertDatabaseHas('uploaders', [
186 186 
             'upload' => 'avatar1.jpg',
187 
-            'upload_multiple' => json_encode(['avatar3.jpg', 'avatar4.jpg',  'avatar5.jpg']),
187 
+            'upload_multiple' => json_encode(['avatar3.jpg', 'avatar4.jpg', 'avatar5.jpg']),
188 188 
         ]);
189 189
190 190 
         $files = Storage::disk('uploaders')->allFiles();
 
@@ -341,7 +341,7 @@  discard block
 
 block discarded – undo
341 341 
         $response = $this->put($this->testBaseUrl.'/1', [
342 342 
             'upload' => null,
343 343 
             'upload_multiple' => null,
344 
-            'clear_upload_multiple' => ['avatar2.jpg',  'avatar3.jpg'],
344 
+            'clear_upload_multiple' => ['avatar2.jpg', 'avatar3.jpg'],
345 345 
             'id' => 1,
346 346 
         ]);
347 347 
 
@@ -364,7 +364,7 @@  discard block
 
 block discarded – undo
364 364
365 365 
         $response = $this->put($this->testBaseUrl.'/1', [
366 366 
             'upload_multiple' => $this->getUploadedFiles(['avatar2.jpg']),
367 
-            'clear_upload_multiple' => ['avatar2.jpg',  'avatar3.jpg'],
367 
+            'clear_upload_multiple' => ['avatar2.jpg', 'avatar3.jpg'],
368 368 
             'id' => 1,
369 369 
         ]);
370 370 
 
@@ -386,7 +386,7 @@  discard block
 
 block discarded – undo
386 386
387 387 
         Uploader::create([
388 388 
             'upload' => 'avatar1.jpg',
389 
-            'upload_multiple' => json_encode(['avatar2.jpg',  'avatar3.jpg']),
389 
+            'upload_multiple' => json_encode(['avatar2.jpg', 'avatar3.jpg']),
390 390 
         ]);
391 391 
     }
392 392 
 
@@ -398,7 +398,7 @@  discard block
 
 block discarded – undo
398 398
399 399 
         Uploader::create([
400 400 
             'upload' => 'avatar1.jpg',
401 
-            'upload_multiple' => json_encode(['avatar2.jpg',  'avatar3.jpg']),
401 
+            'upload_multiple' => json_encode(['avatar2.jpg', 'avatar3.jpg']),
402 402 
         ]);
403 403 
     }
404 404
Please login to merge, or discard this patch.