Multiple::getDefault() - Code Metrics - Inspection of "[POC][WIP] backpack smart components" - Laravel-Backpack/CRUD - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — main (#4854)

by Pedro

created 2023-01-02 12:50 UTC

Multiple::getDefault() B

↳ Parent: Multiple

Complexity

Conditions	8
Paths	8

Size

Total Lines	16
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	8
eloc	12
c	0
b	0
f	0
nc	8
nop	1
dl	0
loc	16
rs	8.4444

<?php

namespace Backpack\CRUD\app\Library\Components\Attributes;

use Backpack\CRUD\app\Library\Components\Interfaces\SmartAttributeInterface;
use Backpack\CRUD\app\Library\Components\Interfaces\SmartCollectionInterface;

class Multiple extends BaseAttribute implements SmartAttributeInterface
{
    public static function getDefault(SmartCollectionInterface $attributes)
    {
        switch ($attributes->getAttributeValue('relation_type')) {
            case 'BelongsToMany':
            case 'HasMany':
            case 'HasManyThrough':
            case 'HasOneOrMany':
            case 'MorphMany':
            case 'MorphOneOrMany':
            case 'MorphToMany':
                return true;
            default:
                return false;
        }

        return false;
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}
    }

    public static function getValidationRules(SmartCollectionInterface $attributes): array
    {
        return ['nullable', 'string'];
    }

    public static function getAttributeName(): string
    {
        return 'relation_type';
    }
}


1			<?php
2
3			namespace Backpack\CRUD\app\Library\Components\Attributes;
4
5			use Backpack\CRUD\app\Library\Components\Interfaces\SmartAttributeInterface;
6			use Backpack\CRUD\app\Library\Components\Interfaces\SmartCollectionInterface;
7
8			class Multiple extends BaseAttribute implements SmartAttributeInterface
9			{
10			public static function getDefault(SmartCollectionInterface $attributes)
11			{
12			switch ($attributes->getAttributeValue('relation_type')) {
13			case 'BelongsToMany':
14			case 'HasMany':
15			case 'HasManyThrough':
16			case 'HasOneOrMany':
17			case 'MorphMany':
18			case 'MorphOneOrMany':
19			case 'MorphToMany':
20			return true;
21			default:
22			return false;
23			}
24
25			return false;
			0 ignored issues – show Unused Code introduced 2023-01-01 17:19 UTC by Report Bug Copy Issue Report `return false` is not reachable. This check looks for unreachable code. It uses sophisticated control flow analysis techniques to find statements which will never be executed. Unreachable code is most often the result of `return`, `die` or `exit` statements that have been added for debug purposes. function fx() { try { doSomething(); return true; } catch (\Exception $e) { return false; } return false; } In the above example, the last `return false` will never be executed, because a return statement has already been met in every possible execution path. Loading history...
26			}
27
28			public static function getValidationRules(SmartCollectionInterface $attributes): array
29			{
30			return ['nullable', 'string'];
31			}
32
33			public static function getAttributeName(): string
34			{
35			return 'relation_type';
36			}
37			}
38

Laravel-Backpack / CRUD

Scrutinizer GitHub App not installed

Pull Request — main (#4854)

Multiple::getDefault() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like