Backpack\CRUD\app\Library\Components\CollectionRepository

Complexity

Total Complexity

13

Size/Duplication

Total Lines	61
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

9 Methods

Rating	Name	Duplication	Size	Complexity
A	addItem()	0	5	2
A	save()	0	4	2
A	getItemByName()	0	4	1
A	replaceItem()	0	6	1
A	removeItem()	0	7	2
A	getAttribute()	0	3	1
A	__construct()	0	2	1
A	setItemAttributes()	0	3	1
A	getItems()	0	6	2

<?php

namespace Backpack\CRUD\app\Library\Components;

use Backpack\CRUD\app\Library\Components\Interfaces\SmartComponentInterface;
use Closure;
use Illuminate\Support\Collection;

class CollectionRepository
{
    public function __construct(private Closure $getCollection, private Closure $saveCollection)
    {
    }

    public function addItem($key, $value, $save = true)
    {
        $items = $this->getItems();
        $items[$key] = $value;
        ! $save ?: $this->save($items->toArray());
    }

    public function getItems(): Collection
    {
        if ($this->getCollection) {
            $collection = ($this->getCollection)();

            return collect($collection);
        }

The function implicitly returns null when the if condition on line 24 is false. This is incompatible with the type-hinted return Illuminate\Support\Collection. Consider adding a return statement or allowing null as return value.

    }

    public function removeItem($attribute, $save = true)
    {
        $items = $this->getItems()->filter(function ($collectionItem, $key) use ($attribute) {

The parameter $key is not used and could be removed.

            return $collectionItem->getName() !== $attribute;
        });

        ! $save ?: $this->save($items);
    }

    private function save($collection)
    {
        if (is_callable($this->saveCollection)) {
            ($this->saveCollection)($collection);
        }
    }

    public function setItemAttributes($key, $attributes)
    {
        $this->addItem($key, $attributes);
    }

    public function getItemByName($name)
    {
        return $this->getItems()->first(function ($item, $key) use ($name) {
            return $key === $name;
        });
    }

    public function replaceItem(SmartComponentInterface $item)
    {
        $items = $this->removeItem($item, false);

Are you sure the assignment to $items is correct as $this->removeItem($item, false) targeting Backpack\CRUD\app\Library\Components\CollectionRepository::removeItem() seems to always return null.

The assignment to $items is dead and can be removed.

        $items = $this->addItem($item, false);

Are you sure the assignment to $items is correct as $this->addItem($item, false) targeting Backpack\CRUD\app\Library\Components\CollectionRepository::addItem() seems to always return null.

        $this->save($items);
    }

    public function getAttribute($attribute)
    {
        return $this->attributes[$attribute];

The property attributes does not exist on Backpack\CRUD\app\Library\Components\CollectionRepository. Did you maybe forget to declare it?

    }
}