Backpack\CRUD\app\Library\CrudPanel\Traits\Update::getModelAttributeValue()

Complexity

Conditions	23
Paths	19

Size

Total Lines	83
Code Lines	43

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	1	Features	0

<?php
    private function getModelAttributeValue($model, $field)
    {
        if (isset($field['entity'])) {
            $relational_entity = $this->parseRelationFieldNamesFromHtml([$field])[0]['name'];

It seems like parseRelationFieldNamesFromHtml() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            $relation_array = explode('.', $relational_entity);

            $relatedModel = $relatedModel = array_reduce(array_splice($relation_array, 0, -1), function ($obj, $method) {

The assignment to $relatedModel is dead and can be removed.

                return $obj->{$method} ? $obj->{$method} : $obj;
            }, $model);

            $relationMethod = Arr::last($relation_array);
            if (method_exists($relatedModel, $relationMethod)) {
                $relation = $relatedModel->{$relationMethod}();
                if ($relation instanceof HasOne || $relation instanceof MorphOne) {
                    return $relatedModel->{$relationMethod}->{Arr::last(explode('.', $relational_entity))};
                }

                if ($relation instanceof HasMany || $relation instanceof MorphMany) {
                    if (isset($field['pivotFields']) && is_array($field['pivotFields'])) {
                        $pivot_fields = Arr::where($field['pivotFields'], function ($item) use ($field) {
                            return $field['name'] != $item['name'];
                        });
                        $related_models = $relatedModel->{$relationMethod};
                        $return = [];

                        // for any given model, we grab the attributes that belong to our pivot table.
                        foreach ($related_models as $related_model) {
                            //for any given related model, we attach the pivot fields.
                            foreach ($pivot_fields as $pivot_field) {
                                $item[$pivot_field['name']] = $related_model->{$pivot_field['name']};
                                $item[$related_model->getKeyName()] = $related_model->getKey();
                            }
                            $return[] = $item;

The variable $item does not seem to be defined for all execution paths leading up to this point.

                        }
                        // we return the json encoded result as expected by repeatable field.
                        return json_encode($return);
                    }
                }

                if ($relation instanceof BelongsToMany || $relation instanceof MorphToMany) {

                    // if pivot is true and there are `pivotFields` we need to get those pivot values to show on the edit page
                    if (isset($field['pivot']) && $field['pivot'] && isset($field['pivotFields']) && is_array($field['pivotFields'])) {

                        // we remove our current relation from the pivotFields.
                        $pivot_fields = Arr::where($field['pivotFields'], function ($item) use ($field) {
                            return $field['name'] != $item['name'];
                        });

                        $related_models = $relatedModel->{$relationMethod};
                        $return = [];

                        // for any given model, we grab the attributes that belong to our pivot table.
                        foreach ($related_models as $related_model) {
                            $item[$field['name']] = $related_model->getKey();
                            //for any given related model, we attach the pivot fields.
                            foreach ($pivot_fields as $pivot_field) {
                                $item[$pivot_field['name']] = $related_model->pivot->{$pivot_field['name']};
                            }
                            $return[] = $item;
                        }

                        // we return the json encoded result as expected by repeatable field.
                        return json_encode($return);
                    }
                }
            }

            return $relatedModel->{$relationMethod};
        }

        if (is_string($field['name'])) {
            return $model->{$field['name']};
        }

        if (is_array($field['name'])) {
            $result = [];
            foreach ($field['name'] as $key => $value) {
                $result = $model->{$value};
            }

            return $result;
        }