Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Completed
Pull Request — master (#1935)
by Cristian
04:23 queued 02:07
created
src/app/Library/CrudPanel/Traits/Settings.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -102,7 +102,7 @@
 block discarded – undo
102 102
      * Defaults to the current operation.
103 103
      *
104 104
      * @param  string   $key   Has no operation prepended. (ex: exportButtons)
105
-     * @return mixed      [description]
105
+     * @return boolean      [description]
106 106
      */
107 107
     public function hasOperationSetting(string $key, $operation = null)
108 108
     {
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -49,7 +49,7 @@
 block discarded – undo
49 49
      */
50 50
     public function settings()
51 51
     {
52
-        return \Arr::sort($this->settings, function ($value, $key) {
52
+        return \Arr::sort($this->settings, function($value, $key) {
53 53
             return $key;
54 54
         });
55 55
     }
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Tabs.php 2 patches
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -35,6 +35,9 @@
 block discarded – undo
35 35
         return ! $this->tabsEnabled();
36 36
     }
37 37
 
38
+    /**
39
+     * @param string $type
40
+     */
38 41
     public function setTabsType($type)
39 42
     {
40 43
         $this->enableTabs();
Please login to merge, or discard this patch.
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -32,7 +32,7 @@  discard block
 block discarded – undo
32 32
      */
33 33
     public function tabsDisabled()
34 34
     {
35
-        return ! $this->tabsEnabled();
35
+        return !$this->tabsEnabled();
36 36
     }
37 37
 
38 38
     public function setTabsType($type)
@@ -114,8 +114,8 @@  discard block
 block discarded – undo
114 114
     {
115 115
         $all_fields = $this->getCurrentFields();
116 116
 
117
-        $fields_without_a_tab = collect($all_fields)->filter(function ($value, $key) {
118
-            return ! isset($value['tab']);
117
+        $fields_without_a_tab = collect($all_fields)->filter(function($value, $key) {
118
+            return !isset($value['tab']);
119 119
         });
120 120
 
121 121
         return $fields_without_a_tab;
@@ -131,7 +131,7 @@  discard block
 block discarded – undo
131 131
         if ($this->tabExists($label)) {
132 132
             $all_fields = $this->getCurrentFields();
133 133
 
134
-            $fields_for_current_tab = collect($all_fields)->filter(function ($value, $key) use ($label) {
134
+            $fields_for_current_tab = collect($all_fields)->filter(function($value, $key) use ($label) {
135 135
                 return isset($value['tab']) && $value['tab'] == $label;
136 136
             });
137 137
 
@@ -150,11 +150,11 @@  discard block
 block discarded – undo
150 150
         $fields = $this->getCurrentFields();
151 151
 
152 152
         $fields_with_tabs = collect($fields)
153
-            ->filter(function ($value, $key) {
153
+            ->filter(function($value, $key) {
154 154
                 return isset($value['tab']);
155 155
             })
156
-            ->each(function ($value, $key) use (&$tabs) {
157
-                if (! in_array($value['tab'], $tabs)) {
156
+            ->each(function($value, $key) use (&$tabs) {
157
+                if (!in_array($value['tab'], $tabs)) {
158 158
                     $tabs[] = $value['tab'];
159 159
                 }
160 160
             });
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Validation.php 2 patches
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -88,7 +88,6 @@
 block discarded – undo
88 88
      * for the given operation.
89 89
      *
90 90
      * @param string $inputKey Field or input name.
91
-     * @param string $operation create / update
92 91
      *
93 92
      * @return bool
94 93
      */
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -94,7 +94,7 @@
 block discarded – undo
94 94
      */
95 95
     public function isRequired($inputKey)
96 96
     {
97
-        if (! $this->hasOperationSetting('requiredFields')) {
97
+        if (!$this->hasOperationSetting('requiredFields')) {
98 98
             return false;
99 99
         }
100 100
 
Please login to merge, or discard this patch.
src/app/Models/Traits/CrudTrait.php 3 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -69,7 +69,7 @@
 block discarded – undo
69 69
      *
70 70
      * @param array $columns - the database columns that contain the JSONs
71 71
      *
72
-     * @return Model
72
+     * @return CrudTrait
73 73
      */
74 74
     public function withFakes($columns = [])
75 75
     {
Please login to merge, or discard this patch.
Unused Use Statements   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -3,9 +3,9 @@
 block discarded – undo
3 3
 namespace Backpack\CRUD\app\Models\Traits;
4 4
 
5 5
 use DB;
6
-use Traversable;
7
-use Illuminate\Support\Facades\Config;
8 6
 use Illuminate\Database\Eloquent\Model;
7
+use Illuminate\Support\Facades\Config;
8
+use Traversable;
9 9
 
10 10
 trait CrudTrait
11 11
 {
Please login to merge, or discard this patch.
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -69,7 +69,7 @@  discard block
 block discarded – undo
69 69
         $conn->getDoctrineSchemaManager()->getDatabasePlatform()->registerDoctrineTypeMapping('json', 'json_array');
70 70
         $conn->getDoctrineSchemaManager()->getDatabasePlatform()->registerDoctrineTypeMapping('jsonb', 'json_array');
71 71
 
72
-        return ! $conn->getDoctrineColumn($table, $column_name)->getNotnull();
72
+        return !$conn->getDoctrineColumn($table, $column_name)->getNotnull();
73 73
     }
74 74
 
75 75
     /*
@@ -86,7 +86,7 @@  discard block
 block discarded – undo
86 86
     public function addFakes($columns = ['extras'])
87 87
     {
88 88
         foreach ($columns as $key => $column) {
89
-            if (! isset($this->attributes[$column])) {
89
+            if (!isset($this->attributes[$column])) {
90 90
                 continue;
91 91
             }
92 92
 
@@ -134,7 +134,7 @@  discard block
 block discarded – undo
134 134
      */
135 135
     public function shouldDecodeFake($column)
136 136
     {
137
-        return ! in_array($column, array_keys($this->casts));
137
+        return !in_array($column, array_keys($this->casts));
138 138
     }
139 139
 
140 140
     /**
@@ -145,7 +145,7 @@  discard block
 block discarded – undo
145 145
      */
146 146
     public function shouldEncodeFake($column)
147 147
     {
148
-        return ! in_array($column, array_keys($this->casts));
148
+        return !in_array($column, array_keys($this->casts));
149 149
     }
150 150
 
151 151
     /*
@@ -219,7 +219,7 @@  discard block
 block discarded – undo
219 219
     public function uploadMultipleFilesToDisk($value, $attribute_name, $disk, $destination_path)
220 220
     {
221 221
         $request = \Request::instance();
222
-        if (! is_array($this->{$attribute_name})) {
222
+        if (!is_array($this->{$attribute_name})) {
223 223
             $attribute_value = json_decode($this->{$attribute_name}, true) ?? [];
224 224
         } else {
225 225
             $attribute_value = $this->{$attribute_name};
@@ -231,7 +231,7 @@  discard block
 block discarded – undo
231 231
         if ($files_to_clear) {
232 232
             foreach ($files_to_clear as $key => $filename) {
233 233
                 \Storage::disk($disk)->delete($filename);
234
-                $attribute_value = array_where($attribute_value, function ($value, $key) use ($filename) {
234
+                $attribute_value = array_where($attribute_value, function($value, $key) use ($filename) {
235 235
                     return $value != $filename;
236 236
                 });
237 237
             }
Please login to merge, or discard this patch.
src/app/Models/Traits/InheritsRelationsFromParentModel.php 2 patches
Unused Use Statements   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -2,8 +2,8 @@
 block discarded – undo
2 2
 
3 3
 namespace Backpack\CRUD\app\Models\Traits;
4 4
 
5
-use ReflectionClass;
6 5
 use Illuminate\Support\Str;
6
+use ReflectionClass;
7 7
 
8 8
 /**
9 9
  * This trait helps a child model (ex: BackpackUser) inherit all relationships of its parent model (ex: User).
Please login to merge, or discard this patch.
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -18,14 +18,14 @@  discard block
 block discarded – undo
18 18
 
19 19
     public static function bootHasParent()
20 20
     {
21
-        static::creating(function ($model) {
21
+        static::creating(function($model) {
22 22
             if ($model->parentHasHasChildrenTrait()) {
23 23
                 $model->forceFill(
24 24
                     [$model->getInheritanceColumn() => $model->classToAlias(get_class($model))]
25 25
                 );
26 26
             }
27 27
         });
28
-        static::addGlobalScope(function ($query) {
28
+        static::addGlobalScope(function($query) {
29 29
             $instance = new static();
30 30
             if ($instance->parentHasHasChildrenTrait()) {
31 31
                 $query->where($instance->getTable().'.'.$instance->getInheritanceColumn(), $instance->classToAlias(get_class($instance)));
@@ -40,7 +40,7 @@  discard block
 block discarded – undo
40 40
 
41 41
     public function getTable()
42 42
     {
43
-        if (! isset($this->table)) {
43
+        if (!isset($this->table)) {
44 44
             return str_replace('\\', '', Str::snake(Str::plural(class_basename($this->getParentClass()))));
45 45
         }
46 46
 
Please login to merge, or discard this patch.
src/app/Models/Traits/SpatieTranslatable/Sluggable.php 3 patches
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -37,7 +37,6 @@
 block discarded – undo
37 37
      * Query scope for finding "similar" slugs, used to determine uniqueness.
38 38
      *
39 39
      * @param \Illuminate\Database\Eloquent\Builder $query
40
-     * @param \Illuminate\Database\Eloquent\Model $model
41 40
      * @param string $attribute
42 41
      * @param array $config
43 42
      * @param string $slug
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -48,7 +48,7 @@
 block discarded – undo
48 48
         $separator = $config['separator'];
49 49
         $attribute = $attribute.'->'.$this->getLocale();
50 50
 
51
-        return $query->where(function (Builder $q) use ($attribute, $slug, $separator) {
51
+        return $query->where(function(Builder $q) use ($attribute, $slug, $separator) {
52 52
             $q->where($attribute, '=', $slug)
53 53
                 ->orWhere($attribute, 'LIKE', $slug.$separator.'%')
54 54
                 // Fixes issues with Json data types in MySQL where data is sourrounded by "
Please login to merge, or discard this patch.
Unused Use Statements   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -2,9 +2,9 @@
 block discarded – undo
2 2
 
3 3
 namespace Backpack\CRUD\app\Models\Traits\SpatieTranslatable;
4 4
 
5
-use Illuminate\Database\Eloquent\Model;
6
-use Illuminate\Database\Eloquent\Builder;
7 5
 use Cviebrock\EloquentSluggable\Sluggable as OriginalSluggable;
6
+use Illuminate\Database\Eloquent\Builder;
7
+use Illuminate\Database\Eloquent\Model;
8 8
 
9 9
 trait Sluggable
10 10
 {
Please login to merge, or discard this patch.
src/helpers.php 2 patches
Doc Comments   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -5,7 +5,7 @@  discard block
 block discarded – undo
5 5
      * Appends the configured backpack prefix and returns
6 6
      * the URL using the standard Laravel helpers.
7 7
      *
8
-     * @param $path
8
+     * @param string $path
9 9
      *
10 10
      * @return string
11 11
      */
@@ -156,6 +156,7 @@  discard block
 block discarded – undo
156 156
      * If that view doesn't exist, it will load the one from the original theme.
157 157
      *
158 158
      * @param string (see config/backpack/base.php)
159
+     * @param string $view
159 160
      *
160 161
      * @return string
161 162
      */
Please login to merge, or discard this patch.
Spacing   +14 added lines, -14 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-if (! function_exists('backpack_url')) {
3
+if (!function_exists('backpack_url')) {
4 4
     /**
5 5
      * Appends the configured backpack prefix and returns
6 6
      * the URL using the standard Laravel helpers.
@@ -11,13 +11,13 @@  discard block
 block discarded – undo
11 11
      */
12 12
     function backpack_url($path = null, $parameters = [], $secure = null)
13 13
     {
14
-        $path = ! $path || (substr($path, 0, 1) == '/') ? $path : '/'.$path;
14
+        $path = !$path || (substr($path, 0, 1) == '/') ? $path : '/'.$path;
15 15
 
16 16
         return url(config('backpack.base.route_prefix', 'admin').$path, $parameters = [], $secure = null);
17 17
     }
18 18
 }
19 19
 
20
-if (! function_exists('backpack_authentication_column')) {
20
+if (!function_exists('backpack_authentication_column')) {
21 21
     /**
22 22
      * Return the username column name.
23 23
      * The Laravel default (and Backpack default) is 'email'.
@@ -30,7 +30,7 @@  discard block
 block discarded – undo
30 30
     }
31 31
 }
32 32
 
33
-if (! function_exists('backpack_users_have_email')) {
33
+if (!function_exists('backpack_users_have_email')) {
34 34
     /**
35 35
      * Check if the email column is present on the user table.
36 36
      *
@@ -45,7 +45,7 @@  discard block
 block discarded – undo
45 45
     }
46 46
 }
47 47
 
48
-if (! function_exists('backpack_avatar_url')) {
48
+if (!function_exists('backpack_avatar_url')) {
49 49
     /**
50 50
      * Returns the avatar URL of a user.
51 51
      *
@@ -78,7 +78,7 @@  discard block
 block discarded – undo
78 78
     }
79 79
 }
80 80
 
81
-if (! function_exists('backpack_middleware')) {
81
+if (!function_exists('backpack_middleware')) {
82 82
     /**
83 83
      * Return the key of the middleware used across Backpack.
84 84
      * That middleware checks if the visitor is an admin.
@@ -93,7 +93,7 @@  discard block
 block discarded – undo
93 93
     }
94 94
 }
95 95
 
96
-if (! function_exists('backpack_guard_name')) {
96
+if (!function_exists('backpack_guard_name')) {
97 97
     /*
98 98
      * Returns the name of the guard defined
99 99
      * by the application config
@@ -104,7 +104,7 @@  discard block
 block discarded – undo
104 104
     }
105 105
 }
106 106
 
107
-if (! function_exists('backpack_auth')) {
107
+if (!function_exists('backpack_auth')) {
108 108
     /*
109 109
      * Returns the user instance if it exists
110 110
      * of the currently authenticated admin
@@ -116,7 +116,7 @@  discard block
 block discarded – undo
116 116
     }
117 117
 }
118 118
 
119
-if (! function_exists('backpack_user')) {
119
+if (!function_exists('backpack_user')) {
120 120
     /*
121 121
      * Returns back a user instance without
122 122
      * the admin guard, however allows you
@@ -128,7 +128,7 @@  discard block
 block discarded – undo
128 128
     }
129 129
 }
130 130
 
131
-if (! function_exists('mb_ucfirst')) {
131
+if (!function_exists('mb_ucfirst')) {
132 132
     /**
133 133
      * Capitalize the first letter of a string,
134 134
      * even if that string is multi-byte (non-latin alphabet).
@@ -150,7 +150,7 @@  discard block
 block discarded – undo
150 150
     }
151 151
 }
152 152
 
153
-if (! function_exists('backpack_view')) {
153
+if (!function_exists('backpack_view')) {
154 154
     /**
155 155
      * Returns a new displayable view based on the configured backpack view namespace.
156 156
      * If that view doesn't exist, it will load the one from the original theme.
@@ -169,7 +169,7 @@  discard block
 block discarded – undo
169 169
 
170 170
         $returnView = $theme.$view;
171 171
 
172
-        if (! view()->exists($returnView)) {
172
+        if (!view()->exists($returnView)) {
173 173
             $returnView = $originalTheme.$view;
174 174
         }
175 175
 
@@ -177,7 +177,7 @@  discard block
 block discarded – undo
177 177
     }
178 178
 }
179 179
 
180
-if (! function_exists('square_brackets_to_dots')) {
180
+if (!function_exists('square_brackets_to_dots')) {
181 181
     /**
182 182
      * Turns a string from bracket-type array to dot-notation array.
183 183
      * Ex: array[0][property] turns into array.0.property.
@@ -194,7 +194,7 @@  discard block
 block discarded – undo
194 194
     }
195 195
 }
196 196
 
197
-if (! function_exists('is_countable')) {
197
+if (!function_exists('is_countable')) {
198 198
     /**
199 199
      * We need this because is_countable was only introduced in PHP 7.3,
200 200
      * and in PHP 7.2 you should check if count() argument is really countable.
Please login to merge, or discard this patch.
src/routes/backpack/base.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -16,7 +16,7 @@
 block discarded – undo
16 16
     'middleware' => 'web',
17 17
     'prefix'     => config('backpack.base.route_prefix'),
18 18
 ],
19
-function () {
19
+function() {
20 20
     // if not otherwise configured, setup the auth routes
21 21
     if (config('backpack.base.setup_auth_routes')) {
22 22
         // Authentication Routes...
Please login to merge, or discard this patch.
src/routes/backpack/custom.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -10,5 +10,5 @@
 block discarded – undo
10 10
     'prefix'     => config('backpack.base.route_prefix', 'admin'),
11 11
     'middleware' => ['web', config('backpack.base.middleware_key', 'admin')],
12 12
     'namespace'  => 'App\Http\Controllers\Admin',
13
-], function () { // custom admin routes
13
+], function() { // custom admin routes
14 14
 }); // this should be the absolute last line of this file
Please login to merge, or discard this patch.