Laravel-Backpack / CRUD

src/app/Http/Requests/ChangePasswordRequest.php

Unused Use Statements +1 added lines, -1 removed lines

@@ -2,8 +2,8 @@
 
 namespace Backpack\CRUD\app\Http\Requests;
 
-use Illuminate\Support\Facades\Hash;
 use Illuminate\Foundation\Http\FormRequest;
+use Illuminate\Support\Facades\Hash;
 
 class ChangePasswordRequest extends FormRequest
 {

Spacing +2 added lines, -2 removed lines

@@ -41,9 +41,9 @@
      */
     public function withValidator($validator)
     {
-        $validator->after(function ($validator) {
+        $validator->after(function($validator) {
             // check old password matches
-            if (! Hash::check($this->input('old_password'), backpack_auth()->user()->password)) {
+            if (!Hash::check($this->input('old_password'), backpack_auth()->user()->password)) {
                 $validator->errors()->add('old_password', trans('backpack::base.old_password_incorrect'));
             }
         });

src/app/Library/CrudPanel/CrudPanel.php

Unused Use Statements +17 added lines, -17 removed lines

@@ -2,33 +2,33 @@
 
 namespace Backpack\CRUD\app\Library\CrudPanel;
 
-use Illuminate\Database\Eloquent\Collection;
-use Backpack\CRUD\app\Library\CrudPanel\Traits\Read;
-use Backpack\CRUD\app\Library\CrudPanel\Traits\Tabs;
-use Backpack\CRUD\app\Library\CrudPanel\Traits\Query;
-use Backpack\CRUD\app\Library\CrudPanel\Traits\Views;
 use Backpack\CRUD\app\Library\CrudPanel\Traits\Access;
+use Backpack\CRUD\app\Library\CrudPanel\Traits\AutoFocus;
+use Backpack\CRUD\app\Library\CrudPanel\Traits\AutoSet;
+use Backpack\CRUD\app\Library\CrudPanel\Traits\Buttons;
+use Backpack\CRUD\app\Library\CrudPanel\Traits\Columns;
 use Backpack\CRUD\app\Library\CrudPanel\Traits\Create;
 use Backpack\CRUD\app\Library\CrudPanel\Traits\Delete;
 use Backpack\CRUD\app\Library\CrudPanel\Traits\Errors;
+use Backpack\CRUD\app\Library\CrudPanel\Traits\FakeColumns;
+use Backpack\CRUD\app\Library\CrudPanel\Traits\FakeFields;
 use Backpack\CRUD\app\Library\CrudPanel\Traits\Fields;
-use Backpack\CRUD\app\Library\CrudPanel\Traits\Search;
-use Backpack\CRUD\app\Library\CrudPanel\Traits\Update;
-use Backpack\CRUD\app\Library\CrudPanel\Traits\AutoSet;
-use Backpack\CRUD\app\Library\CrudPanel\Traits\Buttons;
-use Backpack\CRUD\app\Library\CrudPanel\Traits\Columns;
 use Backpack\CRUD\app\Library\CrudPanel\Traits\Filters;
-use Backpack\CRUD\app\Library\CrudPanel\Traits\Reorder;
-use Backpack\CRUD\app\Library\CrudPanel\Traits\Settings;
-use Backpack\CRUD\app\Library\CrudPanel\Traits\AutoFocus;
+use Backpack\CRUD\app\Library\CrudPanel\Traits\HeadingsAndTitles;
 use Backpack\CRUD\app\Library\CrudPanel\Traits\Macroable;
-use Backpack\CRUD\app\Library\CrudPanel\Traits\FakeFields;
 use Backpack\CRUD\app\Library\CrudPanel\Traits\Operations;
-use Backpack\CRUD\app\Library\CrudPanel\Traits\Validation;
-use Backpack\CRUD\app\Library\CrudPanel\Traits\FakeColumns;
+use Backpack\CRUD\app\Library\CrudPanel\Traits\Query;
+use Backpack\CRUD\app\Library\CrudPanel\Traits\Read;
+use Backpack\CRUD\app\Library\CrudPanel\Traits\Reorder;
 use Backpack\CRUD\app\Library\CrudPanel\Traits\SaveActions;
-use Backpack\CRUD\app\Library\CrudPanel\Traits\HeadingsAndTitles;
+use Backpack\CRUD\app\Library\CrudPanel\Traits\Search;
+use Backpack\CRUD\app\Library\CrudPanel\Traits\Settings;
+use Backpack\CRUD\app\Library\CrudPanel\Traits\Tabs;
+use Backpack\CRUD\app\Library\CrudPanel\Traits\Update;
+use Backpack\CRUD\app\Library\CrudPanel\Traits\Validation;
+use Backpack\CRUD\app\Library\CrudPanel\Traits\Views;
 use Backpack\CRUD\app\Library\CrudPanel\Traits\ViewsAndRestoresRevisions;
+use Illuminate\Database\Eloquent\Collection;
 
 class CrudPanel
 {

Spacing +11 added lines, -11 removed lines

@@ -76,11 +76,11 @@ 
      */
     public function setModel($model_namespace)
     {
-        if (! class_exists($model_namespace)) {
+        if (!class_exists($model_namespace)) {
             throw new \Exception('The model does not exist.', 500);
         }
 
-        if (! method_exists($model_namespace, 'hasCrudTrait')) {
+        if (!method_exists($model_namespace, 'hasCrudTrait')) {
             throw new \Exception('Please use CrudTrait on the model.', 500);
         }
 
@@ -143,7 +143,7 @@ 
     {
         $complete_route = $route.'.index';
 
-        if (! \Route::has($complete_route)) {
+        if (!\Route::has($complete_route)) {
             throw new \Exception('There are no routes for this route name.', 404);
         }
 
@@ -244,7 +244,7 @@ 
      */
     public function getFirstOfItsTypeInArray($type, $array)
     {
-        return array_first($array, function ($item) use ($type) {
+        return array_first($array, function($item) use ($type) {
             return $item['type'] == $type;
         });
     }
@@ -261,8 +261,8 @@ 
 
     public function sync($type, $fields, $attributes)
     {
-        if (! empty($this->{$type})) {
-            $this->{$type} = array_map(function ($field) use ($fields, $attributes) {
+        if (!empty($this->{$type})) {
+            $this->{$type} = array_map(function($field) use ($fields, $attributes) {
                 if (in_array($field['name'], (array) $fields)) {
                     $field = array_merge($field, $attributes);
                 }
@@ -294,15 +294,15 @@ 
     {
         $relationArray = explode('.', $relationString);
 
-        if (! isset($length)) {
+        if (!isset($length)) {
             $length = count($relationArray);
         }
 
-        if (! isset($model)) {
+        if (!isset($model)) {
             $model = $this->model;
         }
 
-        $result = array_reduce(array_splice($relationArray, 0, $length), function ($obj, $method) {
+        $result = array_reduce(array_splice($relationArray, 0, $length), function($obj, $method) {
             return $obj->$method()->getRelated();
         }, $model);
 
@@ -352,7 +352,7 @@ 
         $relation = $model->{$firstRelationName};
 
         $results = [];
-        if (! empty($relation)) {
+        if (!empty($relation)) {
             if ($relation instanceof Collection) {
                 $currentResults = $relation->toArray();
             } else {
@@ -361,7 +361,7 @@ 
 
             array_shift($relationArray);
 
-            if (! empty($relationArray)) {
+            if (!empty($relationArray)) {
                 foreach ($currentResults as $currentResult) {
                     $results = array_merge($results, $this->getRelationModelInstances($currentResult, implode('.', $relationArray)));
                 }

src/app/Library/CrudPanel/Traits/AutoFocus.php

Doc Comments +3 added lines

@@ -12,6 +12,9 @@
         return $this->getOperationSetting('autoFocusOnFirstField');
     }
 
+    /**
+     * @param boolean $value
+     */
     public function setAutoFocusOnFirstField($value)
     {
         return $this->setOperationSetting('autoFocusOnFirstField', (bool) $value);

src/app/Library/CrudPanel/Traits/Create.php

Doc Comments +1 added lines, -1 removed lines

@@ -159,7 +159,7 @@
      * @param \Illuminate\Database\Eloquent\Model $item          The current CRUD model.
      * @param array                               $formattedData The form data.
      *
-     * @return bool|null
+     * @return false|null
      */
     private function createRelationsForItem($item, $formattedData)
     {

Unused Use Statements +1 added lines, -1 removed lines

@@ -2,8 +2,8 @@
 
 namespace Backpack\CRUD\app\Library\CrudPanel\Traits;
 
-use Illuminate\Database\Eloquent\Relations\HasOne;
 use Illuminate\Database\Eloquent\Relations\BelongsTo;
+use Illuminate\Database\Eloquent\Relations\HasOne;
 
 trait Create
 {

Spacing +4 added lines, -4 removed lines

@@ -81,7 +81,7 @@ 
     {
         $all_relation_fields = $this->getRelationFields();
 
-        return array_where($all_relation_fields, function ($value, $key) {
+        return array_where($all_relation_fields, function($value, $key) {
             return isset($value['pivot']) && $value['pivot'];
         });
     }
@@ -156,7 +156,7 @@ 
      */
     private function createRelationsForItem($item, $formattedData)
     {
-        if (! isset($formattedData['relations'])) {
+        if (!isset($formattedData['relations'])) {
             return false;
         }
 
@@ -213,11 +213,11 @@ 
                 $key = implode('.relations.', explode('.', $relationField['entity']));
                 $fieldData = array_get($relationData, 'relations.'.$key, []);
 
-                if (! array_key_exists('model', $fieldData)) {
+                if (!array_key_exists('model', $fieldData)) {
                     $fieldData['model'] = $relationField['model'];
                 }
 
-                if (! array_key_exists('parent', $fieldData)) {
+                if (!array_key_exists('parent', $fieldData)) {
                     $fieldData['parent'] = $this->getRelationModel($relationField['entity'], -1);
                 }
 

src/app/Library/CrudPanel/Traits/Delete.php

Doc Comments +1 added lines, -1 removed lines

@@ -15,7 +15,7 @@
      *
      * @param  int $id The id of the item to be deleted.
      *
-     * @return bool True if the item was deleted.
+     * @return string True if the item was deleted.
      *
      * @throws \Illuminate\Database\Eloquent\ModelNotFoundException if the model was not found.
      *

src/app/Library/CrudPanel/Traits/FakeFields.php

Doc Comments -2 removed lines

@@ -10,8 +10,6 @@
      * plus the '_token' and 'redirect_after_save' variables.
      *
      * @param array    $requestInput The request input.
-     * @param string   $form         The CRUD form. Can be 'create' or 'update' . Default is 'create'.
-     * @param int|bool $id           The CRUD entry id in the case of the 'update' form.
      *
      * @see \Illuminate\Http\Request::all() For an example on how to get the request input.
      *

Spacing +2 added lines, -2 removed lines

@@ -29,7 +29,7 @@ 
                 $fakeFieldKey = isset($field['store_in']) ? $field['store_in'] : 'extras';
                 $this->addCompactedField($requestInput, $field['name'], $fakeFieldKey);
 
-                if (! in_array($fakeFieldKey, $compactedFakeFields)) {
+                if (!in_array($fakeFieldKey, $compactedFakeFields)) {
                     $compactedFakeFields[] = $fakeFieldKey;
                 }
             }
@@ -37,7 +37,7 @@ 
 
         // json_encode all fake_value columns if applicable in the database, so they can be properly stored and interpreted
         foreach ($compactedFakeFields as $value) {
-            if (! (property_exists($this->model, 'translatable') && in_array($value, $this->model->getTranslatableAttributes(), true)) && $this->model->shouldEncodeFake($value)) {
+            if (!(property_exists($this->model, 'translatable') && in_array($value, $this->model->getTranslatableAttributes(), true)) && $this->model->shouldEncodeFake($value)) {
                 $requestInput[$value] = json_encode($requestInput[$value]);
             }
         }

src/app/Library/CrudPanel/Traits/Fields.php

Doc Comments -7 removed lines

@@ -22,7 +22,6 @@ 
      * Add a field to the create/update form or both.
      *
      * @param string|array $field The new field.
-     * @param string       $form  The CRUD form. Can be 'create', 'update' or 'both'. Default is 'both'.
      *
      * @return self
      */
@@ -70,7 +69,6 @@ 
      * Add multiple fields to the create/update form or both.
      *
      * @param array  $fields The new fields.
-     * @param string $form   The CRUD form. Can be 'create', 'update' or 'both'. Default is 'both'.
      */
     public function addFields($fields)
     {
@@ -85,7 +83,6 @@ 
      * Move the most recently added field after the given target field.
      *
      * @param string $targetFieldName The target field name.
-     * @param string $form            The CRUD form. Can be 'create', 'update' or 'both'. Default is 'both'.
      */
     public function afterField($targetFieldName)
     {
@@ -98,7 +95,6 @@ 
      * Move the most recently added field before the given target field.
      *
      * @param string $targetFieldName The target field name.
-     * @param string $form            The CRUD form. Can be 'create', 'update' or 'both'. Default is 'both'.
      */
     public function beforeField($targetFieldName)
     {
@@ -141,7 +137,6 @@ 
      * Remove a certain field from the create/update/both forms by its name.
      *
      * @param string $name Field name (as defined with the addField() procedure)
-     * @param string $form update/create/both
      */
     public function removeField($name)
     {
@@ -330,8 +325,6 @@ 
      * Check if the create/update form has upload fields.
      * Upload fields are the ones that have "upload" => true defined on them.
      *
-     * @param  string   $form create/update/both - defaults to 'both'
-     * @param  bool|int $id   id of the entity - defaults to false
      *
      * @return bool
      */

Spacing +12 added lines, -12 removed lines

@@ -38,23 +38,23 @@ 
 
         // if this is a relation type field and no corresponding model was specified, get it from the relation method
         // defined in the main model
-        if (isset($newField['entity']) && ! isset($newField['model'])) {
+        if (isset($newField['entity']) && !isset($newField['model'])) {
             $newField['model'] = $this->getRelationModel($newField['entity']);
         }
 
         // if the label is missing, we should set it
-        if (! isset($newField['label'])) {
+        if (!isset($newField['label'])) {
             $newField['label'] = mb_ucfirst(str_replace('_', ' ', $newField['name']));
         }
 
         // if the field type is missing, we should set it
-        if (! isset($newField['type'])) {
+        if (!isset($newField['type'])) {
             $newField['type'] = $this->getFieldTypeFromDbColumnType($newField['name']);
         }
 
         // if a tab was mentioned, we should enable it
         if (isset($newField['tab'])) {
-            if (! $this->tabsEnabled()) {
+            if (!$this->tabsEnabled()) {
                 $this->enableTabs();
             }
         }
@@ -89,7 +89,7 @@ 
      */
     public function afterField($targetFieldName)
     {
-        $this->transformFields(function ($fields) use ($targetFieldName) {
+        $this->transformFields(function($fields) use ($targetFieldName) {
             return $this->moveField($fields, $targetFieldName, false);
         });
     }
@@ -102,7 +102,7 @@ 
      */
     public function beforeField($targetFieldName)
     {
-        $this->transformFields(function ($fields) use ($targetFieldName) {
+        $this->transformFields(function($fields) use ($targetFieldName) {
             return $this->moveField($fields, $targetFieldName, true);
         });
     }
@@ -145,7 +145,7 @@ 
      */
     public function removeField($name)
     {
-        $this->transformFields(function ($fields) use ($name) {
+        $this->transformFields(function($fields) use ($name) {
             array_forget($fields, $name);
 
             return $fields;
@@ -159,7 +159,7 @@ 
      */
     public function removeFields($array_of_names)
     {
-        if (! empty($array_of_names)) {
+        if (!empty($array_of_names)) {
             foreach ($array_of_names as $name) {
                 $this->removeField($name);
             }
@@ -172,7 +172,7 @@ 
     public function removeAllFields()
     {
         $current_fields = $this->getCurrentFields();
-        if (! empty($current_fields)) {
+        if (!empty($current_fields)) {
             foreach ($current_fields as $field) {
                 $this->removeField($field['name']);
             }
@@ -246,7 +246,7 @@ 
                 $jsonCastables = ['array', 'object', 'json'];
                 $fieldCasting = $casted_attributes[$field['name']];
 
-                if (in_array($fieldCasting, $jsonCastables) && isset($data[$field['name']]) && ! empty($data[$field['name']]) && ! is_array($data[$field['name']])) {
+                if (in_array($fieldCasting, $jsonCastables) && isset($data[$field['name']]) && !empty($data[$field['name']]) && !is_array($data[$field['name']])) {
                     try {
                         $data[$field['name']] = json_decode($data[$field['name']]);
                     } catch (\Exception $e) {
@@ -275,7 +275,7 @@ 
      */
     public function orderFields($order)
     {
-        $this->transformFields(function ($fields) use ($order) {
+        $this->transformFields(function($fields) use ($order) {
             return $this->applyOrderToFields($fields, $order);
         });
     }
@@ -338,7 +338,7 @@ 
     public function hasUploadFields()
     {
         $fields = $this->getFields();
-        $upload_fields = array_where($fields, function ($value, $key) {
+        $upload_fields = array_where($fields, function($value, $key) {
             return isset($value['upload']) && $value['upload'] == true;
         });
 

src/app/Library/CrudPanel/Traits/Operations.php

Doc Comments +2 added lines, -2 removed lines

@@ -56,7 +56,7 @@ 
     /**
      * Convenience method to make sure all calls are made to a particular operation.
      *
-     * @param  string|array     $operation      Operation name in string form
+     * @param  string|array     $operations      Operation name in string form
      * @param  bool|\Closure    $closure        Code that calls CrudPanel methods.
      * @return void
      */
@@ -70,7 +70,7 @@ 
      * Allc configurations are put inside that operation's namespace.
      * Ex: show.configuration.
      *
-     * @param  string|array     $operation      Operation name in string form
+     * @param  string|array     $operations      Operation name in string form
      * @param  bool|\Closure    $closure        Code that calls CrudPanel methods.
      * @return void
      */

src/app/Library/CrudPanel/Traits/Query.php

Doc Comments +1 added lines, -1 removed lines

@@ -62,7 +62,7 @@
      * Order results of the query in a custom way.
      *
      * @param  array $column           Column array with all attributes
-     * @param  string $column_direction ASC or DESC
+     * @param  string $columnDirection ASC or DESC
      *
      * @return \Illuminate\Database\Eloquent\Builder
      */

Spacing +1 added lines, -1 removed lines

@@ -68,7 +68,7 @@
      */
     public function customOrderBy($column, $columnDirection = 'asc')
     {
-        if (! isset($column['orderLogic'])) {
+        if (!isset($column['orderLogic'])) {
             return $this->query;
         }