Laravel-Backpack / CRUD

src/PanelTraits/RequiredFields.php

Spacing +1 added lines, -1 removed lines

@@ -42,7 +42,7 @@
      */
     public function isRequired($inputName, $operation)
     {
-        if (! isset($this->requiredFields[$operation])) {
+        if (!isset($this->requiredFields[$operation])) {
             return false;
         }
 

src/app/Http/Controllers/Operations/SaveActions.php

Spacing +3 added lines, -4 removed lines

@@ -22,11 +22,11 @@ 
 
         $saveOptions = collect($permissions)
             // Restrict list to allowed actions.
-            ->filter(function ($action, $permission) {
+            ->filter(function($action, $permission) {
                 return $this->crud->hasAccess($permission);
             })
             // Generate list of possible actions.
-            ->mapWithKeys(function ($action, $permission) {
+            ->mapWithKeys(function($action, $permission) {
                 return [$action => $this->getSaveActionButtonName($action)];
             })
             ->all();
@@ -61,8 +61,7 @@ 
      */
     public function setSaveAction($forceSaveAction = null)
     {
-        $saveAction = $forceSaveAction ?:
-            \Request::input('save_action', config('backpack.crud.default_save_action', 'save_and_back'));
+        $saveAction = $forceSaveAction ?: \Request::input('save_action', config('backpack.crud.default_save_action', 'save_and_back'));
 
         if (config('backpack.crud.show_save_action_change', true) &&
             session('save_action', 'save_and_back') !== $saveAction) {

src/PanelTraits/HeadingsAndTitle.php

Spacing +6 added lines, -6 removed lines

@@ -21,7 +21,7 @@ 
      */
     public function getTitle($action = false)
     {
-        if (! $action) {
+        if (!$action) {
             $action = $this->getActionMethod();
         }
 
@@ -38,7 +38,7 @@ 
      */
     public function setTitle($string, $action = false)
     {
-        if (! $action) {
+        if (!$action) {
             $action = $this->getActionMethod();
         }
 
@@ -58,7 +58,7 @@ 
      */
     public function getHeading($action = false)
     {
-        if (! $action) {
+        if (!$action) {
             $action = $this->getActionMethod();
         }
 
@@ -75,7 +75,7 @@ 
      */
     public function setHeading($string, $action = false)
     {
-        if (! $action) {
+        if (!$action) {
             $action = $this->getActionMethod();
         }
 
@@ -95,7 +95,7 @@ 
      */
     public function getSubheading($action = false)
     {
-        if (! $action) {
+        if (!$action) {
             $action = $this->getActionMethod();
         }
 
@@ -112,7 +112,7 @@ 
      */
     public function setSubheading($string, $action = false)
     {
-        if (! $action) {
+        if (!$action) {
             $action = $this->getActionMethod();
         }
 

src/CrudUsageStats.php

Doc Comments +2 added lines, -2 removed lines

@@ -10,7 +10,7 @@ 
      * Check if the application is running in normal conditions
      * (production env, not in console, not in unit tests).
      *
-     * @return void
+     * @return boolean
      */
     private function runningInProduction()
     {
@@ -86,7 +86,7 @@ 
      * @param  string $method  HTTP Method to use for the request.
      * @param  string $url     URL to point the request at.
      * @param  array $payload  The data you want sent to the URL.
-     * @return void
+     * @return boolean
      */
     private function makeCurlRequest($method, $url, $payload)
     {

Spacing +1 added lines, -1 removed lines

@@ -38,7 +38,7 @@
     private function sendUsageStats()
     {
         // only send usage stats in production
-        if (! $this->runningInProduction()) {
+        if (!$this->runningInProduction()) {
             return;
         }
 

src/PanelTraits/Columns.php

Doc Comments +3 added lines, -3 removed lines

@@ -143,7 +143,7 @@ 
     /**
      * Move the most recently added column after the given target column.
      *
-     * @param string|array $targetColumn The target column name or array.
+     * @param string $targetColumn The target column name or array.
      */
     public function afterColumn($targetColumn)
     {
@@ -162,7 +162,7 @@ 
 
     /**
      * Move this column to be first in the columns list.
-     * @return bool|null
+     * @return false|null
      */
     public function makeFirstColumn()
     {
@@ -281,7 +281,7 @@ 
     /**
      * Change attributes for multiple columns.
      *
-     * @param array $columns
+     * @param string[] $columns
      * @param array $attributes
      */
     public function setColumnsDetails($columns, $attributes)

Spacing +16 added lines, -17 removed lines

@@ -68,7 +68,7 @@ 
     public function addColumn($column)
     {
         // if a string was passed, not an array, change it to an array
-        if (! is_array($column)) {
+        if (!is_array($column)) {
             $column = ['name' => $column];
         }
 
@@ -76,7 +76,7 @@ 
         $column_with_details = $this->addDefaultLabel($column);
 
         // make sure the column has a name
-        if (! array_key_exists('name', $column_with_details)) {
+        if (!array_key_exists('name', $column_with_details)) {
             $column_with_details['name'] = 'anonymous_column_'.str_random(5);
         }
 
@@ -84,27 +84,27 @@ 
         $columnExistsInDb = $this->hasColumn($this->model->getTable(), $column_with_details['name']);
 
         // make sure the column has a type
-        if (! array_key_exists('type', $column_with_details)) {
+        if (!array_key_exists('type', $column_with_details)) {
             $column_with_details['type'] = 'text';
         }
 
         // make sure the column has a key
-        if (! array_key_exists('key', $column_with_details)) {
+        if (!array_key_exists('key', $column_with_details)) {
             $column_with_details['key'] = $column_with_details['name'];
         }
 
         // make sure the column has a tableColumn boolean
-        if (! array_key_exists('tableColumn', $column_with_details)) {
+        if (!array_key_exists('tableColumn', $column_with_details)) {
             $column_with_details['tableColumn'] = $columnExistsInDb ? true : false;
         }
 
         // make sure the column has a orderable boolean
-        if (! array_key_exists('orderable', $column_with_details)) {
+        if (!array_key_exists('orderable', $column_with_details)) {
             $column_with_details['orderable'] = $columnExistsInDb ? true : false;
         }
 
         // make sure the column has a searchLogic
-        if (! array_key_exists('searchLogic', $column_with_details)) {
+        if (!array_key_exists('searchLogic', $column_with_details)) {
             $column_with_details['searchLogic'] = $columnExistsInDb ? true : false;
         }
 
@@ -112,14 +112,14 @@ 
 
         // make sure the column has a priority in terms of visibility
         // if no priority has been defined, use the order in the array plus one
-        if (! array_key_exists('priority', $column_with_details)) {
+        if (!array_key_exists('priority', $column_with_details)) {
             $position_in_columns_array = (int) array_search($column_with_details['key'], array_keys($this->columns));
             $this->columns[$column_with_details['key']]['priority'] = $position_in_columns_array + 1;
         }
 
         // if this is a relation type field and no corresponding model was specified, get it from the relation method
         // defined in the main model
-        if (isset($column_with_details['entity']) && ! isset($column_with_details['model'])) {
+        if (isset($column_with_details['entity']) && !isset($column_with_details['model'])) {
             $column_with_details['model'] = $this->getRelationModel($column_with_details['entity']);
         }
 
@@ -166,7 +166,7 @@ 
      */
     public function makeFirstColumn()
     {
-        if (! $this->columns) {
+        if (!$this->columns) {
             return false;
         }
 
@@ -187,8 +187,7 @@ 
         $targetColumnName = is_array($targetColumn) ? $targetColumn['name'] : $targetColumn;
 
         if (array_key_exists($targetColumnName, $this->columns)) {
-            $targetColumnPosition = $before ? array_search($targetColumnName, array_keys($this->columns)) :
-                array_search($targetColumnName, array_keys($this->columns)) + 1;
+            $targetColumnPosition = $before ? array_search($targetColumnName, array_keys($this->columns)) : array_search($targetColumnName, array_keys($this->columns)) + 1;
 
             $element = array_pop($this->columns);
             $beginningPart = array_slice($this->columns, 0, $targetColumnPosition, true);
@@ -225,7 +224,7 @@ 
      */
     public function addDefaultLabel($array)
     {
-        if (! array_key_exists('label', (array) $array) && array_key_exists('name', (array) $array)) {
+        if (!array_key_exists('label', (array) $array) && array_key_exists('name', (array) $array)) {
             $array = array_merge(['label' => mb_ucfirst($this->makeLabel($array['name']))], $array);
 
             return $array;
@@ -251,7 +250,7 @@ 
      */
     public function removeColumns($columns)
     {
-        if (! empty($columns)) {
+        if (!empty($columns)) {
             foreach ($columns as $columnName) {
                 $this->removeColumn($columnName);
             }
@@ -273,8 +272,8 @@ 
      */
     public function remove($entity, $fields)
     {
-        return array_values(array_filter($this->{$entity}, function ($field) use ($fields) {
-            return ! in_array($field['name'], (array) $fields);
+        return array_values(array_filter($this->{$entity}, function($field) use ($fields) {
+            return !in_array($field['name'], (array) $fields);
         }));
     }
 
@@ -331,7 +330,7 @@ 
     {
         $columns = $this->getColumns();
 
-        return collect($columns)->pluck('entity')->reject(function ($value, $key) {
+        return collect($columns)->pluck('entity')->reject(function($value, $key) {
             return $value == null;
         })->toArray();
     }

tests/Unit/CrudPanel/CrudPanelTabsTest.php

Unused Use Statements +1 added lines, -1 removed lines

@@ -2,8 +2,8 @@
 
 namespace Backpack\CRUD\Tests\Unit\CrudPanel;
 
-use Illuminate\Support\Facades\DB;
 use Backpack\CRUD\Tests\Unit\Models\Article;
+use Illuminate\Support\Facades\DB;
 
 class CrudPanelTabsTest extends BaseDBCrudPanelTest
 {

src/PanelTraits/Tabs.php

Spacing +7 added lines, -7 removed lines

@@ -35,7 +35,7 @@ 
      */
     public function tabsDisabled()
     {
-        return ! $this->tabsEnabled;
+        return !$this->tabsEnabled;
     }
 
     public function setTabsType($type)
@@ -116,8 +116,8 @@ 
     {
         $all_fields = $this->getCurrentFields();
 
-        $fields_without_a_tab = collect($all_fields)->filter(function ($value, $key) {
-            return ! isset($value['tab']);
+        $fields_without_a_tab = collect($all_fields)->filter(function($value, $key) {
+            return !isset($value['tab']);
         });
 
         return $fields_without_a_tab;
@@ -133,7 +133,7 @@ 
         if ($this->tabExists($label)) {
             $all_fields = $this->getCurrentFields();
 
-            $fields_for_current_tab = collect($all_fields)->filter(function ($value, $key) use ($label) {
+            $fields_for_current_tab = collect($all_fields)->filter(function($value, $key) use ($label) {
                 return isset($value['tab']) && $value['tab'] == $label;
             });
 
@@ -152,11 +152,11 @@ 
         $fields = $this->getCurrentFields();
 
         $fields_with_tabs = collect($fields)
-            ->filter(function ($value, $key) {
+            ->filter(function($value, $key) {
                 return isset($value['tab']);
             })
-            ->each(function ($value, $key) use (&$tabs) {
-                if (! in_array($value['tab'], $tabs)) {
+            ->each(function($value, $key) use (&$tabs) {
+                if (!in_array($value['tab'], $tabs)) {
                     $tabs[] = $value['tab'];
                 }
             });

src/CrudPanel.php

Spacing +13 added lines, -13 removed lines

@@ -90,11 +90,11 @@ 
      */
     public function setModel($model_namespace)
     {
-        if (! class_exists($model_namespace)) {
+        if (!class_exists($model_namespace)) {
             throw new \Exception('The model does not exist.', 500);
         }
 
-        if (! method_exists($model_namespace, 'hasCrudTrait')) {
+        if (!method_exists($model_namespace, 'hasCrudTrait')) {
             throw new \Exception('Please use CrudTrait on the model.', 500);
         }
 
@@ -147,7 +147,7 @@ 
     {
         $complete_route = $route.'.index';
 
-        if (! \Route::has($complete_route)) {
+        if (!\Route::has($complete_route)) {
             throw new \Exception('There are no routes for this route name.', 404);
         }
 
@@ -248,7 +248,7 @@ 
      */
     public function getFirstOfItsTypeInArray($type, $array)
     {
-        return array_first($array, function ($item) use ($type) {
+        return array_first($array, function($item) use ($type) {
             return $item['type'] == $type;
         });
     }
@@ -265,8 +265,8 @@ 
 
     public function sync($type, $fields, $attributes)
     {
-        if (! empty($this->{$type})) {
-            $this->{$type} = array_map(function ($field) use ($fields, $attributes) {
+        if (!empty($this->{$type})) {
+            $this->{$type} = array_map(function($field) use ($fields, $attributes) {
                 if (in_array($field['name'], (array) $fields)) {
                     $field = array_merge($field, $attributes);
                 }
@@ -298,8 +298,8 @@ 
                 }
             }
 
-            return $this->{$items} = array_merge($elements, array_filter($this->{$items}, function ($item) use ($items) {
-                return ! in_array($item['name'], $this->sort[$items]);
+            return $this->{$items} = array_merge($elements, array_filter($this->{$items}, function($item) use ($items) {
+                return !in_array($item['name'], $this->sort[$items]);
             }));
         }
 
@@ -328,15 +328,15 @@ 
     {
         $relationArray = explode('.', $relationString);
 
-        if (! isset($length)) {
+        if (!isset($length)) {
             $length = count($relationArray);
         }
 
-        if (! isset($model)) {
+        if (!isset($model)) {
             $model = $this->model;
         }
 
-        $result = array_reduce(array_splice($relationArray, 0, $length), function ($obj, $method) {
+        $result = array_reduce(array_splice($relationArray, 0, $length), function($obj, $method) {
             return $obj->$method()->getRelated();
         }, $model);
 
@@ -386,7 +386,7 @@ 
         $relation = $model->{$firstRelationName};
 
         $results = [];
-        if (! empty($relation)) {
+        if (!empty($relation)) {
             if ($relation instanceof Collection) {
                 $currentResults = $relation->toArray();
             } else {
@@ -395,7 +395,7 @@ 
 
             array_shift($relationArray);
 
-            if (! empty($relationArray)) {
+            if (!empty($relationArray)) {
                 foreach ($currentResults as $currentResult) {
                     $results = array_merge($results, $this->getRelationModelInstances($currentResult, implode('.', $relationArray)));
                 }

Unused Use Statements +15 added lines, -15 removed lines

@@ -2,31 +2,31 @@
 
 namespace Backpack\CRUD;
 
-use Backpack\CRUD\PanelTraits\Read;
-use Backpack\CRUD\PanelTraits\Tabs;
-use Backpack\CRUD\PanelTraits\Query;
-use Backpack\CRUD\PanelTraits\Views;
 use Backpack\CRUD\PanelTraits\Access;
+use Backpack\CRUD\PanelTraits\AutoFocus;
+use Backpack\CRUD\PanelTraits\AutoSet;
+use Backpack\CRUD\PanelTraits\Buttons;
+use Backpack\CRUD\PanelTraits\Columns;
 use Backpack\CRUD\PanelTraits\Create;
 use Backpack\CRUD\PanelTraits\Delete;
 use Backpack\CRUD\PanelTraits\Errors;
+use Backpack\CRUD\PanelTraits\FakeColumns;
+use Backpack\CRUD\PanelTraits\FakeFields;
 use Backpack\CRUD\PanelTraits\Fields;
-use Backpack\CRUD\PanelTraits\Search;
-use Backpack\CRUD\PanelTraits\Update;
-use Backpack\CRUD\PanelTraits\AutoSet;
-use Backpack\CRUD\PanelTraits\Buttons;
-use Backpack\CRUD\PanelTraits\Columns;
 use Backpack\CRUD\PanelTraits\Filters;
-use Backpack\CRUD\PanelTraits\Reorder;
-use Backpack\CRUD\PanelTraits\AutoFocus;
+use Backpack\CRUD\PanelTraits\HeadingsAndTitle;
 use Backpack\CRUD\PanelTraits\Macroable;
-use Backpack\CRUD\PanelTraits\FakeFields;
 use Backpack\CRUD\PanelTraits\Operations;
-use Backpack\CRUD\PanelTraits\FakeColumns;
-use Illuminate\Database\Eloquent\Collection;
+use Backpack\CRUD\PanelTraits\Query;
+use Backpack\CRUD\PanelTraits\Read;
+use Backpack\CRUD\PanelTraits\Reorder;
 use Backpack\CRUD\PanelTraits\RequiredFields;
-use Backpack\CRUD\PanelTraits\HeadingsAndTitle;
+use Backpack\CRUD\PanelTraits\Search;
+use Backpack\CRUD\PanelTraits\Tabs;
+use Backpack\CRUD\PanelTraits\Update;
+use Backpack\CRUD\PanelTraits\Views;
 use Backpack\CRUD\PanelTraits\ViewsAndRestoresRevisions;
+use Illuminate\Database\Eloquent\Collection;
 
 class CrudPanel
 {

src/resources/views/fields/select2_nested.blade.php

Spacing +1 added lines, -1 removed lines

@@ -2,7 +2,7 @@
 <div @include('crud::inc.field_wrapper_attributes') >
     <label>{!! $field['label'] !!}</label>
     @include('crud::inc.field_translatable_icon')
-    <?php $entity_model = $crud->getRelationModel($field['entity'],  - 1); ?>
+    <?php $entity_model = $crud->getRelationModel($field['entity'], - 1); ?>
     <select
         name="{{ $field['name'] }}"
         style="width: 100%"