Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Completed
Pull Request — master (#2466)
by Cristian
08:17
created
src/app/Http/Controllers/Operations/DeleteOperation.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -29,11 +29,11 @@
 block discarded – undo
29 29
     {
30 30
         $this->crud->allowAccess('delete');
31 31
 
32
-        $this->crud->operation('delete', function () {
32
+        $this->crud->operation('delete', function() {
33 33
             $this->crud->loadDefaultOperationSettingsFromConfig();
34 34
         });
35 35
 
36
-        $this->crud->operation(['list', 'show'], function () {
36
+        $this->crud->operation(['list', 'show'], function() {
37 37
             $this->crud->addButton('line', 'delete', 'view', 'crud::buttons.delete', 'end');
38 38
         });
39 39
     }
Please login to merge, or discard this patch.
src/app/Http/Controllers/Operations/ShowOperation.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -30,11 +30,11 @@
 block discarded – undo
30 30
         $this->crud->allowAccess('show');
31 31
         $this->crud->setOperationSetting('setFromDb', true);
32 32
 
33
-        $this->crud->operation('show', function () {
33
+        $this->crud->operation('show', function() {
34 34
             $this->crud->loadDefaultOperationSettingsFromConfig();
35 35
         });
36 36
 
37
-        $this->crud->operation('list', function () {
37
+        $this->crud->operation('list', function() {
38 38
             $this->crud->addButton('line', 'show', 'view', 'crud::buttons.show', 'beginning');
39 39
         });
40 40
     }
Please login to merge, or discard this patch.
src/app/Http/Controllers/Operations/RevisionsOperation.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -36,11 +36,11 @@  discard block
 block discarded – undo
36 36
         // allow access to the operation
37 37
         $this->crud->allowAccess('revisions');
38 38
 
39
-        $this->crud->operation('revisions', function () {
39
+        $this->crud->operation('revisions', function() {
40 40
             $this->crud->loadDefaultOperationSettingsFromConfig();
41 41
         });
42 42
 
43
-        $this->crud->operation(['list', 'show'], function () {
43
+        $this->crud->operation(['list', 'show'], function() {
44 44
             // add a button in the line stack
45 45
             $this->crud->addButton('line', 'revisions', 'view', 'crud::buttons.revisions', 'end');
46 46
         });
@@ -88,7 +88,7 @@  discard block
 block discarded – undo
88 88
         $this->crud->hasAccessOrFail('revisions');
89 89
 
90 90
         $revisionId = \Request::input('revision_id', false);
91
-        if (! $revisionId) {
91
+        if (!$revisionId) {
92 92
             abort(500, 'Can\'t restore revision without revision_id');
93 93
         } else {
94 94
             $this->crud->restoreRevision($id, $revisionId); // do the update
Please login to merge, or discard this patch.
src/app/Http/Controllers/Operations/CreateOperation.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -41,11 +41,11 @@
 block discarded – undo
41 41
     {
42 42
         $this->crud->allowAccess('create');
43 43
 
44
-        $this->crud->operation('create', function () {
44
+        $this->crud->operation('create', function() {
45 45
             $this->crud->loadDefaultOperationSettingsFromConfig();
46 46
         });
47 47
 
48
-        $this->crud->operation('list', function () {
48
+        $this->crud->operation('list', function() {
49 49
             $this->crud->addButton('top', 'create', 'view', 'crud::buttons.create');
50 50
         });
51 51
     }
Please login to merge, or discard this patch.
src/app/Http/Controllers/Operations/BulkDeleteOperation.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -29,11 +29,11 @@
 block discarded – undo
29 29
     {
30 30
         $this->crud->allowAccess('bulkDelete');
31 31
 
32
-        $this->crud->operation('bulkDelete', function () {
32
+        $this->crud->operation('bulkDelete', function() {
33 33
             $this->crud->loadDefaultOperationSettingsFromConfig();
34 34
         });
35 35
 
36
-        $this->crud->operation('list', function () {
36
+        $this->crud->operation('list', function() {
37 37
             $this->crud->enableBulkActions();
38 38
             $this->crud->addButton('bottom', 'bulk_delete', 'view', 'crud::buttons.bulk_delete');
39 39
         });
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Operations.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -56,7 +56,7 @@  discard block
 block discarded – undo
56 56
     /**
57 57
      * Convenience method to make sure all calls are made to a particular operation.
58 58
      *
59
-     * @param string|array  $operation Operation name in string form
59
+     * @param string|array  $operations Operation name in string form
60 60
      * @param bool|\Closure $closure   Code that calls CrudPanel methods.
61 61
      *
62 62
      * @return void
@@ -71,7 +71,7 @@  discard block
 block discarded – undo
71 71
      * Allc configurations are put inside that operation's namespace.
72 72
      * Ex: show.configuration.
73 73
      *
74
-     * @param string|array  $operation Operation name in string form
74
+     * @param string|array  $operations Operation name in string form
75 75
      * @param bool|\Closure $closure   Code that calls CrudPanel methods.
76 76
      *
77 77
      * @return void
@@ -93,7 +93,7 @@  discard block
 block discarded – undo
93 93
      * This is called when an operation does setCurrentOperation().
94 94
      *
95 95
      *
96
-     * @param string|array $operations [description]
96
+     * @param string $operations [description]
97 97
      *
98 98
      * @return void
99 99
      */
Please login to merge, or discard this patch.
src/resources/views/crud/fields/table.blade.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -3,7 +3,7 @@  discard block
 block discarded – undo
3 3
 <?php
4 4
     $max = isset($field['max']) && (int) $field['max'] > 0 ? $field['max'] : -1;
5 5
     $min = isset($field['min']) && (int) $field['min'] > 0 ? $field['min'] : -1;
6
-    $item_name = strtolower(isset($field['entity_singular']) && ! empty($field['entity_singular']) ? $field['entity_singular'] : $field['label']);
6
+    $item_name = strtolower(isset($field['entity_singular']) && !empty($field['entity_singular']) ? $field['entity_singular'] : $field['label']);
7 7
 
8 8
     $items = old(square_brackets_to_dots($field['name'])) ?? $field['value'] ?? $field['default'] ?? '';
9 9
 
@@ -15,12 +15,12 @@  discard block
 block discarded – undo
15 15
         } else {
16 16
             $items = '[]';
17 17
         }
18
-    } elseif (is_string($items) && ! is_array(json_decode($items))) {
18
+    } elseif (is_string($items) && !is_array(json_decode($items))) {
19 19
         $items = '[]';
20 20
     }
21 21
 
22 22
     // make sure columns are defined
23
-    if (! isset($field['columns'])) {
23
+    if (!isset($field['columns'])) {
24 24
         $field['columns'] = ['value' => 'Value'];
25 25
     }
26 26
 ?>
Please login to merge, or discard this patch.
src/app/Http/Controllers/CrudController.php 2 patches
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -4,7 +4,6 @@
 block discarded – undo
4 4
 
5 5
 use Illuminate\Foundation\Bus\DispatchesJobs;
6 6
 use Illuminate\Foundation\Validation\ValidatesRequests;
7
-use Illuminate\Http\Request;
8 7
 use Illuminate\Routing\Controller;
9 8
 
10 9
 class CrudController extends Controller
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -27,7 +27,7 @@
 block discarded – undo
27 27
 
28 28
         // call the setup function inside this closure to also have the request there
29 29
         // this way, developers can use things stored in session (auth variables, etc)
30
-        $this->middleware(function ($request, $next) {
30
+        $this->middleware(function($request, $next) {
31 31
             // make a new CrudPanel object, from the one stored in Laravel's service container
32 32
             $this->crud = app()->make('crud');
33 33
             // ensure crud has the latest request
Please login to merge, or discard this patch.
src/app/Http/Controllers/Operations/ListOperation.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -41,7 +41,7 @@  discard block
 block discarded – undo
41 41
     {
42 42
         $this->crud->allowAccess('list');
43 43
 
44
-        $this->crud->operation('list', function () {
44
+        $this->crud->operation('list', function() {
45 45
             $this->crud->loadDefaultOperationSettingsFromConfig();
46 46
         });
47 47
     }
@@ -112,8 +112,8 @@  discard block
 block discarded – undo
112 112
         // if there was an order set, this will be the last one (after all others were applied)
113 113
         $orderBy = $this->crud->query->getQuery()->orders;
114 114
         $hasOrderByPrimaryKey = false;
115
-        collect($orderBy)->each(function ($item, $key) use ($hasOrderByPrimaryKey) {
116
-            if (! isset($item['column'])) {
115
+        collect($orderBy)->each(function($item, $key) use ($hasOrderByPrimaryKey) {
116
+            if (!isset($item['column'])) {
117 117
                 return false;
118 118
             }
119 119
 
@@ -123,7 +123,7 @@  discard block
 block discarded – undo
123 123
                 return false;
124 124
             }
125 125
         });
126
-        if (! $hasOrderByPrimaryKey) {
126
+        if (!$hasOrderByPrimaryKey) {
127 127
             $this->crud->query->orderByDesc($this->crud->model->getKeyName());
128 128
         }
129 129
 
Please login to merge, or discard this patch.