CrudPanelCreateTest - Code Metrics - Inspection of "added tests to scrutinizer path" - Laravel-Backpack/CRUD - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 861d7d...2ad8d1 )

by Cristian

created 2017-09-27 13:07 UTC

CrudPanelCreateTest A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	301
Duplicated Lines	28.24 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	85
loc	301
rs	10
wmc	16
lcom	1
cbo	4

16 Methods

Rating	Name	Duplication	Size	Complexity
A	testCreate()	0	17	1
A	testCreateWithOneToOneRelationship()	0	4	1
A	testCreateWithOneToManyRelationship()	0	19	1
A	testCreateWithManyToManyRelationship()	0	18	1
A	testGetRelationFields()	13	13	1
A	testGetRelationFieldsCreateForm()	9	9	1
A	testGetRelationFieldsUpdateForm()	9	9	1
A	testGetRelationFieldsUnknownForm()	0	13	1
A	testGetRelationFieldsDotNotation()	9	9	1
A	testGetRelationFieldsNoRelations()	0	8	1
A	testGetRelationFieldsNoFields()	0	6	1
A	testGetRelationFieldsWithPivot()	9	9	1
A	testGetRelationFieldsWithPivotNoRelations()	0	9	1
A	testSyncPivot()	18	18	1
A	testSyncPivotUnknownData()	18	18	1
A	testSyncPivotUnknownModel()	0	18	1

How to fix Duplicated Code

<?php

namespace Backpack\CRUD\Tests\Unit\CrudPanel;

use Faker\Factory;
use Backpack\CRUD\Tests\Unit\Models\User;
use Backpack\CRUD\Tests\Unit\Models\Article;

class CrudPanelCreateTest extends BaseDBCrudPanelTest
{
    private $nonRelationshipField = [
        'name' => 'field1',
        'label' => 'Field1',
    ];

    private $userInputFieldsNoRelationships = [
        [
            'name' => 'id',
            'type' => 'hidden',
        ], [
            'name' => 'name',
        ], [
            'name' => 'email',
            'type' => 'email',
        ], [
            'name' => 'password',
            'type' => 'password',
        ],
    ];

    private $articleInputFieldsOneToMany = [
        [
            'name' => 'id',
            'type' => 'hidden',
        ], [
            'name' => 'content',
        ], [
            'name' => 'tags',
        ], [
            'label' => 'Author',
            'type' => 'select',
            'name' => 'user_id',
            'entity' => 'user',
            'attribute' => 'name',
        ],
    ];

    private $userInputFieldsManyToMany = [
        [
            'name' => 'id',
            'type' => 'hidden',
        ], [
            'name' => 'name',
        ], [
            'name' => 'email',
            'type' => 'email',
        ], [
            'name' => 'password',
            'type' => 'password',
        ], [
            'label' => 'Roles',
            'type' => 'select_multiple',
            'name' => 'roles',
            'entity' => 'roles',
            'attribute' => 'name',
            'pivot' => true,
        ],
    ];

    private $userInputFieldsDotNotation = [
        [
            'name' => 'id',
            'type' => 'hidden',
        ], [
            'name' => 'name',
        ], [
            'name' => 'email',
            'type' => 'email',
        ], [
            'name' => 'password',
            'type' => 'password',
        ], [
            'label' => 'Roles',
            'type' => 'select_multiple',
            'name' => 'roles',
            'entity' => 'roles',
            'attribute' => 'name',
            'pivot' => true,
        ], [
            'label' => 'Street',
            'name' => 'street',
            'entity' => 'accountDetails.addresses',
            'attribute' => 'street',
        ],
    ];

    public function testCreate()
    {
        $this->crudPanel->setModel(User::class);
        $this->crudPanel->addFields($this->userInputFieldsNoRelationships);
        $faker = Factory::create();
        $inputData = [
            'name' => $faker->name,
            'email' => $faker->safeEmail,
            'password' => bcrypt($faker->password()),
        ];

        $entry = $this->crudPanel->create($inputData);

        $this->assertInstanceOf(User::class, $entry);
        $this->assertEntryEquals($inputData, $entry);
        $this->assertEmpty($entry->articles);
    }

    public function testCreateWithOneToOneRelationship()
    {
        $this->markTestIncomplete('Not yet implemented');
    }

    public function testCreateWithOneToManyRelationship()
    {
        $this->crudPanel->setModel(Article::class);
        $this->crudPanel->addFields($this->articleInputFieldsOneToMany);
        $faker = Factory::create();
        $inputData = [
            'content' => $faker->text(),
            'tags' => $faker->words(3, true),
            'user_id' => 1,
            'metas' => null,
            'extras' => null,
        ];

        $entry = $this->crudPanel->create($inputData);
        $userEntry = User::find(1);

        $this->assertEntryEquals($inputData, $entry);
        $this->assertEquals($userEntry->articles->last()->toArray(), $entry->toArray());
    }

    public function testCreateWithManyToManyRelationship()
    {
        $this->crudPanel->setModel(User::class);
        $this->crudPanel->addFields($this->userInputFieldsManyToMany);
        $faker = Factory::create();
        $inputData = [
            'name' => $faker->name,
            'email' => $faker->safeEmail,
            'password' => bcrypt($faker->password()),
            'remember_token' => null,
            'roles' => [1, 2],
        ];

        $entry = $this->crudPanel->create($inputData);

        $this->assertInstanceOf(User::class, $entry);
        $this->assertEntryEquals($inputData, $entry);
    }

    public function testGetRelationFields()

    {
        $this->markTestIncomplete('Not correctly implemented');

        $this->crudPanel->setModel(User::class);
        $this->crudPanel->addFields($this->userInputFieldsManyToMany, 'create');

        // TODO: fix method and documentation. when 'both' is passed as the $form value, the getRelationFields searches
        //       for relationship fields in the update fields.
        $relationFields = $this->crudPanel->getRelationFields('both');

        $this->assertEquals($this->crudPanel->create_fields['roles'], array_last($relationFields));
    }

    public function testGetRelationFieldsCreateForm()

    {
        $this->crudPanel->setModel(User::class);
        $this->crudPanel->addFields($this->userInputFieldsManyToMany, 'create');

        $relationFields = $this->crudPanel->getRelationFields('create');

        $this->assertEquals($this->crudPanel->create_fields['roles'], array_last($relationFields));
    }

    public function testGetRelationFieldsUpdateForm()

    {
        $this->crudPanel->setModel(User::class);
        $this->crudPanel->addFields($this->userInputFieldsManyToMany, 'update');

        $relationFields = $this->crudPanel->getRelationFields('update');

        $this->assertEquals($this->crudPanel->update_fields['roles'], array_last($relationFields));
    }

    public function testGetRelationFieldsUnknownForm()
    {
        $this->markTestIncomplete('Not correctly implemented');

        $this->setExpectedException(\InvalidArgumentException::class);

        $this->crudPanel->setModel(User::class);
        $this->crudPanel->addFields($this->userInputFieldsManyToMany);

        // TODO: this should throw an invalid argument exception but instead it searches for relationship fields in the
        //       update fields.
        $this->crudPanel->getRelationFields('unknownForm');
    }

    public function testGetRelationFieldsDotNotation()

    {
        $this->crudPanel->setModel(User::class);
        $this->crudPanel->addFields($this->userInputFieldsDotNotation, 'create');

        $relationFields = $this->crudPanel->getRelationFields('create');

        $this->assertEquals($this->crudPanel->create_fields['street'], array_last($relationFields));
    }

    public function testGetRelationFieldsNoRelations()
    {
        $this->crudPanel->addField($this->nonRelationshipField);

        $relationFields = $this->crudPanel->getRelationFields();

        $this->assertEmpty($relationFields);
    }

    public function testGetRelationFieldsNoFields()
    {
        $relationFields = $this->crudPanel->getRelationFields();

        $this->assertEmpty($relationFields);
    }

    public function testGetRelationFieldsWithPivot()

    {
        $this->crudPanel->setModel(User::class);
        $this->crudPanel->addFields($this->userInputFieldsDotNotation, 'create');

        $relationFields = $this->crudPanel->getRelationFieldsWithPivot('create');

        $this->assertEquals($this->crudPanel->create_fields['roles'], array_last($relationFields));
    }

    public function testGetRelationFieldsWithPivotNoRelations()
    {
        $this->crudPanel->setModel(User::class);
        $this->crudPanel->addFields($this->nonRelationshipField, 'create');

        $relationFields = $this->crudPanel->getRelationFieldsWithPivot('create');

        $this->assertEmpty($relationFields);
    }

    public function testSyncPivot()

    {
        $this->crudPanel->setModel(User::class);
        $this->crudPanel->addFields($this->userInputFieldsManyToMany);
        $faker = Factory::create();
        $inputData = [
            'name' => $faker->name,
            'email' => $faker->safeEmail,
            'password' => bcrypt($faker->password()),
            'remember_token' => null,
            'roles' => [1, 2],
        ];

        $entry = User::find(1);
        $this->crudPanel->syncPivot($entry, $inputData);

        $this->assertEquals($inputData['roles'], $entry->roles->pluck('id')->toArray());
    }

    public function testSyncPivotUnknownData()

    {
        $this->crudPanel->setModel(User::class);
        $this->crudPanel->addFields($this->nonRelationshipField);
        $faker = Factory::create();
        $inputData = [
            'name' => $faker->name,
            'email' => $faker->safeEmail,
            'password' => bcrypt($faker->password()),
            'remember_token' => null,
            'roles' => [1, 2],
        ];

        $entry = User::find(1);
        $this->crudPanel->syncPivot($entry, $inputData);

        $this->assertEquals(1, $entry->roles->count());
    }

    public function testSyncPivotUnknownModel()
    {
        $this->setExpectedException(\BadMethodCallException::class);

        $this->crudPanel->setModel(User::class);
        $this->crudPanel->addFields($this->userInputFieldsManyToMany);
        $faker = Factory::create();
        $inputData = [
            'name' => $faker->name,
            'email' => $faker->safeEmail,
            'password' => bcrypt($faker->password()),
            'remember_token' => null,
            'roles' => [1, 2],
        ];

        $entry = Article::find(1);
        $this->crudPanel->syncPivot($entry, $inputData);
    }
}


1		<?php
2
3		namespace Backpack\CRUD\Tests\Unit\CrudPanel;
4
5		use Faker\Factory;
6		use Backpack\CRUD\Tests\Unit\Models\User;
7		use Backpack\CRUD\Tests\Unit\Models\Article;
8
9		class CrudPanelCreateTest extends BaseDBCrudPanelTest
10		{
11		private $nonRelationshipField = [
12		'name' => 'field1',
13		'label' => 'Field1',
14		];
15
16		private $userInputFieldsNoRelationships = [
17		[
18		'name' => 'id',
19		'type' => 'hidden',
20		], [
21		'name' => 'name',
22		], [
23		'name' => 'email',
24		'type' => 'email',
25		], [
26		'name' => 'password',
27		'type' => 'password',
28		],
29		];
30
31		private $articleInputFieldsOneToMany = [
32		[
33		'name' => 'id',
34		'type' => 'hidden',
35		], [
36		'name' => 'content',
37		], [
38		'name' => 'tags',
39		], [
40		'label' => 'Author',
41		'type' => 'select',
42		'name' => 'user_id',
43		'entity' => 'user',
44		'attribute' => 'name',
45		],
46		];
47
48		private $userInputFieldsManyToMany = [
49		[
50		'name' => 'id',
51		'type' => 'hidden',
52		], [
53		'name' => 'name',
54		], [
55		'name' => 'email',
56		'type' => 'email',
57		], [
58		'name' => 'password',
59		'type' => 'password',
60		], [
61		'label' => 'Roles',
62		'type' => 'select_multiple',
63		'name' => 'roles',
64		'entity' => 'roles',
65		'attribute' => 'name',
66		'pivot' => true,
67		],
68		];
69
70		private $userInputFieldsDotNotation = [
71		[
72		'name' => 'id',
73		'type' => 'hidden',
74		], [
75		'name' => 'name',
76		], [
77		'name' => 'email',
78		'type' => 'email',
79		], [
80		'name' => 'password',
81		'type' => 'password',
82		], [
83		'label' => 'Roles',
84		'type' => 'select_multiple',
85		'name' => 'roles',
86		'entity' => 'roles',
87		'attribute' => 'name',
88		'pivot' => true,
89		], [
90		'label' => 'Street',
91		'name' => 'street',
92		'entity' => 'accountDetails.addresses',
93		'attribute' => 'street',
94		],
95		];
96
97		public function testCreate()
98		{
99		$this->crudPanel->setModel(User::class);
100		$this->crudPanel->addFields($this->userInputFieldsNoRelationships);
101		$faker = Factory::create();
102		$inputData = [
103		'name' => $faker->name,
104		'email' => $faker->safeEmail,
105		'password' => bcrypt($faker->password()),
106		];
107
108		$entry = $this->crudPanel->create($inputData);
109
110		$this->assertInstanceOf(User::class, $entry);
111		$this->assertEntryEquals($inputData, $entry);
112		$this->assertEmpty($entry->articles);
113		}
114
115		public function testCreateWithOneToOneRelationship()
116		{
117		$this->markTestIncomplete('Not yet implemented');
118		}
119
120		public function testCreateWithOneToManyRelationship()
121		{
122		$this->crudPanel->setModel(Article::class);
123		$this->crudPanel->addFields($this->articleInputFieldsOneToMany);
124		$faker = Factory::create();
125		$inputData = [
126		'content' => $faker->text(),
127		'tags' => $faker->words(3, true),
128		'user_id' => 1,
129		'metas' => null,
130		'extras' => null,
131		];
132
133		$entry = $this->crudPanel->create($inputData);
134		$userEntry = User::find(1);
135
136		$this->assertEntryEquals($inputData, $entry);
137		$this->assertEquals($userEntry->articles->last()->toArray(), $entry->toArray());
138		}
139
140		public function testCreateWithManyToManyRelationship()
141		{
142		$this->crudPanel->setModel(User::class);
143		$this->crudPanel->addFields($this->userInputFieldsManyToMany);
144		$faker = Factory::create();
145		$inputData = [
146		'name' => $faker->name,
147		'email' => $faker->safeEmail,
148		'password' => bcrypt($faker->password()),
149		'remember_token' => null,
150		'roles' => [1, 2],
151		];
152
153		$entry = $this->crudPanel->create($inputData);
154
155		$this->assertInstanceOf(User::class, $entry);
156		$this->assertEntryEquals($inputData, $entry);
157		}
158
159	View Code Duplication	public function testGetRelationFields()
		0 ignored issues – show Duplication introduced 2017-09-27 13:12 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
160		{
161		$this->markTestIncomplete('Not correctly implemented');
162
163		$this->crudPanel->setModel(User::class);
164		$this->crudPanel->addFields($this->userInputFieldsManyToMany, 'create');
165
166		// TODO: fix method and documentation. when 'both' is passed as the $form value, the getRelationFields searches
167		// for relationship fields in the update fields.
168		$relationFields = $this->crudPanel->getRelationFields('both');
169
170		$this->assertEquals($this->crudPanel->create_fields['roles'], array_last($relationFields));
171		}
172
173	View Code Duplication	public function testGetRelationFieldsCreateForm()
		0 ignored issues – show Duplication introduced 2017-09-27 13:12 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
174		{
175		$this->crudPanel->setModel(User::class);
176		$this->crudPanel->addFields($this->userInputFieldsManyToMany, 'create');
177
178		$relationFields = $this->crudPanel->getRelationFields('create');
179
180		$this->assertEquals($this->crudPanel->create_fields['roles'], array_last($relationFields));
181		}
182
183	View Code Duplication	public function testGetRelationFieldsUpdateForm()
		0 ignored issues – show Duplication introduced 2017-09-27 13:12 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
184		{
185		$this->crudPanel->setModel(User::class);
186		$this->crudPanel->addFields($this->userInputFieldsManyToMany, 'update');
187
188		$relationFields = $this->crudPanel->getRelationFields('update');
189
190		$this->assertEquals($this->crudPanel->update_fields['roles'], array_last($relationFields));
191		}
192
193		public function testGetRelationFieldsUnknownForm()
194		{
195		$this->markTestIncomplete('Not correctly implemented');
196
197		$this->setExpectedException(\InvalidArgumentException::class);
198
199		$this->crudPanel->setModel(User::class);
200		$this->crudPanel->addFields($this->userInputFieldsManyToMany);
201
202		// TODO: this should throw an invalid argument exception but instead it searches for relationship fields in the
203		// update fields.
204		$this->crudPanel->getRelationFields('unknownForm');
205		}
206
207	View Code Duplication	public function testGetRelationFieldsDotNotation()
		0 ignored issues – show Duplication introduced 2017-09-27 13:12 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
208		{
209		$this->crudPanel->setModel(User::class);
210		$this->crudPanel->addFields($this->userInputFieldsDotNotation, 'create');
211
212		$relationFields = $this->crudPanel->getRelationFields('create');
213
214		$this->assertEquals($this->crudPanel->create_fields['street'], array_last($relationFields));
215		}
216
217		public function testGetRelationFieldsNoRelations()
218		{
219		$this->crudPanel->addField($this->nonRelationshipField);
220
221		$relationFields = $this->crudPanel->getRelationFields();
222
223		$this->assertEmpty($relationFields);
224		}
225
226		public function testGetRelationFieldsNoFields()
227		{
228		$relationFields = $this->crudPanel->getRelationFields();
229
230		$this->assertEmpty($relationFields);
231		}
232
233	View Code Duplication	public function testGetRelationFieldsWithPivot()
		0 ignored issues – show Duplication introduced 2017-09-27 13:12 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
234		{
235		$this->crudPanel->setModel(User::class);
236		$this->crudPanel->addFields($this->userInputFieldsDotNotation, 'create');
237
238		$relationFields = $this->crudPanel->getRelationFieldsWithPivot('create');
239
240		$this->assertEquals($this->crudPanel->create_fields['roles'], array_last($relationFields));
241		}
242
243		public function testGetRelationFieldsWithPivotNoRelations()
244		{
245		$this->crudPanel->setModel(User::class);
246		$this->crudPanel->addFields($this->nonRelationshipField, 'create');
247
248		$relationFields = $this->crudPanel->getRelationFieldsWithPivot('create');
249
250		$this->assertEmpty($relationFields);
251		}
252
253	View Code Duplication	public function testSyncPivot()
		0 ignored issues – show Duplication introduced 2017-09-27 13:12 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
254		{
255		$this->crudPanel->setModel(User::class);
256		$this->crudPanel->addFields($this->userInputFieldsManyToMany);
257		$faker = Factory::create();
258		$inputData = [
259		'name' => $faker->name,
260		'email' => $faker->safeEmail,
261		'password' => bcrypt($faker->password()),
262		'remember_token' => null,
263		'roles' => [1, 2],
264		];
265
266		$entry = User::find(1);
267		$this->crudPanel->syncPivot($entry, $inputData);
268
269		$this->assertEquals($inputData['roles'], $entry->roles->pluck('id')->toArray());
270		}
271
272	View Code Duplication	public function testSyncPivotUnknownData()
		0 ignored issues – show Duplication introduced 2017-09-27 13:12 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
273		{
274		$this->crudPanel->setModel(User::class);
275		$this->crudPanel->addFields($this->nonRelationshipField);
276		$faker = Factory::create();
277		$inputData = [
278		'name' => $faker->name,
279		'email' => $faker->safeEmail,
280		'password' => bcrypt($faker->password()),
281		'remember_token' => null,
282		'roles' => [1, 2],
283		];
284
285		$entry = User::find(1);
286		$this->crudPanel->syncPivot($entry, $inputData);
287
288		$this->assertEquals(1, $entry->roles->count());
289		}
290
291		public function testSyncPivotUnknownModel()
292		{
293		$this->setExpectedException(\BadMethodCallException::class);
294
295		$this->crudPanel->setModel(User::class);
296		$this->crudPanel->addFields($this->userInputFieldsManyToMany);
297		$faker = Factory::create();
298		$inputData = [
299		'name' => $faker->name,
300		'email' => $faker->safeEmail,
301		'password' => bcrypt($faker->password()),
302		'remember_token' => null,
303		'roles' => [1, 2],
304		];
305
306		$entry = Article::find(1);
307		$this->crudPanel->syncPivot($entry, $inputData);
308		}
309		}
310

Laravel-Backpack / CRUD

Scrutinizer GitHub App not installed

Push — master ( 861d7d...2ad8d1 )

CrudPanelCreateTest A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

16 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like