Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Passed
Push — add-tests ( 194aa8 )
by Pedro
15:05
created
src/app/Library/CrudPanel/Traits/AutoSet.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -14,8 +14,8 @@  discard block
 block discarded – undo
14 14
     {
15 15
         $this->getDbColumnTypes();
16 16
 
17
-        array_map(function ($field) use ($setFields, $setColumns) {
18
-            if ($setFields && ! isset($this->getCleanStateFields()[$field])) {
17
+        array_map(function($field) use ($setFields, $setColumns) {
18
+            if ($setFields && !isset($this->getCleanStateFields()[$field])) {
19 19
                 $this->addField([
20 20
                     'name' => $field,
21 21
                     'label' => $this->makeLabel($field),
@@ -28,7 +28,7 @@  discard block
 block discarded – undo
28 28
                 ]);
29 29
             }
30 30
 
31
-            if ($setColumns && ! in_array($field, $this->model->getHidden()) && ! isset($this->columns()[$field])) {
31
+            if ($setColumns && !in_array($field, $this->model->getHidden()) && !isset($this->columns()[$field])) {
32 32
                 $this->addColumn([
33 33
                     'name' => $field,
34 34
                     'label' => $this->makeLabel($field),
@@ -50,7 +50,7 @@  discard block
 block discarded – undo
50 50
     {
51 51
         $dbColumnTypes = [];
52 52
 
53
-        if (! $this->driverIsSql()) {
53
+        if (!$this->driverIsSql()) {
54 54
             return $dbColumnTypes;
55 55
         }
56 56
         $dbColumns = $this->getDbTableColumns();
@@ -115,7 +115,7 @@  discard block
 block discarded – undo
115 115
 
116 116
         $dbColumnTypes = $this->getDbColumnTypes();
117 117
 
118
-        if (! isset($dbColumnTypes[$fieldName])) {
118
+        if (!isset($dbColumnTypes[$fieldName])) {
119 119
             return 'text';
120 120
         }
121 121
 
@@ -210,12 +210,12 @@  discard block
 block discarded – undo
210 210
     {
211 211
         $fillable = $this->model->getFillable();
212 212
 
213
-        if (! $this->driverIsSql()) {
213
+        if (!$this->driverIsSql()) {
214 214
             $columns = $fillable;
215 215
         } else {
216 216
             // Automatically-set columns should be both in the database, and in the $fillable variable on the Eloquent Model
217 217
             $columns = $this->model::getDbTableSchema()->getColumnsNames();
218
-            if (! empty($fillable)) {
218
+            if (!empty($fillable)) {
219 219
                 $columns = array_intersect($columns, $fillable);
220 220
             }
221 221
         }
Please login to merge, or discard this patch.
tests/Unit/CrudPanel/CrudPanelAutoSetTest.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -848,7 +848,7 @@
 block discarded – undo
848 848
 
849 849
     public function testSetDoctrineTypesMapping()
850 850
     {
851
-        if (! method_exists($this->crudPanel->getModel()->getConnection(), 'getDoctrineConnection')) {
851
+        if (!method_exists($this->crudPanel->getModel()->getConnection(), 'getDoctrineConnection')) {
852 852
             $this->markTestSkipped('This test is only for Laravel 10, Laravel 11 does not have dbal as a dependency anymore');
853 853
         }
854 854
 
Please login to merge, or discard this patch.
src/app/Models/Traits/HasRelationshipFields.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -22,7 +22,7 @@  discard block
 block discarded – undo
22 22
     {
23 23
         $connection = DB::connection($this->getConnectionName());
24 24
 
25
-        if (! method_exists($connection, 'getDoctrineSchemaManager')) {
25
+        if (!method_exists($connection, 'getDoctrineSchemaManager')) {
26 26
             return $connection;
27 27
         }
28 28
 
@@ -35,7 +35,7 @@  discard block
 block discarded – undo
35 35
         if (self::isSqlConnection()) {
36 36
             $platform = $connection->getDoctrineSchemaManager()->getDatabasePlatform();
37 37
             foreach ($types as $type_key => $type_value) {
38
-                if (! $platform->hasDoctrineTypeMappingFor($type_key)) {
38
+                if (!$platform->hasDoctrineTypeMappingFor($type_key)) {
39 39
                     $platform->registerDoctrineTypeMapping($type_key, $type_value);
40 40
                 }
41 41
             }
@@ -65,7 +65,7 @@  discard block
 block discarded – undo
65 65
      */
66 66
     public function getColumnType($columnName)
67 67
     {
68
-        if (! self::isSqlConnection()) {
68
+        if (!self::isSqlConnection()) {
69 69
             return 'text';
70 70
         }
71 71
 
@@ -80,7 +80,7 @@  discard block
 block discarded – undo
80 80
      */
81 81
     public static function isColumnNullable($columnName)
82 82
     {
83
-        if (! self::isSqlConnection()) {
83
+        if (!self::isSqlConnection()) {
84 84
             return true;
85 85
         }
86 86
 
@@ -95,7 +95,7 @@  discard block
 block discarded – undo
95 95
      */
96 96
     public static function dbColumnHasDefault($columnName)
97 97
     {
98
-        if (! self::isSqlConnection()) {
98
+        if (!self::isSqlConnection()) {
99 99
             return false;
100 100
         }
101 101
 
@@ -110,7 +110,7 @@  discard block
 block discarded – undo
110 110
      */
111 111
     public static function getDbColumnDefault($columnName)
112 112
     {
113
-        if (! self::isSqlConnection()) {
113
+        if (!self::isSqlConnection()) {
114 114
             return false;
115 115
         }
116 116
 
Please login to merge, or discard this patch.
src/app/Library/Widget.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -37,7 +37,7 @@  discard block
 block discarded – undo
37 37
         // if that widget name already exists in the widgets collection
38 38
         // then pick up all widget attributes from that entry
39 39
         // and overwrite them with the ones passed in $attributes
40
-        if ($existingItem = self::collection()->filter(function ($item) use ($attributes) {
40
+        if ($existingItem = self::collection()->filter(function($item) use ($attributes) {
41 41
             return $item->attributes['name'] === $attributes['name'];
42 42
         })->first()) {
43 43
             $attributes = array_merge($existingItem->attributes, $attributes);
@@ -159,7 +159,7 @@  discard block
 block discarded – undo
159 159
             }
160 160
         }
161 161
         $type = $this->attributes['type'];
162
-        $paths = array_map(function ($item) use ($type) {
162
+        $paths = array_map(function($item) use ($type) {
163 163
             return $item.'.'.$type;
164 164
         }, ViewNamespaces::getWithFallbackFor('widgets', 'backpack.ui.component_view_namespaces.widgets'));
165 165
 
@@ -169,7 +169,7 @@  discard block
 block discarded – undo
169 169
             }
170 170
         }
171 171
         // if no view exists, in any of the directories above... no bueno
172
-        if (! backpack_pro()) {
172
+        if (!backpack_pro()) {
173 173
             throw new BackpackProRequiredException('Cannot find the widget view: '.$this->attributes['type'].'. Please check for typos.'.(backpack_pro() ? '' : ' If you are trying to use a PRO widget, please first purchase and install the backpack/pro addon from backpackforlaravel.com'), 1);
174 174
         }
175 175
         abort(500, 'Cannot find the view for «'.$this->attributes['type'].'» widget type. Please check for typos.');
@@ -253,10 +253,10 @@  discard block
 block discarded – undo
253 253
      */
254 254
     private function save()
255 255
     {
256
-        $itemExists = $this->collection()->filter(function ($item) {
256
+        $itemExists = $this->collection()->filter(function($item) {
257 257
             return $item->attributes['name'] === $this->attributes['name'];
258 258
         })->isNotEmpty();
259
-        if (! $itemExists) {
259
+        if (!$itemExists) {
260 260
             $this->collection()->put($this->attributes['name'], $this);
261 261
         } else {
262 262
             $this->collection()[$this->attributes['name']] = $this;
Please login to merge, or discard this patch.
src/app/Library/Uploaders/Uploader.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -25,7 +25,7 @@  discard block
 block discarded – undo
25 25
 
26 26
     private bool $deleteWhenEntryIsDeleted = true;
27 27
 
28
-    private bool|string $attachedToFakeField = false;
28
+    private bool | string $attachedToFakeField = false;
29 29
 
30 30
     /**
31 31
      * Cloud disks have the ability to generate temporary URLs to files, should we do it?
@@ -62,7 +62,7 @@  discard block
 block discarded – undo
62 62
     /*******************************
63 63
      * Static methods
64 64
      *******************************/
65
-    public static function for(array $crudObject, array $definition): UploaderInterface
65
+    public static function for (array $crudObject, array $definition): UploaderInterface
66 66
     {
67 67
         return new static($crudObject, $definition);
68 68
     }
@@ -103,7 +103,7 @@  discard block
 block discarded – undo
103 103
     public function deleteUploadedFiles(Model $entry): void
104 104
     {
105 105
         if ($this->deleteWhenEntryIsDeleted) {
106
-            if (! in_array(SoftDeletes::class, class_uses_recursive($entry), true)) {
106
+            if (!in_array(SoftDeletes::class, class_uses_recursive($entry), true)) {
107 107
                 $this->performFileDeletion($entry);
108 108
 
109 109
                 return;
@@ -179,7 +179,7 @@  discard block
 block discarded – undo
179 179
 
180 180
     public function getPreviousFiles(Model $entry): mixed
181 181
     {
182
-        if (! $this->attachedToFakeField) {
182
+        if (!$this->attachedToFakeField) {
183 183
             return $this->getOriginalValue($entry);
184 184
         }
185 185
 
@@ -218,7 +218,7 @@  discard block
 block discarded – undo
218 218
         $value = $entry->{$this->getAttributeName()};
219 219
 
220 220
         if ($this->handleMultipleFiles) {
221
-            if (! isset($entry->getCasts()[$this->getName()]) && is_string($value)) {
221
+            if (!isset($entry->getCasts()[$this->getName()]) && is_string($value)) {
222 222
                 $entry->{$this->getAttributeName()} = json_decode($value, true);
223 223
             }
224 224
 
@@ -250,7 +250,7 @@  discard block
 block discarded – undo
250 250
 
251 251
         if ($this->handleMultipleFiles) {
252 252
             // ensure we have an array of values when field is not casted in model.
253
-            if (! isset($entry->getCasts()[$this->name]) && is_string($values)) {
253
+            if (!isset($entry->getCasts()[$this->name]) && is_string($values)) {
254 254
                 $values = json_decode($values, true);
255 255
             }
256 256
             foreach ($values ?? [] as $value) {
@@ -267,7 +267,7 @@  discard block
 block discarded – undo
267 267
 
268 268
     private function performFileDeletion(Model $entry)
269 269
     {
270
-        if (! $this->handleRepeatableFiles) {
270
+        if (!$this->handleRepeatableFiles) {
271 271
             $this->deleteFiles($entry);
272 272
 
273 273
             return;
@@ -296,7 +296,7 @@  discard block
 block discarded – undo
296 296
 
297 297
         $previousValue = $entry->getOriginal($field);
298 298
 
299
-        if (! $previousValue) {
299
+        if (!$previousValue) {
300 300
             return $previousValue;
301 301
         }
302 302
 
Please login to merge, or discard this patch.
src/app/Http/Controllers/Operations/ListOperation.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -27,7 +27,7 @@  discard block
 block discarded – undo
27 27
             'operation' => 'list',
28 28
         ]);
29 29
 
30
-        if (! isset($this->setupDetailsRowRoute) || $this->setupDetailsRowRoute === true) {
30
+        if (!isset($this->setupDetailsRowRoute) || $this->setupDetailsRowRoute === true) {
31 31
             Route::get($segment.'/{id}/details', [
32 32
                 'as' => $routeName.'.showDetailsRow',
33 33
                 'uses' => $controller.'@showDetailsRow',
@@ -43,7 +43,7 @@  discard block
 block discarded – undo
43 43
     {
44 44
         $this->crud->allowAccess('list');
45 45
 
46
-        $this->crud->operation('list', function () {
46
+        $this->crud->operation('list', function() {
47 47
             $this->crud->loadDefaultOperationSettingsFromConfig();
48 48
         });
49 49
     }
@@ -80,7 +80,7 @@  discard block
 block discarded – undo
80 80
         $search = request()->input('search');
81 81
 
82 82
         // check if length is allowed by developer
83
-        if ($length && ! in_array($length, $this->crud->getPageLengthMenu()[0])) {
83
+        if ($length && !in_array($length, $this->crud->getPageLengthMenu()[0])) {
84 84
             return response()->json([
85 85
                 'error' => 'Unknown page length.',
86 86
             ], 400);
Please login to merge, or discard this patch.
src/app/Library/Database/TableSchema.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -20,7 +20,7 @@  discard block
 block discarded – undo
20 20
     public function getColumnsNames()
21 21
     {
22 22
         return array_values(
23
-            array_map(function ($item) {
23
+            array_map(function($item) {
24 24
                 return $item->getName();
25 25
             }, $this->getColumns())
26 26
         );
@@ -34,7 +34,7 @@  discard block
 block discarded – undo
34 34
      */
35 35
     public function getColumnType(string $columnName)
36 36
     {
37
-        if (! $this->schemaExists() || ! $this->schema->hasColumn($columnName)) {
37
+        if (!$this->schemaExists() || !$this->schema->hasColumn($columnName)) {
38 38
             return 'varchar';
39 39
         }
40 40
 
@@ -51,7 +51,7 @@  discard block
 block discarded – undo
51 51
      */
52 52
     public function hasColumn($columnName)
53 53
     {
54
-        if (! $this->schemaExists()) {
54
+        if (!$this->schemaExists()) {
55 55
             return false;
56 56
         }
57 57
 
@@ -66,7 +66,7 @@  discard block
 block discarded – undo
66 66
      */
67 67
     public function columnIsNullable($columnName)
68 68
     {
69
-        if (! $this->hasColumn($columnName)) {
69
+        if (!$this->hasColumn($columnName)) {
70 70
             return true;
71 71
         }
72 72
 
@@ -83,7 +83,7 @@  discard block
 block discarded – undo
83 83
      */
84 84
     public function columnHasDefault($columnName)
85 85
     {
86
-        if (! $this->hasColumn($columnName)) {
86
+        if (!$this->hasColumn($columnName)) {
87 87
             return false;
88 88
         }
89 89
 
@@ -100,7 +100,7 @@  discard block
 block discarded – undo
100 100
      */
101 101
     public function getColumnDefault($columnName)
102 102
     {
103
-        if (! $this->hasColumn($columnName)) {
103
+        if (!$this->hasColumn($columnName)) {
104 104
             return false;
105 105
         }
106 106
 
@@ -116,7 +116,7 @@  discard block
 block discarded – undo
116 116
      */
117 117
     public function getColumns()
118 118
     {
119
-        if (! $this->schemaExists()) {
119
+        if (!$this->schemaExists()) {
120 120
             return [];
121 121
         }
122 122
 
@@ -130,7 +130,7 @@  discard block
 block discarded – undo
130 130
      */
131 131
     private function schemaExists()
132 132
     {
133
-        if (! empty($this->schema)) {
133
+        if (!empty($this->schema)) {
134 134
             return true;
135 135
         }
136 136
 
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Update.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -58,7 +58,7 @@  discard block
 block discarded – undo
58 58
         }
59 59
 
60 60
         // always have a hidden input for the entry id
61
-        if (! array_key_exists('id', $fields)) {
61
+        if (!array_key_exists('id', $fields)) {
62 62
             $fields['id'] = [
63 63
                 'name' => $entry->getKeyName(),
64 64
                 'value' => $entry->getKey(),
@@ -83,12 +83,12 @@  discard block
 block discarded – undo
83 83
         $fieldEntity = $field['entity'] ?? false;
84 84
         $fakeField = $field['fake'] ?? false;
85 85
 
86
-        if ($fieldEntity && ! $fakeField) {
86
+        if ($fieldEntity && !$fakeField) {
87 87
             return $this->getModelAttributeValueFromRelationship($model, $field);
88 88
         }
89 89
 
90 90
         if ($this->holdsMultipleInputs($field['name'])) {
91
-            $result = array_map(function ($item) use ($model) {
91
+            $result = array_map(function($item) use ($model) {
92 92
                 return $model->{$item};
93 93
             }, explode(',', $field['name']));
94 94
 
@@ -110,7 +110,7 @@  discard block
 block discarded – undo
110 110
     {
111 111
         [$relatedModel, $relationMethod] = $this->getModelAndMethodFromEntity($model, $field);
112 112
 
113
-        if (! method_exists($relatedModel, $relationMethod)) {
113
+        if (!method_exists($relatedModel, $relationMethod)) {
114 114
             return $relatedModel->{$relationMethod};
115 115
         }
116 116
 
@@ -129,7 +129,7 @@  discard block
 block discarded – undo
129 129
                     $model = $this->setLocaleOnModel($model);
130 130
                     // when subfields are NOT set we don't need to get any more values
131 131
                     // we just return the plain models as we only need the ids
132
-                    if (! isset($field['subfields'])) {
132
+                    if (!isset($field['subfields'])) {
133 133
                         $result->push($model);
134 134
 
135 135
                         continue;
@@ -157,13 +157,13 @@  discard block
 block discarded – undo
157 157
                 break;
158 158
             case 'HasOne':
159 159
             case 'MorphOne':
160
-                if (! method_exists($relatedModel, $relationMethod)) {
160
+                if (!method_exists($relatedModel, $relationMethod)) {
161 161
                     return;
162 162
                 }
163 163
 
164 164
                 $model = $relatedModel->{$relationMethod};
165 165
 
166
-                if (! $model) {
166
+                if (!$model) {
167 167
                     return;
168 168
                 }
169 169
 
@@ -226,7 +226,7 @@  discard block
 block discarded – undo
226 226
 
227 227
         $relationArray = explode('.', $relationEntity);
228 228
 
229
-        $relatedModel = array_reduce(array_splice($relationArray, 0, -1), function ($obj, $method) {
229
+        $relatedModel = array_reduce(array_splice($relationArray, 0, -1), function($obj, $method) {
230 230
             // if the string ends with `_id` we strip it out
231 231
             $method = Str::endsWith($method, '_id') ? Str::replaceLast('_id', '', $method) : $method;
232 232
 
@@ -253,7 +253,7 @@  discard block
 block discarded – undo
253 253
             // if the subfield name does not contain a dot we just need to check
254 254
             // if it has subfields and return the result accordingly.
255 255
             foreach ((array) $subfield['name'] as $name) {
256
-                if (! Str::contains($name, '.')) {
256
+                if (!Str::contains($name, '.')) {
257 257
                     // when subfields are present, $relatedModel->{$name} returns a model instance
258 258
                     // otherwise returns the model attribute.
259 259
                     if ($relatedModel->{$name} && isset($subfield['subfields'])) {
Please login to merge, or discard this patch.
src/app/Library/Database/DatabaseSchema.php 1 patch
Spacing   +6 added lines, -7 removed lines patch added patch discarded remove patch
@@ -26,7 +26,7 @@  discard block
 block discarded – undo
26 26
     {
27 27
         $connection = $connection ?: config('database.default');
28 28
 
29
-        self::$schema[$connection] = LazyCollection::make(self::getCreateSchema($connection)->getTables())->mapWithKeys(function ($table, $key) use ($connection) {
29
+        self::$schema[$connection] = LazyCollection::make(self::getCreateSchema($connection)->getTables())->mapWithKeys(function($table, $key) use ($connection) {
30 30
             $tableName = is_array($table) ? $table['name'] : $table->getName();
31 31
 
32 32
             if ($existingTable = self::$schema[$connection][$tableName] ?? false) {
@@ -65,7 +65,7 @@  discard block
 block discarded – undo
65 65
      */
66 66
     private static function generateDatabaseSchema(string $connection, string $table)
67 67
     {
68
-        if (! isset(self::$schema[$connection][$table])) {
68
+        if (!isset(self::$schema[$connection][$table])) {
69 69
             self::$schema[$connection][$table] = self::mapTable($connection, $table);
70 70
         }
71 71
     }
@@ -74,20 +74,19 @@  discard block
 block discarded – undo
74 74
     {
75 75
         try {
76 76
             $table = method_exists(self::getCreateSchema($connection), 'getTable') ?
77
-                        self::getCreateSchema($connection)->getTable($tableName) :
78
-                        self::getCreateSchema($connection)->getColumns($tableName);
77
+                        self::getCreateSchema($connection)->getTable($tableName) : self::getCreateSchema($connection)->getColumns($tableName);
79 78
         } catch (\Exception $e) {
80 79
             return new Table($tableName, []);
81 80
         }
82 81
 
83
-        if (! is_array($table) || empty($table)) {
82
+        if (!is_array($table) || empty($table)) {
84 83
             return $table;
85 84
         }
86 85
 
87 86
         $schemaManager = self::getSchemaManager($connection);
88 87
         $indexes = $schemaManager->getIndexes($tableName);
89 88
 
90
-        $indexes = array_map(function ($index) {
89
+        $indexes = array_map(function($index) {
91 90
             return $index['columns'];
92 91
         }, $indexes);
93 92
 
@@ -105,7 +104,7 @@  discard block
 block discarded – undo
105 104
 
106 105
         $indexes = self::$schema[$connection][$table]->getIndexes();
107 106
 
108
-        $indexes = \Illuminate\Support\Arr::flatten(array_map(function ($index) {
107
+        $indexes = \Illuminate\Support\Arr::flatten(array_map(function($index) {
109 108
             return is_string($index) ? $index : $index->getColumns();
110 109
         }, $indexes));
111 110
 
Please login to merge, or discard this patch.