Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Completed
Pull Request — master (#943)
by Pascal
02:34
created
src/PanelTraits/Filters.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -124,7 +124,7 @@
 block discarded – undo
124 124
 
125 125
     /**
126 126
      * Determine if the current CRUD action is a list operation (using standard or ajax DataTables).
127
-     * @return bool
127
+     * @return boolean|null
128 128
      */
129 129
     public function doingListOperation()
130 130
     {
Please login to merge, or discard this patch.
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -10,7 +10,7 @@  discard block
 block discarded – undo
10 10
 
11 11
     public function filtersEnabled()
12 12
     {
13
-        return ! is_array($this->filters);
13
+        return !is_array($this->filters);
14 14
     }
15 15
 
16 16
     public function filtersDisabled()
@@ -54,7 +54,7 @@  discard block
 block discarded – undo
54 54
         $this->enableFilters();
55 55
 
56 56
         // check if another filter with the same name exists
57
-        if (! isset($options['name'])) {
57
+        if (!isset($options['name'])) {
58 58
             abort(500, 'All your filters need names.');
59 59
         }
60 60
         if ($this->filters->contains('name', $options['name'])) {
@@ -131,7 +131,7 @@  discard block
 block discarded – undo
131 131
 
132 132
     public function removeFilter($name)
133 133
     {
134
-        $this->filters = $this->filters->reject(function ($filter) use ($name) {
134
+        $this->filters = $this->filters->reject(function($filter) use ($name) {
135 135
             return $filter->name == $name;
136 136
         });
137 137
     }
@@ -201,7 +201,7 @@  discard block
 block discarded – undo
201 201
         $this->type = $options['type'];
202 202
         $this->label = $options['label'];
203 203
 
204
-        if (! isset($options['placeholder'])) {
204
+        if (!isset($options['placeholder'])) {
205 205
             $this->placeholder = '';
206 206
         } else {
207 207
             $this->placeholder = $options['placeholder'];
@@ -218,16 +218,16 @@  discard block
 block discarded – undo
218 218
 
219 219
     public function checkOptionsIntegrity($options)
220 220
     {
221
-        if (! isset($options['name'])) {
221
+        if (!isset($options['name'])) {
222 222
             abort(500, 'Please make sure all your filters have names.');
223 223
         }
224
-        if (! isset($options['type'])) {
224
+        if (!isset($options['type'])) {
225 225
             abort(500, 'Please make sure all your filters have types.');
226 226
         }
227
-        if (! \View::exists('crud::filters.'.$options['type'])) {
227
+        if (!\View::exists('crud::filters.'.$options['type'])) {
228 228
             abort(500, 'No filter view named "'.$options['type'].'.blade.php" was found.');
229 229
         }
230
-        if (! isset($options['label'])) {
230
+        if (!isset($options['label'])) {
231 231
             abort(500, 'Please make sure all your filters have labels.');
232 232
         }
233 233
     }
Please login to merge, or discard this patch.
src/resources/views/columns/select.blade.php 1 patch
Indentation   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -1,8 +1,8 @@
 block discarded – undo
1 1
 {{-- single relationships (1-1, 1-n) --}}
2 2
 <td>
3 3
 	<?php
4
-		if ($entry->{$column['entity']}) {
5
-	    	echo $entry->{$column['entity']}->{$column['attribute']};
6
-	    }
7
-	?>
4
+        if ($entry->{$column['entity']}) {
5
+            echo $entry->{$column['entity']}->{$column['attribute']};
6
+        }
7
+    ?>
8 8
 </td>
Please login to merge, or discard this patch.
src/resources/views/fields/date.blade.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,7 @@
 block discarded – undo
3 3
 <?php
4 4
 // if the column has been cast to Carbon or Date (using attribute casting)
5 5
 // get the value as a date string
6
-if (isset($field['value']) && ( $field['value'] instanceof \Carbon\Carbon || $field['value'] instanceof \Jenssegers\Date\Date )) {
6
+if (isset($field['value']) && ($field['value'] instanceof \Carbon\Carbon || $field['value'] instanceof \Jenssegers\Date\Date)) {
7 7
     $field['value'] = $field['value']->toDateString();
8 8
 }
9 9
 ?>
Please login to merge, or discard this patch.
src/resources/views/fields/datetime_picker.blade.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -3,11 +3,11 @@
 block discarded – undo
3 3
 <?php
4 4
 // if the column has been cast to Carbon or Date (using attribute casting)
5 5
 // get the value as a date string
6
-if (isset($field['value']) && ( $field['value'] instanceof \Carbon\Carbon || $field['value'] instanceof \Jenssegers\Date\Date )) {
6
+if (isset($field['value']) && ($field['value'] instanceof \Carbon\Carbon || $field['value'] instanceof \Jenssegers\Date\Date)) {
7 7
     $field['value'] = $field['value']->format('Y-m-d H:i:s');
8 8
 }
9 9
 
10
-    $field_language = isset($field['datetime_picker_options']['language'])?$field['datetime_picker_options']['language']:\App::getLocale();
10
+    $field_language = isset($field['datetime_picker_options']['language']) ? $field['datetime_picker_options']['language'] : \App::getLocale();
11 11
 ?>
12 12
 
13 13
 <div @include('crud::inc.field_wrapper_attributes') >
Please login to merge, or discard this patch.
src/resources/views/fields/datetime.blade.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,7 @@
 block discarded – undo
3 3
 <?php
4 4
 // if the column has been cast to Carbon or Date (using attribute casting)
5 5
 // get the value as a date string
6
-if (isset($field['value']) && ( $field['value'] instanceof \Carbon\Carbon || $field['value'] instanceof \Jenssegers\Date\Date )) {
6
+if (isset($field['value']) && ($field['value'] instanceof \Carbon\Carbon || $field['value'] instanceof \Jenssegers\Date\Date)) {
7 7
     $field['value'] = $field['value']->toDateTimeString();
8 8
 }
9 9
 ?>
Please login to merge, or discard this patch.
src/resources/views/fields/date_picker.blade.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -3,11 +3,11 @@
 block discarded – undo
3 3
 <?php
4 4
     // if the column has been cast to Carbon or Date (using attribute casting)
5 5
     // get the value as a date string
6
-    if (isset($field['value']) && ( $field['value'] instanceof \Carbon\Carbon || $field['value'] instanceof \Jenssegers\Date\Date )) {
6
+    if (isset($field['value']) && ($field['value'] instanceof \Carbon\Carbon || $field['value'] instanceof \Jenssegers\Date\Date)) {
7 7
         $field['value'] = $field['value']->format('Y-m-d');
8 8
     }
9 9
 
10
-    $field_language = isset($field['date_picker_options']['language'])?$field['date_picker_options']['language']:\App::getLocale();
10
+    $field_language = isset($field['date_picker_options']['language']) ? $field['date_picker_options']['language'] : \App::getLocale();
11 11
 ?>
12 12
 
13 13
 <div @include('crud::inc.field_wrapper_attributes') >
Please login to merge, or discard this patch.
src/resources/views/fields/table.blade.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -5,7 +5,7 @@
 block discarded – undo
5 5
     $min = isset($field['min']) && (int) $field['min'] > 0 ? $field['min'] : -1;
6 6
     $item_name = strtolower(isset($field['entity_singular']) && !empty($field['entity_singular']) ? $field['entity_singular'] : $field['label']);
7 7
 
8
-    $items = old($field['name']) ? (old($field['name'])) : (isset($field['value']) ? ($field['value']) : (isset($field['default']) ? ($field['default']) : '' ));
8
+    $items = old($field['name']) ? (old($field['name'])) : (isset($field['value']) ? ($field['value']) : (isset($field['default']) ? ($field['default']) : ''));
9 9
 
10 10
     // make sure not matter the attribute casting
11 11
     // the $items variable contains a properly defined JSON
Please login to merge, or discard this patch.
src/resources/views/reorder.blade.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -76,10 +76,10 @@
 block discarded – undo
76 76
                 <ol class="sortable">
77 77
                 <?php
78 78
                     $all_entries = collect($entries->all())->sortBy('lft')->keyBy($crud->getModel()->getKeyName());
79
-                    $root_entries = $all_entries->filter(function ($item) {
79
+                    $root_entries = $all_entries->filter(function($item) {
80 80
                         return $item->parent_id == 0;
81 81
                     });
82
-                    foreach ($root_entries as $key => $entry){
82
+                    foreach ($root_entries as $key => $entry) {
83 83
                         $root_entries[$key] = tree_element($entry, $key, $all_entries, $crud);
84 84
                     }
85 85
                 ?>
Please login to merge, or discard this patch.
src/PanelTraits/Create.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -87,7 +87,7 @@
 block discarded – undo
87 87
     {
88 88
         $all_relation_fields = $this->getRelationFields($form);
89 89
 
90
-        return array_where($all_relation_fields, function ($value, $key) {
90
+        return array_where($all_relation_fields, function($value, $key) {
91 91
             return isset($value['pivot']) && $value['pivot'];
92 92
         });
93 93
     }
Please login to merge, or discard this patch.