Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Completed
Pull Request — master (#144)
by Owen
03:17
created
src/resources/views/reorder.blade.php 1 patch
Indentation   +26 added lines, -26 removed lines patch added patch discarded remove patch
@@ -20,42 +20,42 @@  discard block
 block discarded – undo
20 20
 
21 21
 @section('content')
22 22
 <?php
23
-  function tree_element($entry, $key, $all_entries, $crud)
24
-  {
23
+    function tree_element($entry, $key, $all_entries, $crud)
24
+    {
25 25
     if (!isset($entry->tree_element_shown)) {
26
-      // mark the element as shown
27
-      $all_entries[$key]->tree_element_shown = true;
28
-      $entry->tree_element_shown = true;
26
+        // mark the element as shown
27
+        $all_entries[$key]->tree_element_shown = true;
28
+        $entry->tree_element_shown = true;
29 29
 
30
-      // show the tree element
31
-      echo '<li id="list_'.$entry->getKey().'">';
32
-      echo '<div><span class="disclose"><span></span></span>'.$entry->{$crud->reorder_label}.'</div>';
30
+        // show the tree element
31
+        echo '<li id="list_'.$entry->getKey().'">';
32
+        echo '<div><span class="disclose"><span></span></span>'.$entry->{$crud->reorder_label}.'</div>';
33 33
 
34
-      // see if this element has any children
35
-      $children = [];
36
-      foreach ($all_entries as $key => $subentry) {
34
+        // see if this element has any children
35
+        $children = [];
36
+        foreach ($all_entries as $key => $subentry) {
37 37
         if ($subentry->parent_id == $entry->getKey()) {
38
-          $children[] = $subentry;
38
+            $children[] = $subentry;
39
+        }
39 40
         }
40
-      }
41 41
 
42
-      $children = collect($children)->sortBy('lft');
42
+        $children = collect($children)->sortBy('lft');
43 43
 
44
-      // if it does have children, show them
45
-      if (count($children)) {
44
+        // if it does have children, show them
45
+        if (count($children)) {
46 46
         echo '<ol>';
47 47
         foreach ($children as $key => $child) {
48
-          $children[$key] = tree_element($child, $child->getKey(), $all_entries, $crud);
48
+            $children[$key] = tree_element($child, $child->getKey(), $all_entries, $crud);
49 49
         }
50 50
         echo '</ol>';
51
-      }
52
-      echo '</li>';
51
+        }
52
+        echo '</li>';
53 53
     }
54 54
 
55 55
     return $entry;
56
-  }
56
+    }
57 57
 
58
- ?>
58
+    ?>
59 59
 <div class="row">
60 60
   <div class="col-md-8 col-md-offset-2">
61 61
     @if ($crud->hasAccess('list'))
@@ -73,15 +73,15 @@  discard block
 block discarded – undo
73 73
 
74 74
           <ol class="sortable">
75 75
             <?php
76
-              $all_entries = collect($entries->all())->sortBy('lft')->keyBy($crud->getModel()->getKeyName());
77
-              $root_entries = $all_entries->filter(function($item) {
76
+                $all_entries = collect($entries->all())->sortBy('lft')->keyBy($crud->getModel()->getKeyName());
77
+                $root_entries = $all_entries->filter(function($item) {
78 78
                 return $item->parent_id == 0;
79
-              });
80
-             ?>
79
+                });
80
+                ?>
81 81
             @foreach ($root_entries as $key => $entry)
82 82
               <?php
83 83
                 $root_entries[$key] = tree_element($entry, $key, $all_entries, $crud);
84
-              ?>
84
+                ?>
85 85
             @endforeach
86 86
           </ol>
87 87
 
Please login to merge, or discard this patch.
src/CrudPanel.php 2 patches
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -70,7 +70,7 @@  discard block
 block discarded – undo
70 70
      */
71 71
     public function setModel($model_namespace)
72 72
     {
73
-        if (! class_exists($model_namespace)) {
73
+        if (!class_exists($model_namespace)) {
74 74
             throw new \Exception('This model does not exist.', 404);
75 75
         }
76 76
 
@@ -112,7 +112,7 @@  discard block
 block discarded – undo
112 112
     {
113 113
         $complete_route = $route.'.index';
114 114
 
115
-        if (! \Route::has($complete_route)) {
115
+        if (!\Route::has($complete_route)) {
116 116
             throw new \Exception('There are no routes for this route name.', 404);
117 117
         }
118 118
 
@@ -162,7 +162,7 @@  discard block
 block discarded – undo
162 162
      */
163 163
     public function getFirstOfItsTypeInArray($type, $array)
164 164
     {
165
-        return array_first($array, function ($item) use ($type) {
165
+        return array_first($array, function($item) use ($type) {
166 166
             return $item['type'] == $type;
167 167
         });
168 168
     }
@@ -179,8 +179,8 @@  discard block
 block discarded – undo
179 179
 
180 180
     public function sync($type, $fields, $attributes)
181 181
     {
182
-        if (! empty($this->{$type})) {
183
-            $this->{$type} = array_map(function ($field) use ($fields, $attributes) {
182
+        if (!empty($this->{$type})) {
183
+            $this->{$type} = array_map(function($field) use ($fields, $attributes) {
184 184
                 if (in_array($field['name'], (array) $fields)) {
185 185
                     $field = array_merge($field, $attributes);
186 186
                 }
@@ -206,8 +206,8 @@  discard block
 block discarded – undo
206 206
                 }
207 207
             }
208 208
 
209
-            return $this->{$items} = array_merge($elements, array_filter($this->{$items}, function ($item) use ($items) {
210
-                return ! in_array($item['name'], $this->sort[$items]);
209
+            return $this->{$items} = array_merge($elements, array_filter($this->{$items}, function($item) use ($items) {
210
+                return !in_array($item['name'], $this->sort[$items]);
211 211
             }));
212 212
         }
213 213
 
Please login to merge, or discard this patch.
Unused Use Statements   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -3,6 +3,7 @@  discard block
 block discarded – undo
3 3
 namespace Backpack\CRUD;
4 4
 
5 5
 use Backpack\CRUD\PanelTraits\Access;
6
+use Backpack\CRUD\PanelTraits\AutoFocus;
6 7
 use Backpack\CRUD\PanelTraits\AutoSet;
7 8
 use Backpack\CRUD\PanelTraits\Buttons;
8 9
 use Backpack\CRUD\PanelTraits\Columns;
@@ -16,7 +17,6 @@  discard block
 block discarded – undo
16 17
 use Backpack\CRUD\PanelTraits\Reorder;
17 18
 use Backpack\CRUD\PanelTraits\Update;
18 19
 use Backpack\CRUD\PanelTraits\ViewsAndRestoresRevisions;
19
-use Backpack\CRUD\PanelTraits\AutoFocus;
20 20
 
21 21
 class CrudPanel
22 22
 {
Please login to merge, or discard this patch.
src/PanelTraits/Read.php 2 patches
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -75,7 +75,7 @@  discard block
 block discarded – undo
75 75
     public function hasUploadFields($form)
76 76
     {
77 77
         $fields = $this->getFields($form);
78
-        $upload_fields = array_where($fields, function ($value, $key) {
78
+        $upload_fields = array_where($fields, function($value, $key) {
79 79
             return isset($value['upload']) && $value['upload'] == true;
80 80
         });
81 81
 
@@ -173,7 +173,7 @@  discard block
 block discarded – undo
173 173
      */
174 174
     public function getCellView($column, $entry)
175 175
     {
176
-        if (! isset($column['type'])) {
176
+        if (!isset($column['type'])) {
177 177
             return \View::make('crud::columns.text')->with('crud', $this)->with('column', $column)->with('entry', $entry)->render();
178 178
         } else {
179 179
             if (view()->exists('vendor.backpack.crud.columns.'.$column['type'])) {
Please login to merge, or discard this patch.
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -33,6 +33,7 @@
 block discarded – undo
33 33
      * Get all fields needed for the EDIT ENTRY form.
34 34
      *
35 35
      * @param  [integer] The id of the entry that is being edited.
36
+     * @param integer $id
36 37
      *
37 38
      * @return [array] The fields with attributes, fake attributes and values.
38 39
      */
Please login to merge, or discard this patch.
src/PanelTraits/ViewsAndRestoresRevisions.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -21,7 +21,7 @@
 block discarded – undo
21 21
             $revisionDate = date('Y-m-d', strtotime((string) $history->created_at));
22 22
 
23 23
             // Be sure to instantiate the initial grouping array
24
-            if (! array_key_exists($revisionDate, $revisions)) {
24
+            if (!array_key_exists($revisionDate, $revisions)) {
25 25
                 $revisions[$revisionDate] = [];
26 26
             }
27 27
 
Please login to merge, or discard this patch.
src/resources/views/columns/array.blade.php 1 patch
Indentation   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -1,11 +1,11 @@
 block discarded – undo
1 1
 {{-- enumerate the values in an array  --}}
2 2
 <td>
3 3
     <?php
4
-    	$value = $entry->{$column['name']};
5
-    	// the value should be an array wether or not attribute casting is used
6
-    	if (!is_array($value)) {
7
-    		$value = json_decode($value, true);
8
-    	}
4
+        $value = $entry->{$column['name']};
5
+        // the value should be an array wether or not attribute casting is used
6
+        if (!is_array($value)) {
7
+            $value = json_decode($value, true);
8
+        }
9 9
         if ($value && count($value)) {
10 10
             echo implode(', ', $value);
11 11
         } else {
Please login to merge, or discard this patch.
src/app/Http/Controllers/CrudController.php 2 patches
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -31,7 +31,7 @@  discard block
 block discarded – undo
31 31
 
32 32
         // call the setup function inside this closure to also have the request there
33 33
         // this way, developers can use things stored in session (auth variables, etc)
34
-        $this->middleware(function ($request, $next) {
34
+        $this->middleware(function($request, $next) {
35 35
             $this->setup();
36 36
             return $next($request);
37 37
         });
@@ -56,7 +56,7 @@  discard block
 block discarded – undo
56 56
         $this->data['title'] = ucfirst($this->crud->entity_name_plural);
57 57
 
58 58
         // get all entries if AJAX is not enabled
59
-        if (! $this->data['crud']->ajaxTable()) {
59
+        if (!$this->data['crud']->ajaxTable()) {
60 60
             $this->data['entries'] = $this->data['crud']->getEntries();
61 61
         }
62 62
 
Please login to merge, or discard this patch.
Unused Use Statements   +2 added lines, -4 removed lines patch added patch discarded remove patch
@@ -2,13 +2,11 @@
 block discarded – undo
2 2
 
3 3
 namespace Backpack\CRUD\app\Http\Controllers;
4 4
 
5
+use Backpack\CRUD\CrudPanel;
6
+use Backpack\CRUD\app\Http\Requests\CrudRequest as UpdateRequest;
5 7
 use Illuminate\Foundation\Bus\DispatchesJobs;
6 8
 use Illuminate\Foundation\Validation\ValidatesRequests;
7 9
 use Illuminate\Routing\Controller as BaseController;
8
-use Illuminate\Support\Facades\Form as Form;
9
-use Backpack\CRUD\app\Http\Requests\CrudRequest as StoreRequest;
10
-use Backpack\CRUD\app\Http\Requests\CrudRequest as UpdateRequest;
11
-use Backpack\CRUD\CrudPanel;
12 10
 // CRUD Traits for non-core features
13 11
 use Backpack\CRUD\app\Http\Controllers\CrudFeatures\AjaxTable;
14 12
 use Backpack\CRUD\app\Http\Controllers\CrudFeatures\Reorder;
Please login to merge, or discard this patch.
src/app/Http/Controllers/CrudFeatures/Revisions.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -44,7 +44,7 @@
 block discarded – undo
44 44
         // is somewhat superfluous.. however if we are POSTing, it makes sense to actually have data to post.
45 45
         // Perhaps the route shoud be better named to reflect this (e.g. just /model/{id}/revisions) (??)
46 46
         $revisionId = \Request::input('revision_id', false);
47
-        if (! $revisionId) {
47
+        if (!$revisionId) {
48 48
             abort(500, 'Can\'t restore revision without revision_id');
49 49
         } else {
50 50
             $this->crud->restoreRevision($id, $revisionId); // do the update
Please login to merge, or discard this patch.
src/app/Http/Controllers/CrudFeatures/Reorder.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -174,7 +174,7 @@
 block discarded – undo
174 174
     {
175 175
         $this->crud->hasAccessOrFail('reorder');
176 176
 
177
-        if (! $this->crud->isReorderEnabled()) {
177
+        if (!$this->crud->isReorderEnabled()) {
178 178
             abort(403, 'Reorder is disabled.');
179 179
         }
180 180
 
Please login to merge, or discard this patch.
src/app/Http/Controllers/CrudFeatures/AjaxTable.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -14,7 +14,7 @@  discard block
 block discarded – undo
14 14
 
15 15
         // crate an array with the names of the searchable columns
16 16
         $columns = collect($this->crud->columns)
17
-                    ->reject(function ($column, $key) {
17
+                    ->reject(function($column, $key) {
18 18
                         // the select_multiple columns are not searchable
19 19
                         return isset($column['type']) && $column['type'] == 'select_multiple';
20 20
                     })
@@ -27,7 +27,7 @@  discard block
 block discarded – undo
27 27
         $dataTable = new \LiveControl\EloquentDataTable\DataTable($this->crud->query, $columns);
28 28
 
29 29
         // make the datatable use the column types instead of just echoing the text
30
-        $dataTable->setFormatRowFunction(function ($entry) {
30
+        $dataTable->setFormatRowFunction(function($entry) {
31 31
             // get the actual HTML for each row's cell
32 32
             $row_items = $this->crud->getRowViews($entry, $this->crud);
33 33
 
Please login to merge, or discard this patch.