Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Passed
Push — poc-upload-non-breaking ( e9da1d...d7f4ad )
by Pedro
11:34
created
src/app/Library/CrudPanel/Traits/Relationships.php 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -65,7 +65,7 @@  discard block
 block discarded – undo
65 65
         $model = $this->getRelationModel($entity, -1);
66 66
         $lastSegmentAfterDot = Str::of($field['entity'])->afterLast('.');
67 67
 
68
-        if (! method_exists($model, $lastSegmentAfterDot)) {
68
+        if (!method_exists($model, $lastSegmentAfterDot)) {
69 69
             return (string) Str::of($field['entity'])->beforeLast('.');
70 70
         }
71 71
 
@@ -86,7 +86,7 @@  discard block
 block discarded – undo
86 86
 
87 87
         return collect($this->getCleanStateFields())
88 88
             ->whereIn('relation_type', $relation_types)
89
-            ->filter(function ($item) use ($nested) {
89
+            ->filter(function($item) use ($nested) {
90 90
                 if ($nested) {
91 91
                     return true;
92 92
                 }
@@ -130,7 +130,7 @@  discard block
 block discarded – undo
130 130
      */
131 131
     private function getRelationFieldsWithoutRelationType($relations, $fields = [])
132 132
     {
133
-        if (! is_array($relations)) {
133
+        if (!is_array($relations)) {
134 134
             $relations = [$relations];
135 135
         }
136 136
 
@@ -139,8 +139,8 @@  discard block
 block discarded – undo
139 139
         }
140 140
 
141 141
         foreach ($relations as $relation) {
142
-            $fields = array_filter($fields, function ($field) use ($relation) {
143
-                if (! isset($field['relation_type'])) {
142
+            $fields = array_filter($fields, function($field) use ($relation) {
143
+                if (!isset($field['relation_type'])) {
144 144
                     return false;
145 145
                 }
146 146
 
@@ -174,7 +174,7 @@  discard block
 block discarded – undo
174 174
                     $fields = array_merge($field['subfields'], $fields);
175 175
                 }
176 176
             }
177
-            $fields = array_filter($fields, function ($field) {
177
+            $fields = array_filter($fields, function($field) {
178 178
                 return isset($field['relation_type']) && $field['relation_type'] === 'BelongsTo';
179 179
             });
180 180
         }
@@ -243,8 +243,8 @@  discard block
 block discarded – undo
243 243
     {
244 244
         $all_relation_fields = $this->getRelationFields();
245 245
 
246
-        return Arr::where($all_relation_fields, function ($value, $key) {
247
-            return isset($value['pivot']) && ! $value['pivot'];
246
+        return Arr::where($all_relation_fields, function($value, $key) {
247
+            return isset($value['pivot']) && !$value['pivot'];
248 248
         });
249 249
     }
250 250
 
@@ -257,7 +257,7 @@  discard block
 block discarded – undo
257 257
     {
258 258
         $all_relation_fields = $this->getRelationFields();
259 259
 
260
-        return Arr::where($all_relation_fields, function ($value, $key) {
260
+        return Arr::where($all_relation_fields, function($value, $key) {
261 261
             return isset($value['pivot']) && $value['pivot'];
262 262
         });
263 263
     }
@@ -338,7 +338,7 @@  discard block
 block discarded – undo
338 338
         }
339 339
 
340 340
         // relationships are always public methods.
341
-        if (! $methodReflection->isPublic()) {
341
+        if (!$methodReflection->isPublic()) {
342 342
             return false;
343 343
         }
344 344
 
@@ -368,7 +368,7 @@  discard block
 block discarded – undo
368 368
      */
369 369
     private function isAttributeInRelationString($field)
370 370
     {
371
-        if (! str_contains($field['entity'], '.')) {
371
+        if (!str_contains($field['entity'], '.')) {
372 372
             return false;
373 373
         }
374 374
 
Please login to merge, or discard this patch.
src/ViewNamespaces.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -29,7 +29,7 @@  discard block
 block discarded – undo
29 29
     public static function addFor(string $domain, $viewNamespaces)
30 30
     {
31 31
         foreach ((array) $viewNamespaces as $viewNamespace) {
32
-            if (! in_array($viewNamespace, self::getForDomain($domain))) {
32
+            if (!in_array($viewNamespace, self::getForDomain($domain))) {
33 33
                 self::$viewNamespaces[$domain][] = $viewNamespace;
34 34
             }
35 35
         }
@@ -83,7 +83,7 @@  discard block
 block discarded – undo
83 83
      */
84 84
     public static function getViewPathsFor(string $domain, string $viewName)
85 85
     {
86
-        return array_map(function ($item) use ($viewName) {
86
+        return array_map(function($item) use ($viewName) {
87 87
             return $item.'.'.$viewName;
88 88
         }, self::getFor($domain));
89 89
     }
Please login to merge, or discard this patch.
tests/Unit/CrudPanel/CrudPanelTitlesAndHeadingsTest.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -36,7 +36,7 @@  discard block
 block discarded – undo
36 36
     {
37 37
         $this->crudPanel->setModel(User::class);
38 38
         $request = request()->create('/admin/users/create', 'POST', ['name' => 'foo']);
39
-        $request->setRouteResolver(function () use ($request) {
39
+        $request->setRouteResolver(function() use ($request) {
40 40
             return (new Route('POST', 'admin/users/create', ['UserCrudController', 'create']))->bind($request);
41 41
         });
42 42
         $this->crudPanel->setRequest($request);
@@ -51,7 +51,7 @@  discard block
 block discarded – undo
51 51
     {
52 52
         $this->crudPanel->setModel(User::class);
53 53
         $request = request()->create('/admin/users/create', 'POST', ['name' => 'foo']);
54
-        $request->setRouteResolver(function () use ($request) {
54
+        $request->setRouteResolver(function() use ($request) {
55 55
             return (new Route('POST', 'admin/users/create', ['UserCrudController', 'create']))->bind($request);
56 56
         });
57 57
         $this->crudPanel->setRequest($request);
@@ -66,7 +66,7 @@  discard block
 block discarded – undo
66 66
     {
67 67
         $this->crudPanel->setModel(User::class);
68 68
         $request = request()->create('/admin/users/create', 'POST', ['name' => 'foo']);
69
-        $request->setRouteResolver(function () use ($request) {
69
+        $request->setRouteResolver(function() use ($request) {
70 70
             return (new Route('POST', 'admin/users/create', ['UserCrudController', 'create']))->bind($request);
71 71
         });
72 72
         $this->crudPanel->setRequest($request);
Please login to merge, or discard this patch.
tests/Unit/CrudPanel/CrudPanelMacroTest.php 2 patches
Indentation   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -25,8 +25,8 @@
 block discarded – undo
25 25
         } catch (\Throwable $e) {
26 26
         }
27 27
         $this->assertEquals(
28
-          new \Symfony\Component\HttpKernel\Exception\HttpException(500, 'Cannot register \'setModel\' macro. \'setModel()\' already exists on Backpack\CRUD\app\Library\CrudPanel\CrudPanel'),
29
-          $e
30
-      );
28
+            new \Symfony\Component\HttpKernel\Exception\HttpException(500, 'Cannot register \'setModel\' macro. \'setModel()\' already exists on Backpack\CRUD\app\Library\CrudPanel\CrudPanel'),
29
+            $e
30
+        );
31 31
     }
32 32
 }
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -9,7 +9,7 @@  discard block
 block discarded – undo
9 9
 {
10 10
     public function testItCanRegisterMacro()
11 11
     {
12
-        $this->crudPanel::macro('validMacro', function () {
12
+        $this->crudPanel::macro('validMacro', function() {
13 13
             return true;
14 14
         });
15 15
 
@@ -19,7 +19,7 @@  discard block
 block discarded – undo
19 19
     public function testThrowsErrorIfMacroExists()
20 20
     {
21 21
         try {
22
-            $this->crudPanel::macro('setModel', function () {
22
+            $this->crudPanel::macro('setModel', function() {
23 23
                 return true;
24 24
             });
25 25
         } catch (\Throwable $e) {
Please login to merge, or discard this patch.
tests/Unit/CrudPanel/CrudPanelCreateTest.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -605,7 +605,7 @@  discard block
 block discarded – undo
605 605
 
606 606
     public function testCreateBelongsToFake()
607 607
     {
608
-        $belongsToField = [   // select_grouped
608
+        $belongsToField = [// select_grouped
609 609
             'label'                      => 'Select_grouped',
610 610
             'type'                       => 'select_grouped', //https://github.com/Laravel-Backpack/CRUD/issues/502
611 611
             'name'                       => 'bang_relation_field',
@@ -741,7 +741,7 @@  discard block
 block discarded – undo
741 741
                 'nickname'        => 'i_have_has_one',
742 742
                 'profile_picture' => 'ohh my picture 1.jpg',
743 743
                 'article'         => 1,
744
-                'addresses'       => [ // HasOne is tested in other test function
744
+                'addresses'       => [// HasOne is tested in other test function
745 745
                     [
746 746
                         'city'   => 2,
747 747
                         'street' => 'test',
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Validation.php 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -46,10 +46,10 @@  discard block
 block discarded – undo
46 46
     private function getValidationRulesFromFieldsAndSubfields($fields)
47 47
     {
48 48
         $rules = collect($fields)
49
-            ->filter(function ($value, $key) {
49
+            ->filter(function($value, $key) {
50 50
                 // only keep fields where 'validationRules' OR there are subfields
51 51
                 return array_key_exists('validationRules', $value) || array_key_exists('subfields', $value);
52
-            })->map(function ($item, $key) {
52
+            })->map(function($item, $key) {
53 53
                 $validationRules = [];
54 54
                 // only keep the rules, not the entire field definition
55 55
                 if (isset($item['validationRules'])) {
@@ -57,7 +57,7 @@  discard block
 block discarded – undo
57 57
                 }
58 58
                 // add validation rules for subfields
59 59
                 if (array_key_exists('subfields', $item)) {
60
-                    $subfieldsWithValidation = array_filter($item['subfields'], function ($subfield) {
60
+                    $subfieldsWithValidation = array_filter($item['subfields'], function($subfield) {
61 61
                         return array_key_exists('validationRules', $subfield);
62 62
                     });
63 63
 
@@ -82,10 +82,10 @@  discard block
 block discarded – undo
82 82
     {
83 83
         $messages = [];
84 84
         collect($fields)
85
-            ->filter(function ($value, $key) {
85
+            ->filter(function($value, $key) {
86 86
                 // only keep fields where 'validationMessages' OR there are subfields
87 87
                 return array_key_exists('validationMessages', $value) || array_key_exists('subfields', $value);
88
-            })->each(function ($item, $key) use (&$messages) {
88
+            })->each(function($item, $key) use (&$messages) {
89 89
                 if (isset($item['validationMessages'])) {
90 90
                     foreach ($item['validationMessages'] as $rule => $message) {
91 91
                         $messages[$key.'.'.$rule] = $message;
@@ -93,7 +93,7 @@  discard block
 block discarded – undo
93 93
                 }
94 94
                 // add messages from subfields
95 95
                 if (array_key_exists('subfields', $item)) {
96
-                    $subfieldsWithValidationMessages = array_filter($item['subfields'], function ($subfield) {
96
+                    $subfieldsWithValidationMessages = array_filter($item['subfields'], function($subfield) {
97 97
                         return array_key_exists('validationRules', $subfield);
98 98
                     });
99 99
 
@@ -129,7 +129,7 @@  discard block
 block discarded – undo
129 129
      */
130 130
     public function setValidation($classOrRulesArray = false, $messages = [])
131 131
     {
132
-        if (! $classOrRulesArray) {
132
+        if (!$classOrRulesArray) {
133 133
             $this->setValidationFromFields();
134 134
         } elseif (is_array($classOrRulesArray)) {
135 135
             $this->setValidationFromArray($classOrRulesArray, $messages);
@@ -210,7 +210,7 @@  discard block
 block discarded – undo
210 210
             return $this->checkRequestValidity($extendedRules, $extendedMessages, $formRequest);
211 211
         }
212 212
 
213
-        return ! empty($rules) ? $this->checkRequestValidity($rules, $messages) : $this->getRequest();
213
+        return !empty($rules) ? $this->checkRequestValidity($rules, $messages) : $this->getRequest();
214 214
     }
215 215
 
216 216
     /**
@@ -225,7 +225,7 @@  discard block
 block discarded – undo
225 225
     {
226 226
         $extendedRules = [];
227 227
         $requestRules = $this->getRequestRulesAsArray($request);
228
-        $rules = array_map(function ($ruleDefinition) {
228
+        $rules = array_map(function($ruleDefinition) {
229 229
             return is_array($ruleDefinition) ? $ruleDefinition : explode('|', $ruleDefinition);
230 230
         }, $rules);
231 231
 
@@ -322,7 +322,7 @@  discard block
 block discarded – undo
322 322
      */
323 323
     public function isRequired($inputKey)
324 324
     {
325
-        if (! $this->hasOperationSetting('requiredFields')) {
325
+        if (!$this->hasOperationSetting('requiredFields')) {
326 326
             return false;
327 327
         }
328 328
 
@@ -343,7 +343,7 @@  discard block
 block discarded – undo
343 343
     {
344 344
         [$rules, $messages] = $this->getValidationRulesAndMessagesFromField($field, $parent);
345 345
 
346
-        if (! empty($rules)) {
346
+        if (!empty($rules)) {
347 347
             $this->setValidation($rules, $messages);
348 348
         }
349 349
     }
Please login to merge, or discard this patch.
src/app/Console/Commands/PublishAssets.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -41,12 +41,12 @@
 block discarded – undo
41 41
     private function runConsoleCommand($command)
42 42
     {
43 43
         $process = new Process($command, null, null, null, 60, null);
44
-        $process->run(function ($type, $buffer) {
44
+        $process->run(function($type, $buffer) {
45 45
             $this->line($buffer);
46 46
         });
47 47
 
48 48
         // executes after the command finishes
49
-        if (! $process->isSuccessful()) {
49
+        if (!$process->isSuccessful()) {
50 50
             throw new ProcessFailedException($process);
51 51
         }
52 52
     }
Please login to merge, or discard this patch.
tests/Unit/CrudPanel/CrudPanelOperationsTest.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -16,7 +16,7 @@
 block discarded – undo
16 16
 
17 17
     public function testItCanConfigureOperations()
18 18
     {
19
-        $this->crudPanel->operation(['create', 'update'], function () {
19
+        $this->crudPanel->operation(['create', 'update'], function() {
20 20
             $this->crudPanel->addField(['name' => 'test', 'type' => 'text']);
21 21
         });
22 22
         $this->crudPanel->applyConfigurationFromSettings('create');
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/SaveActions.php 1 patch
Spacing   +16 added lines, -17 removed lines patch added patch discarded remove patch
@@ -28,7 +28,7 @@  discard block
 block discarded – undo
28 28
         $higherAction = $this->getSaveActionByOrder(1);
29 29
 
30 30
         //if there is an higher action and that action is not the backpack default higher one `save_and_back` we return it.
31
-        if (! empty($higherAction) && key($higherAction) !== 'save_and_back') {
31
+        if (!empty($higherAction) && key($higherAction) !== 'save_and_back') {
32 32
             return key($higherAction);
33 33
         }
34 34
 
@@ -47,7 +47,7 @@  discard block
 block discarded – undo
47 47
      */
48 48
     public function getSaveActionByOrder($order)
49 49
     {
50
-        return array_filter($this->getOperationSetting('save_actions') ?? [], function ($arr) use ($order) {
50
+        return array_filter($this->getOperationSetting('save_actions') ?? [], function($arr) use ($order) {
51 51
             return $arr['order'] == $order;
52 52
         });
53 53
     }
@@ -81,7 +81,7 @@  discard block
 block discarded – undo
81 81
         $orderCounter = $this->getOperationSetting('save_actions') !== null ? (count($this->getOperationSetting('save_actions')) + 1) : 1;
82 82
         //check for some mandatory fields
83 83
         $saveAction['name'] ?? abort(500, 'Please define save action name.');
84
-        $saveAction['redirect'] = $saveAction['redirect'] ?? function ($crud, $request, $itemId) {
84
+        $saveAction['redirect'] = $saveAction['redirect'] ?? function($crud, $request, $itemId) {
85 85
             return $request->has('_http_referrer') ? $request->get('_http_referrer') : $crud->route;
86 86
         };
87 87
         $saveAction['visible'] = $saveAction['visible'] ?? true;
@@ -90,7 +90,7 @@  discard block
 block discarded – undo
90 90
 
91 91
         $actions = $this->getOperationSetting('save_actions') ?? [];
92 92
 
93
-        if (! in_array($saveAction['name'], $actions)) {
93
+        if (!in_array($saveAction['name'], $actions)) {
94 94
             $actions[$saveAction['name']] = $saveAction;
95 95
         }
96 96
 
@@ -107,7 +107,7 @@  discard block
 block discarded – undo
107 107
     public function orderSaveAction(string $saveAction, int $wantedOrder)
108 108
     {
109 109
         $actions = $this->getOperationSetting('save_actions') ?? [];
110
-        if (! empty($actions)) {
110
+        if (!empty($actions)) {
111 111
             $replaceOrder = isset($actions[$saveAction]) ? $actions[$saveAction]['order'] : count($actions) + 1;
112 112
 
113 113
             foreach ($actions as $key => $sv) {
@@ -201,7 +201,7 @@  discard block
 block discarded – undo
201 201
     public function orderSaveActions(array $saveActions)
202 202
     {
203 203
         foreach ($saveActions as $sv => $order) {
204
-            if (! is_int($order)) {
204
+            if (!is_int($order)) {
205 205
                 $this->orderSaveAction($order, $sv + 1);
206 206
             } else {
207 207
                 $this->orderSaveAction($sv, $order);
@@ -218,7 +218,7 @@  discard block
 block discarded – undo
218 218
     {
219 219
         $actions = $this->getOperationSetting('save_actions') ?? [];
220 220
 
221
-        uasort($actions, function ($a, $b) {
221
+        uasort($actions, function($a, $b) {
222 222
             return $a['order'] <=> $b['order'];
223 223
         });
224 224
 
@@ -240,7 +240,7 @@  discard block
 block discarded – undo
240 240
             }
241 241
         }
242 242
 
243
-        return array_filter($actions, function ($action) {
243
+        return array_filter($actions, function($action) {
244 244
             return $action['visible'] == true;
245 245
         }, ARRAY_FILTER_USE_BOTH);
246 246
     }
@@ -303,8 +303,7 @@  discard block
 block discarded – undo
303 303
      */
304 304
     public function setSaveAction($forceSaveAction = null)
305 305
     {
306
-        $saveAction = $forceSaveAction ?:
307
-            \Request::input('_save_action', $this->getFallBackSaveAction());
306
+        $saveAction = $forceSaveAction ?: \Request::input('_save_action', $this->getFallBackSaveAction());
308 307
 
309 308
         $showBubble = $this->getOperationSetting('showSaveActionChange') ?? config('backpack.crud.operations.'.$this->getCurrentOperation().'.showSaveActionChange') ?? true;
310 309
 
@@ -371,20 +370,20 @@  discard block
 block discarded – undo
371 370
         $defaultSaveActions = [
372 371
             [
373 372
                 'name' => 'save_and_back',
374
-                'visible' => function ($crud) {
373
+                'visible' => function($crud) {
375 374
                     return $crud->hasAccess('list');
376 375
                 },
377
-                'redirect' => function ($crud, $request, $itemId = null) {
376
+                'redirect' => function($crud, $request, $itemId = null) {
378 377
                     return $request->request->has('_http_referrer') ? $request->request->get('_http_referrer') : $crud->route;
379 378
                 },
380 379
                 'button_text' => trans('backpack::crud.save_action_save_and_back'),
381 380
             ],
382 381
             [
383 382
                 'name' => 'save_and_edit',
384
-                'visible' => function ($crud) {
383
+                'visible' => function($crud) {
385 384
                     return $crud->hasAccess('update');
386 385
                 },
387
-                'redirect' => function ($crud, $request, $itemId = null) {
386
+                'redirect' => function($crud, $request, $itemId = null) {
388 387
                     $itemId = $itemId ?: $request->request->get('id');
389 388
                     $redirectUrl = $crud->route.'/'.$itemId.'/edit';
390 389
                     if ($request->request->has('_locale')) {
@@ -396,17 +395,17 @@  discard block
 block discarded – undo
396 395
 
397 396
                     return $redirectUrl;
398 397
                 },
399
-                'referrer_url' => function ($crud, $request, $itemId) {
398
+                'referrer_url' => function($crud, $request, $itemId) {
400 399
                     return url($crud->route.'/'.$itemId.'/edit');
401 400
                 },
402 401
                 'button_text' => trans('backpack::crud.save_action_save_and_edit'),
403 402
             ],
404 403
             [
405 404
                 'name' => 'save_and_new',
406
-                'visible' => function ($crud) {
405
+                'visible' => function($crud) {
407 406
                     return $crud->hasAccess('create');
408 407
                 },
409
-                'redirect' => function ($crud, $request, $itemId = null) {
408
+                'redirect' => function($crud, $request, $itemId = null) {
410 409
                     return $this->route.'/create';
411 410
                 },
412 411
                 'button_text' => trans('backpack::crud.save_action_save_and_new'),
Please login to merge, or discard this patch.