Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Passed
Push — next ( b21d8c...53c4ef )
by Cristian
31:11 queued 15:41
created
src/app/Library/Validation/Rules/ValidUploadMultiple.php 1 patch
Spacing   +3 added lines, -4 removed lines patch added patch discarded remove patch
@@ -21,8 +21,7 @@  discard block
 block discarded – undo
21 21
         }
22 22
 
23 23
         $previousValues = str_contains($attribute, '.') ?
24
-                            (Arr::get($entry?->{Str::before($attribute, '.')} ?? [], Str::after($attribute, '.')) ?? []) :
25
-                            ($entry?->{$attribute} ?? []);
24
+                            (Arr::get($entry?->{Str::before($attribute, '.')} ?? [], Str::after($attribute, '.')) ?? []) : ($entry?->{$attribute} ?? []);
26 25
 
27 26
         if (is_string($previousValues)) {
28 27
             $previousValues = json_decode($previousValues, true) ?? [];
@@ -39,7 +38,7 @@  discard block
 block discarded – undo
39 38
        
40 39
         // if there is no entry, the values we are going to validate need to be files
41 40
         // the request was tampered so we will set the attribute to null
42
-        if (! $entry && ! empty(Arr::get($data, $attribute)) && ! $this->allFiles(Arr::get($data, $attribute))) {
41
+        if (!$entry && !empty(Arr::get($data, $attribute)) && !$this->allFiles(Arr::get($data, $attribute))) {
43 42
             Arr::set($data, $attribute, null);
44 43
         }
45 44
 
@@ -50,7 +49,7 @@  discard block
 block discarded – undo
50 49
     private function allFiles(array $values): bool
51 50
     {
52 51
         foreach ($values as $value) {
53
-            if (! $value instanceof \Illuminate\Http\UploadedFile) {
52
+            if (!$value instanceof \Illuminate\Http\UploadedFile) {
54 53
                 return false;
55 54
             }
56 55
         }
Please login to merge, or discard this patch.
src/app/Library/Validation/Rules/ValidUpload.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -20,7 +20,7 @@  discard block
 block discarded – undo
20 20
 
21 21
         // if the attribute is not set in the request, and an entry exists,
22 22
         // we will check if there is a previous value, as this field might not have changed.
23
-        if (! Arr::has($this->data, $attribute) && $entry) {
23
+        if (!Arr::has($this->data, $attribute) && $entry) {
24 24
             if (str_contains($attribute, '.') && get_class($entry) === get_class(CrudPanelFacade::getModel())) {
25 25
                 $previousValue = Arr::get($this->data, '_order_'.Str::before($attribute, '.'));
26 26
                 $previousValue = Arr::get($previousValue, Str::after($attribute, '.'));
@@ -37,25 +37,25 @@  discard block
 block discarded – undo
37 37
 
38 38
         // if the value is an uploaded file, or the attribute is not
39 39
         // set in the request, we force fill the data with the value
40
-        if ($value instanceof UploadedFile || ! Arr::has($this->data, $attribute)) {
40
+        if ($value instanceof UploadedFile || !Arr::has($this->data, $attribute)) {
41 41
             Arr::set($this->data, $attribute, $value);
42 42
         }
43 43
 
44 44
         // if there are no entry, and the new value it's not a file ... well we don't want it at all.
45
-        if (! $entry && ! $value instanceof UploadedFile) {
45
+        if (!$entry && !$value instanceof UploadedFile) {
46 46
             Arr::set($this->data, $attribute, null);
47 47
         }
48 48
         
49 49
         $fieldErrors = $this->validateFieldRules($attribute);
50 50
 
51
-        if (! empty($value) && ! empty($this->getFileRules())) {
51
+        if (!empty($value) && !empty($this->getFileRules())) {
52 52
             $fileErrors = $this->validateFileRules($attribute, $value);
53 53
         }
54 54
 
55 55
         return array_merge($fieldErrors, $fileErrors ?? []);
56 56
     }
57 57
 
58
-    public static function field(string|array|ValidationRule|Rule $rules = []): self
58
+    public static function field(string | array | ValidationRule | Rule $rules = []): self
59 59
     {
60 60
         return parent::field($rules);
61 61
     }
Please login to merge, or discard this patch.
tests/Feature/UploadersTest.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -62,7 +62,7 @@  discard block
 block discarded – undo
62 62
 
63 63
         $this->assertDatabaseHas('uploaders', [
64 64
             'upload' => 'avatar1.jpg',
65
-            'upload_multiple' => json_encode(['avatar2.jpg',  'avatar3.jpg']),
65
+            'upload_multiple' => json_encode(['avatar2.jpg', 'avatar3.jpg']),
66 66
         ]);
67 67
 
68 68
         $this->assertTrue(Storage::disk('uploaders')->exists('avatar1.jpg'));
@@ -97,7 +97,7 @@  discard block
 block discarded – undo
97 97
         $response = $this->put($this->testBaseUrl.'/1', [
98 98
             'upload' => $this->getUploadedFile('avatar4.jpg'),
99 99
             'upload_multiple' => $this->getUploadedFiles(['avatar5.jpg', 'avatar6.jpg']),
100
-            'clear_upload_multiple' => ['avatar2.jpg',  'avatar3.jpg'],
100
+            'clear_upload_multiple' => ['avatar2.jpg', 'avatar3.jpg'],
101 101
             'id' => 1,
102 102
         ]);
103 103
 
@@ -109,7 +109,7 @@  discard block
 block discarded – undo
109 109
 
110 110
         $this->assertDatabaseHas('uploaders', [
111 111
             'upload' => 'avatar4.jpg',
112
-            'upload_multiple' => json_encode(['avatar5.jpg',  'avatar6.jpg']),
112
+            'upload_multiple' => json_encode(['avatar5.jpg', 'avatar6.jpg']),
113 113
         ]);
114 114
 
115 115
         $files = Storage::disk('uploaders')->allFiles();
@@ -138,7 +138,7 @@  discard block
 block discarded – undo
138 138
 
139 139
         $this->assertDatabaseHas('uploaders', [
140 140
             'upload' => null,
141
-            'upload_multiple' => json_encode(['avatar2.jpg',  'avatar3.jpg']),
141
+            'upload_multiple' => json_encode(['avatar2.jpg', 'avatar3.jpg']),
142 142
         ]);
143 143
 
144 144
         $files = Storage::disk('uploaders')->allFiles();
@@ -168,7 +168,7 @@  discard block
 block discarded – undo
168 168
         self::initUploaderWithFiles();
169 169
 
170 170
         $response = $this->put($this->testBaseUrl.'/1', [
171
-            'upload_multiple' => ['avatar2.jpg',  'avatar3.jpg'],
171
+            'upload_multiple' => ['avatar2.jpg', 'avatar3.jpg'],
172 172
             'id' => 1,
173 173
         ]);
174 174
 
@@ -180,7 +180,7 @@  discard block
 block discarded – undo
180 180
 
181 181
         $this->assertDatabaseHas('uploaders', [
182 182
             'upload' => 'avatar1.jpg',
183
-            'upload_multiple' => json_encode(['avatar2.jpg',  'avatar3.jpg']),
183
+            'upload_multiple' => json_encode(['avatar2.jpg', 'avatar3.jpg']),
184 184
         ]);
185 185
 
186 186
         $files = Storage::disk('uploaders')->allFiles();
@@ -210,7 +210,7 @@  discard block
 block discarded – undo
210 210
 
211 211
         $this->assertDatabaseHas('uploaders', [
212 212
             'upload' => 'avatar1.jpg',
213
-            'upload_multiple' => json_encode(['avatar3.jpg', 'avatar4.jpg',  'avatar5.jpg']),
213
+            'upload_multiple' => json_encode(['avatar3.jpg', 'avatar4.jpg', 'avatar5.jpg']),
214 214
         ]);
215 215
 
216 216
         $files = Storage::disk('uploaders')->allFiles();
@@ -231,7 +231,7 @@  discard block
 block discarded – undo
231 231
 
232 232
         Uploader::create([
233 233
             'upload' => 'avatar1.jpg',
234
-            'upload_multiple' => json_encode(['avatar2.jpg',  'avatar3.jpg']),
234
+            'upload_multiple' => json_encode(['avatar2.jpg', 'avatar3.jpg']),
235 235
         ]);
236 236
     }
237 237
 
Please login to merge, or discard this patch.
tests/Feature/FakeUploadersTest.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -93,7 +93,7 @@  discard block
 block discarded – undo
93 93
             '_method' => 'PUT',
94 94
             'upload' => $this->getUploadedFile('avatar4.jpg'),
95 95
             'upload_multiple' => $this->getUploadedFiles(['avatar5.jpg', 'avatar6.jpg']),
96
-            'clear_upload_multiple' => ['avatar2.jpg',  'avatar3.jpg'],
96
+            'clear_upload_multiple' => ['avatar2.jpg', 'avatar3.jpg'],
97 97
             'id' => 1,
98 98
         ]);
99 99
 
@@ -173,7 +173,7 @@  discard block
 block discarded – undo
173 173
         $this->assertDatabaseCount('uploaders', 1);
174 174
 
175 175
         $this->assertDatabaseHas('uploaders', [
176
-            'extras' => json_encode(['upload_multiple' => ['avatar2.jpg',  'avatar3.jpg'], 'upload' => 'avatar1.jpg']),
176
+            'extras' => json_encode(['upload_multiple' => ['avatar2.jpg', 'avatar3.jpg'], 'upload' => 'avatar1.jpg']),
177 177
         ]);
178 178
 
179 179
         $files = Storage::disk('uploaders')->allFiles();
@@ -190,7 +190,7 @@  discard block
 block discarded – undo
190 190
         self::initUploaderWithFiles();
191 191
 
192 192
         $response = $this->put($this->testBaseUrl.'/1', [
193
-            'upload_multiple' => $this->getUploadedFiles(['avatar4.jpg',  'avatar5.jpg']),
193
+            'upload_multiple' => $this->getUploadedFiles(['avatar4.jpg', 'avatar5.jpg']),
194 194
             'clear_upload_multiple' => ['avatar2.jpg'],
195 195
             'id' => 1,
196 196
         ]);
@@ -202,7 +202,7 @@  discard block
 block discarded – undo
202 202
         $this->assertDatabaseCount('uploaders', 1);
203 203
 
204 204
         $this->assertDatabaseHas('uploaders', [
205
-            'extras' => json_encode(['upload_multiple' => ['avatar3.jpg', 'avatar4.jpg',  'avatar5.jpg'], 'upload' => 'avatar1.jpg']),
205
+            'extras' => json_encode(['upload_multiple' => ['avatar3.jpg', 'avatar4.jpg', 'avatar5.jpg'], 'upload' => 'avatar1.jpg']),
206 206
         ]);
207 207
 
208 208
         $files = Storage::disk('uploaders')->allFiles();
@@ -222,7 +222,7 @@  discard block
 block discarded – undo
222 222
         UploadedFile::fake()->image('avatar3.jpg')->storeAs('', 'avatar3.jpg', ['disk' => 'uploaders']);
223 223
 
224 224
         FakeUploader::create([
225
-            'extras' => ['upload' => 'avatar1.jpg', 'upload_multiple' => ['avatar2.jpg',  'avatar3.jpg']],
225
+            'extras' => ['upload' => 'avatar1.jpg', 'upload_multiple' => ['avatar2.jpg', 'avatar3.jpg']],
226 226
         ]);
227 227
     }
228 228
 
Please login to merge, or discard this patch.
tests/Feature/UploadersValidationTest.php 1 patch
Spacing   +12 added lines, -12 removed lines patch added patch discarded remove patch
@@ -62,7 +62,7 @@  discard block
 block discarded – undo
62 62
 
63 63
         $this->assertDatabaseHas('uploaders', [
64 64
             'upload' => 'avatar1.jpg',
65
-            'upload_multiple' => json_encode(['avatar2.jpg',  'avatar3.jpg']),
65
+            'upload_multiple' => json_encode(['avatar2.jpg', 'avatar3.jpg']),
66 66
         ]);
67 67
 
68 68
         $this->assertTrue(Storage::disk('uploaders')->exists('avatar1.jpg'));
@@ -97,8 +97,8 @@  discard block
 block discarded – undo
97 97
 
98 98
         $response = $this->put($this->testBaseUrl.'/1', [
99 99
             'upload' => $this->getUploadedFile('avatar4.jpg'),
100
-            'upload_multiple' => $this->getUploadedFiles(['avatar5.jpg',  'avatar6.jpg']),
101
-            'clear_upload_multiple' => ['avatar2.jpg',  'avatar3.jpg'],
100
+            'upload_multiple' => $this->getUploadedFiles(['avatar5.jpg', 'avatar6.jpg']),
101
+            'clear_upload_multiple' => ['avatar2.jpg', 'avatar3.jpg'],
102 102
             'id' => 1,
103 103
         ]);
104 104
 
@@ -110,7 +110,7 @@  discard block
 block discarded – undo
110 110
 
111 111
         $this->assertDatabaseHas('uploaders', [
112 112
             'upload' => 'avatar4.jpg',
113
-            'upload_multiple' => json_encode(['avatar5.jpg',  'avatar6.jpg']),
113
+            'upload_multiple' => json_encode(['avatar5.jpg', 'avatar6.jpg']),
114 114
         ]);
115 115
 
116 116
         $files = Storage::disk('uploaders')->allFiles();
@@ -142,7 +142,7 @@  discard block
 block discarded – undo
142 142
         self::initUploaderWithFiles();
143 143
 
144 144
         $response = $this->put($this->testBaseUrl.'/1', [
145
-            'upload_multiple' => ['avatar2.jpg',  'avatar3.jpg'],
145
+            'upload_multiple' => ['avatar2.jpg', 'avatar3.jpg'],
146 146
             'id' => 1,
147 147
         ]);
148 148
 
@@ -154,7 +154,7 @@  discard block
 block discarded – undo
154 154
 
155 155
         $this->assertDatabaseHas('uploaders', [
156 156
             'upload' => 'avatar1.jpg',
157
-            'upload_multiple' => json_encode(['avatar2.jpg',  'avatar3.jpg']),
157
+            'upload_multiple' => json_encode(['avatar2.jpg', 'avatar3.jpg']),
158 158
         ]);
159 159
 
160 160
         $files = Storage::disk('uploaders')->allFiles();
@@ -171,7 +171,7 @@  discard block
 block discarded – undo
171 171
         self::initUploaderWithFiles();
172 172
 
173 173
         $response = $this->put($this->testBaseUrl.'/1', [
174
-            'upload_multiple' => $this->getUploadedFiles(['avatar4.jpg',  'avatar5.jpg']),
174
+            'upload_multiple' => $this->getUploadedFiles(['avatar4.jpg', 'avatar5.jpg']),
175 175
             'clear_upload_multiple' => ['avatar2.jpg'],
176 176
             'id' => 1,
177 177
         ]);
@@ -184,7 +184,7 @@  discard block
 block discarded – undo
184 184
 
185 185
         $this->assertDatabaseHas('uploaders', [
186 186
             'upload' => 'avatar1.jpg',
187
-            'upload_multiple' => json_encode(['avatar3.jpg', 'avatar4.jpg',  'avatar5.jpg']),
187
+            'upload_multiple' => json_encode(['avatar3.jpg', 'avatar4.jpg', 'avatar5.jpg']),
188 188
         ]);
189 189
 
190 190
         $files = Storage::disk('uploaders')->allFiles();
@@ -341,7 +341,7 @@  discard block
 block discarded – undo
341 341
         $response = $this->put($this->testBaseUrl.'/1', [
342 342
             'upload' => null,
343 343
             'upload_multiple' => null,
344
-            'clear_upload_multiple' => ['avatar2.jpg',  'avatar3.jpg'],
344
+            'clear_upload_multiple' => ['avatar2.jpg', 'avatar3.jpg'],
345 345
             'id' => 1,
346 346
         ]);
347 347
 
@@ -364,7 +364,7 @@  discard block
 block discarded – undo
364 364
 
365 365
         $response = $this->put($this->testBaseUrl.'/1', [
366 366
             'upload_multiple' => $this->getUploadedFiles(['avatar2.jpg']),
367
-            'clear_upload_multiple' => ['avatar2.jpg',  'avatar3.jpg'],
367
+            'clear_upload_multiple' => ['avatar2.jpg', 'avatar3.jpg'],
368 368
             'id' => 1,
369 369
         ]);
370 370
 
@@ -386,7 +386,7 @@  discard block
 block discarded – undo
386 386
 
387 387
         Uploader::create([
388 388
             'upload' => 'avatar1.jpg',
389
-            'upload_multiple' => json_encode(['avatar2.jpg',  'avatar3.jpg']),
389
+            'upload_multiple' => json_encode(['avatar2.jpg', 'avatar3.jpg']),
390 390
         ]);
391 391
     }
392 392
 
@@ -398,7 +398,7 @@  discard block
 block discarded – undo
398 398
 
399 399
         Uploader::create([
400 400
             'upload' => 'avatar1.jpg',
401
-            'upload_multiple' => json_encode(['avatar2.jpg',  'avatar3.jpg']),
401
+            'upload_multiple' => json_encode(['avatar2.jpg', 'avatar3.jpg']),
402 402
         ]);
403 403
     }
404 404
 
Please login to merge, or discard this patch.
tests/config/Uploads/HasUploadedFiles.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -13,7 +13,7 @@
 block discarded – undo
13 13
 
14 14
     protected function getUploadedFiles(array $fileNames, string $mime = 'image/jpg')
15 15
     {
16
-        return array_map(function ($fileName) use ($mime) {
16
+        return array_map(function($fileName) use ($mime) {
17 17
             return new UploadedFile(__DIR__.'/assets/'.$fileName, $fileName, $mime, null, true);
18 18
         }, $fileNames);
19 19
     }
Please login to merge, or discard this patch.
src/app/Library/Database/DatabaseSchema.php 1 patch
Spacing   +6 added lines, -7 removed lines patch added patch discarded remove patch
@@ -26,7 +26,7 @@  discard block
 block discarded – undo
26 26
     {
27 27
         $connection = $connection ?: config('database.default');
28 28
 
29
-        self::$schema[$connection] = LazyCollection::make(self::getCreateSchema($connection)->getTables())->mapWithKeys(function ($table, $key) use ($connection) {
29
+        self::$schema[$connection] = LazyCollection::make(self::getCreateSchema($connection)->getTables())->mapWithKeys(function($table, $key) use ($connection) {
30 30
             $tableName = is_array($table) ? $table['name'] : $table->getName();
31 31
 
32 32
             if ($existingTable = self::$schema[$connection][$tableName] ?? false) {
@@ -65,7 +65,7 @@  discard block
 block discarded – undo
65 65
      */
66 66
     private static function generateDatabaseSchema(string $connection, string $table)
67 67
     {
68
-        if (! isset(self::$schema[$connection][$table])) {
68
+        if (!isset(self::$schema[$connection][$table])) {
69 69
             self::$schema[$connection][$table] = self::mapTable($connection, $table);
70 70
         }
71 71
     }
@@ -74,13 +74,12 @@  discard block
 block discarded – undo
74 74
     {
75 75
         try {
76 76
             $table = method_exists(self::getCreateSchema($connection), 'getTable') ?
77
-                        self::getCreateSchema($connection)->getTable($tableName) :
78
-                        self::getCreateSchema($connection)->getColumns($tableName);
77
+                        self::getCreateSchema($connection)->getTable($tableName) : self::getCreateSchema($connection)->getColumns($tableName);
79 78
         } catch (\Exception $e) {
80 79
             return new Table($tableName, []);
81 80
         }
82 81
 
83
-        if (! is_array($table)) {
82
+        if (!is_array($table)) {
84 83
             return $table;
85 84
         }
86 85
 
@@ -91,7 +90,7 @@  discard block
 block discarded – undo
91 90
         $schemaManager = self::getSchemaManager($connection);
92 91
         $indexes = $schemaManager->getIndexes($tableName);
93 92
 
94
-        $indexes = array_map(function ($index) {
93
+        $indexes = array_map(function($index) {
95 94
             return $index['columns'];
96 95
         }, $indexes);
97 96
 
@@ -109,7 +108,7 @@  discard block
 block discarded – undo
109 108
 
110 109
         $indexes = self::$schema[$connection][$table]->getIndexes();
111 110
 
112
-        $indexes = \Illuminate\Support\Arr::flatten(array_map(function ($index) {
111
+        $indexes = \Illuminate\Support\Arr::flatten(array_map(function($index) {
113 112
             return is_string($index) ? $index : $index->getColumns();
114 113
         }, $indexes));
115 114
 
Please login to merge, or discard this patch.
src/app/Library/Uploaders/SingleFile.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -29,7 +29,7 @@  discard block
 block discarded – undo
29 29
             return $this->getPath().$fileName;
30 30
         }
31 31
 
32
-        if (! $value && CrudPanelFacade::getRequest()->has($this->getNameForRequest()) && $previousFile) {
32
+        if (!$value && CrudPanelFacade::getRequest()->has($this->getNameForRequest()) && $previousFile) {
33 33
             Storage::disk($this->getDisk())->delete($previousFile);
34 34
 
35 35
             return null;
@@ -55,10 +55,10 @@  discard block
 block discarded – undo
55 55
 
56 56
         foreach ($previousRepeatableValues as $row => $file) {
57 57
             if ($file) {
58
-                if (! isset($orderedFiles[$row])) {
58
+                if (!isset($orderedFiles[$row])) {
59 59
                     $orderedFiles[$row] = null;
60 60
                 }
61
-                if (! in_array($file, $orderedFiles)) {
61
+                if (!in_array($file, $orderedFiles)) {
62 62
                     Storage::disk($this->getDisk())->delete($file);
63 63
                 }
64 64
             }
Please login to merge, or discard this patch.
src/app/Console/Commands/Themes/InstallsTheme.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -71,7 +71,7 @@  discard block
 block discarded – undo
71 71
         }
72 72
 
73 73
         // Display general error in case it failed
74
-        if (! $this->isInstalled()) {
74
+        if (!$this->isInstalled()) {
75 75
             $this->errorProgressBlock();
76 76
             $this->note('For further information please check the log file.');
77 77
             $this->note('You can also follow the manual installation process documented on GitHub.');
@@ -84,7 +84,7 @@  discard block
 block discarded – undo
84 84
         $this->progressBlock('Publish theme config file');
85 85
 
86 86
         // manually include the provider in the run-time
87
-        if (! class_exists(self::$addon['provider'])) {
87
+        if (!class_exists(self::$addon['provider'])) {
88 88
             include self::$addon['provider_path'] ?? self::$addon['path'].'/src/AddonServiceProvider.php';
89 89
             app()->register(self::$addon['provider']);
90 90
         }
Please login to merge, or discard this patch.