Laravel-Backpack / CRUD

src/app/Http/Requests/ChangePasswordRequest.php

Unused Use Statements +1 added lines, -1 removed lines

@@ -2,8 +2,8 @@
 
 namespace Backpack\CRUD\app\Http\Requests;
 
-use Illuminate\Support\Facades\Hash;
 use Illuminate\Foundation\Http\FormRequest;
+use Illuminate\Support\Facades\Hash;
 
 class ChangePasswordRequest extends FormRequest
 {

Spacing +2 added lines, -2 removed lines

@@ -41,9 +41,9 @@
      */
     public function withValidator($validator)
     {
-        $validator->after(function ($validator) {
+        $validator->after(function($validator) {
             // check old password matches
-            if (! Hash::check($this->input('old_password'), backpack_auth()->user()->password)) {
+            if (!Hash::check($this->input('old_password'), backpack_auth()->user()->password)) {
                 $validator->errors()->add('old_password', trans('backpack::base.old_password_incorrect'));
             }
         });

src/app/Library/CrudPanel/CrudPanel.php

Unused Use Statements +17 added lines, -17 removed lines

@@ -2,33 +2,33 @@
 
 namespace Backpack\CRUD\app\Library\CrudPanel;
 
-use Illuminate\Database\Eloquent\Collection;
-use Backpack\CRUD\app\Library\CrudPanel\Traits\Read;
-use Backpack\CRUD\app\Library\CrudPanel\Traits\Tabs;
-use Backpack\CRUD\app\Library\CrudPanel\Traits\Query;
-use Backpack\CRUD\app\Library\CrudPanel\Traits\Views;
 use Backpack\CRUD\app\Library\CrudPanel\Traits\Access;
+use Backpack\CRUD\app\Library\CrudPanel\Traits\AutoFocus;
+use Backpack\CRUD\app\Library\CrudPanel\Traits\AutoSet;
+use Backpack\CRUD\app\Library\CrudPanel\Traits\Buttons;
+use Backpack\CRUD\app\Library\CrudPanel\Traits\Columns;
 use Backpack\CRUD\app\Library\CrudPanel\Traits\Create;
 use Backpack\CRUD\app\Library\CrudPanel\Traits\Delete;
 use Backpack\CRUD\app\Library\CrudPanel\Traits\Errors;
+use Backpack\CRUD\app\Library\CrudPanel\Traits\FakeColumns;
+use Backpack\CRUD\app\Library\CrudPanel\Traits\FakeFields;
 use Backpack\CRUD\app\Library\CrudPanel\Traits\Fields;
-use Backpack\CRUD\app\Library\CrudPanel\Traits\Search;
-use Backpack\CRUD\app\Library\CrudPanel\Traits\Update;
-use Backpack\CRUD\app\Library\CrudPanel\Traits\AutoSet;
-use Backpack\CRUD\app\Library\CrudPanel\Traits\Buttons;
-use Backpack\CRUD\app\Library\CrudPanel\Traits\Columns;
 use Backpack\CRUD\app\Library\CrudPanel\Traits\Filters;
-use Backpack\CRUD\app\Library\CrudPanel\Traits\Reorder;
-use Backpack\CRUD\app\Library\CrudPanel\Traits\Settings;
-use Backpack\CRUD\app\Library\CrudPanel\Traits\AutoFocus;
+use Backpack\CRUD\app\Library\CrudPanel\Traits\HeadingsAndTitles;
 use Backpack\CRUD\app\Library\CrudPanel\Traits\Macroable;
-use Backpack\CRUD\app\Library\CrudPanel\Traits\FakeFields;
 use Backpack\CRUD\app\Library\CrudPanel\Traits\Operations;
-use Backpack\CRUD\app\Library\CrudPanel\Traits\Validation;
-use Backpack\CRUD\app\Library\CrudPanel\Traits\FakeColumns;
+use Backpack\CRUD\app\Library\CrudPanel\Traits\Query;
+use Backpack\CRUD\app\Library\CrudPanel\Traits\Read;
+use Backpack\CRUD\app\Library\CrudPanel\Traits\Reorder;
 use Backpack\CRUD\app\Library\CrudPanel\Traits\SaveActions;
-use Backpack\CRUD\app\Library\CrudPanel\Traits\HeadingsAndTitles;
+use Backpack\CRUD\app\Library\CrudPanel\Traits\Search;
+use Backpack\CRUD\app\Library\CrudPanel\Traits\Settings;
+use Backpack\CRUD\app\Library\CrudPanel\Traits\Tabs;
+use Backpack\CRUD\app\Library\CrudPanel\Traits\Update;
+use Backpack\CRUD\app\Library\CrudPanel\Traits\Validation;
+use Backpack\CRUD\app\Library\CrudPanel\Traits\Views;
 use Backpack\CRUD\app\Library\CrudPanel\Traits\ViewsAndRestoresRevisions;
+use Illuminate\Database\Eloquent\Collection;
 
 class CrudPanel
 {

Spacing +11 added lines, -11 removed lines

@@ -76,11 +76,11 @@ 
      */
     public function setModel($model_namespace)
     {
-        if (! class_exists($model_namespace)) {
+        if (!class_exists($model_namespace)) {
             throw new \Exception('The model does not exist.', 500);
         }
 
-        if (! method_exists($model_namespace, 'hasCrudTrait')) {
+        if (!method_exists($model_namespace, 'hasCrudTrait')) {
             throw new \Exception('Please use CrudTrait on the model.', 500);
         }
 
@@ -143,7 +143,7 @@ 
     {
         $complete_route = $route.'.index';
 
-        if (! \Route::has($complete_route)) {
+        if (!\Route::has($complete_route)) {
             throw new \Exception('There are no routes for this route name.', 404);
         }
 
@@ -244,7 +244,7 @@ 
      */
     public function getFirstOfItsTypeInArray($type, $array)
     {
-        return array_first($array, function ($item) use ($type) {
+        return array_first($array, function($item) use ($type) {
             return $item['type'] == $type;
         });
     }
@@ -261,8 +261,8 @@ 
 
     public function sync($type, $fields, $attributes)
     {
-        if (! empty($this->{$type})) {
-            $this->{$type} = array_map(function ($field) use ($fields, $attributes) {
+        if (!empty($this->{$type})) {
+            $this->{$type} = array_map(function($field) use ($fields, $attributes) {
                 if (in_array($field['name'], (array) $fields)) {
                     $field = array_merge($field, $attributes);
                 }
@@ -294,15 +294,15 @@ 
     {
         $relationArray = explode('.', $relationString);
 
-        if (! isset($length)) {
+        if (!isset($length)) {
             $length = count($relationArray);
         }
 
-        if (! isset($model)) {
+        if (!isset($model)) {
             $model = $this->model;
         }
 
-        $result = array_reduce(array_splice($relationArray, 0, $length), function ($obj, $method) {
+        $result = array_reduce(array_splice($relationArray, 0, $length), function($obj, $method) {
             return $obj->$method()->getRelated();
         }, $model);
 
@@ -352,7 +352,7 @@ 
         $relation = $model->{$firstRelationName};
 
         $results = [];
-        if (! empty($relation)) {
+        if (!empty($relation)) {
             if ($relation instanceof Collection) {
                 $currentResults = $relation->toArray();
             } else {
@@ -361,7 +361,7 @@ 
 
             array_shift($relationArray);
 
-            if (! empty($relationArray)) {
+            if (!empty($relationArray)) {
                 foreach ($currentResults as $currentResult) {
                     $results = array_merge($results, $this->getRelationModelInstances($currentResult, implode('.', $relationArray)));
                 }

src/app/Library/CrudPanel/Traits/AutoFocus.php

Doc Comments +3 added lines

@@ -12,6 +12,9 @@
         return $this->getOperationSetting('autoFocusOnFirstField');
     }
 
+    /**
+     * @param boolean $value
+     */
     public function setAutoFocusOnFirstField($value)
     {
         return $this->setOperationSetting('autoFocusOnFirstField', (bool) $value);

src/app/Library/CrudPanel/Traits/Create.php

Doc Comments +1 added lines, -1 removed lines

@@ -159,7 +159,7 @@
      * @param \Illuminate\Database\Eloquent\Model $item          The current CRUD model.
      * @param array                               $formattedData The form data.
      *
-     * @return bool|null
+     * @return false|null
      */
     private function createRelationsForItem($item, $formattedData)
     {

Unused Use Statements +1 added lines, -1 removed lines

@@ -2,8 +2,8 @@
 
 namespace Backpack\CRUD\app\Library\CrudPanel\Traits;
 
-use Illuminate\Database\Eloquent\Relations\HasOne;
 use Illuminate\Database\Eloquent\Relations\BelongsTo;
+use Illuminate\Database\Eloquent\Relations\HasOne;
 
 trait Create
 {

Spacing +4 added lines, -4 removed lines

@@ -81,7 +81,7 @@ 
     {
         $all_relation_fields = $this->getRelationFields();
 
-        return array_where($all_relation_fields, function ($value, $key) {
+        return array_where($all_relation_fields, function($value, $key) {
             return isset($value['pivot']) && $value['pivot'];
         });
     }
@@ -156,7 +156,7 @@ 
      */
     private function createRelationsForItem($item, $formattedData)
     {
-        if (! isset($formattedData['relations'])) {
+        if (!isset($formattedData['relations'])) {
             return false;
         }
 
@@ -213,11 +213,11 @@ 
                 $key = implode('.relations.', explode('.', $relationField['entity']));
                 $fieldData = array_get($relationData, 'relations.'.$key, []);
 
-                if (! array_key_exists('model', $fieldData)) {
+                if (!array_key_exists('model', $fieldData)) {
                     $fieldData['model'] = $relationField['model'];
                 }
 
-                if (! array_key_exists('parent', $fieldData)) {
+                if (!array_key_exists('parent', $fieldData)) {
                     $fieldData['parent'] = $this->getRelationModel($relationField['entity'], -1);
                 }
 

src/app/Library/CrudPanel/Traits/FakeFields.php

Doc Comments -2 removed lines

@@ -10,8 +10,6 @@
      * plus the '_token' and 'redirect_after_save' variables.
      *
      * @param array    $requestInput The request input.
-     * @param string   $form         The CRUD form. Can be 'create' or 'update' . Default is 'create'.
-     * @param int|bool $id           The CRUD entry id in the case of the 'update' form.
      *
      * @see \Illuminate\Http\Request::all() For an example on how to get the request input.
      *

Spacing +2 added lines, -2 removed lines

@@ -32,7 +32,7 @@ 
                     $fakeFieldKey = isset($field['store_in']) ? $field['store_in'] : 'extras';
                     $this->addCompactedField($requestInput, $fieldName, $fakeFieldKey);
 
-                    if (! in_array($fakeFieldKey, $compactedFakeFields)) {
+                    if (!in_array($fakeFieldKey, $compactedFakeFields)) {
                         $compactedFakeFields[] = $fakeFieldKey;
                     }
                 }
@@ -41,7 +41,7 @@ 
 
         // json_encode all fake_value columns if applicable in the database, so they can be properly stored and interpreted
         foreach ($compactedFakeFields as $value) {
-            if (! (property_exists($this->model, 'translatable') && in_array($value, $this->model->getTranslatableAttributes(), true)) && $this->model->shouldEncodeFake($value)) {
+            if (!(property_exists($this->model, 'translatable') && in_array($value, $this->model->getTranslatableAttributes(), true)) && $this->model->shouldEncodeFake($value)) {
                 $requestInput[$value] = json_encode($requestInput[$value]);
             }
         }

src/app/Library/CrudPanel/Traits/Search.php

Doc Comments +2 added lines, -1 removed lines

@@ -35,6 +35,7 @@ 
 
     /**
      * Apply the search logic for each CRUD column.
+     * @param string $searchTerm
      */
     public function applySearchLogicForColumn($query, $column, $searchTerm)
     {
@@ -230,7 +231,7 @@ 
      *
      * @param string   $view
      * @param array    $column
-     * @param object   $entry
+     * @param \Illuminate\Database\Eloquent\Model   $entry
      * @param bool|int $rowNumber The number shown to the user as row number (index)
      *
      * @return string

Unused Use Statements +1 added lines, -1 removed lines

@@ -2,8 +2,8 @@
 
 namespace Backpack\CRUD\app\Library\CrudPanel\Traits;
 
-use Validator;
 use Carbon\Carbon;
+use Validator;
 
 trait Search
 {

Indentation +4 added lines, -4 removed lines

@@ -210,10 +210,10 @@
         // add the details_row button to the first column
         if ($this->getOperationSetting('detailsRow')) {
             $details_row_button = \View::make('crud::columns.details_row_button')
-                                           ->with('crud', $this)
-                                           ->with('entry', $entry)
-                                           ->with('row_number', $rowNumber)
-                                           ->render();
+                                            ->with('crud', $this)
+                                            ->with('entry', $entry)
+                                            ->with('row_number', $rowNumber)
+                                            ->render();
             $row_items[0] = $details_row_button.$row_items[0];
         }
 

Spacing +4 added lines, -4 removed lines

@@ -22,9 +22,9 @@ 
      */
     public function applySearchTerm($searchTerm)
     {
-        return $this->query->where(function ($query) use ($searchTerm) {
+        return $this->query->where(function($query) use ($searchTerm) {
             foreach ($this->columns() as $column) {
-                if (! isset($column['type'])) {
+                if (!isset($column['type'])) {
                     abort(400, 'Missing column type when trying to apply search term.');
                 }
 
@@ -82,7 +82,7 @@ 
 
                 case 'select':
                 case 'select_multiple':
-                    $query->orWhereHas($column['entity'], function ($q) use ($column, $searchTerm) {
+                    $query->orWhereHas($column['entity'], function($q) use ($column, $searchTerm) {
                         $q->where($column['attribute'], 'like', '%'.$searchTerm.'%');
                     });
                     break;
@@ -274,7 +274,7 @@ 
      */
     private function renderCellView($view, $column, $entry, $rowNumber = false)
     {
-        if (! view()->exists($view)) {
+        if (!view()->exists($view)) {
             $view = 'crud::columns.text'; // fallback to text column
         }
 

src/app/Library/CrudPanel/Traits/Tabs.php

Doc Comments +3 added lines

@@ -35,6 +35,9 @@
         return ! $this->tabsEnabled();
     }
 
+    /**
+     * @param string $type
+     */
     public function setTabsType($type)
     {
         $this->enableTabs();

Spacing +7 added lines, -7 removed lines

@@ -32,7 +32,7 @@ 
      */
     public function tabsDisabled()
     {
-        return ! $this->tabsEnabled();
+        return !$this->tabsEnabled();
     }
 
     public function setTabsType($type)
@@ -114,8 +114,8 @@ 
     {
         $all_fields = $this->getCurrentFields();
 
-        $fields_without_a_tab = collect($all_fields)->filter(function ($value, $key) {
-            return ! isset($value['tab']);
+        $fields_without_a_tab = collect($all_fields)->filter(function($value, $key) {
+            return !isset($value['tab']);
         });
 
         return $fields_without_a_tab;
@@ -131,7 +131,7 @@ 
         if ($this->tabExists($label)) {
             $all_fields = $this->getCurrentFields();
 
-            $fields_for_current_tab = collect($all_fields)->filter(function ($value, $key) use ($label) {
+            $fields_for_current_tab = collect($all_fields)->filter(function($value, $key) use ($label) {
                 return isset($value['tab']) && $value['tab'] == $label;
             });
 
@@ -150,11 +150,11 @@ 
         $fields = $this->getCurrentFields();
 
         $fields_with_tabs = collect($fields)
-            ->filter(function ($value, $key) {
+            ->filter(function($value, $key) {
                 return isset($value['tab']);
             })
-            ->each(function ($value, $key) use (&$tabs) {
-                if (! in_array($value['tab'], $tabs)) {
+            ->each(function($value, $key) use (&$tabs) {
+                if (!in_array($value['tab'], $tabs)) {
                     $tabs[] = $value['tab'];
                 }
             });

src/app/Models/Traits/CrudTrait.php

Doc Comments +1 added lines, -1 removed lines

@@ -69,7 +69,7 @@
      *
      * @param array $columns - the database columns that contain the JSONs
      *
-     * @return Model
+     * @return CrudTrait
      */
     public function withFakes($columns = [])
     {

Unused Use Statements +2 added lines, -2 removed lines

@@ -3,9 +3,9 @@
 namespace Backpack\CRUD\app\Models\Traits;
 
 use DB;
-use Traversable;
-use Illuminate\Support\Facades\Config;
 use Illuminate\Database\Eloquent\Model;
+use Illuminate\Support\Facades\Config;
+use Traversable;
 
 trait CrudTrait
 {

Spacing +6 added lines, -6 removed lines

@@ -69,7 +69,7 @@ 
         $conn->getDoctrineSchemaManager()->getDatabasePlatform()->registerDoctrineTypeMapping('json', 'json_array');
         $conn->getDoctrineSchemaManager()->getDatabasePlatform()->registerDoctrineTypeMapping('jsonb', 'json_array');
 
-        return ! $conn->getDoctrineColumn($table, $column_name)->getNotnull();
+        return !$conn->getDoctrineColumn($table, $column_name)->getNotnull();
     }
 
     /*
@@ -86,7 +86,7 @@ 
     public function addFakes($columns = ['extras'])
     {
         foreach ($columns as $key => $column) {
-            if (! isset($this->attributes[$column])) {
+            if (!isset($this->attributes[$column])) {
                 continue;
             }
 
@@ -134,7 +134,7 @@ 
      */
     public function shouldDecodeFake($column)
     {
-        return ! in_array($column, array_keys($this->casts));
+        return !in_array($column, array_keys($this->casts));
     }
 
     /**
@@ -145,7 +145,7 @@ 
      */
     public function shouldEncodeFake($column)
     {
-        return ! in_array($column, array_keys($this->casts));
+        return !in_array($column, array_keys($this->casts));
     }
 
     /*
@@ -219,7 +219,7 @@ 
     public function uploadMultipleFilesToDisk($value, $attribute_name, $disk, $destination_path)
     {
         $request = \Request::instance();
-        if (! is_array($this->{$attribute_name})) {
+        if (!is_array($this->{$attribute_name})) {
             $attribute_value = json_decode($this->{$attribute_name}, true) ?? [];
         } else {
             $attribute_value = $this->{$attribute_name};
@@ -231,7 +231,7 @@ 
         if ($files_to_clear) {
             foreach ($files_to_clear as $key => $filename) {
                 \Storage::disk($disk)->delete($filename);
-                $attribute_value = array_where($attribute_value, function ($value, $key) use ($filename) {
+                $attribute_value = array_where($attribute_value, function($value, $key) use ($filename) {
                     return $value != $filename;
                 });
             }

src/helpers.php

Doc Comments +2 added lines, -1 removed lines

@@ -5,7 +5,7 @@ 
      * Appends the configured backpack prefix and returns
      * the URL using the standard Laravel helpers.
      *
-     * @param $path
+     * @param string $path
      *
      * @return string
      */
@@ -156,6 +156,7 @@ 
      * If that view doesn't exist, it will load the one from the original theme.
      *
      * @param string (see config/backpack/base.php)
+     * @param string $view
      *
      * @return string
      */

Spacing +14 added lines, -14 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-if (! function_exists('backpack_url')) {
+if (!function_exists('backpack_url')) {
     /**
      * Appends the configured backpack prefix and returns
      * the URL using the standard Laravel helpers.
@@ -11,13 +11,13 @@ 
      */
     function backpack_url($path = null, $parameters = [], $secure = null)
     {
-        $path = ! $path || (substr($path, 0, 1) == '/') ? $path : '/'.$path;
+        $path = !$path || (substr($path, 0, 1) == '/') ? $path : '/'.$path;
 
         return url(config('backpack.base.route_prefix', 'admin').$path, $parameters = [], $secure = null);
     }
 }
 
-if (! function_exists('backpack_authentication_column')) {
+if (!function_exists('backpack_authentication_column')) {
     /**
      * Return the username column name.
      * The Laravel default (and Backpack default) is 'email'.
@@ -30,7 +30,7 @@ 
     }
 }
 
-if (! function_exists('backpack_users_have_email')) {
+if (!function_exists('backpack_users_have_email')) {
     /**
      * Check if the email column is present on the user table.
      *
@@ -45,7 +45,7 @@ 
     }
 }
 
-if (! function_exists('backpack_avatar_url')) {
+if (!function_exists('backpack_avatar_url')) {
     /**
      * Returns the avatar URL of a user.
      *
@@ -78,7 +78,7 @@ 
     }
 }
 
-if (! function_exists('backpack_middleware')) {
+if (!function_exists('backpack_middleware')) {
     /**
      * Return the key of the middleware used across Backpack.
      * That middleware checks if the visitor is an admin.
@@ -93,7 +93,7 @@ 
     }
 }
 
-if (! function_exists('backpack_guard_name')) {
+if (!function_exists('backpack_guard_name')) {
     /*
      * Returns the name of the guard defined
      * by the application config
@@ -104,7 +104,7 @@ 
     }
 }
 
-if (! function_exists('backpack_auth')) {
+if (!function_exists('backpack_auth')) {
     /*
      * Returns the user instance if it exists
      * of the currently authenticated admin
@@ -116,7 +116,7 @@ 
     }
 }
 
-if (! function_exists('backpack_user')) {
+if (!function_exists('backpack_user')) {
     /*
      * Returns back a user instance without
      * the admin guard, however allows you
@@ -128,7 +128,7 @@ 
     }
 }
 
-if (! function_exists('mb_ucfirst')) {
+if (!function_exists('mb_ucfirst')) {
     /**
      * Capitalize the first letter of a string,
      * even if that string is multi-byte (non-latin alphabet).
@@ -150,7 +150,7 @@ 
     }
 }
 
-if (! function_exists('backpack_view')) {
+if (!function_exists('backpack_view')) {
     /**
      * Returns a new displayable view based on the configured backpack view namespace.
      * If that view doesn't exist, it will load the one from the original theme.
@@ -169,7 +169,7 @@ 
 
         $returnView = $theme.$view;
 
-        if (! view()->exists($returnView)) {
+        if (!view()->exists($returnView)) {
             $returnView = $originalTheme.$view;
         }
 
@@ -177,7 +177,7 @@ 
     }
 }
 
-if (! function_exists('square_brackets_to_dots')) {
+if (!function_exists('square_brackets_to_dots')) {
     /**
      * Turns a string from bracket-type array to dot-notation array.
      * Ex: array[0][property] turns into array.0.property.
@@ -194,7 +194,7 @@ 
     }
 }
 
-if (! function_exists('is_countable')) {
+if (!function_exists('is_countable')) {
     /**
      * We need this because is_countable was only introduced in PHP 7.3,
      * and in PHP 7.2 you should check if count() argument is really countable.