Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Completed
Pull Request — master (#2138)
by Jasper
02:33
created
src/app/Models/Traits/SpatieTranslatable/SlugService.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -49,7 +49,7 @@
 block discarded – undo
49 49
      */
50 50
     protected function makeSlugUnique(string $slug, array $config, string $attribute): string
51 51
     {
52
-        if (! $config['unique']) {
52
+        if (!$config['unique']) {
53 53
             return $slug;
54 54
         }
55 55
 
Please login to merge, or discard this patch.
src/app/Models/Traits/CrudTrait.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -69,7 +69,7 @@  discard block
 block discarded – undo
69 69
         $conn->getDoctrineSchemaManager()->getDatabasePlatform()->registerDoctrineTypeMapping('json', 'json_array');
70 70
         $conn->getDoctrineSchemaManager()->getDatabasePlatform()->registerDoctrineTypeMapping('jsonb', 'json_array');
71 71
 
72
-        return ! $conn->getDoctrineColumn($table, $column_name)->getNotnull();
72
+        return !$conn->getDoctrineColumn($table, $column_name)->getNotnull();
73 73
     }
74 74
 
75 75
     /*
@@ -86,7 +86,7 @@  discard block
 block discarded – undo
86 86
     public function addFakes($columns = ['extras'])
87 87
     {
88 88
         foreach ($columns as $key => $column) {
89
-            if (! isset($this->attributes[$column])) {
89
+            if (!isset($this->attributes[$column])) {
90 90
                 continue;
91 91
             }
92 92
 
@@ -134,7 +134,7 @@  discard block
 block discarded – undo
134 134
      */
135 135
     public function shouldDecodeFake($column)
136 136
     {
137
-        return ! in_array($column, array_keys($this->casts));
137
+        return !in_array($column, array_keys($this->casts));
138 138
     }
139 139
 
140 140
     /**
@@ -145,7 +145,7 @@  discard block
 block discarded – undo
145 145
      */
146 146
     public function shouldEncodeFake($column)
147 147
     {
148
-        return ! in_array($column, array_keys($this->casts));
148
+        return !in_array($column, array_keys($this->casts));
149 149
     }
150 150
 
151 151
     /*
@@ -219,7 +219,7 @@  discard block
 block discarded – undo
219 219
     public function uploadMultipleFilesToDisk($value, $attribute_name, $disk, $destination_path)
220 220
     {
221 221
         $request = \Request::instance();
222
-        if (! is_array($this->{$attribute_name})) {
222
+        if (!is_array($this->{$attribute_name})) {
223 223
             $attribute_value = json_decode($this->{$attribute_name}, true) ?? [];
224 224
         } else {
225 225
             $attribute_value = $this->{$attribute_name};
@@ -231,7 +231,7 @@  discard block
 block discarded – undo
231 231
         if ($files_to_clear) {
232 232
             foreach ($files_to_clear as $key => $filename) {
233 233
                 \Storage::disk($disk)->delete($filename);
234
-                $attribute_value = array_where($attribute_value, function ($value, $key) use ($filename) {
234
+                $attribute_value = array_where($attribute_value, function($value, $key) use ($filename) {
235 235
                     return $value != $filename;
236 236
                 });
237 237
             }
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Buttons.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -92,7 +92,7 @@  discard block
 block discarded – undo
92 92
          */
93 93
         $button = $this->buttons()->firstWhere('name', $name);
94 94
 
95
-        if (! $button) {
95
+        if (!$button) {
96 96
             abort(500, 'CRUD Button "'.$name.'" not found. Please check the button exists before you modify it.');
97 97
         }
98 98
 
@@ -113,7 +113,7 @@  discard block
 block discarded – undo
113 113
      */
114 114
     public function removeButton($name, $stack = null)
115 115
     {
116
-        $this->setOperationSetting('buttons', $this->buttons()->reject(function ($button) use ($name, $stack) {
116
+        $this->setOperationSetting('buttons', $this->buttons()->reject(function($button) use ($name, $stack) {
117 117
             return $stack == null ? $button->name == $name : ($button->stack == $stack) && ($button->name == $name);
118 118
         }));
119 119
     }
@@ -124,7 +124,7 @@  discard block
 block discarded – undo
124 124
      */
125 125
     public function removeButtons($names, $stack = null)
126 126
     {
127
-        if (! empty($names)) {
127
+        if (!empty($names)) {
128 128
             foreach ($names as $name) {
129 129
                 $this->removeButton($name, $stack);
130 130
             }
@@ -138,14 +138,14 @@  discard block
 block discarded – undo
138 138
 
139 139
     public function removeAllButtonsFromStack($stack)
140 140
     {
141
-        $this->setOperationSetting('buttons', $this->buttons()->reject(function ($button) use ($stack) {
141
+        $this->setOperationSetting('buttons', $this->buttons()->reject(function($button) use ($stack) {
142 142
             return $button->stack == $stack;
143 143
         }));
144 144
     }
145 145
 
146 146
     public function removeButtonFromStack($name, $stack)
147 147
     {
148
-        $this->setOperationSetting('buttons', $this->buttons()->reject(function ($button) use ($name, $stack) {
148
+        $this->setOperationSetting('buttons', $this->buttons()->reject(function($button) use ($name, $stack) {
149 149
             return $button->name == $name && $button->stack == $stack;
150 150
         }));
151 151
     }
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/ViewsAndRestoresRevisions.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -21,7 +21,7 @@
 block discarded – undo
21 21
             $revisionDate = date('Y-m-d', strtotime((string) $history->created_at));
22 22
 
23 23
             // Be sure to instantiate the initial grouping array
24
-            if (! array_key_exists($revisionDate, $revisions)) {
24
+            if (!array_key_exists($revisionDate, $revisions)) {
25 25
                 $revisions[$revisionDate] = [];
26 26
             }
27 27
 
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/HeadingsAndTitles.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -21,7 +21,7 @@  discard block
 block discarded – undo
21 21
      */
22 22
     public function getTitle($action = false)
23 23
     {
24
-        if (! $action) {
24
+        if (!$action) {
25 25
             $action = $this->getActionMethod();
26 26
         }
27 27
 
@@ -38,7 +38,7 @@  discard block
 block discarded – undo
38 38
      */
39 39
     public function setTitle($string, $action = false)
40 40
     {
41
-        if (! $action) {
41
+        if (!$action) {
42 42
             $action = $this->getActionMethod();
43 43
         }
44 44
 
@@ -58,7 +58,7 @@  discard block
 block discarded – undo
58 58
      */
59 59
     public function getHeading($action = false)
60 60
     {
61
-        if (! $action) {
61
+        if (!$action) {
62 62
             $action = $this->getActionMethod();
63 63
         }
64 64
 
@@ -75,7 +75,7 @@  discard block
 block discarded – undo
75 75
      */
76 76
     public function setHeading($string, $action = false)
77 77
     {
78
-        if (! $action) {
78
+        if (!$action) {
79 79
             $action = $this->getActionMethod();
80 80
         }
81 81
 
@@ -95,7 +95,7 @@  discard block
 block discarded – undo
95 95
      */
96 96
     public function getSubheading($action = false)
97 97
     {
98
-        if (! $action) {
98
+        if (!$action) {
99 99
             $action = $this->getActionMethod();
100 100
         }
101 101
 
@@ -112,7 +112,7 @@  discard block
 block discarded – undo
112 112
      */
113 113
     public function setSubheading($string, $action = false)
114 114
     {
115
-        if (! $action) {
115
+        if (!$action) {
116 116
             $action = $this->getActionMethod();
117 117
         }
118 118
 
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Search.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -22,9 +22,9 @@  discard block
 block discarded – undo
22 22
      */
23 23
     public function applySearchTerm($searchTerm)
24 24
     {
25
-        return $this->query->where(function ($query) use ($searchTerm) {
25
+        return $this->query->where(function($query) use ($searchTerm) {
26 26
             foreach ($this->columns() as $column) {
27
-                if (! isset($column['type'])) {
27
+                if (!isset($column['type'])) {
28 28
                     abort(400, 'Missing column type when trying to apply search term.');
29 29
                 }
30 30
 
@@ -82,7 +82,7 @@  discard block
 block discarded – undo
82 82
 
83 83
                 case 'select':
84 84
                 case 'select_multiple':
85
-                    $query->orWhereHas($column['entity'], function ($q) use ($column, $searchTerm) {
85
+                    $query->orWhereHas($column['entity'], function($q) use ($column, $searchTerm) {
86 86
                         $q->where($column['attribute'], 'like', '%'.$searchTerm.'%');
87 87
                     });
88 88
                     break;
@@ -274,7 +274,7 @@  discard block
 block discarded – undo
274 274
      */
275 275
     private function renderCellView($view, $column, $entry, $rowNumber = false)
276 276
     {
277
-        if (! view()->exists($view)) {
277
+        if (!view()->exists($view)) {
278 278
             $view = 'crud::columns.text'; // fallback to text column
279 279
         }
280 280
 
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Update.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -51,7 +51,7 @@  discard block
 block discarded – undo
51 51
 
52 52
         foreach ($fields as &$field) {
53 53
             // set the value
54
-            if (! isset($field['value'])) {
54
+            if (!isset($field['value'])) {
55 55
                 if (isset($field['subfields'])) {
56 56
                     $field['value'] = [];
57 57
                     foreach ($field['subfields'] as $subfield) {
@@ -64,7 +64,7 @@  discard block
 block discarded – undo
64 64
         }
65 65
 
66 66
         // always have a hidden input for the entry id
67
-        if (! array_key_exists('id', $fields)) {
67
+        if (!array_key_exists('id', $fields)) {
68 68
             $fields['id'] = [
69 69
                 'name'  => $entry->getKeyName(),
70 70
                 'value' => $entry->getKey(),
@@ -87,7 +87,7 @@  discard block
 block discarded – undo
87 87
     {
88 88
         if (isset($field['entity'])) {
89 89
             $relationArray = explode('.', $field['entity']);
90
-            $relatedModel = array_reduce(array_splice($relationArray, 0, -1), function ($obj, $method) {
90
+            $relatedModel = array_reduce(array_splice($relationArray, 0, -1), function($obj, $method) {
91 91
                 return $obj->{$method} ? $obj->{$method} : $obj;
92 92
             }, $model);
93 93
 
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Access.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -33,7 +33,7 @@  discard block
 block discarded – undo
33 33
             $this->set($op.'.access', false);
34 34
         }
35 35
 
36
-        return ! $this->hasAccessToAny($operation);
36
+        return !$this->hasAccessToAny($operation);
37 37
     }
38 38
 
39 39
     /**
@@ -73,7 +73,7 @@  discard block
 block discarded – undo
73 73
     public function hasAccessToAll($operation_array)
74 74
     {
75 75
         foreach ((array) $operation_array as $key => $operation) {
76
-            if (! $this->get($operation.'.access')) {
76
+            if (!$this->get($operation.'.access')) {
77 77
                 return false;
78 78
             }
79 79
         }
@@ -90,7 +90,7 @@  discard block
 block discarded – undo
90 90
      */
91 91
     public function hasAccessOrFail($operation)
92 92
     {
93
-        if (! $this->get($operation.'.access')) {
93
+        if (!$this->get($operation.'.access')) {
94 94
             throw new AccessDeniedException(trans('backpack::crud.unauthorized_access', ['access' => $operation]));
95 95
         }
96 96
 
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Filters.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -59,7 +59,7 @@  discard block
 block discarded – undo
59 59
         $this->enableFilters();
60 60
 
61 61
         // check if another filter with the same name exists
62
-        if (! isset($options['name'])) {
62
+        if (!isset($options['name'])) {
63 63
             abort(500, 'All your filters need names.');
64 64
         }
65 65
         if ($this->filters()->contains('name', $options['name'])) {
@@ -201,7 +201,7 @@  discard block
 block discarded – undo
201 201
     {
202 202
         $filter = $this->filters()->firstWhere('name', $name);
203 203
 
204
-        if (! $filter) {
204
+        if (!$filter) {
205 205
             abort(500, 'CRUD Filter "'.$name.'" not found. Please check the filter exists before you modify it.');
206 206
         }
207 207
 
@@ -216,7 +216,7 @@  discard block
 block discarded – undo
216 216
 
217 217
     public function removeFilter($name)
218 218
     {
219
-        $strippedFiltersCollection = $this->filters()->reject(function ($filter) use ($name) {
219
+        $strippedFiltersCollection = $this->filters()->reject(function($filter) use ($name) {
220 220
             return $filter->name == $name;
221 221
         });
222 222
 
@@ -278,16 +278,16 @@  discard block
 block discarded – undo
278 278
 
279 279
     public function checkOptionsIntegrity($options)
280 280
     {
281
-        if (! isset($options['name'])) {
281
+        if (!isset($options['name'])) {
282 282
             abort(500, 'Please make sure all your filters have names.');
283 283
         }
284
-        if (! isset($options['type'])) {
284
+        if (!isset($options['type'])) {
285 285
             abort(500, 'Please make sure all your filters have types.');
286 286
         }
287
-        if (! \View::exists('crud::filters.'.$options['type'])) {
287
+        if (!\View::exists('crud::filters.'.$options['type'])) {
288 288
             abort(500, 'No filter view named "'.$options['type'].'.blade.php" was found.');
289 289
         }
290
-        if (! isset($options['label'])) {
290
+        if (!isset($options['label'])) {
291 291
             abort(500, 'Please make sure all your filters have labels.');
292 292
         }
293 293
     }
Please login to merge, or discard this patch.